- 13 Nov, 2017 40 commits
-
-
Peter Collingbourne authored
cfi_diag was previously disabled due to issues with the ubsan runtime library on Android, which have now been resolved. Bug: 469376 Change-Id: I5de50253c684f66b11174587bfd9caf69bb6d9c8 Reviewed-on: https://chromium-review.googlesource.com/764869Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#516013}
-
Andrey Kosyakov authored
This associates original HttpRequestInfo and encoded data size with Stream in the form of StreamMetadata, so that StreamURLRequestJob could return actual values instead of the bogus ones that it currently makes up. This fixes a problem with reporting actual transferred bytes in DevTools' network panel and removes the need for at last some of the stream override params in WebURLLoaderImpl. Bug: 763700, 705744 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8493bbe464cd9a81a0864e5bcc9afd8b19aea3c5 Reviewed-on: https://chromium-review.googlesource.com/744290Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#516012}
-
Kevin Bailey authored
Add a new icon for tab switch suggestions, to visually distinguish them from suggestions which navigate. Bug: 780835 Change-Id: I6aac9379808da0d7217d9fe84350c48c25104ff6 Reviewed-on: https://chromium-review.googlesource.com/766447Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#516011}
-
Luke Sorenson authored
Bug: 780546 Change-Id: Ic363067d95e66f340f9c9425381d57eafd474980 Reviewed-on: https://chromium-review.googlesource.com/751285Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#516010}
-
dpapad authored
This is in preparation of enabling ESLint checks on that folder. Bug: 720034 Change-Id: I1fcb208f7e0c94b2f8457c55a5399ae863dfe951 Reviewed-on: https://chromium-review.googlesource.com/764386 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#516009}
-
Raymond Toy authored
Log the recommended audio HW buffer size as well as the actual buffer size. These were removed at some point and we're putting them back because it's relatively hard to get this information. These are always printed, but only once when an AudioContext is created, so we aren't actually spamming the console logs. NOPRESUBMIT=true Bug: 783929 Test: Change-Id: I6cea5dca504292cae9160899e8240f384453f913 Reviewed-on: https://chromium-review.googlesource.com/764541 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#516008}
-
Lei Zhang authored
Remove a shadow variable as well. Change-Id: I5449012b5d7ff4d041c52981d8e1705198b53dd9 Reviewed-on: https://chromium-review.googlesource.com/764881Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#516007}
-
Vadym Doroshenko authored
On CL https://chromium-review.googlesource.com/c/chromium/src/+/755595 Password Generation on IOS was removed. This CL removes leftovers. Bug: 752077,700010,782224 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idbd84d45874a877bdc0ab81299123600442f2c98 Reviewed-on: https://chromium-review.googlesource.com/758836Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#516006}
-
Fady Samuel authored
I believe I wrote most of this file and I constantly find myself tweaking it for surface synchronization. Bug: none Change-Id: I2903d9674421ac5ec96cd9411d4ad1fb83bdfa6d Reviewed-on: https://chromium-review.googlesource.com/766392Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#516005}
-
Jinsuk Kim authored
Current tab instance through which the content view is obtained for hit testing may be null, hence caused NPE. This CL moves the hit testing to SelectionPopupController where the content view is directly available. Bug: 783717 Change-Id: I26a1cb264a45b4780a26d27a7174500437a3718c Reviewed-on: https://chromium-review.googlesource.com/765551 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#516004}
-
Tom Sepez authored
Add missing case of "url" param name that triggered XSSAuditor bypass. Make one corresponding change to keep behaviour as stable as possible. Bug: 783618 Change-Id: Ic74bf385d3604e6ff71221ae4104e88c2201e118 Reviewed-on: https://chromium-review.googlesource.com/764113Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#516003}
-
David Jacobo authored
Simple test for checking that IsChromeAnAppCandidate works as intended, also reusing intent_helper package name. Bug: b/67655368 Test: Build and pass added tests. Change-Id: Iee43e769c1773ee1afba1ae3165f6917dc931125 Reviewed-on: https://chromium-review.googlesource.com/764537 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#516002}
-
zhuoyu.qian authored
Remove deprecated OnResponseStarted(URLRequest*), use OnResponseStarted(URLRequest*, int) instead. BUG=488603 TBR=servolk@chromium.org, irisu@chromium.org, ichikawa@chromium.org Signed-off-by:
zhuoyu.qian <zhuoyu.qian@samsung.com> Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4cde46481a3f8e20bc1e9cef9711caf5b0c6d7af Reviewed-on: https://chromium-review.googlesource.com/763193Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#516001}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/8d5ce2d9ede0..b251b72d3d91 $ git log 8d5ce2d9e..b251b72d3 --date=short --no-merges --format='%ad %ae %s' 2017-11-13 mtklein add platform_font_manager() 2017-11-13 bungeman Extract Android FontMgr part of Typeface test. 2017-11-13 bsalomon Drop support for OSMesa in test tools and remove build bot 2017-11-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 197445296..7af63727f (2 commits) 2017-11-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 703671e9f..197445296 (1 commit) 2017-11-10 ethannicholas sksl enum support 2017-11-13 robertphillips Revert "Patch up ref counting of proxies" Created with: roll-dep src/third_party/skia BUG=784158 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I1a4968ab59bcefb054cd49051408e5f4437f26cd Reviewed-on: https://chromium-review.googlesource.com/766849Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516000}
-
Philip Rogers authored
The RLS baseline was wrong and we now match non-RLS except with a scrolling content layer: paint/invalidation/table-two-pass-layout-overpaint.html This test was looking for paint invalidations on the root layer but needed to use the scrolling contents layer with RLS: paint/invalidation/media-audio-no-spurious-repaints.html Bug: 781419 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: Ia60a485552149da396d9847659835a9b06c338d3 Reviewed-on: https://chromium-review.googlesource.com/765569 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#515999}
-
edchin authored
This fixes a bug in which snapshots are blank when opening a new tab from an incognito tab (and vice versa). This fixes two issues: 1) We must take a snapshot of the current tab before switching to a different incognito mode. This was not happening. 2) We must prevent blank snapshots from overwriting perfectly good ones. Bug: 778235 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I761244b2459d0f38f999d630d19643764533ebaf Reviewed-on: https://chromium-review.googlesource.com/764854Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515998}
-
Greg Kerr authored
This experimental CL allows cfprefs and gamecontrollerd to observe how the perf bots respond. This will likely be reverted once the results show up. Bug: 689306 Change-Id: I8e0ab2919e4cf7e65217be1169b63a7bde806df4 Reviewed-on: https://chromium-review.googlesource.com/764394Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#515997}
-
Scott Graham authored
With this SDK roll, Fuchsia now sets PATH. Switch environment variable tests back to checking for its existence to remove #if. Bug: 707030 Change-Id: Ifc0f1fea3388c6ad98f98864bb9bf7c4f8c87035 Reviewed-on: https://chromium-review.googlesource.com/766470Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515996}
-
Steve Kobes authored
This fixes 16 of the 21 compositing/ layout tests listed on crbug.com/778469. The remaining 5 are affected by crbug.com/784053. This patch includes new baselines for the tests that are fixed (diff against generic baselines in patchset 1). These reflect the presence of scrolling layers in the layer tree dump, and "flattenInheritedTransform": false due to crbug.com/778060. Bug: 778469 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1cffa503561942aef7c932f6d52ae541dc88e8a2 Reviewed-on: https://chromium-review.googlesource.com/764952Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#515995}
-
Wez authored
Previously WebKeyboardEvents were built for Windows by ignoring the ui::KeyEvent field values, and populating the WebKeyboardEvent directly from the NativeEvent fields, if available. We now derive the WebKeyboardEvent fields from the supplied ui::Event, and update some fields from the NativeEvent, if available. To reduce the amount of patch-up code, handling of Windows' native auto-repeat flag will be used, for ui::KeyEvents generated from a NativeEvent, instead of being synthesized by ui::KeyEvent::IsRepeated. Bug: 25503 Change-Id: I9d5b1468852d85392ae3a5f57d9457726612ddf1 Reviewed-on: https://chromium-review.googlesource.com/754130Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#515994}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b43ab72..c4f852d8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia6ff2b1e6aecf8f0b0aaac300a6efc2df4509df8 Reviewed-on: https://chromium-review.googlesource.com/766607Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515993}
-
Robert Sesek authored
Tbr: dpranke@chromium.org Bug: 484160 Change-Id: I8b63ce9b3ca95b37cd36f40ee1af619ce0a0409b Reviewed-on: https://chromium-review.googlesource.com/763913Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#515992}
-
Ryan Hamilton authored
Close the connection when a QUIC RST_STREAM is received which contains an invalid final byte offset. BUG=782737 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I740f9320b8d97e8fe0ca4a4ba7af62579988fb7e Reviewed-on: https://chromium-review.googlesource.com/764492Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#515991}
-
Antonio Gomes authored
CL makes use of the existing BitmapCursorFactoryOzone implementation to add pointer/mouse cursor support to Ozone/Wayland. Implementation of wayland_cursor.cc|h is originally based on [1]. [1] https://github.com/01org/ozone-wayland/ TEST=chrome --mash/mus --ozone-platform=wayland BUG=578890 Change-Id: Iccd0a23dd1329bfe32ac78af9379ba3fd739d63f Reviewed-on: https://chromium-review.googlesource.com/644946 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#515990}
-
Lucas Furukawa Gadani authored
This CL cleans up and simplifies SegmentedString, leading to an improvement in parsing performance. This CL also adds a cache for the current_char_ in SegmentedSubstring, so it can avoid a branch when calling GetCurrentChar(). Profiling shows a 1.5% improvement in the jQuery benchmark in Speedometer 2.0 and around 1% across the various VanillaJS benchmarks in Speedometer 2.0. Change-Id: Idc1ae1e277aaec1c9f581075eab563fcd2a72688 Reviewed-on: https://chromium-review.googlesource.com/762016 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#515989}
-
gogerald authored
Bug: 783811 Change-Id: Ic2f9e7fcfb05e4d87f79c8ec53d370edc8b53d27 Reviewed-on: https://chromium-review.googlesource.com/763917Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#515988}
-
Justin Cohen authored
The old-school layout logic in BVC was also re-inserting views on each update, which is unnecessary, and in some cases causes views to show up in the wrong z-order. Insert only needs to happen on initial layout, so gating this in a flag should fix the issues. Bug: 782373 Change-Id: I326f3b9199717c0ad014267fa0239581574a826d Reviewed-on: https://chromium-review.googlesource.com/763711Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#515987}
-
John Abd-El-Malek authored
Fix possible null dereference in SafeBrowsingNavigationObserverManager::IdentifyReferrerChainByWebContents. Change-Id: Idfb13c91de87685598d447ddab8c755693955ea1 Reviewed-on: https://chromium-review.googlesource.com/765214 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#515986}
-
Stephen McGruer authored
This is a reland of 31974d24 Original change's description: > Initial implementation of cc::ScrollTimeline > > This creates a compositor side concept of a ScrollTimeline, and adds > plumbing so that blink WorkletAnimations created with ScrollTimelines > will create a cc::ScrollTimeline on the compositor side. This means > that scroll-driven AnimationWorklets are now possible. > > There are a number of caveats to this initial implementation: > * We never update the cc::ScrollTimeline, so if the scroller > changes on the blink side we won't know. > * We assume that the scroller is composited. If it isn't composited > during animation play() we will log a warning and fail to start, > but if it is composited at that time and later becomes non-composited > we will likely crash. > > Bug: 776952 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Id0342c62209b387130a69edca4ff3682748bd8a3 > Reviewed-on: https://chromium-review.googlesource.com/738437 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: dstockwell <dstockwell@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515645} Bug: 776952 Change-Id: I372d8fd48c62a63b5c6b10688d3829e4ac2c3be1 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/764578Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#515985}
-
Sylvain Defresne authored
As Xcode 9.0+ is required to build Chrome on iOS, remove supports for older versions. Bug: none Change-Id: Idf2e9516cb8f508109e22f3afaef8cd56ad94eb5 Reviewed-on: https://chromium-review.googlesource.com/763409Reviewed-by:
Elodie Banel <lod@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515984}
-
Danyao Wang authored
Currently there is an inconsistency between CreateNavigationItem and GetLastCommittedNonAppSpecificItem. The former sets user agent type of an item to NONE if URL is app-specific. The latter looks for an item with user agent type that is not NONE, and uses VirtualURL to find these. Historically this has not been a problem because app-specific URLs always had identical VirtualURL. Offline Reading List navigation items break this assumption. They have app-specific URLs (e.g. chrome://offline/<blob>) and regular-looking VirtualURLs. Bug: 781284 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I45d9afdb854b1d5340f6d4d2bb7ac306f0897662 Reviewed-on: https://chromium-review.googlesource.com/764540 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#515983}
-
chrome://intervention-internalsThanh Le authored
Change table headers' height and color, since the they look like buttons. Change the "Notes" header back to "Description" since it makes much more sense. Screenshot: https://drive.google.com/a/chromium.org/file/d/188W0j_izuPSxVt6SwskLEOdqUI8vcoCU Bug: 764419 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If743172020754c50b6c234e3bb23f7f2d178cb36 Reviewed-on: https://chromium-review.googlesource.com/763669Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Commit-Position: refs/heads/master@{#515982}
-
Sylvain Defresne authored
Convert TranslateController to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: I62146d7085ab3e230c71cab0510a1ed86aa6a162 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/757109 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#515981}
-
David Valleau authored
R=skau@chromium.org Bug: 779256 Change-Id: I5772282ee310a594b5e31d5931fa38a6fa67cde8 Reviewed-on: https://chromium-review.googlesource.com/755417Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#515980}
-
Scott Graham authored
TBR: wez@chromium.org Bug: 784448, 784449 Change-Id: I06d0473968ae2dbdb9c480cf58b25ba1fbc2a764 Reviewed-on: https://chromium-review.googlesource.com/766152Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515979}
-
Yuriy Taraday authored
After 24423de1dc711cebf73d097943d2090ce4d8aed7 [0] gn boostrap fails with undefined reference to `base::internal::ObserverListThreadSafeBase::tls_current_notification_' Add observer_list_threadsafe.cc that contains that static var to bootstrap.py to make it work again. [0] https://chromium-review.googlesource.com/740989 Bug: 783188 Change-Id: Iac583c52b8aed452b3bdd5b33a60857e2e8285b9 Reviewed-on: https://chromium-review.googlesource.com/758584 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#515978}
-
Hui(Andy) Wu authored
Current phone number rationalization does not distinguish between focusable and non-focusable fields. If a form has a hidden number field then a visible number field, the first one will be considered as the first complete number field, and the second field is not filled automatically as a result. We should skip the non-focusable fields in the rationalization process. Bug: 782240 Change-Id: I71eeb613d3127770b2bf0a0bb120c7cca3282728 Reviewed-on: https://chromium-review.googlesource.com/757217 Commit-Queue: Hui Wu <wuandy@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515977}
-
Helen Li authored
The QuicStreamFactory::OnJobComplete crash is gone in M63. This CL removes the added CHECKs. Bug: 750271 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iee46a69d151be4c5e8ceb91c33ec63e445ede2fd Reviewed-on: https://chromium-review.googlesource.com/766487Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#515976}
-
Lei Zhang authored
Again. Change-Id: I82deeea0c31ac8f609a6a5d98113c65de1fd30b0 Reviewed-on: https://chromium-review.googlesource.com/762873Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#515975}
-
Daniel Bratell authored
In jumbo builds (use_jumbo_build=true) the two different LevelDBStatusToStatus could end up in the same translation unit which would then cause compilation errors since they only differed by return value. This CL gives them unique names, ToServiceWorkerStatus() and ToNotificationDatabaseStatus(). Bug: 746953 Change-Id: Iceaf6facc3142990d62769f693eb57bfc5c5f143 Reviewed-on: https://chromium-review.googlesource.com/760358Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#515974}
-