- 07 May, 2018 40 commits
-
-
Hayato Ito authored
Support slot's expanded nodes, using slot's assigned nodes, for IncrementalShadowDOM. Inspector can show slot's assigned nodes correctly even in IncrementalShadowDOM. virtual/incremental-shadow-dom/http/tests/devtools/elements/shadow/shadow-distribution.js test is still failing, however, this is not a regression of IncrementalShadowDOM. See crbug.com/840238 for details. This CL adds an expected.txt for the test. Bug: 776656,840238 Change-Id: I037caf9184e9be42525575bf2e027cf000bdbf7a Reviewed-on: https://chromium-review.googlesource.com/1029567 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#556414}
-
Jonas Olsson authored
Not every client cares about observing or logs. This change saves those clients from providing a dummy observer/log. If the log isn't provided, explicitly clear log_. This makes it easier to check if the scoped_refptr<media::mojom::ThreadSafeAudioLogPtr> actually holds a value, and skips some unnecessary message forwarding. Bug: 834702 Change-Id: I4c405a7dd90d241847ee60e4c3b8db58bf0a3fc9 Reviewed-on: https://chromium-review.googlesource.com/1043907Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Cr-Commit-Position: refs/heads/master@{#556413}
-
Marc Treib authored
It's unused. Bug: 839834 Change-Id: Ic354b16a5534aab8ce89c036b8a81a2ceeb3ae60 Reviewed-on: https://chromium-review.googlesource.com/1046672Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556412}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0cb7b82e..19f90f91 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia3ba15f2d9318caf0cdc29fa51c85ce724c26f02 Reviewed-on: https://chromium-review.googlesource.com/1046250Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556411}
-
Guido Urdaneta authored
TBR=eseckler@chromium.org Bug: 839747 Change-Id: Ic98a3b585163f663c983403d34d958460658c884 Reviewed-on: https://chromium-review.googlesource.com/1046597 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#556410}
-
Guido Urdaneta authored
TBR=kenrb@chromium.org Bug: 840314 Change-Id: I81f0b9b208ddf1985fca4e30694a2c4416b233dc Reviewed-on: https://chromium-review.googlesource.com/1046825Reviewed-by:
-
Colin Blundell authored
As a first step toward completely eliminating the usage of ProfileIdentityProvider in //components/gcm_driver, this CL threads in SigninManager and replaces direct usage of ProfileIdentityProvider in GCMProfileService::IdentityObserver with equivalent usage of SigninManager. Note that it is easy to verify that the usage is equivalent: The ProfileIdentityProvider method calls are replaced with their implementations in profile_identity_provider.cc. Full design doc here: https://docs.google.com/document/d/1OmNrIiMDkF7eOYVB4RIiDvY7pQz3zUrOf-D4TVwdRQA/edit?ts=5aa6b936# TBR=zea@chromium.org, rockot@chromium.org Bug: 809923 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I20515d7431f0e8f5370a47cd04c8b21eb0874d6f Reviewed-on: https://chromium-review.googlesource.com/1004999 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#556408}
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: I810feee6bd00d881289e12bf9dc328f070a7b125 Reviewed-on: https://chromium-review.googlesource.com/1046727Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556407}
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: I55754ed89c069499824d66b0737dbde98e0a119d Reviewed-on: https://chromium-review.googlesource.com/1046745Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: Id57af99390197cf17ae5e8feb9820f12cb251620 Reviewed-on: https://chromium-review.googlesource.com/1046705Reviewed-by:
-
Guido Urdaneta authored
TBR=chfremer@chromium.org Bug: 840294 Change-Id: I2919e8b959ec0e6b1a4b9f2d52e382cbfe0c6d3e Reviewed-on: https://chromium-review.googlesource.com/1046670Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: If7850581bd83a1c55f81d05b1c8f030f5e2caf14 Reviewed-on: https://chromium-review.googlesource.com/1046691Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: I51df4c72bb8de0faff2922748ed3d0201716f102 Reviewed-on: https://chromium-review.googlesource.com/1046690Reviewed-by:
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: I5db5f4d91fa1cca880d17d8b428598562b487abf Reviewed-on: https://chromium-review.googlesource.com/1046685Reviewed-by:
-
Marc Treib authored
It's used within OnConfigureDone which receives it as a param, but no need to store and expose it. Bug: 839834 Change-Id: I553e7b8f8b4cbab97c3c00d21e609f0e05d8dff9 Reviewed-on: https://chromium-review.googlesource.com/1044223Reviewed-by:
-
stkhapugin@chromium.org authored
Adds a new metric that logs users focusing and immediately defocusing the omnibox without changing it or copying it. This should allow to see the regression when the steady state location bar will be introduced. Bug: 837164 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icf177b57ca1781930e21c57f9c40dc829aac0982 Reviewed-on: https://chromium-review.googlesource.com/1030190Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556399}
-
Vadym Doroshenko authored
When Password Manager deals with form action it gets it with GetCanonicalActionForForm. But when FormData is created in WebFormElementToFormData another way of receiving action is used (difference is that now in WebFormElementToFormData params and auth is not stripped). It looks that using GetCanonicalActionForForm is more robust and right way. It shouldn't influence autofill in any way: 1.Signature calculation is based on action scheme and host that wouldn't change. 2.Autofill doesn't use action for filling. Bug: 831123 Change-Id: Id8ea5fd80bbfb6a3e9c354fecb2b21ad868283a6 Reviewed-on: https://chromium-review.googlesource.com/1041952Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#556398}
-
Max Morin authored
This reverts commit ef15ddc5. Reason for revert: Crashing on WebRTC bot: https://build.chromium.org/deprecated/chromium.webrtc/builders/Win10%20Tester/builds/28286 Stack trace: base::debug::StackTrace::StackTrace [0x02F08F00+32] base::debug::StackTrace::StackTrace [0x02EDEACD+13] logging::LogMessage::~LogMessage [0x02E9DD40+80] base::ThreadTaskRunnerHandle::Get [0x02EA23ED+189] std::make_unique<media::VideoCaptureDeviceClient,std::unique_ptr<media::VideoFrameReceiverOnTaskRunner,std::default_delete<media::VideoFrameReceiverOnTaskRunner> >,scoped_refptr<media::VideoCaptureBufferPool> &,base::RepeatingCallback<std::unique_ptr<medi [0x024D0D18+178] base::internal::FunctorTraits<std::unique_ptr<media::VideoCaptureJpegDecoder,std::default_delete<media::VideoCaptureJpegDecoder> > (__cdecl*)(base::RepeatingCallback<void __cdecl(mojo::InterfaceRequest<media::mojom::JpegDecodeAccelerator>)>,base::Repeatin [0x024D1330+70] base::internal::Invoker<base::internal::BindState<std::unique_ptr<media::VideoCaptureJpegDecoder,std::default_delete<media::VideoCaptureJpegDecoder> > (__cdecl*)(base::RepeatingCallback<void __cdecl(mojo::InterfaceRequest<media::mojom::JpegDecodeAccelerat [0x024D12E1+33] media::VideoCaptureDeviceClient::OnIncomingCapturedData [0x03F23016+246] media::VideoCaptureDeviceWin::FrameReceived [0x03F2B124+228] media::SinkInputPin::Receive [0x03F2BF05+181] (No symbol) [0x6EB233FB] (No symbol) [0x6EB232F7] (No symbol) [0x6EB401BA] (No symbol) [0x6EB2420F] (No symbol) [0x6EB37E3B] BaseThreadInitThunk [0x763F8654+36] RtlGetAppContainerNamedObjectPath [0x77254B17+311] RtlGetAppContainerNamedObjectPath [0x77254AE7+263] Original change's description: > [Video Capture Service] Support accelerated jpeg decoding > > * Move/rename class content::VideoCaptureGpuJpegDecoder to > media::VideoCaptureJpegDecoderImpl and break dependencies to |content| in order > to make it reusable for the video capture service. (I was unable to convince > Gerrit that this is a move/rename. Sorry for this making it harder to review.) > * Split Gpu memory buffer factory methods from interface ui.mojom.Gpu to new interface > ui.mojom.GpuMemoryBufferFactory > * Update class ui::ClientGpuMemoryBufferManager to depend on only the new interface > ui.mojom.GpuMemoryBufferFactory. > * Inject dependencies on ui.mojom.GpuMemoryBufferFactory and viz.mojom.GpuService > from Browser into video capture service when starting up the service. > * Enable the existing-but-disabled test cases for accelerated jpeg decoding in > combination with video capture service > > Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing > > Bug: 820608, 720604 > Test: content_browsertests --gtest_filter=VideoCaptureBrowserTest.* > Change-Id: Ic9860e4f846dc0abfc85fec673b1d9c15b99c7d1 > Reviewed-on: https://chromium-review.googlesource.com/971302 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556197} TBR=avi@chromium.org,sadrul@chromium.org,jcliang@chromium.org,tsepez@chromium.org,sandersd@chromium.org,emircan@chromium.org,mojahsu@chromium.org,piman@chromium.org,chfremer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 820608, 720604 Change-Id: I518790cfb4eede5fd66d1f2862043285992c8af2 Reviewed-on: https://chromium-review.googlesource.com/1046525Reviewed-by:
-
Vadym Doroshenko authored
It's leftover from https://chromium-review.googlesource.com/c/chromium/src/+/1026111 where these methods where moved to password_form_filling.h but their definition was not removed from password_manager.h. Bug: None Change-Id: I51362bd8874dc89c0db5075cd4fbf403bdbacc49 Reviewed-on: https://chromium-review.googlesource.com/1044222Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#556396}
-
Hans Wennborg authored
Apparently the cv-qualifier of a function type must match, during deduction, see http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_active.html#1584 Recent Clang versions error about this so the code must be adjusted. Bug: 840251 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I715da586731ee97a7c5bfc27b522454dac14d316 Reviewed-on: https://chromium-review.googlesource.com/1046588 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
As part of ongoing scheduler architecture refactoring, this patch updates NonMainThreadScheduler so it can be used in place of WebSchedulerImpl. Specifically, this patch does the following: * Let NonMainThreadScheduler inherit from ThreadScheduler (in addition to WebThreadScheduler). * Implement required virtual functions. * Remove WebSchedulerImpl instance from WebThreadImplForWorkerScheduler, and make it work with NonMainThreadScheduler. Now, WebThreadImplForWorkerScheduler works without relying on WebSchedulerImpl. WebSchedulerImpl is still used by RendererWebSchedulerImpl, so the class itself is not removed yet. This patch adds post-constructor initialization to NonMainThreadScheduler in order to initialize a member requiring a virtual function call. The work is done in the Init() function which is now a non-virtual function of the class, and the original virtual Init() function is renamed to InitImpl(), which is called from Init(). Bug: 826203 Change-Id: I7499fb1df197b760e2289414020f7136e3545a46 Reviewed-on: https://chromium-review.googlesource.com/1032452 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556394}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I755155128114101f02a0871a3bcd9bebe93639d5 Reviewed-on: https://chromium-review.googlesource.com/1046380 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556393}
-
Max Morin authored
This facilitates further development until logging stuff is ready. No-Try since last PS only added a comment. No-Try: true Bug: 812557 Change-Id: I2121ea9d485c7db999b8d89d9fa0039ef9ab8136 Reviewed-on: https://chromium-review.googlesource.com/1046206 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Don't emit new lines before/after display:contents elements. Bug: 837452 Change-Id: I9e43f836d569b6435672c36f5c50a13605fbdc21 Reviewed-on: https://chromium-review.googlesource.com/1042285Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#556391}
-
Marina Ciocea authored
Used by AudioInputStreamBroker (introduced in dependent CL) instead of AudioInputDeviceManager::KeyboardMicRegistration implementation, in order to avoid thread jumps and to keep broker interface simple. AudioInputDeviceManager::KeyboardMicRegistration will be removed after switching to audio service input streams. Bug: 828868 Change-Id: I41aac3e01faeb0d4d47f98726bc069640fb346e3 Reviewed-on: https://chromium-review.googlesource.com/1044216 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
I forgot to patch dynamic_annotations following the instructions in README.chromium when I rolled Abseil last time. TBR=phoglund@chromium.org Bug: None Change-Id: Ib295b0b9d59cb50853f552b5c38a5b1d54b50a3f Reviewed-on: https://chromium-review.googlesource.com/1046054Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#556389}
-
rhalavati@chromium.org authored
Socket patterns are no longer required in traffic annotation tests, hence they are removed from traffic_annotation_extractor clang tool. The original plan was to have network traffic annotation as an optional argument of socket create functions, and we needed to check if the argument existed for all calls that originate from Chrome. This is now changed to having annotations as a mandatory argument of the socket write functions, and as it is enforced by the compiler, we do not need to test it. Bug: 690323 Change-Id: I101fb7295662c3488807091cb9a8686cfc87d249 Reviewed-on: https://chromium-review.googlesource.com/1046087 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556388}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3059fd7dba63..b9ff578f32e7 $ git log 3059fd7db..b9ff578f3 --date=short --no-merges --format='%ad %ae %s' 2018-05-04 wangqing-hf Add name to AUTHORS. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I396ab1a4ba46207261e7bee84c02dca6f9d697e7 Reviewed-on: https://chromium-review.googlesource.com/1046160Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556387}
-
Yuta Kitamura authored
This patch moves source files that only serve the main thread scheduler from renderer/ to main_thread/, which is the new home for those files after the ongoing scheduler architecture refactoring. All moved headers are only included from main_thread/, with the exception of auto_advancing_virtual_time_domain.h which is used by a test in common/, which should be OK. Bug: 826203 Change-Id: I7ea7594cca5c2ebf66805db0dfacd0183cc7a6d4 Reviewed-on: https://chromium-review.googlesource.com/1038944 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=sammiequon@google.com Change-Id: Ib81a49d4529985630cd33bc89941331cf3bc7e4e Reviewed-on: https://chromium-review.googlesource.com/1046248Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556385}
-
Yoshifumi Inoue authored
This patch makes |TextIteratorTextState| to represent relative position by explicit classification |PositionNodeType| with functions to emit code unit for each |PositionNodeType| instead of start and end offsets and computing parent node when emitting for improving code health. Before this patch, relative positions are encoded into start offset and end offset arguments of |SpliceBufer(code_unit, node, start, end)| as start=0, end=0 code_unit is emitted before node. start=0, end=1 code_unit is emitted as node. start=1, end=1 code_unit is emitted after node. in |TextIterator|. |SimpleBackwardTextIterator| passes |start| and |end| offsets of container node instead of encoded number of above. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1023502 Make CharacterIterator: :GetPosition{Before,After}() not to crash with block content Change-Id: I4be96f877fbcf1be52d2c4bc876226777353dc9a Reviewed-on: https://chromium-review.googlesource.com/1029393 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#556384}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ic26f5efb7353ea1a768b08d034803c6aa155d010 Reviewed-on: https://chromium-review.googlesource.com/1046374Reviewed-by:
-
Hajime Hoshi authored
This method is not used anywhere. Change-Id: I55d636d3b3fa789a25041c680b35fece5ef78c64 Reviewed-on: https://chromium-review.googlesource.com/1032193Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit 2f276c3b. Reason for revert: Caused text rendering regression in Windows. crbug.com/840010 Original change's description: > Roll src/third_party/skia/ 05cfcff70..b9a1e688f (15 commits) > > https://skia.googlesource.com/skia.git/+log/05cfcff70ced..b9a1e688fd9c > > $ git log 05cfcff70..b9a1e688f --date=short --no-merges --format='%ad %ae %s' > 2018-05-04 liyuqian Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice > 2018-05-04 benjaminwagner [infra] Move GCE tasks to smaller/larger VMs. > 2018-05-04 bungeman Allow finer rotation in Viewer app. > 2018-05-04 robertphillips Revert "Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)" > 2018-05-04 bsalomon Remove unused SK_DISABLE_ARC_TO_LINE_TO_CHECK build flag > 2018-05-04 bsalomon Remove could not invert matrix SkDebugfs > 2018-05-04 mtklein Don't use getDeviceClipBounds() to bound pic ops. > 2018-05-02 herb Remove android specific code > 2018-05-04 bungeman Avoid drawing BW clipped color glyphs many times. > 2018-05-04 fmalita [skottie] Disable on Android Framework builds > 2018-05-04 borenet [recipes] Remove core.setup() > 2018-05-04 robertphillips Make degenerate kernel in fill_in_2D_gaussian_kernel sum to 1 > 2018-05-04 robertphillips Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2) > 2018-05-04 caryclark Revert "Reland "remove obsolete color defines"" > 2018-05-04 bsalomon Make RenderDoc work automatically with GLX viewer > > Created with: > roll-dep src/third_party/skia > BUG=chromium:836113 > > > The AutoRoll server is located here: https://autoroll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=brianosman@chromium.org > > Change-Id: Ia3664eaddce0f59e7cb22413152bbe6375884eec > Reviewed-on: https://chromium-review.googlesource.com/1044782 > Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#556184} TBR=brianosman@google.com,skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:836113,chromium:840010 Change-Id: Id9ab44b4ffe8b7bc3f3b267d2f27a732d97f5161 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1046286 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#556381}
-
Victor Costan authored
OnRegistrationStored is guaranteed to be called after a ServiceWorkerRegistration has been persisted to ServiceWorkerStorage, so observers can assume that methods like ServiceWorkerStorage::GetUserData will find the registration. Bug: 729800 Change-Id: I35181050b2f35a3b82c4f8e5a22383905b9bc482 Reviewed-on: https://chromium-review.googlesource.com/1043064 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#556380}
-
Adam Rice authored
The checks of entry.encodedBodySize and entry.decodedBodySize in the http/tests/misc/resource-timing-sizes-multipart.html layout test were disabled because the values of those fields were nonsense. Those fields now have meaningful values, so re-enable the checks. BUG=631004 Change-Id: Id7902c194d03b4f26b9bdab5c891aa21cbddd01c Reviewed-on: https://chromium-review.googlesource.com/1036965Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#556379}
-
Tetsui Ohkubo authored
As described in the design doc, old SystemTray class is going to be replaced by UnifiedSystemTray class. Model variables of SystemTrayItems will be decoupled into SystemTrayModel, and tray icons will be implemented in UnifiedSystemTray by obseving the models. This is the initial CL to replace the old SystemTray button by new UnifiedSystemTray button. Old SystemTray still has unrelated logic e.g. notification generation, so at this point we still instantiate SystemTray and just set the visibility to false. When we finish refactoring to move all unrelated logic to outside SystemTray, we can stop instantiating it. Screenshot: http://screen/jVCtkJgKCXa Design doc: go/cros-qs-restyling TEST=manual BUG=836134 Change-Id: I89e708ad239fb93aee5993fd10ace7fdeaab6673 Reviewed-on: https://chromium-review.googlesource.com/1025495 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#556378}
-
Noel Gordon authored
Put AddEntriesMessage first in the code to introduce the concept, move TestEntryInfo afterward (it's just a helper). Run 'git cl format' over this file to format the enum's per style. No change in behavior, no new tests. Tbr: slangley, yamaguchi-san Bug: 833834 Change-Id: I4ea9333b090e4beead7217c843d3416c927ed933 Reviewed-on: https://chromium-review.googlesource.com/1045959Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556377}
-
Sasha Morrissey authored
Adds the following 4 new UMAs: FileBrowser.DirectoryTree.SelectTopLevelExpand FileBrowser.DirectoryTree.SelectTopLevelEntry FileBrowser.DirectoryTree.SelectExpand FileBrowser.DirectoryTree.SelectEntry These record when certain entries are selected in the Directory Tree (the navigation on the LHS of the Files App). etc), select expand next to these entries, and select folders inside these entries. Then check chrome://histograms to ensure UMA was recorded correctly. Test: Select different directories in the tree (Drive, Add New Services, Bug: 397213 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I493d34c93d292e6a4d8b15594308486a96ddd644 Reviewed-on: https://chromium-review.googlesource.com/954774 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#556376}
-
Sasha Morrissey authored
Adds a 'Manage in Drive' button to the context menu for entries in the Files app for ChromeOS. Creates a new DriveManageAction which appears enabled only for non-directory entries (for now) in Drive when offline mode is not enabled. Uses getEntryProperties() for the entry to get its 'alternateUrl' (provided by the Drive Sync API) and navigates to this URL in the browser. 'Manage in Drive', ensure the browser window opens and navigates to the file. Test: Right-click on a file in Google Drive in the File Manager, select Bug: 831480 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieaa359b9e825bef166ea25ec23ae1693681d91f7 Reviewed-on: https://chromium-review.googlesource.com/1011465 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
-
