GitLab

TBR=smut

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7a7d48866cdd35834ffc0c10d0a9147d39555c9c
Reviewed-on: https://chromium-review.googlesource.com/c/1287050
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600546}

This CL adds another experimental omnibox Pedal to restart Chrome,
intended to help the user update Chrome.

Bug: 893183
Change-Id: I3371f053044bae6dd9fe0c46a63a6b394695201c
Reviewed-on: https://chromium-review.googlesource.com/c/1281162
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600545}

U+0909 (उ) and U+0993 (ও) look similar to the number 3. Thic cl adds
these two characters to the mapping to 3 when determining whether to
fall back to punycode when displaying URLs.

Bug: 895885
Change-Id: I233127570c8e34e791ef5663c1ece9207d6c7bda
Reviewed-on: https://chromium-review.googlesource.com/c/1287031Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600544}

This is a reland of afe32c4a

Original landed in crrev.com/c/1284752.

Original change's description:
> Build chrome_apk on the chromium.perf android builders.
>
> Requires crrev.com/c/1283629
>
> Bug: 817842
> Change-Id: I9bda31e2b98d58cb514e1ba79c0d4a5457a566a2
> Reviewed-on: https://chromium-review.googlesource.com/c/1284752
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600499}

TBR=nednguyen@google.com,perezju@chormium.org

Bug: 817842
Change-Id: I83c0913573789452c9a92c32896978f30a2838c3
Reviewed-on: https://chromium-review.googlesource.com/c/1286754Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600543}

Replace the pretend menus created in the app shim (which never actually
appeared correctly) with real menus.

Share the chrome::MainMenuBuilder code for PWAs and the browser app. To
MenuItemBuilder:
- add a disable() function which allows PWA mode to skip many menu items
- change the string_format_1 to take a base::string16 instead of the
  id for the string (because we have no id for the current PWA)

Update the menu building functions to make the PWA menus identical
to the existing PWA menus created in the browser process by
AppShimMenuController.

Make AppShimDelegate expose NSUserInterfaceValidations (matching
AppDelegate), but do not hook anything up yet.

Bug: 895139
Change-Id: I0393048b3a29d2ab0bee14cab802694d296b4058
Reviewed-on: https://chromium-review.googlesource.com/c/1278916
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600542}

May require (slight) rebaselining, as the legacy code may differ from
the raster pipeline precision.

Change-Id: I54878dfa59e2dd6c5a7eb6ff9c5f278ec6eff726
Reviewed-on: https://chromium-review.googlesource.com/c/1280790
Commit-Queue: Mike Reed <reed@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600541}

This patch moves the SkottieWrapper from ui/gfx to cc/paint. This is the
next step in moving the rasterization of skottie to worker threads.

Bug: 890224
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2b5f47b60a11bfbc495bb260ad6003ced85d6fad
Component: cc, paint, gfx, views
Reviewed-on: https://chromium-review.googlesource.com/c/1285091Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600540}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/23e331fe..bad9daf2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0506ad53dff467abe34e671669305e746d96ac2e
Reviewed-on: https://chromium-review.googlesource.com/c/1286283Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600539}

This is only called from test-code, and thus is dead in practice.
Replace uses in test-code with the the Changed() method.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9cdf92314140e65c30bc2a901d34345bf128392d
Reviewed-on: https://chromium-review.googlesource.com/c/1286813Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#600538}

Implements vector and string decoding for responses and fixes/tests
struct-in-struct.

Bug: 883496
Change-Id: I9d518103fb28b93802a487765f5fefb65ef01ea1
Reviewed-on: https://chromium-review.googlesource.com/c/1246958
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600537}

Bug: skia:8471

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8c3656331e0a3e1b7666167a63984091dfec306e
Reviewed-on: https://chromium-review.googlesource.com/c/1283553Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#600536}

Bug: 893154
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8af1dc06fe5fe531235a0545bdca933b9e70e6ce
Reviewed-on: https://chromium-review.googlesource.com/c/1284911
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600535}

This reverts commit 76a90fd9.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> kFaviconsPerCategoryImage compilation fix for Jumbo builds
> 
> Fix for error during creating chrome_public_apk:
> 
> In file included from gen/chrome/browser/browser_jumbo_17.cc:42:
> ./../../chrome/browser/android/explore_sites/image_helper.cc:22:11: error: redefinition of 'kFaviconsPerCategoryImage'
> const int kFaviconsPerCategoryImage = 4;
>           ^
> ./../../chrome/browser/android/explore_sites/explore_sites_service_impl.cc:27:11: note: previous definition is here
> const int kFaviconsPerCategoryImage = 4;
>           ^
> 1 error generated.
> 
> Example compilation settings:
> 
> target_os="android"
> target_cpu="arm"
> enable_nacl=false
> symbol_level=0
> remove_webcore_debug_symbols=true
> is_debug=false
> dcheck_always_on=false
> is_component_build=false
> use_jumbo_build=true
> 
> BUG=895593
> 
> Change-Id: Ic9eaae0239fd4ab53a357df7dff2143b0cc921c4
> Reviewed-on: https://chromium-review.googlesource.com/c/1285056
> Reviewed-by: Cathy Li <chili@chromium.org>
> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
> Cr-Commit-Position: refs/heads/master@{#600459}

TBR=dewittj@chromium.org,dimich@chromium.org,chili@chromium.org,marcin@mwiacek.com,freedjm@chromium.org

Change-Id: Ia4b4969a8036063a1a44f843f3fbddc044eb6dae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 895593
Reviewed-on: https://chromium-review.googlesource.com/c/1287094Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600534}

The cr_cronet.py script got broken by https://chromium-review.googlesource.com/c/chromium/src/+/1273824.
This change fixes it.

Bug: 786559
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ic71a1eee5041a27bfe51d706e7d16a4d83c6ee7e
Reviewed-on: https://chromium-review.googlesource.com/c/1286739Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600533}

https://chromium.googlesource.com/catapult.git/+log/b273e0cd217d..519565187c85


git log b273e0cd217d..519565187c85 --date=short --no-merges --format='%ad %ae %s'
2018-10-17 benjhayden@chromium.org Revert "Migrate trace_viewer.gypi to gni"
2018-10-17 nednguyen@google.com Add support for --repeat flag in typ
2018-10-17 chiniforooshan@chromium.org aura: filter out frames not submitted from browser
2018-10-17 benjhayden@chromium.org Migrate trace_viewer.gypi to gni


Created with:
  gclient setdep -r src/third_party/catapult@519565187c85

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:895699,chromium:894261,chromium:883894,chromium:895699
TBR=sullivan@chromium.org

Change-Id: I42ab97661d390f5ea0e56de3f6196dd4ac19a925
Reviewed-on: https://chromium-review.googlesource.com/c/1286751Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600532}

Bug 850000 added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch replaces all the
uses in /third_party/blink

Spec: https://drafts.csswg.org/css-logical/#box

BUG=862141

Change-Id: I4d50faa5071ce735931488990d6c2275e57932f7
Reviewed-on: https://chromium-review.googlesource.com/c/1163785Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#600531}

Add an install warning for the case when an extension requests optional
host permissions that are already covered by required host permissions.

This is a follow-up to 1265118.

Bug: 859959

Change-Id: Idf639b89016ac72a4df5406d290baa177e83a0e4
Reviewed-on: https://chromium-review.googlesource.com/c/1274054
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600530}

Before this change, we were using DirectCompositionSurfaceWin on most
newer systems, but it's not needed unless hardware overlays are
supported.

The disable_direct_composition workaround increases crash rates because
it's applied before GLSurfaceEGL decides to use direct composition with
ANGLE native EGL surfaces.

This change moves all direct composition logic from GLSurfaceEGL to
DirectCompositionSurfaceWin, and removes use of direct composition with
ANGLE surfaces.

Bug: 894675
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2e9c7c8a7ff36fe7b24868544c03aad0e0b7dad6
Reviewed-on: https://chromium-review.googlesource.com/c/1278529
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600529}

IdnSpoofChecker incorrectly assumed that a skeleton string shouldn't contain any dots. This isn't true, skeletons of some characters such as Extended Arabic-Indic Digit Zero (۰) is indeed a dot.

Remove this assumption and add a test case.

Bug: 877045
Change-Id: I6e73c4d2b850f614b8a685f5068d9cd1028f1b24
Reviewed-on: https://chromium-review.googlesource.com/c/1284058Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600528}

This is a reland of 7f0c13c7

We've bumped capacity in both the builder pool and tester pool.
Hopefully that'll be enough!

Original change's description:
> Move telemetry_unittests from cros VM fyi bot to CQ bot.
>
> Bug: 876494
> Change-Id: Icfa8631e1278745a50e439d78b4373fb1f0f1f3a
> Reviewed-on: https://chromium-review.googlesource.com/c/1281230
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599851}

Bug: 876494
Change-Id: Id83dc5f3e0063c130ce7b80b8a72e28b9f72bd83
Reviewed-on: https://chromium-review.googlesource.com/c/1286900Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600527}

Trims the userinfo (username and password), path, query and ref.

iOS already does this. This just reuses the same URL formatting logic
on other platforms.

We should rename the URLFormatter flag in a followup CL for consistency.

This does not get all the text interactions perfect. For example,
pressing the right arrow key on the elided URL will place the cursor
at the end of the host, not the end of the full URL.

It's not 100% clear what the right text interactions are yet, but this
is a first step towards experimenting with these issues.

Bug: 895940
Change-Id: I959c4e33cc28022110db247eeb6e8c38b9fcb672
Reviewed-on: https://chromium-review.googlesource.com/c/1284053Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600526}

Bug: 890068, 310429
Change-Id: I8945c37cc6a5cd654620d719a8ea89a2fad8a1ac
Reviewed-on: https://chromium-review.googlesource.com/c/1274108
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600525}

Chromevox does not need to specify a locale the current language if
it isn't already specified by the user. This is already done by
the TTS controller. If Chromevox also choses a locale we end up
doing matching on the locale before the voice, and Chromevox does
not appear to use the default system voice.

Bug: 896321
Change-Id: I0ea4919aaf24dd52a72f552b93c4d7490a188ef2
Reviewed-on: https://chromium-review.googlesource.com/c/1286932Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600524}

In Network Quality Estimator (NQE), remove the logic to compute
BDP (bandwidth delay product) since this is not being used anymore.

Change-Id: Ic61c0491d85eadd9a922ecdbfaa016e1e20ace9f
Bug: 895878
Reviewed-on: https://chromium-review.googlesource.com/c/1279436Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600523}

Change-Id: Icafce9c1651fc590cb21020b41e0d59f8ea0eba3
Reviewed-on: https://chromium-review.googlesource.com/c/1203392
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600522}

Sandbox is supported in InProcessBrowserTests since https://crrev.com/87bf974e05e6d0f9dcc28f3c51cf46fd4b9a3145.

Change-Id: I7775488ec4d9a529455eed20de9e3a2ec4f667c3
Reviewed-on: https://chromium-review.googlesource.com/c/1286662Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600521}

BUG=242216

Change-Id: Iea525e5c1091aa85193b23edbedead8bf997ab05
Reviewed-on: https://chromium-review.googlesource.com/c/1286907Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600520}

Update to the spec suggests that we now enable certain constraints in
getDisplayMedia() call. This CL will allow them from higher level and update
wpt tests. Note that actual application of constraints will follow in the next
CLs.

Bug: 326740
Change-Id: I1f0b3c9b7a2feab7b17ee79c8c2420d9ced7fda8
Reviewed-on: https://chromium-review.googlesource.com/c/1284733Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600519}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/2eee64982a09..451dc721b571


git log 2eee64982a09..451dc721b571 --date=short --no-merges --format='%ad %ae %s'
2018-10-17 lannm@chromium.org chromeos_config: Disable Tast VM tests on paladins.


Created with:
  gclient setdep -r src/third_party/chromite@451dc721b571

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib2ad94ceffb5c01617b69769b9b6abce6bffef61
Reviewed-on: https://chromium-review.googlesource.com/c/1286115Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600518}

Add the flag for media session media key handling in ash
to chrome://flags.

BUG=894255

Change-Id: I7bdeea6312629d284e7d7ec6441a1d6948063ccf
Reviewed-on: https://chromium-review.googlesource.com/c/1286972Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600517}

This reverts commit b942c118.

Reason for revert: The patch caused all of our ratio metrics to disappear on the UMA dashboard. The metrics are being sent, but I suspect the sample count is too low for reporting. Also, it didn't fix the perf regression. 

Original change's description:
> Record MainFrame ratio UMA only every 30 seconds
> 
> Mobile performance regressed when UMA and UKM metrics for the
> Rendering Core team were added to BeginMainFrame. We hypothesize
> that the primary cost is recording UMA on every frame for the
> new metrics, so this patch switches to recording UMA only every 30
> seconds, or on frame destruction, when the UKM metrics are recorded.
> 
> The plan is to monitor performance graphs to determine if this has the
> desired effect.
> 
> For the ForcedLayout metric we may need to send the primary UMA metric
> only once per frame, not once per forced layout as is done now. That is
> a follow on patch.
> 
> R=​vmpstr@chromium.org
> BUG=890871,891003,891341
> 
> Change-Id: I2f4ec8bb9301cece98aef52463d671e4bebcd91e
> Reviewed-on: https://chromium-review.googlesource.com/c/1260443
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Commit-Queue: Stephen Chenney <schenney@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597113}

TBR=vmpstr@chromium.org,rkaplow@chromium.org,holte@chromium.org,schenney@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 890871, 891003, 891341
Change-Id: I4668b91a1cc7080d65ba722a2168652cd5b89416
Reviewed-on: https://chromium-review.googlesource.com/c/1286735
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600516}

R=proberge

Change-Id: I0c5b4ba69c8a39f3336989fee5bddc700da48aa0
Reviewed-on: https://chromium-review.googlesource.com/c/1286282Reviewed-by: proberge <proberge@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600515}

Bug: 889494
Change-Id: I4e2a36f2ca7e93db9b5bacb6a32a64abf9ae812c
Reviewed-on: https://chromium-review.googlesource.com/c/1282929Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600514}

r600401 moved use of the FeatureList to an earlier point that was after
Cronet was initilizing the FeatureList which caused a CHECK failure.
Move the FeatureList initialization earlier so it happens first.

Bug: 896315
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I7a10d09e71382995d79af2ee001e77ac9614b8b4
Reviewed-on: https://chromium-review.googlesource.com/c/1286742Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600513}

https://webrtc.googlesource.com/src.git/+log/fab9129e9427..09beff2cfd84


git log fab9129e9427..09beff2cfd84 --date=short --no-merges --format='%ad %ae %s'
2018-10-17 Peter) Slatala Add UseMediaTransport RTCConfiguration support in Java class
2018-10-17 srte@webrtc.org Removes undefined declarations in channel.h.
2018-10-17 kwiberg@webrtc.org rtc::Buffer: Handle move self-assignment
2018-10-17 nisse@webrtc.org Delete more rtc_base/stringutils.*


Created with:
  gclient setdep -r src/third_party/webrtc@09beff2cfd84

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8d1e0dc475b3a17a9ed9e7e07877d6b10eaddc97
Reviewed-on: https://chromium-review.googlesource.com/c/1286630Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600512}

Geometry seems like a good home for Length, LengthPoint,
LengthSize and LengthBox. This brings more sanity to
the structure of blink/renderer/platform.

Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If74d1efb789d8d47c3b5b7c4afa25ec989e0e53d
Reviewed-on: https://chromium-review.googlesource.com/c/1285115Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600511}

BUG=chromium:881334

Change-Id: I1d6273ee84f263b738d229562eaf7cfd98ca203a
Reviewed-on: https://chromium-review.googlesource.com/c/1286909Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Nicolas Capens <capn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600510}

The tests were initially landed in the following cl:
https://chromium-review.googlesource.com/c/chromium/src/+/1278963

The logic of the cl is re-landed in a separate cl(r599781) to give it
more time to bake. This cl re-lands the browser tests after applying
the following changes:

1- Addressed renaming nit.
2- Used MainThreadFrameObserver to make sure that compositor is synced
after scrolling on main thread.

Bug: 894703
Change-Id: I25d6dbf7f216bbedecb6673d6c2819dcd1d82d55
Reviewed-on: https://chromium-review.googlesource.com/c/1286875Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600509}

Classes with only static functions are not allowed as per the style
guide (https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_and_Global_Functions).

Instead, InstantService will own the single UrlValidityChecker instance.

Bug: 874194
Change-Id: Ia4fa35abfdfde3e0d64b268c11c9b7a82fedc126
Reviewed-on: https://chromium-review.googlesource.com/c/1283947
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600508}

This reverts commit 5423fd8a.

Reason for revert: Breaks Chrome Custom Tabs.

Original change's description:
> Update UI for unsupported Android OS and make Jelly Bean unsupported.
>
> This CL updates the UI to show a badge icon in the app menu icon
> whenever the user is running Chrome on a currently unsupported Android
> version.  This badge in the app menu is only displayed once, until the
> user taps the app menu icon. If the user does in fact get a new version,
> the badge state is reset, and will be shown again. The current behavior
> for out of date users stays the same as before (once per cold start).
>
> In addition, a new menu item is displayed at the top of the menu that
> explains that Chrome is unable to update. Nothing happens when you tap
> the menu item in the case of an unsupported OS version.
>
> The new menu item and the new warning message in About Chrome will
> always be displayed when the user is in this state, regardless of
> whether the app menu has already been tapped (which removes the badge).
>
> This CL also updates the UI in Settings - About Chrome to show a new
> message and a warning icon when the user is running Chrome on an
> unsupported version of the Android OS.
>
> By default, Jelly Bean is considered unsupported after this CL, but this
> can be overridden from the variations framework.
>
> It is possible to use command line flags or chrome://flags for
> testing the different states, though that does not impact the
> About Chrome screen.
>
> Binary-Size: This CL adds new assets and the minimal code required.
> Bug: 847940
> Change-Id: If128e1692b66c5804928183718000aaf1e2ffaa6
> Reviewed-on: https://chromium-review.googlesource.com/c/1243167
> Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599369}

TBR=nyquist@chromium.org,dtrainor@chromium.org,twellington@chromium.org,mdjones@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 847940
Change-Id: Ifde69d6fe007bf0ace6f1f2517db9c1b07526798
Reviewed-on: https://chromium-review.googlesource.com/c/1286973
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600507}