GitLab

Consider the following tree :
++kRootWebArea AXID:1
++++kGenericContainer AXID:2
++++++kGenericContainer AXID:3
++++++++kStaticText AXID:4 "some text"
++++++++kStaticText AXID:5 "more text"
...(possibly more content following)

If GetAttributeValue is called on a range :
start_: TEXT_POSITION anchor_id=4 text_offset=0 "<s>ome text"
end_:   TEXT_POSITION anchor_id=2 text_offset=17 "some textmore tex<t>"

This GetAttributeValue would overrun the |end_| because iterating with
|CreateNextAnchorPosition| doesn't create ancestor positions, so the
looping condition will not exit the loop.

Instead, the loop continues until reaching the end of document, where
it will return a NULL_POSITION and |GetDelegate| returns a nullptr.

Snapping the iterator start/end positions to be |AsLeafTextPosition|
fixes this loop.

Bug: 1011057, 928948
Change-Id: If038d8d4bc0ed596fd2339931258822897c3c8d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879778
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#709609}

This skips a check that is only needed for html:style and, for SVG elements,
animatable SVG attributes (including html:class). In cases where we statically
know that is not the case, we should use the fast variants (as we do in most
existing uses).

Generated by:
  git grep -l hasAttribute.*html_names third_party/blink/renderer | xargs perl -pi -e 's/hasAttribute(?=\(html_names::k(?!(Class|Style)Attr\b)[A-Za-z]+Attr\b)/FastHasAttribute/'
  git grep -l getAttribute.*html_names third_party/blink/renderer | xargs perl -pi -e 's/getAttribute(?=\(html_names::k(?!(Class|Style)Attr\b)[A-Za-z]+Attr\b)/FastGetAttribute/'
  git cl format

Plus the minimum changes needed to satisfy check_blink_style, and two corrections
for attributes which could collide with animatable SVG attributes (type and href)
where the local context does not make it clear that the element is in fact an
HTMLElement.

Change-Id: I56bd622b20eb7a893e53e902e7d576c9cba0dd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880150
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709608}

https://skia.googlesource.com/skia.git/+log/d0a404e84d47..a979b28cbbd0

git log d0a404e84d47..a979b28cbbd0 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 halcanary@google.com SkQP: mark several gms as unsuitable for skqp
2019-10-25 mtklein@google.com tweak ar/libtool setup

Created with:
  gclient setdep -r src/third_party/skia@a979b28cbbd0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Bug: None
Change-Id: I317a0e1aa0d275af05550ca6276d8cbc35fbf1bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881507Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709607}

This change adds the following system color keywords:
    - ActiveText: Text in active links.
    - Field: Background of input fields.
    - FieldText: Text in input fields.

These keywords are hidden behind a newly added runtime enabled feature:
NewSystemColors.

Spec: https://drafts.csswg.org/css-color-4/#css-system-colors

Bug: 1015968
Change-Id: If4f339f19c98455c93990d52b6f3a96c71b25b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872774
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709606}

This CL adds chrome layer code to register to Chime. The actual
implementation is in an Android DFM in downstream.

The code is set up according to new modulization effort, that
chrome/browser/notifications/chime/android is self contained.

Bug: 1013386
Change-Id: Iafc4269e1597af30af624e9772c6a38edcb4e5a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874576
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709605}

A link inside of a heading is a pretty common situation, but TalkBack only
lands on either the heading (if doing heading navigation) or the link
(if doing linear navigation or controls & links navigation), and it doesn't
make it clear that there's both a heading and a link.

Make it work better with TalkBack with the following changes:

1. A heading consisting of only a link should be marked as clickable.
2. Clicking on a heading consisting of only a link should click the link.
3. Role description for a heading consisting of a link should be
   "heading link" for both the heading and the link inside.

Bug: 884356
Change-Id: I1e23d166ab39d7a9bc2cfa401deaddd5f291dc3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874517
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709604}

Move FrameMsg_EnforceInsecureNavigationsSet to a RemoteFrame mojo
interface.

BUG=1008432

Change-Id: I12e9509d0fc7d85e75f226e85730d5527ce3831f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874056Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709603}

Fixes gpu_fyi_tests_dx12vk_release_trybot missing "release_trybot" in
mb_config.pyl.

Bug: 1010584
Change-Id: If95a5e98212ee0015550857af41f78b88e99b945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881346Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709602}

This CL adds additional unit tests to the safety tip heuristics in
preparation for metrics collection. and fixes the logic in these
heuristics to conform to expected behavior.  This CL also double checks
that a reputation warning will never be shown on an error page, and adds
a few QoL readability comment improvements.

Bug: 1014598
Change-Id: Ia489339b221308b37473ef7669b45cfaa92cd586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881226
Commit-Queue: Aidan Beggs <beggs@google.com>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709601}

chrome.browser.utils should only contain leaf-node util classes, and is
now in a separate build target.

Bug: 995916
Change-Id: I251c34c097cfd1c17db06e3cc6fe83b581df5721
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879748
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709600}

Bug: 1011921
Change-Id: I7091f5fa8c42abe4ed779d5ac0d761ea3bf26eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876983
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709599}

This feature got missing when moving output formatting from Telemetry
to Results Processor.

Bug: 1017904
Change-Id: I36258576b5fc72ab7a0093dc74b7882cfd5a1d19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879936
Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709598}

This CL extracts the core stack copying parts of
tracing::StackUnwinderAndroid into the dedicated base::StackCopierSignal
class, and adapts it for direct use by the sampling profiler stack
unwinding implementation. This drops some unneeded code; updates the code
to run on 32-bit Android, 64-bit Android, and 64-bit Linux platforms;
and converts the code to use C++ atomics.

The StackUnwinderAndroid implementation will eventually be replaced
wholesale by the sampling profiler implementation for Android. This CL
does not attempt to reuse the extracted stack copying implementation on
its own, in order to avoid introducing bugs in StackUnwinderAndroid due
to the differing implementations.

TBR=gab@chromium.org

Bug: 988579
Change-Id: I0293771679c5deae69fdbb007d8828ead575ee0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872967Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709597}

Bug: 984550
Change-Id: I885fc575b49c4049b83b17cc4c2248daf2525b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876974Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709596}

https://android.googlesource.com/platform/external/perfetto.git/+log/88d9a552a4b7..512f209de9b5

git log 88d9a552a4b7..512f209de9b5 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 treehugger-gerrit@google.com Merge "Add DETACH, ATTACH and CANCEL buffer events to the Frame event proto"

Created with:
  gclient setdep -r src/third_party/perfetto@512f209de9b5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Id90d35ad7fd0cc733dd0ad78b012c49395ef8190
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881467Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709595}

Bug: 1013646
Change-Id: Ib4ef4402b3d4fae7efdb8f5c474886e8da1fc99e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879952Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709594}

This cl checks for methods named 'ForTest' in the final release apk.

Bug: 1012373
Change-Id: I33afb2eeb0726bc8d2c66bec779a4950753a5250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879604
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709593}

Bug: 1013688
Change-Id: I3896525dd57b8590a0f6aad184f9e5a8bc7133c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879662
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709592}

https://chromium.googlesource.com/catapult.git/+log/59c3eac20665..4b1db19bd426

git log 59c3eac20665..4b1db19bd426 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 sadrul@chromium.org trace-viewer: Avoid generating tracks when a process is hidden.

Created with:
  gclient setdep -r src/third_party/catapult@4b1db19bd426

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC simonhatch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=simonhatch@google.com

Bug: chromium:1018229
Change-Id: Ia3047e2b717b8603708d99498be2f024eb02c8b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881026Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709591}

BUG=1017204
TEST=test only change
TBR=boliu@chromium.org

Change-Id: Ie2ef6fa04c3ab94dc4703eb63aaeea648186a7c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881567Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709590}

Add more information for users when CRX extension fails to parse and we
suspect it needs to be updated to the new CRX3 format.

Fixed: chromedriver:3188
Change-Id: I77eb8eb7231de57519e972467312ee9975d44243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879461Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709589}

Kstaled is a new swap subsystem for CrOS. This CL will send dbus
messages to debugd based on the user's experimental group.

BUG=b/123039911
TESTED=With a 4.14 kernel and a new debugd build.

Change-Id: Ide79d61050e2d916d8d9907d37856746ef12c29d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858463
Commit-Queue: Brian Geffon <bgeffon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709588}

TBR=manucornet@chromium.org

Test: none
Bug: none
Change-Id: Ibe2345c3eea249271da956d3f23ad89785ba7210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881316Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709587}

WebView uses a similar approach to disable features that are not
supported. This allows feature detection for APIs that are not yet
supported.

Change-Id: I1ee0f7a9752658b4d365ee42e5f29cb674af2d4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879680Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709586}

The recent refactoring (linked bug) broke them in two ways:
* Tests were being filtered based on having "test" in the path, but the
  names now are all just "shard".
* When an apk_under_test exists, dex files from both apks were being
  copied to the same directory, so "shard1.dex" was being clobbered.

This also refactors ClassLoaderPatcher a bit to make it more clear what
logic happens on O+ vs pre-O.

Bug: 1013688
Change-Id: I4c5e0e5a84bc9875c2262b0108d506797e430e93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881310Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709585}

It saves a copy.

Bug: 973403
Change-Id: I347c6f584dd2fcb164665eab0540a6bc2840d3f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879434Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#709584}

No users of flush used or required a repeating closure, so
switching to base::OnceClosure.

Bug: 1007799, 1007810
Change-Id: I675f2a5251360a40b13e509ec7daa1dbdcccaa28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878554Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#709583}

Currently, the unindexed subresource filter rulesets are being treated
as text files, however, they are constructed a little strangely.
For example, many lines end in control characters. One such control
character is ^M, i.e. \r, so some (but only a few) lines end with \r\n.
This interferes with git patches, causing some tools to then incorrectly
'fix' these inconsistent line endings to \n, corrupting the ruleset.

Adding a .gitattributes file in the appropriate folder should cause git
to treat these files as binary, preventing this hypercorrection.

Bug: 1018284
Change-Id: I6823417bb12e843aba9856c0f76f1f4958d6505c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881313Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709582}

Flakiness dashboard shows that these 4 tests are flaky on all platforms.

Bug: 1018027
Change-Id: I56ddb0756f6b3b549ac115cbda4b4b58ec8b37e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880082Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709581}

crrev.com/c/1879992 restricted Latin Small Letter Thorn to Icelandic
domains. This CL does the same for Eth (ð) as it can be confused with
the characters "o" and "d" in some fonts.

This change affects less than 10 real world domains with limited popularity.

Bug: 1017707, 929711
Change-Id: I037054530feb1d34e9243ef5da35cf431f3b80b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881344Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709580}

Change-Id: I424491c3499f5bcf7444f6c6a14928b7aa9cd525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880527Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709579}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2ab3f107..c29060c2

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I35c97b356865d54d78331589dfc5b3ee610af533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880955Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709578}

This reverts commit 9ca63e64.

Reason for revert: Clank should use the GmsCore implementation of isUVPAA, see crbug.com/1017587

Original change's description:
> Reland isUVPAA implementation on clank
> 
> Currently, clank is using the isUVPAA that gmscore supports, and
> the behavior of isUVPAA is intentionally narrowed to return true
> only if fingerprint is available. Since gmscore is going to change
> the behavior of isUVPAA to return true if fingerprint or screen
> lock is available, clank should reland its own isUVPAA implementation
> to return true only if fingerprint is available.
> 
> This CL is the first of 3 CLs to add isUVPAA implemenration on clank
> and remove the flow to call isUVPAA that gmscore supports.
> 
> Bug: n/a
> Change-Id: I7f0a025b49597fe73e070562bf96921e64c24622
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739973
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Suzy Li <suzyli@google.com>
> Cr-Commit-Position: refs/heads/master@{#686226}

TBR=kenrb@chromium.org,suzyli@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1017587
Change-Id: Ib31b0fe0999de859f4e47642e1568ac813c47949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881378Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Suzy Li <suzyli@google.com>
Cr-Commit-Position: refs/heads/master@{#709577}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8e6dcb29585..a8bf5caaa8fd


Created with:
  gclient setdep -r src-internal@a8bf5caaa8fd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ifb1742422ca417e35b42beecae8a0e30c00605a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881392Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709576}

Bug: 1018201
Change-Id: I05b8d6aca2217b585f505ee0b18e7462edd75506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879194
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709575}

This will help to build unit tests for printing API.

Bug: 996785
Change-Id: I9485dbe49949b0f420ea86b9847240537ab46cca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879449Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709574}

Bug: 985574
Change-Id: I06d11dd466b7cb803b2324a45848ec09c9f28799
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879324
Commit-Queue: Yun Liu <yliuyliu@google.com>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709573}

ResetAnimatedType() and ApplyResultsToTarget() are always called in
"sequence" by the one method
(SMILAnimationSandwich::ApplyAnimationValues), so we can move the call
to SetAnimatedAttribute() to the latter method.
Then we fold the calls to InvalidateAnimatedAttribute() into the
Set/ClearAnimatedAttribute calls.

Also simplify Set/ClearWebAnimatedAttributes() since they can now
trivially call into the modified versions of Set/ClearAnimatedAttribute().

For SVGAnimateMotionElement, move the invalidation of the target from
CalculateAnimatedValue() to ApplyResultsToTarget().

Bug: 1017723
Change-Id: I6ee237aa1be725db44b02212fe8a1bff1cd5e16b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878771Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#709572}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/47bbd64428c2..ad3655cf0bd3

git log 47bbd64428c2..ad3655cf0bd3 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 saklein@chromium.org cros_clean: Add option to clean chroot's /tmp
2019-10-25 saklein@chromium.org cros_clean: YAPF file.

Created with:
  gclient setdep -r src/third_party/chromite@ad3655cf0bd3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I7e076c6bb1e1838c45be00340b908b525f6b5afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881391Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709571}

In order to properly clip ARC notifications, we need to properly bound them in
the parent Widget layer and draw a custom border with a Z-order above all other
layers.

BUG=976952, 919642

Change-Id: I2c41eaef27798cc1009d4d4f4449674860b5dd84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877452Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709570}