- 10 Mar, 2014 40 commits
-
-
skyostil@chromium.org authored
NOTRY=true Review URL: https://codereview.chromium.org/191713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255965 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
R=jbauman@chromium.org, piman@chromium.org, jbauman, piman BUG=350141 Review URL: https://codereview.chromium.org/191563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255962 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
Add a meaning tag to IDS_EXTENSION_PROMPT_WARNING_HOSTS_MANY to disambiguate it from IDS_EXTENSION_PROMPT_WARNING_HOSTS_DEFAULT, which has the same text but is used in a different plural case. BUG=342370 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/192773005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255961 0039d316-1c4b-4281-b951-d872f2087c98
-
wittman@chromium.org authored
Separates bookmark UI overrides from settings overrides to avoid future conflict in requirements/goals of the two different pieces of functionality. Retains deprecated support under chrome_settings_overrides for backwards compatibility. This will be removed for the M36 release. BUG=349049 R=kalman@chromium.org, pkasting@chromium.org, vasilii@chromium.org Review URL: https://codereview.chromium.org/183883033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255959 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
fixed issue 349227: Uninit error due to DuplicateHandle failure - add check on DuplicateHandle and assign duped to be NULL on failure BUG=349227 R=sky@chromium.org, wfh@chromium.org, jschuh@chromium.org TEST=manual+drmemory Review URL: https://codereview.chromium.org/181013016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255955 0039d316-1c4b-4281-b951-d872f2087c98
-
mikhal@google.com authored
Main changes: 1. Adding an IntializeAudio and InitializeVideo to CastSender. 2. Separating FrameInput to audio and video which enables initializing each separately. 3. Changing the CastSender and CastReceiver Create functions to return a scoped_ptr. These changes better align Cast with the Chromium pipeline. BUG=346822 R=hclam@chromium.org Review URL: https://codereview.chromium.org/163553006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255954 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
> Always broadcast one last "tab not blocked" notification before closing a tab. > > BUG=336386 > TEST=as in bug > > Review URL: https://codereview.chromium.org/132103005 TBR=avi@chromium.org Review URL: https://codereview.chromium.org/192913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255952 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@google.com authored
This CL moves ChromeSigninClient from being created in SigninManagerFactory and owned by SigninManager into being a BCKS. The motivation is that other core Signin classes (e.g., *ProfileOAuth2TokenService) will need access to the SigninClient instance as well. ChromeSigninClient being a BCKS enables such access, as the respective factories can simply get the ChromeSigninClient instance from the ChromeSigninClientFactory in order to pass it in to the core classes that are being created. BUG=350710 R=rogerta@chromium.org Review URL: https://codereview.chromium.org/192313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255951 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
BUG=348915 R=oshima@chromium.org Review URL: https://codereview.chromium.org/191073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255946 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@chromium.org authored
This CL replaces the usage of content::BrowserThread by base::Thread in a straightforward fashion. It also removes now-unneeded includes and DEPS temporary allowances relating to core Autofill test code. BUG=303083 R=joi@chromium.org Review URL: https://codereview.chromium.org/190213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255944 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Notable changes: * Replace the num-lock related methods with a single DisableNumLock(), since num-lock LED is always turned off in chromeos (more details at crbug.com/124189) * Remove SetLockedModifiers(), since DisableNumLock() and SetCapsLockEnabled() are sufficient. * Remove GetLockedModifiers(), since only CapsLockIsEnabled() is useful. BUG=none R=derat@chromium.org, yukishiino@chromium.org Review URL: https://codereview.chromium.org/189663009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255943 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255941 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
> Only notify V8 once per timezone change > > The timezone is a global property. No need to notify V8 for every single > frame. > > As a side-effect, we don't have a race with context creation. > > BUG=348856 > R=marja@chromium.org, kalman@chromium.org > > Review URL: https://codereview.chromium.org/190763008 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/190953007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255939 0039d316-1c4b-4281-b951-d872f2087c98
-
jeremy@chromium.org authored
Rename to reflect what this actually does. BUG=350832 TBR=kbr@chromium.org Review URL: https://codereview.chromium.org/192613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255937 0039d316-1c4b-4281-b951-d872f2087c98
-
beaufort.francois@gmail.com authored
Screenshot: http://i.imgur.com/6hrYh1c.png Review URL: https://codereview.chromium.org/191143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255936 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255935 0039d316-1c4b-4281-b951-d872f2087c98
-
haraken@chromium.org authored
TBR=morrita1 Review URL: https://codereview.chromium.org/189413013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255934 0039d316-1c4b-4281-b951-d872f2087c98
-
primiano@chromium.org authored
This introduces the final piece to the classifier which are able to do basic parsing for mmap and native heap traces. BUG=340294 NOTRY=true Review URL: https://codereview.chromium.org/184043006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255933 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@chromium.org authored
As ContentAutofillDriver is the //content-based driver implementation for the PasswordManager component, it belongs within the component itself rather than in the //chrome embedder of the component. BUG=348515 R=dubroy@chromium.org TBR=darin Review URL: https://codereview.chromium.org/192633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255932 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
Show the full extension information in the extension controlled setting bubble for Default search engines. Also fix the glitch where the bubble popping up from the Default Search Engine list (DSE) appearing behind a selected row in the Other Search Engine list (OSE). That is fixed by making the OSE list have a lower z-index within the stacking context than the DSE. BUG=314507 R=dbeam@chromium.org Review URL: https://codereview.chromium.org/181293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255931 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
Polish the appearance of the Controlled by Extension bubble and change the link from "Manage extensions" (plural) to "Manage extension" (singular). By providing the ID to the chrome://extensions page it will automatically scroll to the right extension and highlight it. BUG=350869 R=dbeam@chromium.org Review URL: https://codereview.chromium.org/191033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255929 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
The timezone is a global property. No need to notify V8 for every single frame. As a side-effect, we don't have a race with context creation. BUG=348856 R=marja@chromium.org, kalman@chromium.org Review URL: https://codereview.chromium.org/190763008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255928 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=347565 R=dcarney@chromium.org Review URL: https://codereview.chromium.org/192693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255927 0039d316-1c4b-4281-b951-d872f2087c98
-
jeremy@chromium.org authored
* Measure power instead of CPU usage in tab switching measurement. * Fix a bug in said measurement where the initial open tab in the browser window was not navigated. * Add a benchmark that switches between 5 blank tabs. BUG=339180 Review URL: https://codereview.chromium.org/178363005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255925 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
BUG=349925 Review URL: https://codereview.chromium.org/179793007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255924 0039d316-1c4b-4281-b951-d872f2087c98
-
vasilii@chromium.org authored
BUG=349838 Review URL: https://codereview.chromium.org/190723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255923 0039d316-1c4b-4281-b951-d872f2087c98
-
skyostil@google.com authored
TBR=skyostil Review URL: https://codereview.chromium.org/189843012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255922 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255921 0039d316-1c4b-4281-b951-d872f2087c98
-
halcanary@google.com authored
Chromium base revision: 255867 / f5986665 Old Skia revision: 13700 New Skia revision: 13701 Control CL: https://codereview.chromium.org/192323003 This CL was created by Skia's roll_deps.py script. Bypassing commit queue trybots: NOTRY=true Review URL: https://codereview.chromium.org/189513011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255920 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
- Wire provider_id to Scriptable-API ServiceWorkerProvider - Send AddScriptClient/RemoveScriptClient message which is sent when navigator.serviceWorker is accessed (or detached) We can use the clients information when we dispatch events to controllee documents. BUG=349919 TEST=will add browser tests after one more patch in blink Review URL: https://codereview.chromium.org/182863004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255919 0039d316-1c4b-4281-b951-d872f2087c98
-
reed@chromium.org authored
TBR=ben@chromium.org Review URL: https://codereview.chromium.org/192373004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255918 0039d316-1c4b-4281-b951-d872f2087c98
-
lazyboy@chromium.org authored
Very Similar to chrome.contextMenus API, only applies to the <webview> that it is called upon. var w = document.querySelector('webview'); w.contextMenus.OnClicked.addListener(function() { .. }); w.contextMenus.create({id: '1', title: 'one'}); w.contextMenus.update({id: '2', title: 'new', onclick: ...}); w.contextMenus.remove('1'); w.contextMenus.removeAll('1'); This CL adds the actual implementation to the previously exposed skeleton API. Docs/snippets here: https://docs.google.com/a/chromium.org/document/d/1AoMD6kF8ui1dikzTrwK-weVHegSqQaLV2zx4xJSh_fQ/edit TBR=stevenjb@chromium.org BUG=140315 Test=Can be tested inside a chrome apps <webview>. <webview>.contextMenus.create(...) to create custom context menu items. The API is similar to chrome.contextMenus API. Similarly .update, .remove, .removeAll is also supported. Click event handler can be specified as <webview>.contextMenus.onClick.addListener(...). Review URL: https://codereview.chromium.org/186213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255917 0039d316-1c4b-4281-b951-d872f2087c98
-
beaufort.francois@gmail.com authored
As you can see in `src/ui/webui/resources/css/menu.css`, the z-index CSS property for the menu is 3. Since the z-index CSS property of the check Image is also 3, it causes some UI glitches like the one below. I've set it to 2 since 1 is used by thumbnails. OLD=http://i.imgur.com/HfCtRvJ.png NOW=http://i.imgur.com/nXkLa3b.png Review URL: https://codereview.chromium.org/121723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255916 0039d316-1c4b-4281-b951-d872f2087c98
-
tiago.vignatti@intel.com authored
This patch change the order that gl target reads Mesa headers, giving precedence to third_party/khronos over third_party/mesa/src/include. BUG=266310 TEST=locally on Linux only Review URL: https://codereview.chromium.org/184433003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255915 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
It's still used all over the place, so the compilation logs are spilled with warnings BUG=none TBR=sbc@chromium.org,binji@chromium.org Review URL: https://codereview.chromium.org/190283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255914 0039d316-1c4b-4281-b951-d872f2087c98
-
pliard@chromium.org authored
Note that private dirty is already measured on Android. BUG=347919 Review URL: https://codereview.chromium.org/190743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255913 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255912 0039d316-1c4b-4281-b951-d872f2087c98
-
haraken@chromium.org authored
The Blink roll broke browser_tests in Chromium OS: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22180 > Blink roll 168755:168805 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=168756:168805&mode=html > TBR= > BUG= > > Review URL: https://codereview.chromium.org/192373003 TBR=haraken@chromium.org Review URL: https://codereview.chromium.org/192373006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255911 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
* Drop SyncTaskManager::Schedule{,Sync}Task * Rename Schedule{,Sync}TaskAtPriority to Schedule{,Sync}Task BUG=344769 Review URL: https://codereview.chromium.org/190663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255909 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@google.com authored
The componentization is straightforward, following the patterns of other Autofill test componentizations. BUG=303083 R=isherman@chromium.org Review URL: https://codereview.chromium.org/177013005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255908 0039d316-1c4b-4281-b951-d872f2087c98
-