GitLab

This CL adds a new UMA metric WebApk.Navigation.InScope which is
recorded on every WebAPK navigation. It records whether WebAPK
navigations are within the WebAPK's scope.

BUG=999648

Change-Id: I0d8fc678f396e8fd55c48aabd41b8878ee8fdcd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788304
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695828}

Get rid of native event (i.e: XEvent) usage when translating ui::KeyEvent into
GdkEvent in GtkUi GdkKeyBindingsHandler and InputMethod context implementation.
Native event usage outside platform code is undesired and blocks changes such
as Aura/X11 => Ozone/X11 migration (e.g: PlatformEvent migration
crbug.com/965991).

It is worth noting that aura IME code has been slightly modified to set root
window as Event::target() during the PRE_DISPATCH phase (for some reason
InputMethodContext::DispatchKeyEvent() is called at this phase) so that IME
context implementation is then able to retrieve the X11 Window id, needed by
GdkEvent system.

To be able to retrieve XEvent group field in gtkui code, an Event::Property has
been added and for now is set only for non-ozone X11. Ozone/X11 will be
addressed in a follow-up CL.

Rationale:
https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc/edit?usp=sharing

Bug: 965991, 987939
Change-Id: I64929d6866c1dfcfddbfe75166a1bad139c2da8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789603
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695827}

R=kbr@chromium.org

Bug: 998038
Change-Id: Ic31d28938ef205b36657fc7bd297fe8a63d08543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798052
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695826}

Makes test_env.py compatible with both Python 2 and 3. Also adds a very
simple test to ensure that it remains compatible until some other test
switches to Python 3.

As a side effect of adding the test, also makes
testing/scripts/common.py compatible with Python 3 since it's
necessary for running isolated scripts.

Bug: 898348
Change-Id: Ib58cf4c4f85df60a432764d7f744bc3fee09ae3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796525Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695825}

With the non-NetworkService path now removed, only the
URLRequest::Delegate auth path is used.

This CL leaves a supporting enum and callback in NetworkDelegate, which
aren't used by NetworkDelegate, but are still used. I'll figure out
where to move them in another CL.

Bug: 934009
Change-Id: Icf5f8344ca0326c7ac0bbd72440ad602f65c3363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798886Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695824}

Copies ContentView from components and EventOffsetHandler from chrome.
These together will call EventForwarder.setCurrentTouchEventOffsets at
the right times to correctly offset user input under browser controls

Change-Id: I29a418457c4daf2306e7ce13e8311a489b1ca958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796046Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695823}

This is a short-term workaround to get a browser test passing
when ServiceWorkerOnUI is enabled.

When ServiceWorkerContextCore is destroyed (i.e., browser shut down or
DeleteAndStartOver() is called), Mojo callbacks can be destroyed without
being run, which causes Mojo to DCHECK.

In the failing browser test
(PendingAppManagerImplBrowserTest.InstallChromeURLFails) the callback
for Register gets destroyed when ServiceWorkerJobCoordinator is
destroyed and destroys the ServiceWorkerRegisterJob that owns the
callback.

This test failure happens for Register job on when ServiceWorkerOnUI is
enabled, but it looks like this can happen for any Mojo callback that
goes through ServiceWorkerContextCore regardless of that feature.

Medium to longer term fixes are:
- Make the ServiceWorkerProviderHosts destruct before
  ServiceWorkerJobCoordinator and other objects that can hold callbacks
  like ServiceWorkerStorage. The provider hosts hold the connections to
  the renderer, and dropping the connections allows the callbacks to be
  dropped without DCHECK.
- However, that won't help the case of destruction due to
  DeleteAndStartOver, because currently the provider hosts and Mojo
  connections survive while the job coordinator and other objects
  are destroyed. We should drop Mojo connections on shutdown (see
  issue 877356).

Bug: 1002776, 877356, 824858
Change-Id: I8d99e7c37eb51eda7ca2baf5f32be25e1c399b79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795645Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Auto-Submit: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695822}

This cl adds an experiment to the CompositorPriorityExperiments class that will
set the compositior to kVeryHighPriority until it exhausts a budget. Once the budget
runs out it will set the compositor back to kNormalPriority until the budget is
replenished.

Bug: 966177
Change-Id: I62d9b261501c99dbe62efa008cbdbc8acd902f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767956
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Scott Haseley <shaseley@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695821}

When an autoscroll is in progress and the pointer moves out of arrow/
track bounds, the animation is expected to "pause" until the pointer
moves back in the bounds. This CL implements that feature for the
compositor threaded scrollbars.

Bug: 967004
Change-Id: I85d0c1c343f39651055198688dcb056ceb587d1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764526
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695820}

ExtensionsMenuButton was a HoverButton which did not implement the logic
for adding elide. LabelButton has elide but needs additional padding to
look like what was a HoverButton.

Bug: 985382
Change-Id: I94ed473e0fadb234774fd26fa9109a9adab11e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788512
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695819}

Change-Id: I5fa43851d21942c51a8ff3a8b79bb6bd03cce287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797330Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695818}

Now that Widevine is in a nested directory, check for it's existence as
a directory (and not a file). Also update the permissions on the
actual Widevine library to be ${SHLIB_PERMS}.

Tested by building "installer" and then installing it. Widevine is
installed and Shaka player works with Widevine.

Bug: 1002648
Test: Installed Chrome and played Widevine content.
Change-Id: I531c0f7da58b50d36bb4e72fdde11f05cfa9f5a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799306Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695817}

* DCHECK() about not calling mojo callbacks before they're destroyed

This happens when the user types more quickly than we can respond

* Holding backspace accidentally shows matches for last deleted char

This happens because when input is emptied, the UI immediately hides
the matches UI, but an asynchronous result from the autocomplete
"backend" returns right after, which renders a new result.

R=mahmadi@chromium.org

Bug: 1001761, 1001762
Change-Id: Ic18dd8c63e79d4fe2d1563134920725dc19daf97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790434Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695816}

Making webkit-box use LayoutFlexibleBox means ShouldScaleColumnsForParent
would return false, where as it previously wouldn't. Returning false means
width:100% table-cells won't stretch. This patch makes
ShouldScaleColumnsForParent() not return false for webkit-box, so that
width:100% for table cells continues to stretch.

BUG=993813
TEST=fast/block/block-size-integer-overflow.html

Change-Id: I0236c45401a7d71e8f6be8f9cbe0237ddbd46f8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798986Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695815}

This histogram will continue to be useful for stabilizing the Windows
UI Automation implementation. Extend its expiry by six months.

Also update the range of known values to include UIA_IsDialogPropertyId
which was introduced in RS5.

Bug: 988814
Change-Id: Ibee9d36facf637f65b61f2a92bd8e29f0cd9e749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785623Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#695814}

It is possible that the frame becomes detached from the document
after dispatching the event. This is the only way the FrameScheduler
could be null. I previously checked it in SetLifecycleState in
change https://chromium.googlesource.com/chromium/src.git/+/42b61856cfd1b63bed1a1cae45cac6b7e41e9e0f
and that seemed to decrease the number of crashes, but they still
seem to exist. These additional checks should cover those situations.

BUG=994442

Change-Id: I59ad0e4f4e047f4548c72ad103691a260290626e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798888
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695813}

The default HWND provider for UI Automation will generate a runtime id
for our fragment root, but relying on this behavior for the legacy
window was breaking the Inspect tool's ability to expand the tree for
web content. Removing the special case and generating a runtime id for
the fragment root as for any other node fixes the issue.

Bug: 928811
Change-Id: Id15d33cacbc97699e904e9bf53e1b39975cbf8a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797096Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#695812}

The goal is to allow the use of ax_enums.mojom-forward.h in header
files, reducing the amount of transitively-included code from the mojo
headers.

This change is purely mechanical - just fix the includes where
various ax::mojom::Foo enum values are used.

Bypassing other owners per mechanical change policy:
https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes

TBR=dmazzoni@chromium.org

Bug: 1001715
Test: compiles
Change-Id: I091294909e322e4b1d8817cce0115e21dde96ed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798757
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695811}

- Autogenerating Polymer 3 version of cr-lazy-render and test
- Adding to the demo page
- Removing legacy templatizer behavior from Polymer 3 exports, since it
should not be used now that cr-lazy-render is updated to use
Polymer.Templatize.templatize() instead (see
https://crrev.com/c/1786248).

Bug: 965770
Change-Id: I58b0cd8b19b6f668888aa48fc56c7ad9817efac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790641
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695810}

Previously if we had a table-cell which was %-block-size based,
replaced elements would resolve their percentages against this height
during both the "measure" and "layout" phases.

This was incorrect, instead during the measure phase we should only
resolve a percentage against a "fixed" height table-cell, and indefinite
for all other cases.

Bug: 1001083
Change-Id: If4217a7545830d1279911753930bf821c2c023d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793942
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695809}

The updated tooltip will include "Do not disturb is {on/off}", making it more
consistent with the other tooltip buttons.

BUG=1002471

Change-Id: I2cb41dc89aa1bf133dd77640340cc0c140a8b96a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795306Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695808}

Backport some tests in /chrome/renderer/media/cast_ipc_dispatcher_unittest.cc to SingleThreadTaskEnvironment

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chrome/renderer/media/cast_ipc_dispatcher_unittest.cc.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=miu@chromium.org

Bug: 891670
Change-Id: Ie63b2a50f17930c348dd9b9ebb6f65ce0cc8963c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786843
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695807}

Updated the bug links for the
external/wpt/css/css-scroll-snap/scroll-target* tests.

Bug: 10030555
Change-Id: Iaf735d7118c4c2e8ac6a934a4e35707c2144cf1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798209Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Kaan Alsan <alsan@google.com>
Cr-Commit-Position: refs/heads/master@{#695806}

https://skia.googlesource.com/skia.git/+log/3c70f9acfc33..f7cf794890d4

git log 3c70f9acfc33..f7cf794890d4 --date=short --no-merges --format='%ad %ae %s'
2019-09-11 nifong@google.com Assert there are some sources when running skpbench
2019-09-11 kjlubick@google.com [canvaskit] expose ComputeTonalColors
2019-09-11 robertphillips@google.com Update comparison in BackendAllocation tests
2019-09-11 kjlubick@google.com [canvaskit] expose all 8 radii for RRect

Created with:
  gclient setdep -r src/third_party/skia@f7cf794890d4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=mtklein@google.com

Bug: None
Change-Id: I6b536048699ec036c8e329cad557c04d975b8088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799143Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695805}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/media/remoting.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=miu@chromium.org

Bug: 891670
Change-Id: I2093f1325393019e14ccb6e3b4f057401a0892c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787139
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695804}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/media/base/fake_audio_worker_unittest.cc.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=miu@chromium.org

Bug: 891670
Change-Id: I0e22fd1759c690657cebc7f7677c6942cd27a461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786742
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695803}

This reverts commit d249d6d6.

Reason for revert: Speculatively reverting due to crbug.com/1002946

Original change's description:
> FinalizeFrame for getImageData and ConvertToBlob
>
> For deferred offscreen canvases, it's possible that there are un-drawn,
> recorded commands at these points.
>
> Bug: 1002523
> Change-Id: I0b47319ff38aaa4030e9b74f897abd54eeeb4bcc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779107
> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
> Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
> Reviewed-by: Fernando Serboncini <fserb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#695215}

TBR=fserb@chromium.org,aaronhk@chromium.org,juanmihd@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1002523, 1002946
Change-Id: I8aa5e3843ed8a48a0fbb4b4e86ed45f566189ccc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798758Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695802}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6de79412..d70a348f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I037fc7f0a0aa425e124f7a9eed75243e0ca24569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799043Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695801}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/media/cast.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=miu@chromium.org

Bug: 891670
Change-Id: I6bd10bb9bfbc2d47f609640df14c2950db3541c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787210
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695800}

Make NetworkChangeNotifierWin::RecomputeCurrentConnectionType() static
to avoid referencing NetworkChangeNotifierWin vtable pointer when it
might be dead.  This can happen when RecomputeCurrentConnectionType()
is posted to |blocking_task_runner_| and NetworkChangeNotifierWin is
destroyed.

Bug: 995781
Change-Id: I56805777fb77a5b37829962e41d4d0b0e09eb468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789666
Commit-Queue: Eric Orth <ericorth@chromium.org>
Auto-Submit: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695799}

Remove some usage of deprecated callback types in base/*. Where possible
convert to the corresponding once type, otherwise replace with the
repeating type.

Also remove the PRESUBMIT rule exception that allows the deprecated
callback types in base/*. Note the PRESUBMIT rule uses a regex that
includes base:: so it doesn't catch usage inside namespace base that
isn't fully qualified.

Bug: 714018
Change-Id: I52acb7f46a7f447d189f2ae066fa89f593fb682d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795573Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695798}

Bug: 958115
Change-Id: I4a4aa20cec53b55adb31678d12bf13aafdca5889
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797213Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695797}

Bug: 976352
Change-Id: I9e125f2a7d2dfe24691e8097623cbc65866fe353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796002Reviewed-by: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695796}

Bug: 1000382
Change-Id: I5af4f79b7092c1ad9e459f4f2401e19e08139288
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797174
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695795}

https://webrtc.googlesource.com/src.git/+log/7e2441234b94..a1727db1acca

git log 7e2441234b94..a1727db1acca --date=short --no-merges --format='%ad %ae %s'
2019-09-11 harimb@google.com Revert "Add support of AudioRecord.Builder in the ADM for Android"

Created with:
  gclient setdep -r src/third_party/webrtc@a1727db1acca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I93fb3c110c17db4eb55050ec3bddd42e5e2c2fec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799031Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695794}

Using wpt-import in Chromium 4a9804e2.
With Chromium commits locally applied on WPT:
cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org:
  external/wpt/css/CSS2/linebox

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Ie688514c5d7d1690b80b57123dd18ef9173c628d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799083Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695793}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/services/shape_detection.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=mcasas@chromium.org

Bug: 891670
Change-Id: Ic6a5245d25a2a75218813cbb33670842a1140ac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786681
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695792}

The stack traversal call seems to be long enough causing blocking other
threads from execution.

BUG=1002285

Change-Id: I24980c72d5fcddd395eaaaab4e7fba32563c250c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797322Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695791}

https://chromium.googlesource.com/chromium/deps/icu.git/+log/53f6b23..faee8bc
  faee8bc Fix Hungarian number format.

Bug: chromium:992694
Change-Id: I2cb0d74607a1331ef9df76607ff3f63f4009046f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798885Reviewed-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695790}

Per guidance from the UI team, these types of dialogs should only have
yes/no equivalent buttons. They should not have an 'X' close button at
the top right corner that allows the user to ignore the dialog without
making an explicit decision.

Dialogs that no longer have an 'X' button as a result of this change:
1) Asking user if they want to enter a WebXR session.
2) Confirm form resubmission dialog.
3) Chrome extension asking for permission to download a file.
4) Page asking for directory access.

Bug: 985017
Change-Id: I109f5bc7d5e493f16170b9ab3599e7d7dd647c1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797093Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695789}