GitLab

Viz process that can be run using service manager is only used when mash
is run in multi-process mode with out-of-process viz (i.e. when both
Mash and MashOopViz features or on). Currently, service manager uses
aura::Env mode (MUS vs LOCAL) to allow this which is wrong. Also, a
recent change (r611340) causes service manager to run before aura::Env
is created which breaks things further. This CL checks Mash and
MashOopViz features to allow out-of-process viz.

BUG=912218

Change-Id: Ib828acefd07abcb9ab134c9ed866fc3d4792de40
Reviewed-on: https://chromium-review.googlesource.com/c/1373883Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616041}

Patch is aligning PromiseState to other @IntDef:

1. with @IntDef element first, @Retention second and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface

Change-Id: Ia94bbd12a0e4cac0e4a0d504dbd3c24a2a8b10f7
Reviewed-on: https://chromium-review.googlesource.com/c/1370950Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616040}

This policy behaves a lot like BrowserSwitcherUseIeSitelist, except it
can point to a different URL than the one IE uses.

Bug: 846316
Change-Id: I52f91019aabcdd9b20163198195770fb52183e98
Reviewed-on: https://chromium-review.googlesource.com/c/1361327
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616039}

       +66,360 bytes main lib size
      +483,380 bytes main dex size
      +780,271 bytes normalized apk size
      +299,669 bytes APK size
      +865,224 bytes Estimated installed size (Android Go)
    +2,252,524 bytes Estimated installed size
InstallBreakdown (+2,251,998 bytes):
        +2,778 bytes unwind_cfi (dev and canary only) size
        +2,673 bytes Non-compiled Android resources size
       +66,360 bytes Native code size
          +589 bytes Package metadata size
    +2,163,890 bytes Java code size
       +15,708 bytes Compiled Android resources size
        +2,466 entries fields
        +3,489 entries methods
          +794 entries types
        +1,732 entries strings

Specifics: 
InstallSize: 
Dex: 
Change-Id: I75d601109fcd2ed725ed70bbd907da9a1da3bd6f
Reviewed-on: https://chromium-review.googlesource.com/c/1374165Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616038}

Since PlzNavigate is the only way navigation works currently, this
comment is no longer valid.

Change-Id: I0a922d096a9bfd574e904ef6ee0fa5b79793e6ec
Reviewed-on: https://chromium-review.googlesource.com/c/1373018Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616037}

Tap inside the status area of auto-hide shelf with app list opened will
dismiss the app list and hide the shelf at the same time. This will
let the status area can't receive the gesture event to open the
corresponding tray bubble. This cl adds a lock for the auto-hide shelf
and uses it to lock the auto-hide shelf state if dismiss the app list
through tapping the status area of auto-hide shelf.

Bug: 902680
Change-Id: Ib946d57a25a664f3f0b80230d35a38a5c2cc1256
Reviewed-on: https://chromium-review.googlesource.com/c/1373012
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616036}

When initializing pExcludeCredentialList parameter of a
WEBAUTHN_MAKE_CREDENTIAL_OPTIONS struct, the code calls std::transform
with a wrong value for the output iterator argument. As a result, the
code crashes if an exclude_list was set in the request. This fixes the
issue by passing the correct output iterator. (The initialization of
the equivalent pAllowCredentialList parameter during GetAssertion was
already correct.)

Bug: 898718
Change-Id: Id0611348f6b4e208d9176d714b10da95b474bd2e
Reviewed-on: https://chromium-review.googlesource.com/c/1374401Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616035}

Bug: internal 110279510
Test: manual
Change-Id: I52cc1ab552f6d405cf0eb15c79fa6ea88f51398d
Reviewed-on: https://chromium-review.googlesource.com/c/1372628
Commit-Queue: Tiansong Cui <tiansong@google.com>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616034}

Improve the readability. "an string" -> "a string", mostly.

Bug: None
Change-Id: I71ef9fa7545e23c977a7b90192161776d69cf527
Reviewed-on: https://chromium-review.googlesource.com/c/1180275Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616033}

R=robertogden@chromium.org

Bug: 908491
Change-Id: Id65e7b73fda8f873d9d818683b12df449d65c96d
Reviewed-on: https://chromium-review.googlesource.com/c/1352821Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tom Bergan <tombergan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616032}

In preparation for review.skia.org/173427
add a switch so Chrome can use the old version.
Once Chrome is rebaselined, it will be switched to
the newer version.

R=fmalita@chromium.org
BUG=899689

Change-Id: I0ccf1e682337b238afa024ad26b09dde875afefd
Reviewed-on: https://chromium-review.googlesource.com/c/1374162Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616031}

The test creates windows on ash side, which uses the Shell's
env in local mode. Hence, occlusion state change happens
synchronously and does not depend on grouping occlusion state
change.

Bug: 910303
Change-Id: I99765acb3818295cbb96cef212cea91e06929704
Reviewed-on: https://chromium-review.googlesource.com/c/1372662Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616030}

We need to persist main frame overlay across page navigations [1].
LocalFrameView doesn't persist across same origin page navigations,
while LocalFrame does, so FrameOverlay should be managed by
LocalFrame.

The test happened to pass with FrameOverlay in LocalFrameView because
the GraphicsLayer created by the FrameOverlay for the previous
LocalFrameView was left in the graphics layer tree. Actually this is
an unwanted memory leak. The new LocalFrameView may create its own
FrameOverlay resulting two overlay GraphicsLayers in the graphics
layer tree.

This CL fixes the leak bug. It's also needed by ComposteAfterPaint
which doesn't use GraphicsLayer.

Also set correct property tree state when painting frame overlays.
This is important for subframes to paint the overlay at the correct
place in the overlay layer.

[1] compositing/visibility/overlays-persist-on-navigation.html

Bug: 912570
Change-Id: Ib458b6fa374aa25478ce52da1226a0c43df7d1ef
Reviewed-on: https://chromium-review.googlesource.com/c/1372723
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616029}

The latest version no longer depends on neon-animation which has been
deprecated.

Bug: 907333
Change-Id: I68ada294a8f159db7fd5f393733be47afd347d2e
Reviewed-on: https://chromium-review.googlesource.com/c/1373880Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616028}

https://android.googlesource.com/platform/external/perfetto.git/+log/38b36666a125..ca5569f2c920


git log 38b36666a125..ca5569f2c920 --date=short --no-merges --format='%ad %ae %s'
2018-12-12 fmayer@google.com fuzzing: Consume everything in buffered_frame_deserialzier.


Created with:
  gclient setdep -r src/third_party/perfetto@ca5569f2c920

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I9c85583421867cd7f69cb4ccb442ab1946f0eb69
Reviewed-on: https://chromium-review.googlesource.com/c/1374139Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616027}

This CL allows reporting events without event handlers. In particular,
this implies that slow clicks cause slow mousedown events, so the tests
are modified accordingly.

Bug: 823744
Change-Id: I9578519ae538496404bb220001d3ca97565b7bd7
Reviewed-on: https://chromium-review.googlesource.com/c/1368458Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616026}

https://chromium.googlesource.com/catapult.git/+log/277cdb9bcc3e..ebff6e2b3d0a


git log 277cdb9bcc3e..ebff6e2b3d0a --date=short --no-merges --format='%ad %ae %s'
2018-12-12 uwyiming@google.com Potential Perf Regression Expected: Add nonce to injected scripts for responses with restrictive CSP script-src directive.


Created with:
  gclient setdep -r src/third_party/catapult@ebff6e2b3d0a

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:904534
TBR=sullivan@chromium.org

Change-Id: Ie3c930e05e732e25f060e22b5cf99c56d8de2aa9
Reviewed-on: https://chromium-review.googlesource.com/c/1374047Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616025}

If we show a notification with a long title, a context message and an
image, the line limit of the message body is set to 0 so that the image
can be flush against the icon.

This CL removes this limitation and therefore the "feature" of having
the image flush against the icon when the notification contains a lot of
text. The notification message can now contain:

0 title lines: 5 max lines message
1 title lines: 5 max lines message
2 title lines: 3 max lines message

This does not depend on whether there is an image or a context message.
We still make sure that there is at least 16px of space between the icon
and the image, if the text part is higher than the icon.

Bug: 697573
Change-Id: Ic8f2441de58e4503d93da025275b57ba5a2a92b9
Reviewed-on: https://chromium-review.googlesource.com/c/1350749Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616024}

Change-Id: I96ef67192107f46e5524a406535c1c1fa51fbc80
Reviewed-on: https://chromium-review.googlesource.com/c/1374392Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616023}

 https://chromium.googlesource.com/chromium/deps/icu.git/+log/407b393..2823bdd7


The following change includes:

  2823bdd7 Fix crash of new Intl.DateTimeFormat("ja-u-tz-uslax")

Test: v8: intl/regress-8469
Bug: v8:8469

Change-Id: I3ac43f0a54761c3de0b5764b3075e587bef74275
Reviewed-on: https://chromium-review.googlesource.com/c/1373009
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616022}

Bug: 911674
Change-Id: Ia010b625ed72ca575fc1aeafdf64990bcd2171d8
Reviewed-on: https://chromium-review.googlesource.com/c/1366766
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616021}

Currently there is no way to override a method handler that is already
registered to an ExportedObject. A support to do so is required to
correctly implement Chrome OS Bluetooth dispatcher which needs to
add/remove an interface to an exported object dynamically. Therefore
this CL adds methods to allow method handlers to be unexported so
another handler can be exported afterwards.

Bug: 883039
Change-Id: Id26dbdb8b2ee3425c21ec0797e1c08183f3e04ab
Reviewed-on: https://chromium-review.googlesource.com/c/1370573
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616020}

This CL introduces a feature to prevent showing all preview types on all
reloads. Historically, only Offline previews have been prevented on
reload, but this notion should be cautiously extended to all Previews
types.

Bug: 914029
Change-Id: I8f3859a7f3ffd62b159cd064f117ed462faa1920
Reviewed-on: https://chromium-review.googlesource.com/c/1372541Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616019}

Reduced table body row heights from 44px to 42px. 42px is just sufficient to
display 3 lines. Any less, and cells with 3 lines of contents would grow in
height on hover. 3 lines seems sufficient for most matches without consuming too
much vertical space.

Reduced table header row padding from 20 (top) and 10px (bottom) to 12 and 6px
respectively. This looks more visually pleasing and consumes less vertical space
without appearing cramped compared with the adjacent table rows.

Bug: 891303
Change-Id: I75efba70799163bd7f33e1340cfecdd2d1bb45a3
Reviewed-on: https://chromium-review.googlesource.com/c/1374400Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616018}

Bug: 740993
Change-Id: I8253d80703333beb4d252b585df910c71af43ab6
Reviewed-on: https://chromium-review.googlesource.com/c/1371019
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616017}

Bug: None
Change-Id: I01bf6013df07ba47d3f1b567a8ce7e7235971bdb
Reviewed-on: https://chromium-review.googlesource.com/c/1356558Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616016}

Spacing between buttons on the downloads page was not specified in the
styling, and was instead the result of whitespace that is removed when
using the legacyOptimizations: true flag in Polymer 2. Specify 8px
margin between buttons to match spacing used in other Web UI
paper-buttons.

Bug: 912488
Change-Id: Icca140d02fe85fbb8b847b67f6925da87e13b26f
Reviewed-on: https://chromium-review.googlesource.com/c/1373137Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616015}

For some reason the snapped_dest_rect for background image geometry
calculations was not actually snapped. Snapping it fixes cases where
we were not filling to the border without regressing any tests (in
fact improving some).

Probably fixes most of the background bugs resulting from the previous
big refactoring.

R=fmalita@chromium.org
BUG=912423,889426

Change-Id: Ieba65130e7f8c0e95db7375ab3a8188bfc78d8d5
Reviewed-on: https://chromium-review.googlesource.com/c/1372556
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616014}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfed8e9b27e3..d80da25f9a45


Created with:
  gclient setdep -r src-internal@d80da25f9a45

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I2e6d5d9381c4e6497cc806420ee27c717aaca41a
Reviewed-on: https://chromium-review.googlesource.com/c/1374044Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616013}

This was previously the transition animation for the tab strip during
the tab switcher transition. It is no longer used.

Change-Id: Iead91a20ea25f5810e2556a0de99f4f0ec310592
Reviewed-on: https://chromium-review.googlesource.com/c/1370826
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616012}

In order to prepare to use ScenicSurface from multiple files, move it to
its own file.

Bug: 861853
Test: run_content_shell \
  --enable-features=VizDisplayCompositor,UseSkiaRenderer,UseSkiaDeferredDisplayList,UiGpuRasterization,OzoneDrmMojo
  --enable-oop-rasterization --enable-vulkan --enable-gpu-rasterization \
  --enable-raster-to-sk-image --use-raster-context-provider \
  --force-gpu-rasterization --use-gl=swiftshader --no-sandbox \
  --disable-gpu-sandbox

Change-Id: Ie1197b3f355a079513828353fc20e9a16162e9ea
Reviewed-on: https://chromium-review.googlesource.com/c/1362474
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616011}

Revert "Reland "Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz.""

This reverts commit aacc21d3.

Reason for revert: No longer needed now that https://chromium-review.googlesource.com/c/chromium/src/+/1371080 is relanded

Original change's description:
> Reland "Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz."
> 
> This reverts commit 9ef757a8.
> 
> Reason for revert: is again needed after https://chromium-review.googlesource.com/c/chromium/src/+/1362457 was reverted
> 
> Original change's description:
> > Revert "Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz."
> > 
> > This reverts commit 0baa5bdf.
> > 
> > Reason for revert: is not needed after https://chromium-review.googlesource.com/c/chromium/src/+/1362457
> > 
> > Original change's description:
> > > Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz.
> > > 
> > > Bug: 911836
> > > Change-Id: Ia76687b3cb8d329792e5ef0310faee93d05344f2
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1361725
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > Commit-Queue: Max Moroz <mmoroz@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#613792}
> > 
> > TBR=bungeman@chromium.org,mmoroz@chromium.org,thomasanderson@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 911836
> > Change-Id: Ibc4c88faadd5c1e603fc0f26ce956c282909798e
> > Reviewed-on: https://chromium-review.googlesource.com/c/1365083
> > Reviewed-by: Max Moroz <mmoroz@chromium.org>
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#614534}
> 
> TBR=bungeman@chromium.org,mmoroz@chromium.org,thomasanderson@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 911836
> Change-Id: Id09d7c0394e8c5eb445aa19ba5a62f8fa251ecb0
> Reviewed-on: https://chromium-review.googlesource.com/c/1371885
> Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
> Reviewed-by: Max Moroz <mmoroz@chromium.org>
> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615545}

TBR=bungeman@chromium.org,mmoroz@chromium.org,thomasanderson@chromium.org,fhorschig@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 911836
Change-Id: I2f772722a02a6b1f39457cd6588794ef3d1d11c0
Reviewed-on: https://chromium-review.googlesource.com/c/1374399Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616010}

Bug: 898261
Change-Id: Idc5d040a535be7b03b326ed30a902166b63d9b48
Reviewed-on: https://chromium-review.googlesource.com/c/1374138
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616009}

Chrome style forbids binding a pointer to a temporary, so this change allows temporaries to be used in these calls.

Change-Id: I83904fca01f13323bc28d36b33a00b5c300490b3
Reviewed-on: https://chromium-review.googlesource.com/c/1368788Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616008}

It is only sent if valid, and isn't valid on machines with no Omaha
(e.g. official builders).

Bug: 914443
Change-Id: I9d8746557290bc80ede5b3eba8330cce1405e4fd
Reviewed-on: https://chromium-review.googlesource.com/c/1374450Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616007}

Inline text has a 1px border. Previously, we used a white 1px border on the fill
text in order to help align them vertically add also add a 1px horizontal gap
between them. After other styling changes, the invisible border was no longer
necessary for vertical alignment. Additionally, it was causing the horizontal
positioning to be slightly off. This CL removes the invisible border, instead
using a right-margin for horizontal positioning.

Bug: 891303
Change-Id: Ib5fdfc876ada51f129ac2b34c1c59b3d1bd1994e
Reviewed-on: https://chromium-review.googlesource.com/c/1374204Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616006}

The message pump is responsible for creating a toplevel span for each time slice
triggered from I/O polling. This type of work is not run in the context of a
a TaskAnnotator, and is completely invisible to tracing without help from the
message pump.

Bug: 914201
Test: run_content_shell --remote-debugging-port=9222
      ssh root@fuchsia -N -L 9222:localhost:9222
      add localhost to chrome://inspect?tracing & connect

Change-Id: Ib9d248303c1c11d6fd7f616c31e0a76949c14d63
Reviewed-on: https://chromium-review.googlesource.com/c/1373132Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616005}

Remove extraneous |removeAllWebFrames| call to ensure a WebFrame exists for the main frame when navigating back then forward on a same page (ex:example.com#link) link.

Additionally, add tests to validate the returned WebFrame object.

Bug: 913825
Change-Id: I5abe3a50769564c1c95157eb713ee435093cbab4
Reviewed-on: https://chromium-review.googlesource.com/c/1368768Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616004}

This was causing a crash if the throttle was destroyed before the
callback was called.

Bug: 914436
Change-Id: Id52e41c2f42fe29116a2b877311cc1d9405b5116
Reviewed-on: https://chromium-review.googlesource.com/c/1374159Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616003}

Bug: 896225
Change-Id: I35a7355a3d3b5fb9ad8d5425e2855985ab36e63a
Reviewed-on: https://chromium-review.googlesource.com/c/1370824
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616002}