- 14 Sep, 2019 40 commits
-
-
Nico Weber authored
No intended behavior change. Bug: none Change-Id: I2acc32b560f5aea94d9e7b45272194884d65b1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804315 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#696654}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9329acdeb98..b340e3d9e410 Created with: gclient setdep -r src-internal@b340e3d9e410 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I81ae644e439edfccc56a10a76c3a1175f8184362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804779Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696653}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4bcadcaaec5d..a94f125fb5a8 git log 4bcadcaaec5d..a94f125fb5a8 --date=short --no-merges --format='%ad %ae %s' 2019-09-14 vapier@chromium.org lint: disable distutils.version warnings Created with: gclient setdep -r src/third_party/chromite@a94f125fb5a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7bcd0a3e8b7c13414f889aa84f089a966d9f23ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804839Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696652}
-
Ionel Popescu authored
The input type="month" popup UI is updated by introducing a new MonthPicker. MonthPicker uses 2 parts already implemented: - year list view - today button Added tests to validate the new UI for the popup. Further CLs will be sent for updating the font, colors, keyboard navigation and introducing support for step attribute. Bug: 1003625 Change-Id: Id6ef4e88877edea4cba5b963f27681ce56d79d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802684 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#696651}
-
Rouslan Solomakhin authored
Before this patch, when PaymentRequest object destroyed native objects, it would set the static variable "is any PR showing" to false, regardless of whether it was showing any UI. If another PaymentRequest object was showing UI, it would now not benefit from new PaymentRequest objects checking this variable in PaymentRequest.show() and rejecting with "Another UI is already showing" error. Example old buggy behavior: pr1.show(); // Shows UI. isAnyUiShowing = true. pr2.show(); // Rejects. isAnyUiShowing = false. Bug. pr3.show(); // Shows UI. Bad. Buggy behavior was introduced in https://crrev.com/c/1762760. This patch resets the "is any PR showing" to false only if a UI is being destroyed. After this patch, calling show() on multiple PaymentRequest objects while one of them is already showing will reject with "Another UI is already showing" error. Example new correct behavior: pr1.show(); // Shows UI. isAnyUiShowing = true. pr2.show(); // Rejects. pr3.show(); // Rejects. TBR=danyao@chromium.org Bug: 1000432 Change-Id: I7341c3b80d4f04f0b8e692580581ff7ccfeddbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804577Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#696650}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I30abfe0324a88102e642f7fd3205d567aed289d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803965Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/328e0bde7d37..f9329acdeb98 Created with: gclient setdep -r src-internal@f9329acdeb98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I195f2c15b5520555b38946395a288a62cbf137b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804778Reviewed-by:
-
Bo Liu authored
TBR=sky@chromium.org Change-Id: I6379dde3bff0b16e5b1c823d5511174bfa8b6c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803765Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#696647}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c56cc363d23f..328e0bde7d37 Created with: gclient setdep -r src-internal@328e0bde7d37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7894a6eaf4086c8950ebeaaddf9836be87743f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804636Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9d25ad41920e..73ec83f0febd git log 9d25ad41920e..73ec83f0febd --date=short --no-merges --format='%ad %ae %s' 2019-09-14 raul@tambre.ee setup_color: Don't output an error if GetConsoleMode fails Created with: gclient setdep -r src/third_party/depot_tools@73ec83f0febd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1001187 Change-Id: Ia72d025a457c6b5b17e1acd58faf3650156db0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804635Reviewed-by:
-
Anton Bikineev authored
Change-Id: Id92f3da6039c0d2e040ee55caa0ca0b722844233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803920Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#696644}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9fd0e7aefdf8..c56cc363d23f Created with: gclient setdep -r src-internal@c56cc363d23f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9359114329789331f970289766f2c2172be9de51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804264Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia3892713f1886c67436e4fa9664a04a74daa7bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804073Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2af2515d..29c09b1d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I52d6881615a65a88504445125cef52c51c6e47c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804765Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696641}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b76d3875bc1b..b0b8d9e4cd23 git log b76d3875bc1b..b0b8d9e4cd23 --date=short --no-merges --format='%ad %ae %s' 2019-09-14 treehugger-gerrit@google.com Merge "Add 'Cancel recording' button" Created with: gclient setdep -r src/third_party/perfetto@b0b8d9e4cd23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1a78547cbaa5c73bb85aab2fea90dc11787e05ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804071Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fdadc02909bf..9fd0e7aefdf8 Created with: gclient setdep -r src-internal@9fd0e7aefdf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8f9cce50586312bdf04dd8aa4e895c75954edfa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804838Reviewed-by:
-
rbpotter authored
Bug: 1002807 Change-Id: I35cc15294e5a41f5932aea07f2d92b45707586e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801230Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#696638}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0dd37ce029f0..ec06ebd25b71 git log 0dd37ce029f0..ec06ebd25b71 --date=short --no-merges --format='%ad %ae %s' 2019-09-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9004bcf3..9f151687 (696490:696593) Created with: gclient setdep -r src/third_party/webrtc@ec06ebd25b71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iab2205cd8c31b6600074e40548e3603c492702e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804261Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2cb1315d99e4..e1af44498b6e git log 2cb1315d99e4..e1af44498b6e --date=short --no-merges --format='%ad %ae %s' 2019-09-14 reed@google.com add guard to switch to SkPathTypes Created with: gclient setdep -r src/third_party/skia@e1af44498b6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Iec00fe8627a9aa429bdf149bd668c4dbac80c9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804824Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I252faf757e63580f13160591778b605b07ec64fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804317Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696635}
-
Bo Liu authored
Add code paths that allow switching between TextureView and SurfaceView for rendering. Only tested visually starting different modes, but did not try dynamically switching modes yet. No attempt at making the switch seamless. Made shell not resize when soft keyboard is displayed. TextureView will stretch the texture before the surface is resized, which looks bad with browser controls. Remove some copied code that is not needed. Change-Id: I732efd37d7b8abe47c51b0b684d6fffe94b905ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803800 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
Jesse Schettler authored
Add a new mojo interface (printing::mojom::PrintRenderFrameHelper) and use it to replace the PrintMsg_InitiatePrintPreview IPC message. This also enables using the new mojo method to pass a PrintRendererPtr to the PrintRenderFrameHelper, which will be implemented in a separate change. Bug: b:140576300 Test: ./unit_tests --gtest_filter=PrintViewManagerTest.* Test: Verify print preview still works Change-Id: Icda449d9a72166d1162b95b5e08303752b2fa8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788233Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#696633}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f5ad5c1a3f33..c2da3ad9993b git log f5ad5c1a3f33..c2da3ad9993b --date=short --no-merges --format='%ad %ae %s' 2019-09-14 awscreen@chromium.org [FXCRT] Add string<->double support routines 2019-09-13 thestig@chromium.org Fix variable name mismatches in CPDF_Array. 2019-09-13 awscreen@chromium.org [FXCRT] Add double rounding support Created with: gclient setdep -r src/third_party/pdfium@c2da3ad9993b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:611744,chromium:611744 Change-Id: I14639c7499833e6a9b620b54ffda9a339e75c4e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804814Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9d4f6483..2af2515d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I13a333635a37f29be5af355794abfaa9416ee0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804756Reviewed-by:
-
Bettina authored
Bug: 1003962 Change-Id: I7deae76d9e7635b040b2adb1f8562f86c1b41376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804381 Auto-Submit: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#696630}
-
Tom Anderson authored
GetThemeProvider() will return nullptr before the view is added to the widget, so avoid using it in OmniboxTabSwitchButton and instead obtain the theme from OmniboxResultView. BUG=1004012 R=pkasting Change-Id: I464b7a81b73df06fb18d6c2f6a9a9180f0d79079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804820 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#696629}
-
Zhenyao Mo authored
We assumed GLContext::GetCurrent() will not return null, but it the wild it seems it could be null. So instead of DCHECK, we fail gracefully. BUG=1002637 TEST=crash reports R=sunnyps@chromium.org Change-Id: If3b83bd93c73353632baedfa7876cba77cebdf16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804219 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#696628}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a75199c956a7..fdadc02909bf Created with: gclient setdep -r src-internal@fdadc02909bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:991788,chromium:None Change-Id: I86bfcc01c6296cb5b41a06dbeb9a86addc422dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803961Reviewed-by:
-
Eric Seckler authored
This reverts commit fd8826a6. Reason for revert: suspecting this to be the cause of crbug.com/997610. Original change's description: > Reland "tracing: Enable startup tracing for spawned child processes" > > This is a reland of e40282f6. > > Includes a fix to BackgroundTracingActiveScenario, which could end up enabling > TraceLog without installing the TraceEventDataSource overrides on Android, see > patch set 1 -> 2. This likely caused the crashes observed in crbug.com/997582. > > Original change's description: > > tracing: Enable startup tracing for spawned child processes > > > > Enables startup tracing for child processes spawned by the browser while > > a tracing session is active. > > > > This allows us to collect early trace events in the period of time > > before the child connects to the tracing service. > > > > Bug: 968424 > > Change-Id: I1708cabae77cdd2ab3a33929c28cfab04eb723e3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755746 > > Commit-Queue: Eric Seckler <eseckler@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: ssid <ssid@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689599} > > Bug: 968424 > Change-Id: Id69f0821671caf05238896d4a0e1b581b5d5be44 > TBR: avi@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782812 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694981} TBR=avi@chromium.org,ssid@chromium.org,eseckler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 968424, 997610 Change-Id: Ie7d48681d109d55204338ed6f2f4f0ed5920c1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804063Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#696626}
-
Erik Chen authored
Change-Id: I6755790c356541fb751f12d27dc379881120b7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804375 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#696625}
-
Alexis Savery authored
Add UMA histogram "Platform.StatefulUsedSpace" for Chrome OS. This tracks the space used for the stateful partition in GB. Implementation CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1775464 Bug: chromium:999309 Test: ran validate_format.py Change-Id: If2638edf7b48f8420c1893b6cdc3f71623f5ae17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776853 Commit-Queue: Alexis Savery <asavery@chromium.org> Reviewed-by:Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#696624}
-
Robert Sesek authored
They are the only remaining files in that directory, so they can just go in wtf/ instead. Bug: 95729 Change-Id: I3f0d0647835d5cde29b2d3024005075d3feb7d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803764Reviewed-by:
-
Robert Sesek authored
The internal signing job now always notarizes. Bug: 850199 Change-Id: I2450be540779e60049425065695555fa04296a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804581 Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#696622}
-
Koji Ishii authored
This patch fixes |may_break_inside| in |NGLineBreaker|. Issue 1002442 revealed an error case in |ShapingLineBreaker|. In that case, it returns a result whose size is larger than the available space. Before this patch, |NGLineBreaker| assumes that the line overflows if the result size is larger than the available size, and sets |may_break_inside| to |false|, which prevents breaking in |HandleOverflow()|. This can cause rather a large layout error. crrev.com/c/1797954 tried to fix the error in |ShapingLineBreaker|, but it looks like some tests is relying on the behavior and it was reverted. This patch instead makes |NGLineBreaker| more robust, by using the actual overflow state from |ShapingLineBreaker| to compute |may_break_inside|. The error in |ShapingLineBreaker| is not fixed yet, but with this fix, the worst result is to not able to fit a word that can fit by less than 1px or so. Further work for better correctness will be tracked in issue 1003742. Bug: 1002442, 1003742 Change-Id: I13a3172abc8a0d2f5f78b2dd0b57b85de593fdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803019Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#696621}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cf4deab60e30..2cb1315d99e4 git log cf4deab60e30..2cb1315d99e4 --date=short --no-merges --format='%ad %ae %s' 2019-09-13 khushalsagar@chromium.org Reland "gpu: Update GrGLCaps usage of fTextureRectangle with chromium." Created with: gclient setdep -r src/third_party/skia@2cb1315d99e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:900706,chromium:998038 Change-Id: I302f8f10d687862c5490a78e59dffa22274066a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804776Reviewed-by:
-
Matt Reynolds authored
GamepadService is implemented as a global singleton. Typically there is only ever one GamepadService instance for the lifetime of the browser, but in tests a new instance may be created for each test case. Previously, when a new instance was created the previous instance would leak. This CL makes sure the previous instance is destroyed before a new one is created. At startup, the GamepadService is passed a service_manager::Connector to allow gamepad data fetchers to use the device service to enumerate and communicate with gamepads on the polling thread. The Connector must be destroyed on the same thread it is bound to. Since the polling thread is owned by GamepadProvider, the Connector has also been moved into GamepadProvider so it can be destroyed along with the polling thread. A pointer to the Connector is provided to the data fetcher when it is added to the GamepadProvider. BUG=961039 Change-Id: I66741b3ea5971cea3bbf2ba81bd1f734a7664ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777024 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#696619}
-
Kyle Horimoto authored
This CL shows an error in the settings page when a Cellular network is not connectable. Bug: 947351 Change-Id: I68c270afec2cd99a773b4eeedf6c1e351486a15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779348Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#696618}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/170e919274a2..b76d3875bc1b git log 170e919274a2..b76d3875bc1b --date=short --no-merges --format='%ad %ae %s' 2019-09-13 treehugger-gerrit@google.com Merge "Add 'chrome logs' probe to perfetto record config" Created with: gclient setdep -r src/third_party/perfetto@b76d3875bc1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I716a8d633979b5c353d04b3bbaebee54e392fe22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804775Reviewed-by:
-
Kush Sinha authored
This is a reland of 1e78e311 The performance issues in https://crbug.com/1001518 have been fixed. Original change's description: > Enable crOS Account Manager by default > > Chrome OS Account Manager has been enabled for 1% on Stable channel. > Enable it on ToT as preparation for 100% Stable ramp up. > > TBR=droger@chromium.org > > Bug: 816954 > Change-Id: I6e0097237600e40c39a98e59af063deddd1da9a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761588 > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689126} Bug: 816954 Change-Id: Ibbf78c4c598ba6ddb085ccea870a4409276c745c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801756Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#696616}
-
Manu Cornet authored
Change-Id: I7c9888e2bbd7e3646273b7b02456bec5cb82ffff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803660Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#696615}
-
