- 28 Feb, 2018 40 commits
-
-
Gauthier Ambard authored
This CL merges the LegacyToolbarCoordinator in the ToolbarCoordinator. Bug: 809785 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I444edfa36c23986323fb3ec686c29d4e3c25ba87 Reviewed-on: https://chromium-review.googlesource.com/931441 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539810}
-
Gauthier Ambard authored
This CL updates the size of the toolbars to match the requirements. The requirements are described in: crbug.com/807778. Bug: 807284 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icabb8adc10d9b6e4828e83e0b94260612ca334b9 Reviewed-on: https://chromium-review.googlesource.com/939480 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539809}
-
Keishi Hattori authored
When incremental marking is enabled, new pages are allocated while marking. By moving the MarkAsUnswept from before marking to after, this simplifies swept flag management. This is because pre sweep all pages become unswept. This CL also adjusts ObjectPayloadSizeForTesting for this change. Change-Id: Ic5ea315a2cfd2c65e8d8f08e55b1d202fbeb5915 Reviewed-on: https://chromium-review.googlesource.com/938887 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#539808}
-
Mounir Lamouri authored
These changes are sent over with UKM data and wiped when local data are wiped. Bug: 814351 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I189a430e46fb2a68af34aa7d4b237adad45d781a Reviewed-on: https://chromium-review.googlesource.com/931471 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#539807}
-
Yuri Wiitala authored
Adds a browser test to confirm that tab capture grabs all content and content updates when cross-site render process isolation is turned on. The addition of this test revealed a pre-existing bug where the consumer would not get a video frame for updated content. This happened whenever OnFrameDamaged() was being called before OnBeginFrame() (which can happen when Surfaces are changed). Bug: 808718 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo Change-Id: Ic965ece20d4c40eb65cdb78452148283935e5184 Reviewed-on: https://chromium-review.googlesource.com/936661Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539806}
-
Scott Chen authored
Bug: 815018 Change-Id: I4acef1831cee5f32b6f2b307c5d695e7f3177cb9 Reviewed-on: https://chromium-review.googlesource.com/939180 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#539805}
-
Chandan Padhi authored
This CL adds support for audio and video properties in MediaStreamTrack.getCapabilities() for audio and video sources other than getUserMedia(). Bug: 293292 Change-Id: I14569ad829b80ade60ea52f371edc0bffd282583 Reviewed-on: https://chromium-review.googlesource.com/934481 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#539804}
-
Thomas Tangl authored
For the personalized sync promo in the user menu and the contextual promos "Sync as <FIRST>" should be displayed instead of "Sync as <FIRST> <LAST>". This CL fixes this. Bug: 810865 Change-Id: Idf3f40b9f9a7ecac8dff4d2ab293cafda8399249 Reviewed-on: https://chromium-review.googlesource.com/939396Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#539803}
-
Martin Sramek authored
Specifically, record the resource IDs of the strings the user saw and clicked on when giving consent for Chrome Sync on Android. See detailed explanation in this (internal) doc: https://docs.google.com/document/d/1Psl9VJ4Dbc1Dh5bXCTa85OF1_DE3viTTHYwybu3V6Uk/edit#bookmark=id.6zygb41dn9vl Bug: 781765 Change-Id: I55c04b7c206602d892dcfff34c47b79876000608 Reviewed-on: https://chromium-review.googlesource.com/880861Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#539802}
-
Thomas Tangl authored
This CL fixes a bug in the accounts submenu of the contextual promos to start sync with the correct account. Change-Id: Ib1dd02e66d900172bec38be6ee0449335fe77449 Reviewed-on: https://chromium-review.googlesource.com/941144Reviewed-by:
-
Daniel Bratell authored
If the same include guard is used twice, it becomes impossible to include both those headers in the same translation unit and that can be hard to debug and understand. This patch renames some include guards that have the same names (copy/paste) as existing include guards. Found while working on a PRESUBMIT test for include guards. It will not warn for these things, but it was easy to add that test locally. There are another few thousand files that have wrongly named include guards. Left as an exercise to the reader. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic7ba08558d3fbae0d3bee843f3092d472f8c643b Reviewed-on: https://chromium-review.googlesource.com/937712Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#539800}
-
Aleksandar Stojiljkovic authored
BUG=737410 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id977164b8acf715c0601b27bc70b54bf5d01d6a6 Reviewed-on: https://chromium-review.googlesource.com/940221Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Aleksandar Stojiljkovic <aleksandar.stojiljkovic@intel.com> Cr-Commit-Position: refs/heads/master@{#539799}
-
Sylvain Defresne authored
The testing::Test fixture (used by TEST macro) does not drain the autorelease pool after a test. PlatformTest should be used. Bug: none Change-Id: I7b33f0c53bc57fb8f2266bc58eb578d71da642b4 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/940132 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539798}
-
Manuel Rego Casasnovas authored
"ahem" is causing flakiness on Windows, so this patch just replaces "ahem" by "Ahem" on css-ui WPT tests. BUG=724392,796733 Change-Id: I956e939790319ec956164f34af8c72f109c528ef Reviewed-on: https://chromium-review.googlesource.com/940133Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#539797}
-
Colin Blundell authored
This CL adds a convenience static function to hide casting of a SigninManagerBase instance to its corresponding SigninManager instance. This function follows in the grand tradition of Profile::FromBrowserContext. This CL also switches all applicable callsites to use the new function and removes unnecessary static_casts to SigninManagerBase that are scattered around the codebase. Note that there are some static_casts that cannot be switched: the ones in the various SigninManagerFactory instances. These are casting from KeyedService* rather than SigninManagerBase*. TBR=jam@chromium.org Change-Id: Ib150071b11a1558f96d06f184a83775acc8b088b Reviewed-on: https://chromium-review.googlesource.com/939400 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Per Åhgren authored
This CL adds a command line switch based on base::Feature to allow the user to explicitly specify when the setup used is such that the audio playout and capture are done on different clocks (has clock-drift). Bug: chromium:816742 Change-Id: I8a8e15ef479062a0ab30878ef3bde5b5c1f52d6e Reviewed-on: https://chromium-review.googlesource.com/938921 Commit-Queue: Per Åhgren <peah@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#539795}
-
Fredrik Söderquist authored
Since the 'pathLength' attribute moved to SVGGeometryElement, so should the attribute mutation handling. Bug: 815170 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I04bc19988f80f3c3fe4810897e3003403c6997c6 Reviewed-on: https://chromium-review.googlesource.com/939625 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#539794}
-
Colin Blundell authored
This reverts commit 1a37b165. Reason for revert: Causing components_unittests to fail compile due to missing definition of the static function. See https://bugs.chromium.org/p/chromium/issues/detail?id=817302#c1 for more details. Original change's description: > [MacViews] Shim |ShowModalDialog| for Polychrome > > Since "ViewsBrowserWindows" is a Chrome feature, this CL follows > CreateNativeWebModalManager in declaring a function in components > and defining it in c/b/ui/cocoa. > > Background: > Polychrome is an intermediate step to shipping MacViews browser. > Currently, switching between Cocoa browser and MacViews browser requires > a buildflag. Polychrome builds both Cocoa and MacViews into the same > binary and allows switching between them based on a feature flag. > More details at crbug.com/802257 > > As Cocoa and (much of) Views were not typically built together, > some symbols were reused. With Polychrome, these are duplicate symbols. > This CL resolves the issue by renaming the Cocoa symbols, and then > shimming them for the (regular, not Polychrome) Cocoa build. > > Bug: 808017 > Change-Id: I9bf1845aa22305928aafd74884793f0fa86afe56 > Reviewed-on: https://chromium-review.googlesource.com/929942 > Reviewed-by: Mike Wittman <wittman@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#538832} TBR=ellyjones@chromium.org,wittman@chromium.org,lgrey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 808017 Change-Id: I523fee5108b570a8e36bb5f5bc91a3896c916742 Reviewed-on: https://chromium-review.googlesource.com/941161Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#539793}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dfa786d6..86431ec7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Icfcfb83a3161245f68acebc3bbff2b4d18668159 Reviewed-on: https://chromium-review.googlesource.com/940485Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#539792}
-
Daniel Bratell authored
wincrypt.h and OpenSSL headers define the same macros (until a later version of OpenSSL at least) so therefore we need to include crypto/wincrypt_shim.h instead which hides the clashing macros. TBR=pmonette@chromium.org Bug: 746957 Change-Id: I629859f8e381ccadfdf9b6d811330bd8fc35be95 Reviewed-on: https://chromium-review.googlesource.com/940225Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#539791}
-
Mythri Alle authored
CodeCacheAfterExecute is on a finch experiment since 3 weeks and the results from the finch trial show a 20-40% reduction in javascript compilation time [1]. [1]:https://docs.google.com/document/d/1Y-a1XcpImrCMCMLJosNiMfjtIjP9zL_upUGlJzeowSo/edit?usp=sharing Bug: chromium:808007, chromium:783124 Change-Id: Idb0264a81eebc23b12cad71a7dfcdb2a9c0edae7 Reviewed-on: https://chromium-review.googlesource.com/939385Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#539790}
-
Gabriel Charette authored
TaskSchedulerWorkerPoolHistogramTest.NumTasksBeforeCleanup still depends on cleanup timing, I'll try to remove those dependencies in a follow-up. R=fdoray@chromium.org, robliao@chromium.org Bug: 816170 Change-Id: I2cca331d18ee8f3ca384493bd3584c68240c445e Reviewed-on: https://chromium-review.googlesource.com/936626 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#539789}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e7d579a8. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13005 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/line-break TBR=kereliuk No-Export: true Change-Id: I04ebc58e38a8649bf783f3fc6e7f90fde3b51508 Reviewed-on: https://chromium-review.googlesource.com/940486 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#539788}
-
tzik authored
Tbr: jennyz@chromium.org Change-Id: Iac44f0b08ffef83322e9811fe4bc65cab11ce1c1 Reviewed-on: https://chromium-review.googlesource.com/940706 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#539787}
-
Michael Lippautz authored
Instead just forward to the Trace method of this visitor which will call ListHashSetNode::Trace after marking the node. Bug: chromium:802273 Change-Id: Ic13090edead2e26c94ce0f0157e3d3f6d1effcb3 Reviewed-on: https://chromium-review.googlesource.com/939823 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Risan authored
This change add a method to request Chrome to send all existing mount points. This method is called everytime vold is reseting. Bug: 64500663 Change-Id: If10577a3d40ebd240a2ad242f703a28ecd3c363e Reviewed-on: https://chromium-review.googlesource.com/938683 Commit-Queue: Risan <risan@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#539785}
-
Colin Blundell authored
There are no obvious recent changes to have turned this test flaky. The best hypothesis that I have is that something in the changes in https://codereview.chromium.org/2939943004 was problematic, although in that case it's unclear why it would only start turning up now. TBR=asvitkine@chromium.org Bug: 817172 Change-Id: Ic0665e7d8d606b5ecb01d11f641bcfe2ec82a1ab Reviewed-on: https://chromium-review.googlesource.com/941121Reviewed-by:
-
Darren Shen authored
ComputedStylePropertyMap should return computed values. For 'transform', that's "as specified, but relative lengths converted to absolute" [1]. This means we need to return the individual transform components like 'translate3d'. Currently there's no code to do this, so we have to roll our own. [1] https://drafts.csswg.org/css-transforms-1/#propdef-transform Bug: 816803 Change-Id: I64305512fa0d0ce32ba86ea2b14595b551ff1c8d Reviewed-on: https://chromium-review.googlesource.com/938885Reviewed-by:
-
Vaclav Brozek authored
So far, SavePasswordsPreferences always assumed that onResume is only called after Chrome is killed. However, it can also be called when it is just paused. In that case, and if the export warning is shown, onResume should not cause another export warning dialog to pop up. Also, if Chrome is resumed after a long time, the reauthentication for exporting should not be conisdered valid any more. Therefore, this CL adds a member variable keeping a reference to the export warning dialog inside SavePasswordsPreferences. During onResume, it uses the variable to dismiss the dialog if the reauthentication is no longer valid. The CL also makes SavePasswordsPreferences skip creating the warning dialog in case it already exists and is functional. (Note: if Chrome is resumed after being killed, the warning dialog will be re-created by Android, but not functional. In that case it dismisses itself and SavePasswordsPreferences need to re-create it properly. This is not changed in this CL.) Bug: 815156 Change-Id: I5e6372cbde1e7e5d1e333fd06206f99618907eb6 Reviewed-on: https://chromium-review.googlesource.com/939471 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#539782}
-
Ivan Afanasyev authored
This is a reland of ccaa8bf9. Original change's description: > Fix wrong password saving when loging to facebook. > > Facebook.com may perform |SameDocumentNavigation| on login form submit. > User password will be saved even if it is wrong. > > The changeset disables trigger on action changes. > > Change-Id: I4103661fb9649280862229248f329da23dcc8912 > Bug: 808917 > Reviewed-on: https://chromium-review.googlesource.com/897638 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Иван Афанасьев <ivafanas@yandex-team.ru> > Cr-Commit-Position: refs/heads/master@{#539110} Bug: 808917 Change-Id: I098cde3361288d60d083649f25ceec8265140f7a Reviewed-on: https://chromium-review.googlesource.com/940122Reviewed-by:
-
Manuel Rego Casasnovas authored
"ahem" is causing flakiness on Windows, so this patch just replaces "ahem" by "Ahem" on WPT tests. BUG=724392,794136 Change-Id: I55ce2ee7ed36b2708da571f52256716e97a072cb Reviewed-on: https://chromium-review.googlesource.com/940921Reviewed-by:
-
Christos Froussios authored
The export progress UI offers a cancellation action. Cancelling should stop writing to the disk and undo any content which was already written. This CL introduces the chrome.passwordsPrivate function cancelExportPasswords() which forwards the user's request to cancel to the browser. The API proposal for the export functions of passwordsPrivate is https://docs.google.com/document/d/1WtsbdTnWpZUMlL6q9mqdO_bY8QZi-JSrJV9RkZysNpQ/edit# I have updated it with the cancel function. Bug: 811779 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I095af1029bdda7dc45e8623b77acad4464e80310 Reviewed-on: https://chromium-review.googlesource.com/924058 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539779}
-
Chandan Padhi authored
This CL ensures that MediaStreamTrack.getCapabilities() does not have range properties if they don't have a valid range. Bug: 293292 Change-Id: I6f85086fb4af7e17faca069f76299a0256f1872d Reviewed-on: https://chromium-review.googlesource.com/938983 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Ioana Pandele authored
This CL adds the following metrics: - PasswordManager.ExportPasswordsToCSVResult - PasswordManager.TimeReadingExportedPasswords Metrics still to be added in following CLs: - PasswordManager.ExportedPasswordsPerUserInCSV Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5e92c93f07888e0e3fc7c7468de5543755e6834d Reviewed-on: https://chromium-review.googlesource.com/912131 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Kent Tamura authored
HTMLFormControlElement::UpdateAncestorDisabledState() checked if the highest <legend> is the first <legend> child of the highest disabled <fieldset>. It should check <lengend> child of every disabled fieldset ancestors. Bug: 817181 Change-Id: I8f7dedd8089757d9eae726de359b0efe47cf9f44 Reviewed-on: https://chromium-review.googlesource.com/940644Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#539776}
-
Fredrik Söderquist authored
Cleanup some (now) unnecessary explicit 'this' dereferences as well. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I49238bf7b32760e5a05f6b6ce41557d34423ea45 Reviewed-on: https://chromium-review.googlesource.com/931508Reviewed-by:
-
Naoki Fukino authored
Android apps are closed by BrowserBack key on Chrome OS. To make the built-in app's behavior consistent and keep the app alive, we minimize the app window on BrowserBack. Bug: 807521 Test: Manually tested Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib4883b75791721baf1b2ff814d4e5047a0dfe726 Reviewed-on: https://chromium-review.googlesource.com/940743Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#539774}
-
chrome://newtab/#open_tabsMarc Treib authored
The NTP hasn't had an "open tabs" page in years. Time to get rid of this. TBRing trivial test-only changes in app_menu_controller_unittest.mm and recent_tabs_sub_menu_model_unittest.cc. TBR=ellyjones@chromium.org Bug: none Change-Id: Ib4d901ef6cfe67ab546016cc09dfcc2d9673572c Reviewed-on: https://chromium-review.googlesource.com/939395 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#539773}
-
tzik authored
base::Bind used to fail if a raw pointer to a non-ref-counted object is passed as a receiver. Though that is an expected failure, its error was hard to read. This CL adds a static_assert for the failing case for better error message. Change-Id: I7057fbfaa0c24530f3b9e28b4362f4b8637cd1be Reviewed-on: https://chromium-review.googlesource.com/923661 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#539772}
-
David Tseng authored
- any node with the editable boolean property should automatically be considered a text field - ChromeVox expects to see |url| on a root automation node - clarify what gets used as an accessible name - give each ax tree source an id Change-Id: I073808c797da55f9b54c3732cc8bb7a22da6a7c6 Reviewed-on: https://chromium-review.googlesource.com/936429Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#539771}
-
