GitLab

Removes chrome os ifdefs from SigninManager. SigninManagerBase provides
all necessary functionality for that platform.

I plan to change most callers of SigninManagerFactory::GetForProfile to use
GetBaseForProfile in a follow up CL, and ultimately have the factory only
create an SMB (versus a full SigninManager) on Chrome OS.

TBR=sky@chromium.org
for chrome/, chrome/browser, chrome/browser/ui, and chrome/test.

TBR=zelidrag@chromium.org
for chrome/browser/chromeos/login

TBR=mpcomplete@chromium.org
for chrome/browser/extensions/api/identity

BUG=181451, 174927

Review URL: https://codereview.chromium.org/12502017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195410 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195409 0039d316-1c4b-4281-b951-d872f2087c98

To making InputMethodDescriptor simple, let me remove operators.
Also remove operator related tests because operator had been used only in tests.

BUG=None
TEST=ran all unit_tests.

Review URL: https://codereview.chromium.org/14123005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195408 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224018, 168224
TEST=On a Chrome for Android official build, launch Chrome, quit it and launch it again. Go to chrome://version and verify that the string "5a3c10b5" appears in the Variations list. (This corresponds to the server-controlled Test0PercentDefault field trial).
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13954011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195407 0039d316-1c4b-4281-b951-d872f2087c98

After this CL, the effective address family will be determined by
the UDP connect test rather than the last interface enumeration probe.

BUG=223876

Review URL: https://codereview.chromium.org/14161008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195406 0039d316-1c4b-4281-b951-d872f2087c98

When a SPDY stream is stalled, always queue it up for resumption when
the session send window goes positive, as it may end up being stalled
by the session also.

Add regression tests.

BUG=233910
TBR=rch@chromium.org

Review URL: https://codereview.chromium.org/14148007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195405 0039d316-1c4b-4281-b951-d872f2087c98

Changes code to use the images committed with http://crrev.com/14362011.

BUG=232963

Review URL: https://codereview.chromium.org/14189012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195404 0039d316-1c4b-4281-b951-d872f2087c98

Since the text color changed, its backround color has to change also
otherwise Label's GetReadableColor() will use a computed text color
instead of the specified one.

BUG=230068

Review URL: https://codereview.chromium.org/14298015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195403 0039d316-1c4b-4281-b951-d872f2087c98

Fails on Windows XP.

This reverts commit 61feca81.
TBR=bbudge@chromium.org

BUG=79375

Review URL: https://codereview.chromium.org/13990006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195402 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155363
R=msw@chromium.org,mukai@chromium.org

Review URL: https://codereview.chromium.org/13879011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79375

Review URL: https://codereview.chromium.org/14320023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195400 0039d316-1c4b-4281-b951-d872f2087c98

The simple cache experiment control group will be "version 3" of the cache
format, enforced on the index. This will cause users to drop their blockfile
backend on startup in the control group, but keep their backend from session
to session.

R=felipeg@chromium.org,pasko@chromium.org
BUG=231054

Review URL: https://chromiumcodereview.appspot.com/14129004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195399 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230195
win_x64_rel busted. All other bots passed
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/14318004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195398 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79375

Review URL: https://codereview.chromium.org/14246030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229660
TEST=url_unittests
R=brettw@chromium.org
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/14371002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195396 0039d316-1c4b-4281-b951-d872f2087c98

login.HeaderBar.animateIn/Out is preferred during refactoring. However,
they are not properly wired. This CL fixes the problem.

BUG=233722

Review URL: https://codereview.chromium.org/14220004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195395 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/14369004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195394 0039d316-1c4b-4281-b951-d872f2087c98

1. Add the resource to chrome.exe so that omaha can use it for app commands.
2. Make extension install not prompt because the window launches behind the
current window (along with other problems) which results in a bad user experience.

Note that the only code path touched is strictly only hit by the limited install from
webstore code path.


TESTED=The unit test and tested the functionality using a test page which calls the app command.
BUG=233783

Review URL: https://chromiumcodereview.appspot.com/14381004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195393 0039d316-1c4b-4281-b951-d872f2087c98

> url: Copy 'googleurl_unittests' target from 'url_unittests'. Attempt 2.
> 
> To not break the buildbot, this creates a fake target that copies url_unittests
> to googleurl_unittests as temporary scaffolding.
> 
> BUG=229660
> R=brettw@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/14199009

TBR=tfarina@chromium.org

Review URL: https://codereview.chromium.org/14028022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195392 0039d316-1c4b-4281-b951-d872f2087c98

http://i.imgur.com/OOjPmDJ.png

Sideloaded extensions that have a webstore update URL have a global error bubble replacing the normal extension install dialog.

Still TODO:
- Making this not appear for new profiles.
- Unit tests.

BUG=229083

Review URL: https://chromiumcodereview.appspot.com/14328029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195391 0039d316-1c4b-4281-b951-d872f2087c98

handle is requested.

GLES2DecoderImpl::DoTexImageIOSurface2DCHROMIUM uses
GLContext::GetHandle's result as an argument to 
CGLTexImageIOSurface2D, which expects a valid CGLContextObj
as the handle (not NULL).

BUG=230300

Review URL: https://chromiumcodereview.appspot.com/14241007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195390 0039d316-1c4b-4281-b951-d872f2087c98

To not break the buildbot, this creates a fake target that copies url_unittests
to googleurl_unittests as temporary scaffolding.

BUG=229660
R=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14199009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195389 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224531

Review URL: https://chromiumcodereview.appspot.com/14199008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195388 0039d316-1c4b-4281-b951-d872f2087c98

Temporarily adding libpeerconnection as a dependency on three test targets that fail to link on lucid32.
I'm looking into what the problems are, but in the meantime checking this in to fix the build.

BUG=231068
TBR=grunell@chromium.org

Review URL: https://codereview.chromium.org/13923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195385 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233709
TBR=hans
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195220

Review URL: https://chromiumcodereview.appspot.com/14169006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195379 0039d316-1c4b-4281-b951-d872f2087c98

to extensions that need it for release.

BUG=chromium:233718
TEST=built

Review URL: https://chromiumcodereview.appspot.com/13852050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195378 0039d316-1c4b-4281-b951-d872f2087c98

This updates PowerPolicyController to always send the power
management policy contained in Chrome's preferences to the
power manager, rather than only sending prefs that have been
changed from their defaults.  Note that this currently only
takes effect once the user has logged in.

It also makes the screen get locked at the same time as when
it's turned off when the "Require password to wake from
sleep" setting is enabled.

BUG=225730,225969

Review URL: https://codereview.chromium.org/14134004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195376 0039d316-1c4b-4281-b951-d872f2087c98

This fix sends a DeviceChanged notification to all the
BluetoothAdapter::Observer when a BluetoothDevice::Connect makes the
BluetoothDevice::IsConnecting property change.

BUG=231985
TEST=None

Review URL: https://chromiumcodereview.appspot.com/12374062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195375 0039d316-1c4b-4281-b951-d872f2087c98

BUG=2204

Review URL: https://chromiumcodereview.appspot.com/12886022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195374 0039d316-1c4b-4281-b951-d872f2087c98

- Search requests uses both: current cookies and OAuth2 token for device Robot Account.
- User cookies or OAuth2 used in search for operation with a printer (print, get capabilities etc.)
- Put printer accessible for Robot Account to local destination.

BUG=179229
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/14370003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195371 0039d316-1c4b-4281-b951-d872f2087c98

And, Don't stack screenshot notifications.

Changed profile handling. The profile is now retrieved everytime a screenshot is taken and
not only once in Ash init. The reason is that the profile can change, which caused this crash.

Changed behavior for a subsequent screenshot notification. It will replace the previous
notification (rather than add a new one).

When saving to Google Drive we have two path: screenshot path (used in notification) and
local path (for internal cash/work; used in writing). Add proper handling of both paths.


BUG=231707, 232876, 233574
R=jamescook@chromium.org
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/14027009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195370 0039d316-1c4b-4281-b951-d872f2087c98

R=enne
BUG=176312
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/14378007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195369 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195368 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=148734%3A148757&mode=html

TBR=caseq@chromium.org

Review URL: https://codereview.chromium.org/14378005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233149

Review URL: https://chromiumcodereview.appspot.com/14367006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195365 0039d316-1c4b-4281-b951-d872f2087c98

Fix bugs wrt focus and anchored widgets and immersive mode being disabled. See bugs below for more details.

BUG=188567, 233483
Test=ImmersiveModeControllerAshTest.*

Review URL: https://chromiumcodereview.appspot.com/13942011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195364 0039d316-1c4b-4281-b951-d872f2087c98

This CL is adding a minimize function for clicks on launcher items if only a single item (already active) is associated with it. This is done to avoid that the user clicks and nothing happens (and people expect it to do that). The feature is guarded by a flag.

If the minimize action is not wanted, we use a bouncing animation which gives the user at least some feedback that he has done something.

BUG=231663
TEST=unittest & visual

Review URL: https://chromiumcodereview.appspot.com/14328031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195362 0039d316-1c4b-4281-b951-d872f2087c98

This adds ability to serialize cc::Picture to base64 string
and to initialize the picture back from that serialization.

Review URL: https://chromiumcodereview.appspot.com/13884018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195361 0039d316-1c4b-4281-b951-d872f2087c98

This feature was broken in crrev.com/189540.

Review URL: https://codereview.chromium.org/14070016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195360 0039d316-1c4b-4281-b951-d872f2087c98