- 19 Oct, 2019 25 commits
-
-
rajendrant authored
Allow subresource redirect to be enabled via field trial Bug: 1013776 Change-Id: I72e8221a584005cb8d351b65d9a53c6c8be1e744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861276 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#707622}
-
Lindsay Pasricha authored
Bug: 1015953 Change-Id: Ia1e33435e5beadbdc22c8b86113143b06271024d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869496 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#707621}
-
Shimi Zhang authored
testJsAddAndRemoveEventListener and testJsReplyProxyReplyToTheCorrectJsObject are flaky due to execute JavaScript call and replying port are not in the same mojo channel, so the sequence is not guaranteed, therefore there is a race between them. These tests are following the same pattern: // JavaScript posts a message to the app. JsReplyProxy proxy = message.replyProxy; proxy.postMessage(message); // When the web page receives the message, it saves the message as // JavaScript global variable say "JsVariable". messageReceived = executeJavaScript("JsVariable"); assertEqual(expectedResult, messageReceived); // Due to the race, when executeJavaScript the JsVariable may not be // set yet, so the assert may fail. This CL makes the replying channel to be associated with the legacy IPC channel so the calling order reflects the execution order. Bug: 1015023 Change-Id: I336d816d73096a3ec2c5cd35eaa205808359afa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865594Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707620}
-
rbpotter authored
Update Polymer Bundler and Polymer CSS build to more recent versions, and adjust as necessary to fix build and test breakages from the bundler update. This is a prerequisite for updating bundled Web UI pages to use JS modules/Polymer 3. This update increases the size of npm_modules.tar.gz by around 18% (1M), because we need to support both Polymer2 and Polymer3 in the toolchain during the migration. Once Polymer2 related tools (polymer-bundler, crisper) are removed, npm_modules.tar.gz's size will be decreased again by a similar amount. Some fixes for bundler v4.0.10 originally from: https://chromium-review.googlesource.com/c/chromium/src/+/1652566 by aee@. Bug: 921285 Change-Id: Ibb751cdac789af70e87f3774c5d27d0cafd57150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857568 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#707619}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/973a36942fb6..c11f343a2e62 git log 973a36942fb6..c11f343a2e62 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 vapier@chromium.org osutils_unittest: add some debugging code 2019-10-18 vapier@chromium.org image_lib: fix up for python 3 Created with: gclient setdep -r src/third_party/chromite@c11f343a2e62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I52a6b7dcfcb3c904f88a7ef51dedb008db0e66fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869812Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707618}
-
Tom Anderson authored
This fixes the initial state of the menu, where previously there would be no check mark next to the active profile and the edit and create profile entries would be disabled. R=thestig Change-Id: I1aebbac6fac657fbcb50324068ac58d5c38dd74d Bug: 1015759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869990 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#707617}
-
Giovanni Ortuño Urquidi authored
A new version of Closure Compiler started mangling symbols of a generic type used for pending receivers. This CL introduces a PendingReceiver interface and exports its properties so that Closure doesn't mangle its symbols. Ideally we would use bounded generic types, but that feature is not available on the current version of Closure Compiler. A follow up CL will change all usage of generic types to bounded generic types to avoid future instances of this bug and will land after we roll a new version of Closure Compiler. Fixed: 1012109 Change-Id: Ibdd42b4fe496042a3edd3079707c675dc81bc626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868216 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#707616}
-
Ilia Samsonov authored
The reason for this cl is to avoid setting test's location data expectation explicitly, which easily changes. Instead, we use gtest utils to find test's location data. Bug: 1015157 Change-Id: I6802d476afe68fe872a6fabad3649827d874a4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866619Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#707615}
-
Alfonso Garza authored
cross-platform use. This change updates CardExpirationDateFixFlow to follow the same pattern as CardUnmaskPrompt and the next CL will add the iOS part. Also adds tests for CardExpirationDateFixFlowControllerImpl as the delegate was previously untested. Bug: 993850 Change-Id: I87bfe2c0533a7f431baf16a1bde29d1e03f87e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863116Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Cr-Commit-Position: refs/heads/master@{#707614}
-
dpapad authored
- Replace HTML Imports with JS modules, Polymer2 with Polymer3 - Update pdf_extensions_test.cc to run tests in a JS module context, leveraging the _test_resources/ mechanism to load test files as part of the extension. - Remove PDF Viewer tests from webui_html_imports_polyfill_browser_tests.filter Bug: 1005029 Change-Id: Ibed2a20ae2d648d6fc7f093b27d4c8396890b04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829493 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#707613}
-
Yue Li authored
While traning/retraining the voice model, override the hotword always on state to true. Otherwise the training may fail when the device has no Dsp support and disconnected to the power source. Bug: b/139329513 Test: Manual Test Change-Id: Ia1aeb93640935760271b045958d09109aa2826c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867180 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707612}
-
Xiaohui Chen authored
There is a large number of unspecified query source, let's split it out and record seperately. Bug: None Test: locally build Change-Id: If55a3b61232c3a388d0379715cc91092a2b91583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869811Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#707611}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0df7697235b4..c65eb34d2f37 git log 0df7697235b4..c65eb34d2f37 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 herb@google.com Update for XCode 11 include system 2019-10-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-18 halcanary@google.com Docs: include/docs with doxygen 2019-10-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). 2019-10-18 halcanary@google.com Docs: Add links to header files. 2019-10-18 michaelludwig@google.com Rename SkDevice::ctm() to localToDevice() 2019-10-18 kjlubick@google.com [canvaskit] Roll chrome version for testing 2019-10-18 fmalita@chromium.org [skottie] Default camera for 3D layers 2019-10-18 jcgregorio@google.com [docs] - Add link to buildbot search. 2019-10-18 fmalita@chromium.org [skottie] Camera does not apply to regular/2D layers 2019-10-18 bungeman@google.com Add SkColorData.h to gn. 2019-10-18 jvanverth@google.com Use LazyProxy to set up Metal swapchain. 2019-10-18 senorblanco@chromium.org Dawn: allow CopySrc usage of swapchain texture. 2019-10-18 senorblanco@chromium.org Dawn: fix single-sided stencil. 2019-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ed6e230ec65e..6dee176c8d7d (11 commits) 2019-10-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6652f0b64287..a68a80a4dbf9 (1 commits) 2019-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src e27799ab..7ca6de3a (467 commits) 2019-10-18 herb@google.com Convert prepareForDrawing to glyph buffers 2019-10-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-17 fmalita@chromium.org [skottie] Fix camera/3D layer transform interactions 2019-10-17 mtklein@google.com Revert "impl. _clamp_8888 shaders using general mechanism" 2019-10-17 brianosman@google.com Particles: Fake 3D example 2019-10-17 halcanary@google.com WebGL2: Add BlitFramebuffer, ShaderDerivativeSupport 2019-10-17 hcm@google.com add release notes for m79 2019-10-17 kjlubick@google.com Tell rewrite_includes to ignore node_modules 2019-10-17 brianosman@google.com Add spinning cube demo to particle gallery 2019-10-17 senorblanco@chromium.org Update Dawn to ToT. 2019-10-17 mtklein@google.com impl. _clamp_8888 shaders using general mechanism 2019-10-17 robertphillips@google.com Revert "Reduce inputs to GrProgramDesc::Build method(s)" 2019-10-17 robertphillips@google.com Reduce inputs to GrProgramDesc::Build method(s) 2019-10-17 jcgregorio@google.com [perf] - Update docs. 2019-10-17 robertphillips@google.com Plumb GrBackendFormat into the GrPrimitiveProcessor::TextureSampler 2019-10-17 drott@chromium.org Remove unused transform parameter of ctfont_create_exact_copy 2019-10-17 herb@google.com Reland "Introduce SkGlyphSourceBuffer" 2019-10-17 egdaniel@google.com Remove GrPixelConfigIsCompressed call. 2019-10-17 senorblanco@chromium.org Dawn: silence some warnings on win-clang. 2019-10-17 senorblanco@chromium.org Dawn: build libdawn-native as a static lib, not shared. 2019-10-17 brianosman@google.com Fix a couple minor bugs in particle code 2019-10-17 hcm@google.com Update Skia milestone to 80 Created with: gclient setdep -r src/third_party/skia@c65eb34d2f37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:9545,chromium:None,chromium:None,chromium:None Change-Id: I26cfbb5ed3c6fb38cbfc2fed213b5ec7ac80fc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869767Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707610}
-
Koji Ishii authored
This patch fixes the baseline regression caused by r707250 (crrev.com/c/1864755). Bug: 982194 Change-Id: Icfe40ea68764dd09ab10345915c4aebd57d8d21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868533Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#707609}
-
Ian Kilpatrick authored
Patch 2-of-6. This merges NGBoxFragmentPainter::Paint{Block,Inline}FloatingChildren inton NGBoxFragmentPainter::PaintFloatingChildren. It also allows correctly descending into block children when enabled. Bug: 988015 Change-Id: Ia6137bdbddb1c7d27dff3fae631a7c1eca1a7e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868980Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#707608}
-
Mei Liang authored
This CL adds the following tests for incognito toggling in GTS. 1. testIncognitoToggle_tabCount 2. testIncognitoToggle_thumbnailFetchCount testIncognitoToggle_thumbnailFetchCount is disabled for now, since the current implemented behavior for thumbnail fetching is not ideal. Seems like we fetch thumbnail for all tabs in the TabModel (normal+incognito), when we switch TabModel or enter the tab switcher. Change-Id: Ic6406ec14ec4a2c909eb025da38af988420eaf06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856722 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707607}
-
Brandon Wylie authored
Bug: 995572 Change-Id: Id011b737da5e72fe961f4b4e998cf070ea8f4f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863627 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#707606}
-
Mason Freed authored
WebUI is in the process of upgrading to Polymer 3. In the meantime, the Web Components APIs (particularly HTML Imports) will be auto-re-enabled for WebUI pages, so that the existing Polymer 2 code continues to function. A v0 polyfill was previously being used to ensure compatibility on some pages, but that approach has been abandoned in favor of a full upgrade to P3. So the can_use_polyfill check can be eliminated, and instead rely on the re-enabled features for all WebUI pages. Bug: 911943, 965770 Change-Id: Icd3a0d768c64d3e8b81cb89885872fcd67a875ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869622 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#707605}
-
Ian Kilpatrick authored
Patch 1-of-6. Previously this bit didn't propagate for new formatting contexts. For enabling more of the NGBoxFragmentPainter we need this bit to cross across these boundaries. This worked previously as it was only for inline formatting contexts, which only contain atomic-inlines which paint atomically (the one case where we don't want to propagate this bit). Bug: 988015 Change-Id: I06ee83fdfda924d781cb4f34ca312989591f017f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869402 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#707604}
-
Xinghui Lu authored
This is a reland of e0b95885 Previous CL broke WebView build because startAllowlistLookup is not implemented. Original change's description: > Remove default startAllowlistLookup interface > > Bug: 995926 > Change-Id: I76ac44526fcf7241b800899810db81dbdd598ae3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846092 > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703911} Bug: 995926, 1012531 Change-Id: I9d1788b61d87fa05c6f03ae1a76f454526bab6c1 Test: autoninja -C out/Debug system_webview_google_apk Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850769Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#707603}
-
Emily Stark authored
In https://bugs.chromium.org/p/chromium/issues/detail?id=1005096, I fixed a crash in HTTP Auth committed interstitials by changing a GetVisibleEntry() to a GetPendingEntry(), and I reasoned that GetPendingEntry() should always be non-null at this point. It turns out, I reasoned wrong. It seems that there is some interleaving of navigations starting and getting cancelled where the pending entry is null when processing a main-frame response. So this CL adds a null check before accessing the pending entry. Bug: 1015787,1006955 Change-Id: I70e06e6c8aeee6db93c5797593d4eda6cd5c906d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869299 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#707602}
-
Stephen Martinis authored
I seemed to have messed up and not uploaded the last changes I made to https://crrev.com/c/1856822. I had meant to switch to ninja targets, but the CL doesn't have those changes. Bug: 1015682 Change-Id: Iefff69a47a682f2bc5ca549dc65348bd65536981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869836 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#707601}
-
Philip Rogers authored
This patch adds an enabled-by-default feature (DoNotCompositeTrivial3D) that stops compositing trivial 3D transforms (e.g., translateZ(0)) on all platforms (low and high end). This change will reduce cross-platform and cross-browser differences. This is likely to reduce memory as well. A feature flag has been added so a reverse-experiment can be run. This can be manually tested with --enable-features=DoNotCompositeTrivial3D and --disable-features=DoNotCompositeTrivial3D. The logic for whether a non-trivial 3D transform was present had bugs such as not accounting for the "rotate" CSS property, treating "transform: rotateX(0)" as having a 3D component, and treating "rotate: 1 1 1 0deg" as having a 3D component. These issues have been fixed in the new ComputedStyle::HasNonTrivial3DTransformOperation function which is tested in CompositingRequirementsUpdaterTest.NonTrivial3DTransforms. Bug: 1012775 Change-Id: I368847f61d015df8b2f703d7cbe8098da5eb79f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849141 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707600}
-
Johannes Henkel authored
New revision: bbc72612409377752c8fd2e7a63a1a5947b7dc4b Change-Id: Iba3668076860e1844b2d6c49c10bbf6a6de35e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867437 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#707599}
-
Mitsuru Oshima authored
1) add "subpixel_font_rendering" condition in gpu control list. 2) Add subplixel_font_rendering gn flag to set this value. 3) Enable gpu_raster on Mali* GPU only when subpixel font rendering is disabled. Bug: 996858 Test: Manually tested on the device. covered by unittest. Change-Id: If7d2a96e0ec7d3eba0f10f218a50c2d52957272b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787352 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#707598}
-
- 18 Oct, 2019 15 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a5230910bf2f..973a36942fb6 git log a5230910bf2f..973a36942fb6 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 lamontjones@chromium.org config: update bug# on (non-crit) jetstream Created with: gclient setdep -r src/third_party/chromite@973a36942fb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic89a7261b97457d4f5e11c576eeaa6cacc5f4442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869768Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707597}
-
Nate Fischer authored
No change to logic. This adds a java_cpp_strings target to generate MetricsSwitches.java, so Chrome (and later, Android WebView) javatests can depend on these switches. This is implemented following https://chromium.googlesource.com/chromium/src/+/HEAD/docs/android_accessing_cpp_switches_in_java.md This does not verify the existing usage of these tests, but only swaps the string literal for the corresponding java constant. Bug: 1011991 Test: autoninja -C out/Default chrome_public_test_apk Change-Id: I14177f1194438d12ca04338475bbb28dc6daca03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863867 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#707596}
-
James Cook authored
This puts the registration closer to where the prefs are used. It also eliminates duplicate "for_test" registration that we added for the now-cancelled mustash project. This CL is cleanup, no behavior changes. Bug: 1013466 Change-Id: If8710cea0733291af14ce69e0ac95de9f34b34b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869760 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707595}
-
Lukasz Anforowicz authored
Before r694827, request_initiator for fetches from content scripts would be incompatible with request_initiator_site_lock, so CORB would safe-fail to treating request_initiator as if it was an opaque origin. This meant that no Access-Control-Allow-Origin would ever satisfy CORB. Since r694827 requests from content scripts set request_initiator to the origin of the frame/page where the content script was injected (not to the origin of the extension). This helps a tiny bit with https://crbug.com/920638 - now CORB will pass through responses with Access-Control-Allow-Origin that matches the origin of the frame/page where the content script runs. This CL adds a test that verifies this particular benefit of r694827. Bug: 920638 Change-Id: I139b12e4f46d48136e627a98b4f072cacc33b8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864827 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707594}
-
Pavel Yatsuk authored
This CL includes following changes: - Record user's interaction with IdentityDisc in a way that can be used in IPH triggering conditions. - Introduce IPH metrics - Enable IdentityDisc IPH in tests through fieldtrial_testing_config.json R=holte@chromium.org,twellington@chromium.org Change-Id: I6b1aa2b64d2d52173ad9e83ea2329287d7c28635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868833 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#707593}
-
Julie Jeongeun Kim authored
This CL converts SharedURLLoaderFactoryInfo to new Mojo types using PendingRemote and Remote and updates ContentBrowserClient::HandleExternalProtocol() with mojo::PendingRemote<network::mojom::URLLoaderFactory>. Bug: 955171 Change-Id: Ie0d3dec0d00f107d9b9eea84c7cd7e0a314b5445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861554 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#707592}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a286fcc59c3a..6f8624c5117e Created with: gclient setdep -r src-internal@6f8624c5117e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I04bbfa19e78f0d0843464c482a7b2e110668e33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869930Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707591}
-
Dana Fried authored
This ensures that even at odd scaling factors we get a 1DIP separator between infobars. Fixes: 1014072 Bug: 1014072 Change-Id: Ib3e0deb6601b7c8f2b3949feabce9a35af45697c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867849Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#707590}
-
Nasko Oskov authored
This method on RenderFrameHostManager::Delegate is not really needed. It is a single line wrapper around NavigationController method and the delegate interface already has a method to get the NavigationController. As such, I'm removing it and replacing it with a direct call on the NavigationContoller. Bug: 1015882 Change-Id: Iffc68d2e3e42e102d115337c271a820a2b368707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869714 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#707589}
-
Sam Fortiner authored
The previous implementation assumed there was always a client and could crash attempting to retrieve the name of the layer. Instead, we are making DebugName always available and leveraging that. Bug: 1015727 Change-Id: I01ebcf5babd117ec2340a79064785ba4ba6b161d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869295Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707588}
-
David Tseng authored
This ensures we don't capture the Search key when there's no ChromeVox focus. This is important for cases like ARC++, where TalkBack needs to get Search. The ARC++ window explicitly clears focus in the case where TalkBack is in control. Bug: 1011894 Change-Id: I15f0b438f16397e92ee59ebd8bd0cb74b9a927e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862719 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#707587}
-
Ayu Ishii authored
This change changes the behavior of when multiple requests come from the same origin on one tab. Instead of cancelling requests that come later, this will be changed to prioritize the last request made for the origin and cancel requests previously made. This is consistent with the behavior in web USB. Bug: 985438 Change-Id: I76c0047fea8852346e13fc99a4d092ab80a5a24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860683Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#707586}
-
Yun Liu authored
Write profile data after Android apk-based gtests finished. Bug: 985574 Change-Id: If22313a6eca142226a3fa095a0f40b8d44c00e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867190Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#707585}
-
Robert Ogden authored
This is done by querying the cookie store on navigation start and on every redirect for the current navigation url. If any one of the requests had cookies, the boolean flag is set. Bug: 995437 Change-Id: If39c9b98ff35423bcb672f437d35d0b7aff9f538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868329 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#707584}
-
James Cook authored
This puts the pref registration closer to where the prefs are used. It also eliminates the duplicate "for_test" registration that we added for the now-cancelled mustash project. I fixed a few cases where the pref was registered with a different default value in tests than in production. This CL is cleanup, no behavior changes expected. Bug: 1013466 Change-Id: Ie8c36b0adc9d39ce1f3170ae8ff6983e831e030a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869770 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707583}
-