GitLab

Following up after https://crrev.com/c/1787406
appears to have fixed idle paint issue by enabling 3 disabled tests:
accesscorrections
jetspizza
star_city_games


Bug: 993044
Change-Id: I005f0c722b9168a32579b2aafcb851e763105e11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808425
Auto-Submit: Ian Struiksma <ianstruiksma@google.com>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Cr-Commit-Position: refs/heads/master@{#697688}

Page zoom level is a page/view concept, but the code to manage it is
currently in RenderFrameImpl, though only run when it is the root frame.

This doesn't dramatically change ownership of responsibility but moves
the code up into RenderViewImpl. RenderWidget still goes through
RenderFrameImpl (though more explicitly) to set the zoom level on the
RenderView. And RenderWidget takes responsibility for closing the page
popup instead of having multiple "set page zoom" methods on
RenderViewImpl.

This uncovered some spooky action-at-a-distance and makes it more
explicit and documented, though no less unfortunate. A local root
LocalFrame does not initialize with the correct page zoom value because
it has no parent to read it from. We (accidentally?) worked around that
by setting the RenderView's page zoom to its current value when
navigating a (new) LocalFrame, which would call into blink's WebView
and walk through the entire frame tree setting the value on everything,
eventually also on the new LocalFrame.

Now on navigation, for a local root, we call RenderWidget's
UpdateWebViewWithDeviceScaleFactor() which does the same thing by
re-setting the WebView's page zoom factor. This was done when making
a new main frame in multiple places (RenderView and RenderFrame both
called it in the same CreateFrame() callstack). Now it is consolidated
to a single place on navigation for the main frame and child frames
giving them more consistent behaviour, and going explicitly through
this method that should go away if things were well designed, rather
than re-setting the RenderView to its own value.

Remove calls to UpdateWebViewWithDeviceScaleFactor() scattered
throughout RenderViewImpl and RenderFrameImpl. What we need is for
1) The Page to be updated with PreferCompositingToLCDText when the
device scale factor changes.
2) The WebView to be updated when the device scale factor changes.
3) The LocalFrame of a local root needs its page zoom set by poking
the WebViewImpl to walk through all frames and set it.

R=erikchen@chromium.org

Bug: 419087
Change-Id: I97c0e287be8f96a4ac632d63b981c190169dc1a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799386Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697687}

This experiment did not provide data indicating that we want to launch it, so
let's make sure that it does no remain as an active experiemnt in
fieldtrial_testing_config.json.

Bug: 966406
Change-Id: I70a46f6234137fdfe696b738f3fa3b7b109b1a51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807324
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Dominic Battré <battre@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697686}

https://android.googlesource.com/platform/external/perfetto.git/+log/8c80da317efc..7259f61fb600

git log 8c80da317efc..7259f61fb600 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 fmayer@google.com Merge "Use GetTestDataPath for tests."

Created with:
  gclient setdep -r src/third_party/perfetto@7259f61fb600

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Ib56de7b4ab6fe4a53910c65e2d7078d6c6335425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809888Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#697685}

Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1769102

PS2 is the original CL rebased. Diff PS2->PS11 to see the one-line fix
for bug 1000327. This is applied in addition to the base change in
https://chromium-review.googlesource.com/c/chromium/src/+/1810036 to fix
a more general race condition in render process host reuse.

This moves the Resource Coordinator Service off of Service Manager APIs
in favor of direct Mojo interface usage. A public browser API is exposed
to give content clients access to the service connection.

NOPRESUBMIT=true

Bug: 977637, 1000327
Change-Id: Id3742584f25b3891386e62789db1b4121b0d3007
TBR: dcheng@chromium.org
TBR: avi@chromium.org
TBR: yucliu@chromium.org
TBR: torne@chromium.org
TBR: erikchen@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809098Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#697684}

Bug: 982922, fuchsia:24570
Change-Id: If9fb495249488c43f97e4451a14f0193911d600f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804527Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697683}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/83d2cae04c5f..122f4535b1be

git log 83d2cae04c5f..122f4535b1be --date=short --no-merges --format='%ad %ae %s'
2019-09-18 vapier@chromium.org cros_test_lib: deprecate some unittest aliases
2019-09-18 vapier@chromium.org unittests: change self.assertEquals to self.assertEqual

Created with:
  gclient setdep -r src/third_party/chromite@122f4535b1be

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I16a4b8d2f37d894e4955d889007083e5b6def4b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809889Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#697682}

Now that socket_client.h can be moved out of the Blink exposed API
layer, the extra copy step in P2PSocketClientImpl::SendWithPacketId
can also be removed.
This solution was added temporarily in [1], as part of Onion souping
this file.

[1] https://crrev.com/c/1805159/

In summary, this CL:

- moves socket_client.h from blink/public/platform/modules/p2p/
  to blink/renderer/platform/p2p/.
  - adapts the header being moved accordingly.
  - eliminates blink/public/platform/modules/p2p/ altogether.

- P2PSocketClientImpl::SendWithPacketId to operate over WTF::Vector,
  instead of std::vector.

BUG=787254, 919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I1c8713cb6c96663cd0d7db8acbac1dfaa4809931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806979
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697681}

TBR=antrim@chromium.org

Bug: 997685
Change-Id: I22694fc565d49083e7fd937d7d97a7b9e64029e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809530Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697680}

CloudReportingEnabled policy is using an extension to collect data and
this extension is used as a signal by chrome://management page.

The extension is going to be deprecated soon and its logic is moved into
Chromium code base. Make sure that the chrome://management page still
covers all data we collected.

Without the extension, CloudReportingEnabled collects almost same data
except the safe browsing ones. The safe browsing data reporting will be
owned by other enterprise feature.

Bug: 956237
Change-Id: Idb35ad27da50405898dfc499a37b7255f9bad735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808704Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697679}

This reverts commit 59860aa8.

Reason for revert: Suspected breakage of WPT importer (crbug.com/1005222)

Original change's description:
> [blinkpy] Extend Mac macro to cover more versions
> 
> Although we don't fully support 10.14 or 10.15 yet (we don't have
> version-specific baselines for them), this should help to drastically
> drive down the number of failures.
> 
> Bug: 1001606
> Change-Id: I3cd93619c015cb154885a154660b169eb1bada58
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790267
> Auto-Submit: Robert Ma <robertma@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#694358}

TBR=dpranke@chromium.org,robertma@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1001606
Change-Id: Ifd0fc72269bfbe56a5faeac8492b42adc9f5ce89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810761Reviewed-by: Luke Z <lpz@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697678}

This reverts commit 04e92329.

Reason for revert: Likely candidate for linux-chromeos-rel builder failures:

https://chromium-swarm.appspot.com/task?id=475cd90235116110
../../chrome/browser/chromeos/login/test/oobe_screen_waiter.cc:53: Failure
Expected equality of these values:
  target_screen_
    Which is: demo-preferences
  GetOobeUI()->current_screen()
    Which is: network-selection


Original change's description:
> Chrome OS Oobe: Show Ash dialog only if required
> 
> When starting a managed guest session (with no Terms of Service), a
> blank Ash dialog is shown for a brief moment before the session starts.
> This is caused by the Ash dialog for Oobe being shown even when all the
> Oobe screens are skipped.
> 
> This CL changes the behavior of the Ash dialog to only show when
> required by using a OobeUI::Observer. The dialog is not shown by
> default, and will be shown when a Oobe screen is shown.
> 
> OobeScreenWaiter now checks that the native window is visible by
> default. A small number of tests had to be changed to either show the
> native window or ignore the visibility check. The reasoning for the
> changes are in the comments for their respective tests.
> 
> The WebUI behavior is unchanged.
> 
> Bug: 1000164
> Change-Id: I9995f4beba85d7c5af7b13f81f1a654e2d52f372
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790450
> Commit-Queue: Jit Yao Yap <jityao@google.com>
> Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#697539}

TBR=antrim@chromium.org,jityao@google.com

Change-Id: I4b663f335ad6ef084a2583d54519452fa4a95d19
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1000164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808710Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697677}

Use new code introduced in: https://crrev.com/c/1758358

Bug: 1000751
Change-Id: Ib1f4d966530c2111e9b0c1fe14637caf4b32d9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810839
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697676}

Currently, if an unsupported JS feature is used, localization presubmit
checks will fail with the raw error message from esprima, the JS parsing
library. This CL wraps a try-catch block around the parsing call and outputs
a nice error message that specifies the file location and the reason.

Before:
Error: Line 9: Unexpected token =

After:
Error: DevTools localization parser failed:
third_party\blink\renderer\devtools\front_end\security\SecurityPanel.js: Line 9: Unexpected token =
This error is likely due to unsupported JavaScript features. Such features
are not supported by eslint either and will cause presubmit to fail. Please
update the code and use official JavaScript features.


Bug: 941561
Change-Id: If945563f84224232155a7de7cf597c5395a0cbb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729729Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#697675}

This CL sends the sanitized PresentationFeedback to viz clients instead
of the original feedback.

Change-Id: Icaa567e1dcb5a7acad8d465671ada67cb874095e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810059
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697674}

There is no need for ViewportAdjustmentExperiment since the only experiment
remaining is just the kSmoothScrollingDefault feature flag.
GetActiveViewportExperiment() can just be a function that returns
whether or not smooth scrolling is turned on. GetActiveViewportExperiment()
and ViewportAdjustmentExperiment are still needed for downstream compatibility,
and will be removed in a subsequent CL.

Bug: 914042
Change-Id: I57bcd13dafaafb3b3a05ec65f23dacf2936e81e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799663Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697673}

FuchsiaVideoDecoder wasn't handling the end-of-stream correctly. The
DecodeCB for EOS buffer was called out of order when there are other
pending Decode requests. Also DCHECKs were failing.

Also updated unittests to detect this issue.

Bug: 997853
Change-Id: Iae04250521e929d8ad220ead08d701f274a15979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810397
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697672}

The class was used in the non-viz codepath which we don't support
anymore.

R=ericrk@chromium.org

Change-Id: Iffc9b63d1c10e8696fb1f2c92acf6afdb138fa81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809810
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697671}

Heap snapshot web worker currently calls localization functions directly,
but this causes an issue as localizable resources are not available to
the worker. To fix this, send serialized messages to the main thread and
localize them there.

Bug: 941561
Change-Id: Ic9f434e93fd3a2bb7b06aa669aaa85f905c72df8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758732Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#697670}

When the toolbar's display mode is not ::NORMAL the extensions container
is never initialized. Not checking for this (or container availability)
leads to crashes when the extension-uninstall dialog tries to find where
to anchor to in the window.

This intentionally checks the display mode instead of container
availability as the containers should always be created in ::NORMAL.

Bug: chromium:1005154
Change-Id: I5c51bf0f2a02c75896355ccee39077d6c55a0d3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809974
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697669}

Specifically:
 - Remove dependencies to cr.ui.List, cr.ui.ListItem and list.css
   since these were (erroneously?) added at r508574, but were not used.
 - Hook up closure_compile target, since it was not referenced from anywhere.
 - Replace remaining HTML imports with regular <script> tags instead.

Bug: 937747
Change-Id: Ib26d4a31ecb365e23205f28d21d18a79ce03aa52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809110Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697668}

Since the current localization system uses a unique ID for each string that
is calculated based on the the md5 hash of the string, each string
in the grdp files needs to be unique. However, there are strings in the
frontend that appear multiple times. When such strings are moved across
folders, sometimes a seemingly random grdp file is changed by the autofix
script. (See https://crrev.com/c/1683826 for an example)

This CL introduces shared_strings.grdp, a file dedicated for strings that
are shared across folders/grdp files. Instead of putting these strings in
the grdp files that come first when sorted alphabetically, they live in
shared_strings.grdp and have common descriptions among all instances of
such strings. This way if shared strings need to be moved, it's more clear
what's going on.

Note that this CL contains a lot of changes that are generated automatically
(e.g. shared strings are removed from their current locations), so here's
the list of actual changes that need to be reviewed:

* shared_strings.grdp file is added to front_end/langpacks and front_end/langpacks/
devtools_ui_strings.grd
* path to shared_strings.grdp is added to scripts/localization_utils/localization_utils.js
* in scripts/localization_utils/check_localized_strings.js, the parser marks
strings that appear more than once as shared and set the target grdp file to be
shared_strings.grdp
* shared_strings.grdp file is checked by scripts/check_localizability.js for
localizability violations
* shared_strings.grdp messages have common descriptions added

Bug: 941561
Change-Id: I00db23854656509f2f03988e70adc0109b6e09d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800918Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#697667}

https://chromium.googlesource.com/angle/angle.git/+log/873079f1d3a2..e34564bafe83

git log 873079f1d3a2..e34564bafe83 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 ynovikov@chromium.org Revert "Suppress crashing perftests on Win Intel Exp Rel"

Created with:
  gclient setdep -r src/third_party/angle@e34564bafe83

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Bug: chromium:997674
Change-Id: Ifc271b11d3f170345dec722c4ba74afd19591061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810188Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#697666}

Create experiment for SafeBrowsingPasswordProtectionForSignedInUsers.

Bug: 914410
Change-Id: Iae3e6d2b74419048e1a78eb0479bed1d6446282e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809899Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697665}

R=yusufo@chromium.org

Bug: 985386
Change-Id: If0074993b229e2a4da5fa0cf7f59e3fdce2c75a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809518Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Matt Simmons <mattsimmons@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697664}

This has been enabled by default since M76. Time to get rid of it.

Change-Id: I7427d5f991b4c7eedd9bea6c2305683ef187f658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811198
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#697663}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd281eec08fe..795cab2777e2


Created with:
  gclient setdep -r src-internal@795cab2777e2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ib529fe8044fd4502d4128b694435f56eb71e879d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809986Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#697662}

Right now Java per-CL coverage instrument everything as full code base coverage.
To only instrument class files related to affected files in a CL, we can:
1. Extract class files only related to affected source files in a jar.
2. Instrument these extracted class files.
3. Extract unaffected members from original jar.
4. Zip everything out to output path.

Bug: 1001387
Change-Id: Iaf6a75c7f8005b5d64eee22bc604f25d0c2fcd8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797109Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#697661}

https://skia.googlesource.com/skia.git/+log/dd0dff1c35d2..e3671013e5a1

git log dd0dff1c35d2..e3671013e5a1 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 jvanverth@google.com Reland "Add ETC2 support to Metal backend."

Created with:
  gclient setdep -r src/third_party/skia@e3671013e5a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=brianosman@google.com

Bug: None
Change-Id: Ib87a3662c50d4ee2733082ccf257e2d20e732b95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810186Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#697660}

Bug: 1004532
Change-Id: I1a883ddc6c7a0459706afdadf099e6658801e829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810042Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697659}

This fixes an issue where the IPC nesting level wasn't being decremented
correctly when printing a PDF.

Bug: b:140576300
Test: Print a PDF
Change-Id: I63579581f2c8a5b9afb231e6057ef8f2f7425ca7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809973Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697658}

- Change Linux changelog links to https.
- Update the links to point to googleblog.com.
- Reorder the cases to stable/beta/dev.

The updated URLs are short enough to fit on line, so debchange won't cut
them off anymore.

Bug: 428613

Change-Id: I5aeb151c10fb202ab1f3b77ff4554ed6b486c84e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810458Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697657}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ad7f2c5c4c7f..36c1c0e22fab

git log ad7f2c5c4c7f..36c1c0e22fab --date=short --no-merges --format='%ad %ae %s'
2019-09-17 52076061+digit-google@users.noreply.github.com Fix Fuchsia build. (#2868)
2019-09-16 raun.krisch@gmail.com Adding valilidation checks for OpEntryPoint duplicate names and execution mode (#2862)
2019-09-16 alanbaker@google.com Extra resource interface validation (#2864)
2019-09-13 alanbaker@google.com Split capability tests (#2866)
2019-09-13 alanbaker@google.com SPIRV-Tools support for SPIR-V 1.5 (#2865)

Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@36c1c0e22fab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,geofflang@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
TBR=radial-bots+chrome-roll@google.com,geofflang@chromium.org

Bug: None
Change-Id: I129f542843f54f1de5e396268a59cb5a550dd3e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809984
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#697656}

Screenshot:
https://drive.google.com/file/d/13LQ5jov5tzc__Q1X-xUq-FX9Ptet2i9y/view?usp=sharing

Flag: profile-menu-revamp

Note: String is subject to change.

Bug: 995720
Change-Id: I2658c66897fe899a16355bdced923e32d8c4cf87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811117
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697655}

IconLoader::ClearImage should also be called on removing the icon,
otherwise it will return incorrect (empty) image after the app
reinstallation.

Bug: b/139496595
Test: manually
Change-Id: I833adf45bd62ee4f3c64c039ae5fdb7364d04cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809750Reviewed-by: Long Cheng <lgcheng@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697654}

Bug: none
Change-Id: I987547cfa1a5007ea3e3844afcc6f7c9d8ad9cd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810762
Auto-Submit: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697653}

Change-Id: If88a9f663337ee91aee816459e9f4ae35ebaaaec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810184
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697652}

search-focused "New Search" and "Incognito Search" actions.

This replaces the force-touch shortcuts to open new tabs with the
omnibox focused.

This also updates the current quick action icon set to be more
harmonious and in sync with the Material icon set.

Bug: 957837
Change-Id: I6f40f98a675b2a92031d40f3f38efbe3d19ff4d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712873Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697651}

This reduces memory copies.

Bug: 991501
Change-Id: Icfd1c0c973d52a4528ec6a7364d7616328a882a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809038Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697650}

The ownership of the "observer_" member field of CookieNotificationBridge
was unclear and after a casual look at the code, it was unclear whether
the code caused a retain cycle or not.

Rename the member field, mark it as __strong and add documentation to
make it clear that the ownership model is correct, and that there is no
retain cycle caused by this object.

Bug: 1005153
Change-Id: I8f49e39e8355a0a2c758848ef34c45b4d5335b66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809376
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697649}