- 15 Jan, 2021 19 commits
-
-
Olivier Yiptong authored
This introduces an option bag for the enumeration API. The first capability enabled by this option bag is to apply an exact-match filter to fonts returned by the API. Bug: 1164077 Change-Id: Id6e76038c1647859c15e8e0ad6aa711b809466ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622063 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#843820}
-
tby authored
These are largely replaced by the app list notifier metrics. Bug: 1165218,1165219 Change-Id: I35652f5a674d9e8b5efdead52a48d65e7c0cf58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627196Reviewed-by:
Rachel Wong <wrong@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#843819}
-
siashah authored
The change does not do anything, once crrev.com/c/2528698 is merged, a follow-up change will add code to trigger the infobar and the instrumentation tests along with it. UX mock: https://screenshot.googleplex.com/5eMqi7HmpZj7NoB Implementation: https://screenshot.googleplex.com/8QVPnCpZQYSGih4 The bottom confetti in the UX mock will be implemented as a follow-up. Bug: 1093057 Change-Id: I8f7326cac3c9830080408ab789a47b3b3e4e34e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612398Reviewed-by:
Siddharth Shah <siashah@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#843818}
-
Taylor Bergquist authored
Bug: 1093974 Change-Id: I1dcc65adb2f35c8269e8a6508d1165caf0f445cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630845Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#843817}
-
Xianzhu Wang authored
We don't distinguish them when using them, so don't need to generate them separately. This makes it easier to implement the scale methods of ui::TransformAnimationCurveAdapter. Bug: 1161586 Change-Id: Iea77b01216a31682e8249e3a6675b6f070f3a09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602253Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843816}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/18a45a67b21a..29da6d23a9d7 2021-01-14 andoli@chromium.org [module.json extensions] Migrate @ViewLocationResolver in elements/ 2021-01-14 andoli@chromium.org [module.json extensions] Add unit tests for new view extensions registration infrastructure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1153091 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I51550bf4845ffb89079a1b684dca48347c717ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630301Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843815}
-
James Vecore authored
ReceiveMessagesExpress's dtor was indirectly calling back into WebRtcSignalingMessenger and accessing incoming_messages_listener_ after it has already been destroy. By changing the ordering of the member variables we ensure that ReceiveMessagesExpress gets torn down before incoming_messages_listener_ is torn down. Fixed: 1166520 Change-Id: I6b780b79ef7b857c281ea4eaa30f9dab71fe2262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630731Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#843814}
-
David Black authored
Small previews were slightly visible before animating in because they weren't sufficiently offset relative to the parent container. Bug: 1166754 Change-Id: I4f7c06c460861591e058c537c542c00d8ac62495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629655Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#843813}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/178c01be65a4..7231b2e72311 2021-01-14 fancl@chromium.org Dashboad: Reduce random sample tests in small range If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: Ic8baa01c145ccd098c4c70e2de9d5985d49642aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630593Reviewed-by:
-
Eric Willigers authored
We add a browser test that reads from the socket using script. Bug: 905818 Change-Id: I5addd5bca78325bb549a86e8443773c893946561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629187Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#843811}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610636358-cc0d7707c698b33d5a2e049b9e10a4117c1fdf55.profdata to chrome-win32-master-1610647094-29bf0a5bdecd41fe52f35b6c0534103ef2302651.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ide1acb55b3752ac6816c220ed35a9ecc748a1dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630299Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1c5e63e54513..7acc2d9fe3a6 2021-01-14 mbonadei@webrtc.org Revert "Refactor rtc_base build targets." 2021-01-14 danilchap@webrtc.org Delete unused functions in ModuleRtpRtcpImpl 2021-01-14 auorion@microsoft.com Add ability to load CreateDirect3DDeviceFromDXGIDevice from d3d11.dll 2021-01-14 handellm@webrtc.org SetOfferedRtpHeaderExtensions: fix error code. 2021-01-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 189823ba..42ab9dc8 (843026:843550) 2021-01-14 nisse@webrtc.org Update AudioDeviceBuffer to use C++ lambdas instead of rtc::Bind 2021-01-14 lndmrk@webrtc.org Include packetization in video codec string 2021-01-14 danilchap@webrtc.org Revert "Replace RTC_WARN_UNUSED_RESULT with ABSL_MUST_USE_RESULT in c++ code" 2021-01-14 danilchap@webrtc.org Replace RTC_WARN_UNUSED_RESULT with ABSL_MUST_USE_RESULT in c++ code 2021-01-14 handellm@webrtc.org SetNegotiatedHeaderExtensions_w: Set list synchronously. 2021-01-14 sprang@webrtc.org Adds VideoDecoder::GetDecoderInfo() 2021-01-14 nisse@webrtc.org Delete unused VideoType enum values 2021-01-14 chunbo.hua@intel.com Fix typo in audio processing header. 2021-01-14 hta@webrtc.org Improve structuring of test for audio glitches. 2021-01-14 chunbo.hua@intel.com Fix AudioProcessing::Config::ToString() implementation. 2021-01-14 nisse@webrtc.org Add new empty build targets rtp_rtcp_legacy and video_legacy. 2021-01-14 landrey@webrtc.org Fix inconsistencies in network BUILD.gn file 2021-01-14 nisse@webrtc.org Change PeerConnectionE2EQualityTest to use lambdas instead of rtc::Bind 2021-01-14 alessiob@webrtc.org AGC2 minor code clean up 2021-01-13 jianj@google.com Add av1 to lower range IDs. 2021-01-13 natim@webrtc.org Reland "ChannelStatistics used for RTP stats in VoipStatistics." 2021-01-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c0feffab..189823ba (842900:843026) 2021-01-13 mbonadei@webrtc.org Replace all uses of the word 'master' with 'builder_group' in //tools/mb 2021-01-13 sakal@webrtc.org Handle case createShader throws an exception. 2021-01-13 hta@webrtc.org Add a test to detect excessive audio delay during renegotiation. 2021-01-13 landrey@webrtc.org Fix cpu usage dvqa test on windows 2021-01-13 mbonadei@webrtc.org Remove CheckCompile method from MetaBuildWrapper. 2021-01-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b24f1bec..c0feffab (842774:842900) 2021-01-13 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-13T04:03:21). 2021-01-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e35e978e..b24f1bec (842656:842774) 2021-01-12 aleloi@google.com Revert "ChannelStatistics used for RTP stats in VoipStatistics." 2021-01-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0026868b..e35e978e (842481:842656) 2021-01-12 natim@webrtc.org ChannelStatistics used for RTP stats in VoipStatistics. 2021-01-12 nisse@webrtc.org Revert "Add task queue to RtpRtcpInterface::Configuration." 2021-01-12 danilchap@webrtc.org Fill fps allocation by LibaomAv1Encoder::GetEncoderInfo 2021-01-12 terelius@webrtc.org Move logged types for RTC event log into event headers. 2021-01-12 ivoc@webrtc.org Correction for the calculation of the abs max value 2021-01-12 nisse@webrtc.org Add task queue to RtpRtcpInterface::Configuration. 2021-01-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cbaaf9e4..0026868b (842367:842481) 2021-01-12 danilchap@webrtc.org Use rtc::CopyOnWriteBuffer::MutableData instead of data in fuzzers 2021-01-12 nisse@webrtc.org Delete KeepBufferRefs helpers, and use of rtc::Bind. 2021-01-12 nisse@webrtc.org Add thread annotation to IncomingVideoStream 2021-01-12 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-12T04:04:10). 2021-01-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2059e3a7..cbaaf9e4 (842148:842367) 2021-01-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 78ea2c1b..2059e3a7 (842019:842148) 2021-01-11 mbonadei@webrtc.org Refactor rtc_base build targets. 2021-01-11 philipel@webrtc.org Remove webrtc::VideoDecoder::PrefersLateDecoding. 2021-01-11 mbonadei@webrtc.org [build] Remove obsolete gn flag If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1051821,chromium:1095763,chromium:1117773,chromium:1146835,chromium:1158070,chromium:1161837,chromium:1164276 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0b695f5946acc1216777701b894bfa60d78c8d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630487Reviewed-by:
-
Joel Riley authored
Panel is no longer focusable, only its child buttons. STS JS code now calls focus() on button instead of panel itself to re-focus panel. AX-Relnotes: Fix bug where pressing Search key + S twice in a row without text selection while panel is visible would focus panel but then remove focus from panel button. Bug: 1166733 Change-Id: I45958dabbe3ee4ba21ddee26f6e00a3a75d0f464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629658 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#843808}
-
Pavel Yatsuk authored
This CL adjusts Save Password message title and description to reflect feedback from privacy team: http://doc/1FxSQbCL-zqUsTJaEodEvZ7D8ENxE3lzg5_e7ZEsu8Uk#heading=h.vgwmyj43xgsb This CL adds strings for both options. Only one is currently used. Once we make a decision I'll clean up unused option. BUG=1166841 R=twellington@chromium.org Change-Id: I762c6dbc5e99f9c5fee574321be2750d5d61509f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630447Reviewed-by:
-
Charlene Yan authored
The active tab is not yet reflected in the tab strip when BrowserTabStripController is notified of the select change. The index given to TabStrip to show as active will scroll the tabstrip the minimum amount to make it visible. Bug: 1116120 Change-Id: Iee5260960f30f06e84812261beaffb7317180efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625910 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#843806}
-
Junji Watanabe authored
Similar to run-swarmed.py https://crrev.com/c/2623734, "mb.py run -s" will use CAS instead of Isolate server. Bug: 1163817 Change-Id: Ib0488417a1967736b0d665b49ed6f8d70e01cab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626807 Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#843805}
-
Hui Yingst authored
CalculateBackgroundParts() needs to be migrated to PdfViewPluginBase since it can be used identically by both PdfViewWebPlugin and OutOfProcessInstance. This CL migrates `background_parts_` and `available_area_` to PdfViewPluginBase and provides accessors and mutators for them, so that CalculateBackgroundParts() can be migrated as well. Bug: 1140629 Change-Id: I767468a3716bae40c96c8c36b49d6dd2bb16008d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625787 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#843804}
-
Gyuyoung Kim authored
This CL migrates AwViewHostMsg_SubFrameCreated to FrameHost interface. This CL moves the handler of the existing IPC message from AwContentsMessageFilter to AwRenderViewHostExt. Lastly, AwContentsMessageFilter class is removed because all IPC messages have complected to be converted to Mojo. Bug: 1163149 Change-Id: I11ee339030d463072361911fc5317c29738d17ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623370Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#843803}
-
Leonid Baraz authored
Uses well-known public key for verification. For the time being only DEV key is verified. Bug: b:170054326 Bug: b:177569962 Change-Id: I16c2b9c730f1dbc39a725c958a284863d55921d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630426Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843802}
-
- 14 Jan, 2021 21 commits
-
-
Peter Kasting authored
Bug: 1159562 Change-Id: Ie422b927005bc4603731688e2425e1771a4b652c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630245 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#843801}
-
Egor Pasko authored
Followup to http://crrev.com/843584, where the wrong histogram was taken to rephrase the moment when it is recorded. Correcting the description for: ChromiumAndroidLinker.RelroAvailableImmediately, ChromiumAndroidLinker.RelroSharingStatus Bug: 1154224 Change-Id: Ic19053752a82eb7ff1f12e8777510d66f01467e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630705 Commit-Queue: Egor Pasko <pasko@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#843800}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/320b6dfbe5e4..2d79f95e908d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If6c17cce82d2708b88fe630d1fc653b67ffd39a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630293Reviewed-by:
-
Esmael El-Moslimany authored
When custom links are disabled, the shortcut tiles shouldn't be draggable. For touch, the drag start is initiated by a 'touchstart' event. This CL disables the drag for this situation. When using touch, 'touchmove' scrolls the page content. This is not desired for draggable elements like the custom shortcuts. For this reason 'touch-action' is set to 'none'. The location of the dragging tile when using touch is not correct. The code was using |pageX| and |pageY| which takes into account the scroll position. When there is a non-zero scroll offset, the location of the dragging element is incorrect. |clientX| and |clientY| should be used instead. Bug: 1161486 Change-Id: Ie0ae9c08fb396fe2d19b4c294a4698cf57184b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630007 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#843798}
-
Joe DeBlasio authored
In crrev.com/c/2504507, I added Lookalikes owners as owners of site engagement, but I missed several engagement directories. This CL updates those missed directories to point to the "main" OWNERS file at components/site_engagement/OWNERS, and adds a link out to the lookalike owners from there. Change-Id: I0a6d7ddc7cab3bf6a34672ec0006849dedf14e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628137Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#843797}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/bac5544e9832c65c95283e95062263c79a9a6733..f8f35c95550e6796ab8b2c0f8e37e7ce4bc67302 Bug: none Change-Id: I454f1272780b63e64438bd021413a0802d3b9279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628934 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#843796}
-
Gary Tong authored
Bug: 1042757 Change-Id: I720c371465c332d9128a61193d7b0af77461d94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630107 Auto-Submit: Gary Tong <gatong@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#843795}
-
Garrett Beaty authored
Bug: 1165826 Change-Id: Ie08cc5bcfa6ad53cf92e00f95a0564842f0ff6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625272 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#843794}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Icb7eac31f9e11bcef9d5a42c05c4642a345ad0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630365Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843793}
-
Michael Bai authored
It seems there is a common issue need to fix. Bug: 1161326 Change-Id: I4e6a4d4660a0dec0d2b817aa7933fd3aa6a9b97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630727Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#843792}
-
Katie Dektar authored
Bug: 1166803 Change-Id: I960aab4e3af48fc48b377db1493eba4bc98fe241 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630427 Auto-Submit: Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#843791}
-
Mason Freed authored
It appears that this state was used previously, but is no longer needed. This should cause no behavior changes. Change-Id: I7a36dcdb735654d1ce87debeb82c71a4ccd129eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630286 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#843790}
-
Sam Goto authored
Bug: 1141125 Change-Id: I3f71f116ed17eb1014e7bd08c3850421ff7a957d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630425Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#843789}
-
Scott Violet authored
While the typical case is EnterFullscreenModeForTab is not called multiple times in a row, there may be some corner cases with oopif that result in it being called consecutively. This ensure the delegate is only notified once. BUG=1142101 TEST=FullscreenBrowserTest.DelegateNotCalledMoreThanOnce Change-Id: Ifa094e53b714f78fe61a0d5dd46a33f08c436e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630726 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
John Rummell authored
Bug: 1165081, 1165082 Change-Id: Iaa9ea45ecced614b13e3c266b6302a8c2891d5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626170Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#843787}
-
Sophie Chang authored
Following https://chromium-review.googlesource.com/c/chromium/src/+/2628748, this is the only code path that uses this file and I want to delete it. Plus, the browser test currently doesn't depend on the file contents so it can be any arbitrary file. Change-Id: I65dcf1665f8b35a35247b6e80f2be68fa1c1b761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629657 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843786}
-
Xiaoqian Dai authored
Bug: 1166828 Change-Id: Ic54c9c2f1c42a86802a1c9df3ce558cc18586c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630292Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#843785}
-
chrome://omniboxmanukh authored
Currently, the column is only displayed when 'Show all details' is enabled. With this CL, it will always be shown. Bug: 891303 Change-Id: I66ca6c05e3821a1f375d6ee7f05042efd1c5574d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630406Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843784}
-
Mason Freed authored
Rather than manually retrieve the "id" attribute, it is cleaner and faster to use the existing blink::Element method, which is optimized [1]. This should have no behavior changes. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/dom/element.h;l=1326;drc=9f3ae654ee080ec3ccb5c3f85a51f5e880f5f18e Change-Id: Ic7634eaa8e8057315d83317862ae16428ee15078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628029Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#843783}
-
Nicolas Ouellet-Payeur authored
It already had a ScopedKeepAlive to keep the BrowserProcess from shutting down while clearing data. But it also needs a ScopedProfileKeepAlive, to keep the Profile* from being deleted while clearing. ScopedProfileKeepAlive is a no-op when DestroyProfileOnBrowserClose is false (which is the default for now). Bug: 88586 Change-Id: Ie5a133f99e2b67c0901abc3935cdbe804f2b4030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625996Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#843782}
-
Nick Diego Yamane authored
When a tab is dragged out of a maximized window, the detached window is created in restored state (ie: with different geometry) and tab drag controller needs to adjust the window and dragged tabs' bounds (more specifically x location), so that they appear under the pointer. That's done at TabStrip::TabDragContextImpl::SetBoundsForDrag() function [2], which calls into Views::SetBoundsRect() for each selected Tab view. It turns out that it is not enough to ensure the tabstrip and its parent, TabStripRegionView, get properly re-laid out, leading to issues like [1], where the dragged tab gets partially or totally occluded by the TabStripRegionView's child views. To fix it, this CL adds layout invalidation for tab strip just after setting bounds rect for each dragged tabs, ensuring both tab strip and its parent views are correctly relaid out. Bug: 1151092 [1] https://drive.google.com/file/d/1a6kEVy0DNUo9TTeiCYjkpf7d42TI3T7n [2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/tabs/tab_strip.cc;l=697-708;drc=d81c5852498699fe3cd812e78d31c77c28e29281 R=sky@chromium.org Change-Id: I51244ad4485856334ce3443ed92ce80e2fad2cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572040 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
