- 03 Jan, 2019 40 commits
-
-
Xida Chen authored
This CL does the plubming for the PaintWorkletLayerPainter. It follows the same implementation as the existing LayerTreeMutator which is designed for animation worklet. Change-Id: I173a61173e025d257f1782c5270e41ca24538e9e Reviewed-on: https://chromium-review.googlesource.com/c/1350332 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619628}
-
Colin Blundell authored
This CL inverts the dependency between SigninManager and SigninErrorController: rather than the former depending on the latter, the latter now depends on the former. The concrete motivation is that SigninManager forms part of the core implementation of the Identity Service, whereas SigninErrorController is fundamentally a client-side class: it coalesces authentication errors from various underlying sources in order to conveniently present global information to the UI. The inversion of the dependency is conceptually straightforward. Currently, SigninManager updates SigninErrorController's primary account ID when its own primary account is set/cleared. This CL changes SigninErrorController to explicitly check SigninManager's primary account ID and to observe SigninManager for changes to the primary account. Note that this change means that if the primary account were to be set/cleared on ChromeOS in an ongoing session, SigninErrorController would not be notified (since the SigninManager observer callbacks are not invoked on ChromeOS). However, in production on ChromeOS the primary account is set when SigninManagerBase is created and is never cleared. As of this CL, SigninManagerBase will be created before SigninErrorController (since the latter now depends on the former). This CL was unfortunately difficult to subdivide: the changes to make SigninErrorController depend on SigninManager and the changes to have SigninErrorController *use* SigninManager need to be made atomically in order to avoid the two objects depending on each other, which is an antipattern for KeyedServices. The meaningful changes are the ones to signin_error_controller.* and signin_manager_base.*. To test this change, I verified the following: - Start Chrome - Sign in to the browser - Sign out on the web (e.g., in gmail) - Observe that the "sync paused" error shows up in the avatator button on the top right of the chrome - Restart Chrome - Observe that the "sync paused" error is still present - Sign in to the browser again - Observe that the "sync paused" error goes away I also verified that the above behavior is dependent on SigninErrorController being correct by changing SigninErrorController::Update() to return immediately and verifying that the avatar button never changes through the above set of steps. Followup CLs will move signin_error_controller.* out of the signin_internals GN target and will port SigninErrorController to talk to IdentityManager. TBR=droger@chromium.org Bug: 917836 Change-Id: I7e4a66bcffa4c1d3a8f296dabbf6a7c38602b5fa Reviewed-on: https://chromium-review.googlesource.com/c/1390012 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#619627}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4cfddf92. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" 23a658b9 "WebBluetooth Scanning API" e9314f41 "Fix resource-timing.html document.domain test" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 71e2c3fd "Invalidate the graphics layer subtree on stacking change of descendant PaintLayer." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2a9c667753b136145712e4f4944a514cdf3a4b29 Reviewed-on: https://chromium-review.googlesource.com/c/1394378Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619626}
-
Mark Cogan authored
The ViewControllerSwapping method -showTabSwitcher: had a completion parameter that was no longer being used. Change-Id: Ife1b0609191868d9a3505d8ea0657c54c8ed25dc Reviewed-on: https://chromium-review.googlesource.com/c/1392341 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#619625}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I6523d678d86c8ece5b33483e5a93fe96868790da Reviewed-on: https://chromium-review.googlesource.com/c/1394446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619624}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28aa65d24293..4abc078d238b Created with: gclient setdep -r src-internal@4abc078d238b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4c079efe300be08b97a6208402fbb1ae9373a902 Reviewed-on: https://chromium-review.googlesource.com/c/1394198Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619623}
-
Khushal Sagar authored
The ClientPaintCache assumes that once an entry has been added to its state tracking, it is guarenteed to be transferred to the service side cache and is removed only when explicitly purged. This assumption is not true in the case where serializing an op fails due to insufficient memory. In this scenario, the memory is remapped and the op is re-serialized but any changes made to the ClientPaintCache state, supposed to be a mirror of the service side state, are not actually made to the service side state. This cause the Client and Service PaintCaches to get in an inconsistent state and we fail to raster the tile due to deserialization failures. Avoid this by tracking the serialized cache entries in a pending list that is committed only when the data is guarenteed to be transferred to the service, and discarded otherwise. R=enne@chromium.org, ericrk@chromium.org Bug: 912282 Change-Id: I96d4108acb4903ce0ff48b54718c65b61805e103 Reviewed-on: https://chromium-review.googlesource.com/c/1393138 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#619622}
-
Finnur Thorarinsson authored
The UX design calls for showing only one number/email on-screen, and have the rest show only in details view (a view that will appear in an upcoming CL). Bug: 860467 Change-Id: Ifaccdbd89b0fc5041cef7c05e288469032f5e78b Reviewed-on: https://chromium-review.googlesource.com/c/1393368Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#619621}
-
A Olsen authored
- Changes OwnerSettingsServiceChromeOsFactory so that its stubbed behavior can be used without setting a switch - Changes CrosSettings so that it can be stubbed during a test without worrying about it being reinitialized later - Add a new class ScopedTestingCrosSettings that makes use of this new functionality, is much simpler than ScopedCrosSettingsTestHelper. - Changes one test - users_private_apitest.cc - that previously used switches, so that it no longer uses switches, as a proof-of-concept. For more details, see the bug. Bug: 909635 Change-Id: I57b053038592512fb7cfb7c09061d5d03475e979 Reviewed-on: https://chromium-review.googlesource.com/c/1392186 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#619620}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/512058c06578..28aa65d24293 Created with: gclient setdep -r src-internal@28aa65d24293 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I562aad60a5eaca06c056e3b0c1b85a90eb2fe6fa Reviewed-on: https://chromium-review.googlesource.com/c/1394196Reviewed-by:
-
Rune Lillesveen authored
In the dynamic profile, /deep/ have been translated into descendant combinators for a while. Removing selectors from webui which should have no effect. Bug: 794083 Change-Id: Ic30ad81bd8ae14adf4f36b4fdc718b355dd96fb1 Reviewed-on: https://chromium-review.googlesource.com/c/1392952Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#619618}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aae6ae39a356..fdde2926df92 git log aae6ae39a356..fdde2926df92 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 904bb9185767..4627b3705d59 (1 commits) Created with: gclient setdep -r src/third_party/skia@fdde2926df92 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I79b0340bd6cd4b9d6f2be288660c3331002740d2 Reviewed-on: https://chromium-review.googlesource.com/c/1394197Reviewed-by:
-
Morten Stenshorne authored
Place them together with their friends. :) And use appropriate bug numbers. TBR=eae@chromium.org Bug: 829028, 875235, 918663 Change-Id: Ib8c5164747dc433e145984c869ce1fd19557686d Reviewed-on: https://chromium-review.googlesource.com/c/1394305Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#619616}
-
Jérôme Lebel authored
|_unifiedConsentCoordinator| should be removed once the sign-in is done and the user consent is recorded. This is to avoid to receive notifications related to the UIScrollView in UnifiedConsentViewController, like: -[ChromeSigninViewController unifiedConsentCoordinatorDidReachBottom:] Bug: 918557 Change-Id: I9d57dbf4d9f37f636fa44105f268d7089e192abf Reviewed-on: https://chromium-review.googlesource.com/c/1393372Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/013602ac..39e8ad8f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic3703e140485fa6cddbeaaf14943557b2a550485 Reviewed-on: https://chromium-review.googlesource.com/c/1394375Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619614}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cff4a724. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" 23a658b9 "WebBluetooth Scanning API" e9314f41 "Fix resource-timing.html document.domain test" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 71e2c3fd "Invalidate the graphics layer subtree on stacking change of descendant PaintLayer." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1c14ef3c2c82ab5426a48dded689b007d54db29c Reviewed-on: https://chromium-review.googlesource.com/c/1394373Reviewed-by:
-
Sergio Villar Senin authored
A new function has to be added to identity_test_utils in order to set the maximum number of authentication token fetch retries to 0, i.e., to disable retries. Bug: 912171 Change-Id: I7f39f8b0aec5c180a92a2b26cb3e6a73f58645b1 Reviewed-on: https://chromium-review.googlesource.com/c/1386791 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#619612}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d238bb67a52a..2b9d702c09f1 git log d238bb67a52a..2b9d702c09f1 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 yunchao.he@intel.com Fix a bug for depth test on Vulkan backend Created with: gclient setdep -r src/third_party/dawn@2b9d702c09f1 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I39f7f4705c05de016c25f467dfab2cbffeab51f6 Reviewed-on: https://chromium-review.googlesource.com/c/1394194Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b7b477b1120e..4f718c120c1e git log b7b477b1120e..4f718c120c1e --date=short --no-merges --format='%ad %ae %s' 2019-01-03 primiano@google.com Merge "Extract base::UnixSocketRaw" Created with: gclient setdep -r src/third_party/perfetto@4f718c120c1e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I49d0496f3b002553b0b9c5d639c097f3d166054f Reviewed-on: https://chromium-review.googlesource.com/c/1394195Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I43853fea01bd25d4c8be1c92ec029911e306ea8d Reviewed-on: https://chromium-review.googlesource.com/c/1394445Reviewed-by:
-
Dominik Röttsches authored
DWriteFontProxy is no longer implemented as a message filter but is a regular Mojo service now. Rename files from *_message_filter_* to *_impl_*. Change-Id: I8e5202993c45168636a2e09287f69da397ac5092 Reviewed-on: https://chromium-review.googlesource.com/c/1392345 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#619608}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/995eb7e708cf..512058c06578 Created with: gclient setdep -r src-internal@512058c06578 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie31ed8527bbd110b365001cbff55455904e6c6ed Reviewed-on: https://chromium-review.googlesource.com/c/1394444Reviewed-by:
-
Eric Seckler authored
perfetto_unittests and content_unittests seem to be passing. Other test suites (content_browsertests / services_unittests) aren't currently supported on Fuchsia so can't yet verify that everything works in practice. Depends on aosp/853409 and aosp/859117. Bug: 916074 Change-Id: I6d7c034fdf9e3086e08b6a1338e78f75a1c86afd Reviewed-on: https://chromium-review.googlesource.com/c/1382134Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#619606}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0fe2ff41..013602ac Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6d4eb78a69583fbfc6777c7f86d99a4e47263d6 Reviewed-on: https://chromium-review.googlesource.com/c/1394368Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96345a23dfa9..aae6ae39a356 git log 96345a23dfa9..aae6ae39a356 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@aae6ae39a356 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I9331ddf10087b5410949b21a8a81b3d48c5b8864 Reviewed-on: https://chromium-review.googlesource.com/c/1394443Reviewed-by:
-
Mohsen Izadi authored
This used to represent three different modes: disabled, simple ui, parallax ui. Now that the parallax mode is removed, we can use a simple bool. BUG=890390 Change-Id: Ic96fb6fa82c0fa2f9071e39ef5b0b10af5587e75 Reviewed-on: https://chromium-review.googlesource.com/c/1275205Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619603}
-
Tomasz Moniuszko authored
Bug: 918516 Change-Id: Id97aac57ef7e4bc64e312712068d8500f1d2f4e2 Reviewed-on: https://chromium-review.googlesource.com/c/1386432 Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#619602}
-
Dominik Röttsches authored
Change the FontUniqueNameTable proto to allow associating font unique names of multiple locales with the same font file. We do not need to distinguish them in storage, as the information about which type of font name was matched will not be needed later. Sort the name lookup table upfront, so that later searches can be more efficient and employ binary search. As a preparation to using this for the Windows font unique name matching implementation, generalize the proto field which is used for storing the Android build fingerprint when persisting this protobuf. Bug: 918144 Change-Id: Ib3fe8840564429a68c6444dd2e9760a21848b7ca Reviewed-on: https://chromium-review.googlesource.com/c/1392096 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#619601}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b6f54f365ea..995eb7e708cf Created with: gclient setdep -r src-internal@995eb7e708cf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If3973cc4b1471f7d01149bf369b87d6126fa9feb Reviewed-on: https://chromium-review.googlesource.com/c/1394205Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/904bb9185767..4627b3705d59 git log 904bb9185767..4627b3705d59 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 jmadill@chromium.org Add gl null driver tests to DrawElements. Created with: gclient setdep -r src/third_party/angle@4627b3705d59 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Id94a35155be81aebd6cc93c2337e014467d25a9c Reviewed-on: https://chromium-review.googlesource.com/c/1394206Reviewed-by:
-
Cathy Li authored
Also fixes a number of issues: 1. Re-reinforce the max 2 rows of sites on categories 2. Update tests to account for the 4-sites-per-row rule Change-Id: I27b232466314ce0398c6f5ba31ebdb340e6dbdfc Reviewed-on: https://chromium-review.googlesource.com/c/1377141Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
In the long-term we want |request_initiator_site_lock| to take precedence over |request_initiator| everywhere in the NetworkService. This is risky however, because there are known cases where |request_initiator| may differ from |request_initiator_site_lock| even without a malicious/compromised renderer in the picture (e.g. HTML Imports). Therefore, in the short-term, we start with enforcing |request_initiator_site_lock| only for Cross-Origin Read Blocking (CORB) - this is safer because: - CORB only applies to a subset of requests and so this approach seems safer and okay to enable by default (while measuring the impact via UMA and having a kill switch ready). - CORB is only web-observable when blocking subresource requests trigerred by XHR/fetch API (and these requests seem to always use a |request_initiator| compatible with |request_initiator_site_lock|; this is covered by new tests added by this CL). Bug: 871827 Change-Id: If9459bfbd09411d70c3547de0e50a58832e75503 Reviewed-on: https://chromium-review.googlesource.com/c/1377385 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#619597}
-
Reka Norman authored
This CL adds a permissions map to the app struct used by the fake backend, and allows these permissions to be toggled in the PWA permission view. Bug: 906508 Change-Id: I292671d5f4fa9034fac10eba421380aaef8367ad Reviewed-on: https://chromium-review.googlesource.com/c/1388128Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Reka Norman <rekanorman@google.com> Cr-Commit-Position: refs/heads/master@{#619596}
-
Nico Weber authored
See bug for details. Bug: 917404,256342 Change-Id: Ic5fd959f23e77b9194af4faecceeefffe0b924ae Reviewed-on: https://chromium-review.googlesource.com/c/1387395 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#619595}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be1288c9..0fe2ff41 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id1ceba37859361a70f5a4915a497d6fb791f908e Reviewed-on: https://chromium-review.googlesource.com/c/1394384Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f55b6a510625..b5f346a1b0b4 git log f55b6a510625..b5f346a1b0b4 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@b5f346a1b0b4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2a1b65d4316c68910792527d9e87e5a73fb8dd9b Reviewed-on: https://chromium-review.googlesource.com/c/1394363Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic4422602a4dab51f54a2d1a87fdcd827cc38d8ea Reviewed-on: https://chromium-review.googlesource.com/c/1394367Reviewed-by:
-
Darwin Huang authored
Bug 369621 originally led to this check being introduced via https://codereview.chromium.org/289573002/patch/40001/50002, but after https://crrev.com/c/1345809, I'm not sure that it's still necessary. This change succeeds when tested against the "minimized test case" provided in crbug.com/369621 's description, but I'm unsure how to make the minimized test case fail, so this doesn't prove that the change would succeed against the fuzzer's test case (which originally filed the bug). As I'm unable to view the relevant fuzzer test case, (see crbug.com/918705), I don't know exactly what may have caused the fuzzer to fail. Therefore, I've added a CHECK for the time being, so that we will be notified in canary if my assumption was incorrect. Bug: 369621 Change-Id: Ie9b47a4b38ba1ed47624de776015728e541d27f7 Reviewed-on: https://chromium-review.googlesource.com/c/1393436Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#619591}
-
Zhongyi Shi authored
Use PendingStreams to buffer incoming streams. Behavior changes protected by QUIC version 99 Allow QuicSession to buffer frames for incoming streams in a PendingStream until the first byte arrives, if ShouldBufferIncomingStream() returns true. Change QuicSpdySession to return true for v99 unidirectional streams. Merge internal change: 226538637 https://chromium-review.googlesource.com/c/chromium/src/+/1394084 Changes how QUIC connection IDs are created. Seventh step towards variable length QUIC connection IDs. This CL has more of the codebase treat QUIC connection IDs as opaque bags of bytes instead of uint64_t's. The change is protected by GFE restart flags quic_variable_length_connection_ids_(client|server). This CL also removes the enabling_blocked_by on quic_restart_flag_quic_connection_ids_network_byte_order. Merge internal change: 226428581 https://chromium-review.googlesource.com/c/chromium/src/+/1394083 In QUIC v99, client closes connection if it tries to create a server initiated bidirectional stream. Merge internal change: 226397697 https://chromium-review.googlesource.com/c/chromium/src/+/1393784 Add QpackHeaderTable::inserted_entry_count(). Turns out this quantity is needed for relative indexing on the encoder stream, not the dropped entry count. See https://quicwg.org/base-drafts/draft-ietf-quic-qpack.html#rfc.section.3.2.5. Merge internal change: 226352231 https://chromium-review.googlesource.com/c/chromium/src/+/1393342 Fix ServerSendsVersionNegotiation in http end_to_end_test In tests with the client supporting all versions (from a bucket) and the server supporting all possible versions, the client's choice of version can be one that the server also supports, but not be the head of the list. The current implementation of ServerSendsVersionNegotiation would return true in this case, even though the server won't send version negotiation. (This currently isn't an issue because of which tests are run with TLS enabled and how the buckets are set up, but it will be an issue when there are more version buckets added in the CRYPTO frame CL.) Merge internal change: 226246369 https://chromium-review.googlesource.com/c/chromium/src/+/1393673 Change header type byte in v99 to meet draft 17 https://quicwg.org/base-drafts/draft-ietf-quic-transport.html Merge internal change: 226235106 https://chromium-review.googlesource.com/c/chromium/src/+/1393672 Modify CheckMultiPathResponse to use a client_framer to validate path responses. Merge internal change: 226227650 https://chromium-review.googlesource.com/c/chromium/src/+/1393341 Add two DCHECKs to TestHeadersHandler::ReleaseHeaderList(). Because belts and suspenders. Merge internal change: 226211897 https://chromium-review.googlesource.com/c/chromium/src/+/1393377 Change flag count 'quic_monotonic_epoll_clock' to only increment when time goes backwards. Merge internal change: 226196406 https://chromium-review.googlesource.com/c/chromium/src/+/1393663 Make ReadFileContents take |filename| argument as QuicStringPiece. Merge internal change: 226192259 https://chromium-review.googlesource.com/c/chromium/src/+/1393462 Signal error in QpackProgressiveDecoder if header data prefix is incomplete. Every header block must have a prefix that communicates Largest Reference and Delta Base Index. Make it an error if header block data is terminated without a complete prefix. Merge internal change: 226190644 https://chromium-review.googlesource.com/c/chromium/src/+/1393550 Change behavior of empty QUIC connection IDs. Empty connection IDs (created using either QuicConnectionId() (the default constructor) or EmptyQuicConnectionId()) now have length zero instead of 8. QuicConnectionIdFromUInt64(0) is no longer considered empty. QuicConnectionIdIsEmpty() has been removed. Some test code is changed from EmptyConnectionId() to TestConnectionId() because the code it exercises expects 8-byte connection IDs. Merge internal change: 226099591 https://chromium-review.googlesource.com/c/chromium/src/+/1393549 Adopt QuicConnectionId::ToString(). Switches the parts of the code that need a string representation of a connection ID away from the hop through a uint64_t. Use QuicConnectionId::ToString() to stringify QUIC connection IDs as hex strings instead of decimal strings. Merge internal change: 226060328 https://chromium-review.googlesource.com/c/chromium/src/+/1393525 Change server_address/client_address to self_address/peer_address in ProcessPacketInterface::ProcessPacket and all override methods. Merge internal change: 225995694 https://chromium-review.googlesource.com/c/chromium/src/+/1393446 Fix Quic_Frame.cc output to use correct frame type for APPLICATION_CLOSE frame Quic_frame.cc attempted to output a CONNECTION_CLOSE frame when when the frame was, in fact, an APPLICATION_CLOSE. This CL corrects that. N/A - these frames exist only in version 99 Merge internal change: 225979605 https://chromium-review.googlesource.com/c/chromium/src/+/1393445 Add default virtual destructor for every derived class in QPACK. Merge internal change: 225925387 https://chromium-review.googlesource.com/c/chromium/src/+/1393434 Add stream_id to progressive encoder and decoder. This will be necessary for the encoder to keep track of references to dynamic entries by stream id, and for the decoder so that a Header Acknowledgement instruction (which contains the stream id) can be sent when decoding is complete. Also use the (currently incorrectly defined 32-bit, soon-to-be-64 bit) QuicStreamId type instead of uint64_t for stream IDs. Merge internal change: 225917487 https://chromium-review.googlesource.com/c/chromium/src/+/1393433 Add Header Data Prefix to Qpack{En,De}coder. Encoder does not emit dynamic entries yet, so Largest Reference and Base Index are always zero. Decoder does not decode dynamic entries yet, but at least records Largest Reference and Base Index. Merge internal change: 225908419 https://chromium-review.googlesource.com/c/chromium/src/+/1393334 Add Header Data Prefix instruction and necessary fields. Add support for second varint in QpackInstructoin{En,De}coder. Also rename static bit to S bit, because in the Header Data Prefix it is a Sign. Merge internal change: 225895953 https://chromium-review.googlesource.com/c/chromium/src/+/1392366 Sixth step towards variable length QUIC connection IDs. This CL creates QuicUtils::CreateRandomConnectionId() and adopts it from inside //third_party/quic/. There will be followup CLs to adopt it from our clients, to facilitate our effort of moving them away from QuicConnectionIdFromUInt64(). Merge internal change: 225884942 https://chromium-review.googlesource.com/c/chromium/src/+/1392362 Add QPACK dynamic table.(Prototype code not used in production yet.) Implement dynamic table with synchronous lookup only. The ability to request an entry that has not been added to the table yet and call back with the result later will be added in a future CL. However, as the decoder can request that the encoder never refers to an unacknowledged entry by setting SETTINGS_QPACK_BLOCKED_STREAMS to zero (default value), this functionality will be enough for a compliant (though not maximally efficient) decoder. This CL already uses the nomenclature "dynamic table capacity" and "maximum dynamic table capacity" proposed at https://github.com/quicwg/base-drafts/pull/2115#issuecomment-446796679 which has not been merged into the spec yet. Merge internal change: 225870655 https://chromium-review.googlesource.com/c/chromium/src/+/1392329 Split AppendIetfTypeByte and ProcessIetfTypeByte out from AppendIetfPacketHeader and ProcessIetfPacketHeader. Refactoring only. No functional change expected. Merge internal change: 225827558 https://chromium-review.googlesource.com/c/chromium/src/+/1392359 Change server_address/client_address to self_address/peer_address in buffered packet store. (n/a) Rename only, not protected. Merge internal change: 225817243 https://chromium-review.googlesource.com/c/chromium/src/+/1392177 Change-Id: I073e223e92314ac7fdb69a15098e63ac52855f7c Reviewed-on: https://chromium-review.googlesource.com/c/1394143 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#619590}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48bbc53ea4d0..904bb9185767 git log 48bbc53ea4d0..904bb9185767 --date=short --no-merges --format='%ad %ae %s' 2019-01-02 jmadill@chromium.org Rename constants in blocklayout.h. Created with: gclient setdep -r src/third_party/angle@904bb9185767 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Ibde0902fa4e4f6713dda961757707a1cfd8b60d6 Reviewed-on: https://chromium-review.googlesource.com/c/1393923Reviewed-by:
-
