- 17 Nov, 2017 40 commits
-
-
Ria Jiang authored
Bug: none Change-Id: I726fa1f76e21b6c1a75cb19100eaa3ad19c26c91 Reviewed-on: https://chromium-review.googlesource.com/775817Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#517435}
-
Louis Romero authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifc43afb495541b7ed62e9d001d331469d3156caa Reviewed-on: https://chromium-review.googlesource.com/776694Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#517434}
-
Michael Thiessen authored
lolk Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8341d0c701f46a50f92bf5c6fb1682ab136c0b72 TBR=ymalik@chromium.org Change-Id: I8341d0c701f46a50f92bf5c6fb1682ab136c0b72 Reviewed-on: https://chromium-review.googlesource.com/776156Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#517433}
-
Dirk Pranke authored
This reverts commit 85f6ac62. Reason for revert: It looks like this breaks a clean checkout; see crbug.com/786356 and https://ci.chromium.org/buildbot/chromium.chromiumos/chromeos-amd64-generic-rel/1519 (and the next build, which is I think a clobber build). Original change's description: > Roll src/third_party/chromite/ ef632e4a4..aed007c17 (60 commits) > > https://chromium.googlesource.com/chromiumos/chromite.git/+log/ef632e4a473b..aed007c17605 > > $ git log ef632e4a4..aed007c17 --date=short --no-merges --format='%ad %ae %s' > 2017-11-13 cywang auto_updater: Apply cold reboot for AU > 2017-11-15 dgarrett cros tryjob: Fix submission of unknown build configs. > 2017-11-15 dgarrett cros_tryjob: Add go link to -tryjob error messages. > 2017-11-16 phobbs Revert "gob_util: Support Appengine Gerrit credentials." > 2017-11-14 dgarrett branch-util: Fix branch-util-tryjob for testing. > 2017-11-15 shapiroc Fix issue with model specific au fanout > 2017-11-07 aelder deploy_chrome: Add --private_key option > 2017-11-09 phobbs locking: Fix errno.EDEADLK reference. > 2017-11-15 cmtice Revert "generic_stages: temporarily ignore all target prebuilts." > 2017-11-15 chrome-bot Update config settings by config-updater. > 2017-11-15 hiroh TestSimpleChromeWorkflowStage: Pass --nogn-gen to cros chrome-sdk > 2017-11-09 phobbs gob_util: Support Appengine Gerrit credentials. > 2017-11-08 achuith [cros_vm]: Use virtio instead of cirrus. > 2017-11-14 cmtice generic_stages: temporarily ignore all target prebuilts. > 2017-11-13 shapiroc Configure coral for chrome/android pfq and paladin > 2017-09-13 vapier cros tryjob: restore metavar > 2017-11-14 stevenjb TestSimpleChromeWorkflowStage: Pass --nogngen to cros chrome-sdk > 2017-11-14 chrome-bot Update config settings by config-updater. > 2017-11-13 xixuan cros-update: use curl instead of wget to check devserver health. > 2017-11-13 chrome-bot Update config settings by config-updater. > 2017-09-29 stevenjb cros_chrome_sdk: Automatically generate args.gn files > 2017-11-11 manojgupta Revert "generic_stages: temporarily ignore all target prebuilts." > 2016-07-20 sjg commands: Use cros_config_host instead of fdtget > 2017-11-08 dgarrett cbuildbot: Enforce tryjob safe configs. > 2017-11-01 dgarrett cros tryjob: Enforce tryjob safe configs. > 2017-11-07 manojgupta generic_stages: temporarily ignore all target prebuilts. > 2017-11-09 akeshet summarize_build_stats: link to new cq-weekly dashboard > 2017-11-09 akeshet summarize_build_stats: drop the "Top reasons" table > 2017-11-09 akeshet summarize_build_stats: add a category picker to the top X lists > 2017-11-10 chrome-bot Update config settings by config-updater. > 2017-11-09 dgarrett chromeos_config: Remove tryjob config overrides. > 2017-11-01 dgarrett cros tryjob: Update --list for production vs tryjob. > 2017-11-07 vapier image_test: move security_CroshModules autotest here > 2017-11-08 derat chromite: Make TastVMTestStage unforgiving. > 2017-11-06 nxia Get current builders_array from metadata. > 2017-11-09 stevenjb chrome_chromeos_lkgm: Add --email to 'git cl upload' > 2017-11-08 derat chromite: Run ARC Tast VM tests on betty-release. > 2017-11-08 ayatane Fix typo > 2017-11-06 ayatane Exclude provision suite from subsystems > 2017-08-21 smbarber chromeos_config: Add tatl-full builder on external waterfall > 2017-11-08 lhchavez Remove support for aosp_bertha* Android targets > 2017-11-08 stevenjb chrome_chromeos_lkgm: Remove any existing chrome checkout > 2017-11-08 chrome-bot Update config settings by config-updater. > 2017-09-28 nxia chromite changes for Cros_CL_Status_Viewer > 2017-11-06 phobbs cidb: Changes for cl_exonerator > 2017-11-07 dgarrett chromeos_config: Update generated files together. > 2017-11-07 achuith [cros_vm]: Better error messages for qemu. > 2017-11-03 pprabhu cidb_integration_test: Wait longer for mysqld to initialize. > 2017-11-08 chrome-bot Update config settings by config-updater. > 2017-10-20 dgarrett chromeos_config: Create mirrored tryjob build configs. > 2017-11-07 stevenjb cros_chromeos_lkgm: Add UploadNewLKGM stage (take 4) > 2017-11-06 akeshet pre-cq: mark failed-to-apply changes as pre-cq-failed so they don't loop > 2017-10-27 davidriley Reland "cbuildbot: Emit partition files for provisioning purposes." > 2017-11-06 derat chromite: Ensure TastVMTest runs after VMTest failure. > 2017-11-06 pprabhu cq_stats: deploy the correct cidb credentials. > 2017-11-06 pprabhu Update cidb settings for gen2 SQL instances. > 2017-11-06 pprabhu Hack fake_modules some more to allow chromite import. > 2017-10-31 dgarrett cros_uprevchrome: Tweak tempdir creation. > 2017-11-06 dgarrett cros_tryjob: Add --chrome_version passthrough option. > 2017-11-03 llozano chromite: cleanup board lists for llvm-toolchain configs. > > Created with: > roll-dep src/third_party/chromite > > Bug: 762650 > Change-Id: Ib17a3570e32c98bae423d88c6320a5be95a26fef > Reviewed-on: https://chromium-review.googlesource.com/775023 > Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517193} TBR=stevenjb@chromium.org,alemate@chromium.org,xiaoyinh@chromium.org Change-Id: I2c2079179b5aa59820bc2c58bc2ab21b96f63342 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762650 Reviewed-on: https://chromium-review.googlesource.com/777059Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#517432}
-
Gauthier Ambard authored
The OmniboxFocuser protocol is used through the app (e.g. in NTP). The ToolbarCoordinator needs to implement it to be passed as a protocol to those objects. Bug: 784911 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I29e531dfee92596ec6e1f3b926a142306c64a037 Reviewed-on: https://chromium-review.googlesource.com/771891 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517431}
-
Rune Lillesveen authored
Change-Id: Ie5be4c9508d63fb0a58180942bdee3a8cbb3ef2b Reviewed-on: https://chromium-review.googlesource.com/776878Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#517430}
-
Kristian H. Kristensen authored
Allow primary planes to not have to be the size of the mode. This lets us configure a primary plane that's smaller than the current mode, which will be useful for the underlay strategy. This commit also adds a new option to ozone_demo to test the partial primary plane functionality. BUG=772239 TEST=ozone_demo --enable-drm-atomic --partial-primary-plane works on KBL or RK3399 boards showing red/blue pulsing square; ozone_demo --disable-drm-atomic --partial-primary-plane shows black screen but doesn't exit or crash. Bug: Change-Id: Ie77b02848efca717dee465783c692333d2e6c988 Reviewed-on: https://chromium-review.googlesource.com/666000Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#517429}
-
Gauthier Ambard authored
Bug: 784911 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia01f0d2e9e4a32607c0bd0c18228564110585909 Reviewed-on: https://chromium-review.googlesource.com/776881Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#517428}
-
Martin Sramek authored
After https://chromium-review.googlesource.com/771890, the functionality tested by this fuzzer depends on base::CommandLine. This was not initialized in the fuzzer, making it crash. Bug: 786023 Change-Id: I1c599e3231d5236b6ffb59e20373c2243ee0d026 Reviewed-on: https://chromium-review.googlesource.com/776874Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#517427}
-
Guido Urdaneta authored
This reverts commit 0326c088. Reason for revert: Suspect of causing virtual/outofblink-cors/external/wpt/service-workers/service-worker/fetch-request-fallback.https.html to fail on several Mac and Linux bots. See for example https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.12/builds/7923 Original change's description: > Plumb extra errors from ResourceRequestCompletionStatus to Blink > > This patch plumbs CORSError and HTTP response headers > from ResourceRequestCompletinoStatus to Blink's ResourceError. > > Test: ./Tools/Scripts/run-webkit-tests virtual/outofblink-cors > Bug: 736308 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I20e4ec9a2e7ca93ce692a5a8312dadf59eb0f345 > Reviewed-on: https://chromium-review.googlesource.com/749024 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517388} TBR=kinuko@chromium.org,toyoshim@chromium.org,tyoshino@chromium.org,yhirano@chromium.org,mkwst@chromium.org Change-Id: Ib973ef76eaab93e4c4dbf9b08712bbd560eac368 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 736308 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/776913Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#517426}
-
Julia Tuttle authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic7038de9351cd34c22a23a0e60694e7330e1ab66 Reviewed-on: https://chromium-review.googlesource.com/766730Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#517425}
-
Eugene But authored
This CL implements DownloadTask public interface. DownloadControllerImpl CL: crrev.com/c/758525 Design doc: http://go/ios-web-download-api Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iffea44bfb64cc945f7d899dd7181556a730394f1 Reviewed-on: https://chromium-review.googlesource.com/775889Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517424}
-
Will Harris authored
These are obtained from the reverse of WTERMSIG macro - e.g. WTERMSIG(132) is 4 which is SIGILL defined in sys/signal.h BUG=None Change-Id: Ifbfb9895354ca511f2787d21feb4b33e415fd8ec Reviewed-on: https://chromium-review.googlesource.com/773778Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#517423}
-
Colin Blundell authored
Several DEPS entries were allowing dependencies on the internals of a service. This CL tightens those DEPS down. Note that a couple are left: this is intentional, as in those cases the services in question are actually being embedded in the dependent. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7e91f08559399997059c4c81dd7857e19c776175 Reviewed-on: https://chromium-review.googlesource.com/776695Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#517422}
-
Benoit Lize authored
Cygprofile code does a compare and swap on an atomic value. Use the STL atomic_fetch_or_explicit() instead of hand-coding a CAS. Bug: 776702 Change-Id: I049dbbb5f67255b6556d6beae37f243030561079 Reviewed-on: https://chromium-review.googlesource.com/776682Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#517421}
-
Eugene But authored
Verified callbacks correctness with NavigationCallbacksTest.FailedNavigation integration test. Before this CL DidStartNavigation was called twice (second time for presenting error in Native Content). DidFinishNavigation was called once (also for presenting NativeContent). First DidStartNavigation did not have a matching DidStartNavigation call. This CL removes DidStartNavigation/DidFinishNavigation callbacks for for presenting error in Native Content and adds balanced DidFinishNavigation callback in handleLoadingError:. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id15ef8c9422e571f74f9c00bf88ea98ccbf6607c Reviewed-on: https://chromium-review.googlesource.com/758718 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#517420}
-
Francois Doray authored
This enum replaces resource_coordinator::TabManager::DiscardTabCondition. It can be used by code that doesn't depend on TabManager and/or that is unrelated to tabs. TBR=msw@chromium.org Bug: 775644 Change-Id: I71931a4f32c161bec467e1851d2a68ab843d2d24 Reviewed-on: https://chromium-review.googlesource.com/738298Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#517419}
-
Francois Doray authored
The goal is to make it easy to verify that an aura::Window always has a layer once initialized. Bug: 738387 Change-Id: I09c4972006c8a4b86fcde0e39fc12291187e0a78 Reviewed-on: https://chromium-review.googlesource.com/774909 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#517418}
-
Carlos IL authored
Change-Id: I9c225af54f104c2627d519422ec5a3519b325da6 Reviewed-on: https://chromium-review.googlesource.com/761442Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#517417}
-
Bence Béky authored
Data show that 75% of pushed streams that are matched to a request have response headers at the time of matching. Obtaining this single piece of information was the sole purpose of this histogram, it can now be removed. Bug: 764155 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iff906283dc589c22fe1ffb7f89b759846ca1bbbc Reviewed-on: https://chromium-review.googlesource.com/771544Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#517416}
-
Vaclav Brozek authored
The linked bug contains a confusion about the intended messaging in case when the user taps the Show button in Chrome password settings on iOS and fails to authenticate. This CL adds two tests, one for a successful and one for a failed authentication, documenting the expected outcomes to prevent changing behaviour in the feature by accident. Bug: 785923 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If9c84c0ebe076f827b4c1b2611c0b77e8a779a44 Reviewed-on: https://chromium-review.googlesource.com/776784Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517415}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb0a53b0..48661839 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7c9b3bb5daf37a5cd0009c0c36d9fbfb0603e003 Reviewed-on: https://chromium-review.googlesource.com/775986Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517414}
-
Marc Treib authored
These checks can be fairly expensive, and they're called on the critical path for all navigations. No reason to pay the cost for non-SUs. Bug: 786035 Change-Id: Id47d0b2fe4c86371fd4c277e363a4f7fcfd49194 Reviewed-on: https://chromium-review.googlesource.com/775959Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#517413}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/0a8798b26675..feee08f4da81 $ git log 0a8798b26..feee08f4d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I489e4ab2c0e8d2fa29b05d08005b679172a41ac0 Reviewed-on: https://chromium-review.googlesource.com/776743Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517412}
-
Olivier Robin authored
These fields cannot be filled, so ignore event on them. Test: autofilling shipping address in shop.economist.com Bug: Change-Id: I0c754b61da4c6cadda912ce10dfd2edd43285719 Reviewed-on: https://chromium-review.googlesource.com/749947Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Moe Ahmadi (slow) <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517411}
-
Xiaocheng Hu authored
This patch slightly reorganizes the above mentioned function to make the logic clearer that, the function has three major branches dependig on the type of |layout_object|: text, block flow with children, or atomic inline. Detail: Adding |IsAtomicInlineLevel()| check to the last part of the function doesn't introduce any behavior change. This is because that |LayoutBox::InlineBoxWrapper()| returns non-null result only when the layout object is an atomic inline. Bug: 771398 Change-Id: Id61830a9ad11de40c5ae7456e3e13b6a4094b1a9 Reviewed-on: https://chromium-review.googlesource.com/775659Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#517410}
-
Michael van Ouwerkerk authored
Screenshots: http://shortn/_e12t0VKa6o Bug: 759134 Change-Id: I448ad8960f3999ee7b95b35fe9d5eadaed7d3015 Reviewed-on: https://chromium-review.googlesource.com/776661 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#517409}
-
kylechar authored
Some OOPIF problems have been fixed when running content_browsertests with --enable-viz. Add passing tests back to FYI trybot to check for flaky tests. TBR: sky@chromium.org Bug: 762510 Change-Id: I1e284daff7f46e05a3c7ecc447d16510ebef50b1 Reviewed-on: https://chromium-review.googlesource.com/775975Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#517408}
-
Aidan Wolter authored
Add a missing `true` when comparing a jinja variable. Without this, the statement always resolves to true causing build failures in multiple platforms. TEST=None BUG=None Change-Id: Ic5973e7f65c7f7cbef4bc77df6c1d214bec6ddb4 Reviewed-on: https://chromium-review.googlesource.com/775605Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#517407}
-
Yuly Novikov authored
After https://chromium-review.googlesource.com/720019 changed scaling. BUG=785392 TBR=kbr@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If9b38cd6e915a547743ff21f6267847ef48adcbf Reviewed-on: https://chromium-review.googlesource.com/775156 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#517406}
-
Maks Orlovich authored
HttpCache.CantConditionalizeZeroFreshnessFromMemHint is logged along HttpCache.CantConditianlizeCause == ZERO_FRESHNESS to denote this working. Since this is implemented as dooming entries, it messes somewhat with the "open stale" feature on error page. It's my understanding that feature is not turned on, so this just relaxes tests for it to use things not eligible for the behavior change. Bug: 729679 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie9a489fb6fa53a76691615c789c7373650180de0 Reviewed-on: https://chromium-review.googlesource.com/732841 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#517405}
-
Gauthier Ambard authored
This CL adds a LocationBar to the ToolbarCoordinator. The ToolbarCoordinator is the delegate for the LocationBar so it needs to conforms to the LocationBarDelegate protocol. Bug: 784911 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1b7d2aa2c7813f5d50622594a8922beacb62e6f6 Reviewed-on: https://chromium-review.googlesource.com/771693 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#517404}
-
Maxim Kolosovskiy authored
[Password Generation] Notify PasswordGenerationAgent about focus change when the user triggers the context menu The generation agent tracks last password field that had focus. The field is used for user-triggered password generation. Before this CL, the generation agent wasn't notified about focus change when the user triggers the context menu (only when the user makes left click on the field). This CL propagates right click events to autofill. Bug: 784840 Change-Id: I31e1d793350f3bd9a6b8a3d61d9fcff6e61acdd8 Reviewed-on: https://chromium-review.googlesource.com/768811Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#517403}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/bb27c3a1483c..2c7f34c833b4 $ git log bb27c3a14..2c7f34c83 --date=short --no-merges --format='%ad %ae %s' 2017-10-09 oetuaho Initialize uninitialized GLSL arrays in a for loop Created with: roll-dep src/third_party/angle BUG=735497 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I7a25c9f6a48140ab7ed97cb8fb2ef3680c62ed54 Reviewed-on: https://chromium-review.googlesource.com/776642Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517402}
-
Sandra Sun authored
virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html is flaky. This patch temporarily disables the test, and a following test will update the test and enable it back again. Bug: 778696 Change-Id: Id27ccb14e0deda20e46478a237ed07962ad7eb5d Reviewed-on: https://chromium-review.googlesource.com/770599Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#517401}
-
Eric Seckler authored
Moves virtual time offsets and durations from int to float to allow specifying virtual time budgets with higher precision. Also adds a return value to Emulation.setVirtualTimePolicy, to report the absolute time when virtual time was first enabled. Bug: 646774 Change-Id: I37fc197f2e9565bf5540fc3787a288a7ac11fa7e Reviewed-on: https://chromium-review.googlesource.com/749948 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#517400}
-
kylechar authored
Try dropping two flags that shouldn't be needed. This only modifies the FYI trybot to confirm there are no tests that flake without the flags. TBR: sky@chromium.org Bug: 760181 Change-Id: I9918be273622e4acb016c56dbea3be32560e6040 Reviewed-on: https://chromium-review.googlesource.com/775753Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#517399}
-
Gauthier Ambard authored
- Creates a feature flag for Clean Toolbar. - Creates a ToolbarAdapter class that will be inited when the flag is enabled. - Adapter conforms to Toolbar protocol, but no-ops all implementation for now. - Adapter inits a CleanToolbarView controller and plumbs a dispatcher, WebstateList and ChromeBrowserState. - Adds a WebStateList parameter to BrowserViewControllerDependencyFactory. - Adds a convenience viewController getter to AbstractWebToolbar protocol. CL mainly done by sczs@. Bug: 784502 Change-Id: Ie0c1fce6062adc123e8226252b827281f96ff081 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/771713Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#517398}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ecd62a6cf65a..57e0828fade9 $ git log ecd62a6cf..57e0828fa --date=short --no-merges --format='%ad %ae %s' 2017-11-16 robertphillips Add backend GPU objects to fiddle app Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I11d1b0a39c14af81aa027ecf0f95c32a6cab6000 Reviewed-on: https://chromium-review.googlesource.com/776735Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517397}
-
Shivani Sharma authored
This is not a functionality change but a refactoring CL. In HttpCache::Transaction::WriterAboutToBeRemovedFromEntry we were setting entry_ to null only when result < 0. But there not need be any such condition and entry_ can be set to null for all cases since the transaction is being removed from the entry. This will help in all paths being consistent. It will also make sure that there is no path when a writer transaction is left with an entry pointer by mistake when the entry_ could have been destroyed. Bug: 784458 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4478964256ad3c7d12232cc4e5e793fc61f54cc3 Reviewed-on: https://chromium-review.googlesource.com/775138Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#517396}
-