GitLab

BUG=391888

Review URL: https://codereview.chromium.org/373973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281966 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392281
TEST=ChunkDemuxerTest.SeekCompleteDuringAbort

Review URL: https://codereview.chromium.org/374203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281965 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Signedness mismatch

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/372163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281964 0039d316-1c4b-4281-b951-d872f2087c98

We should really get rid of the plain |identifier|, rename
|identifier_wrapped| to |identifier|, and make that rule produce an
ast.Identifier (say).

But that change will be more involved.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/376023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281963 0039d316-1c4b-4281-b951-d872f2087c98

c/b/e/extension_view_host.h currently includes platform-specific UI code
and has a "temporary" exception in extensions/DEPS.

This CL removes the exception and resolves the layering by having the
platform-specific UI code provide an implementation of (static)
ExtensionViewHost::CreateExtensionView(). An abstract base,
ExtensionView, is added for use in the platform agnostic code.

This removes a lot of #ifdefs from extension_view_host.h which were in
the way while trying to get toolkit-views building on Mac for the
`chrome` target.

BUG=125846, 390755
TEST=Refactoring. Should be no functional changes for extension views
(e.g. Google Cast toolbar popup, Lookup Companion for Wikipedia) -
appearance and keyboard interaction should be unchanged.

Review URL: https://codereview.chromium.org/363233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281962 0039d316-1c4b-4281-b951-d872f2087c98

The bitstream has changed. Once the roll in
https://codereview.chromium.org/380493002
lands this test can be updated and re-enabled.

BUG=392309

Review URL: https://codereview.chromium.org/379563008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281961 0039d316-1c4b-4281-b951-d872f2087c98

This is a precursor CL to having MetricsStateManager be able to recover missing client_ids and restore old installation dates.

BUG=391338
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/370813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281960 0039d316-1c4b-4281-b951-d872f2087c98

Fixup after "Gamepad: don't notify about connected pads twice".
The CHECK(!g_gamepad_service) I added is failing because during
unit tests several instance can be created and destroyed.

R=bajones@chromium.org
BUG=391503

Review URL: https://codereview.chromium.org/372053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281959 0039d316-1c4b-4281-b951-d872f2087c98

This adds requireAsync, which returns a promise for the requested
module, allowing extension modules to asynchronously import AMD modules:

requireAsync('foo').then(function(foo) {
  // Use foo.
});

BUG=390397

Review URL: https://codereview.chromium.org/359413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281957 0039d316-1c4b-4281-b951-d872f2087c98

Using an ArrayBuffer as the argument to XMLHttpRequest.send() is no
longer deprecated in the latest WHATWG spec, according to
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26153#c1

This change removes the metrics used by the deprecation process. The
deprecation warnings will be removed in the Blink-side CL below.
https://codereview.chromium.org/373023002/

BUG=237493
NOTRY=true

Review URL: https://codereview.chromium.org/372223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281956 0039d316-1c4b-4281-b951-d872f2087c98

This change plumbs top level window resize notifications from X11 through to the WindowManager and to the GLSurface associated with the top level window. It's an incremental step towards adding support for window manager level layout management (see crbug.com/389785).

There's preliminary X11 Support for --start-fullscreen (don't try this) and --start-maximized command line arguments as well. This part of the patch could be broken out.


BUG=388524

Review URL: https://codereview.chromium.org/354933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281955 0039d316-1c4b-4281-b951-d872f2087c98

This change fixed the AppendMuxedCluster() so that it actually creates
proper multiplexed clusters instead of appending a sequence of
unmultiplexed clusters. Minor changes to a few test expectations were
needed to properly reflect what should happen when the blocks are
actually multiplexed properly.

Review URL: https://codereview.chromium.org/378863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281954 0039d316-1c4b-4281-b951-d872f2087c98

David's been doing a bunch of work in this area and is most qualified
to review changes.

BUG=none

Review URL: https://codereview.chromium.org/377023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281953 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233982
NOTRY=True

Review URL: https://codereview.chromium.org/368973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281952 0039d316-1c4b-4281-b951-d872f2087c98

Add option to bypass the data compression proxy if the request resource
type (as inferred by the renderer process) is not an image.

For background, see this design doc:

https://docs.google.com/a/google.com/document/d/1Kz92Fmw3lv_R-2aNvLp8jW9lkfKOZciTZtni2qQ_Adc/edit

BUG=391836

Review URL: https://codereview.chromium.org/332313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392288
TBR=benjhayden@chromium.org

Review URL: https://codereview.chromium.org/371363008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281950 0039d316-1c4b-4281-b951-d872f2087c98

A change to enable whitelisting for some applications incorrectly determined
whether or not the module being loaded was "llc" or "ld". This resulted in a
few regressions:
  * PNaCl applications can't use dev channel APIs
  * PNaCl applications see no effect with --enable-pepper-testing.

This change checks the correct field in NaClLaunchParams instead.

BUG=392277

Review URL: https://codereview.chromium.org/374223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392288
TBR=benjhayden@chromium.org

Review URL: https://codereview.chromium.org/381433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281948 0039d316-1c4b-4281-b951-d872f2087c98

Also combined two identiciation conditional blobs for android into one.
With this patch:
  - ozone files no longer built if use_ozone is 0.
  - media_unittests builds even if media_use_libvpx is 0.

Also removes an unnecessary test_support_perf dependency. Not sure how that ever built since having it means there are 2 main functions (one in test_support_perf and the other in ffmpeg_unittests.cc.

BUG=none

Review URL: https://codereview.chromium.org/377993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281947 0039d316-1c4b-4281-b951-d872f2087c98

Use the same prioritization for accelerator processing for the bookmark
shortcut when overridden by an extension as for when it is built-in to
the browser. Namely, allow WebContents key processing to take place
before extension accelerator processing.

Two changes are required:

1. Register the keybinding with normal priority rather than high
priority, so that FocusManager::OnKeyEvent does not process the
accelerator before the WebContents.

2. Don't process the accelerator for the extension in the
AcceleratorTarget subclasses. Instead, use the existing browser command
processing in BookmarkCurrentPage which delegates to the extension. This
is necessary so that the extension accelerator processing does not get
invoked while command execution is otherwise blocked in
BrowserView::PreHandleKeyboardEvent.

This change is for Views. Mac will be addressed in a separate CL.

BUG=389340

Review URL: https://codereview.chromium.org/360423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281946 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/379453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281945 0039d316-1c4b-4281-b951-d872f2087c98

This increases the emulated discardable memory limit to 512MB by
setting the soft limit to 32MB and the hard limit expiration time
to 1 second.

BUG=383361,372158

Review URL: https://codereview.chromium.org/342943008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281944 0039d316-1c4b-4281-b951-d872f2087c98

DownloadProtectionService is not used on Android. Android platform
provides such protection. Disable the service and related unit tests
in full safe browsing mode because TwoPhaseUploaderTest
doesn't have test server support on Android.
    
Also disable client side detection (CSD) service on Android,
which isn't used at this point.
    
Disable part of PhishingTermFeatureExtractorTest.ExtractFeatures
test due to http://crbug.com/392234. The test tests the code used
by CSD which is disabled on Android.

BUG=381896

Review URL: https://codereview.chromium.org/348083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281943 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/374203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281942 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca@chromium.org

BUG=391943

Review URL: https://codereview.chromium.org/374943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281941 0039d316-1c4b-4281-b951-d872f2087c98

This file went away in https://codereview.chromium.org/324773002

Review URL: https://codereview.chromium.org/372783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281940 0039d316-1c4b-4281-b951-d872f2087c98

Gets rid of the rest of CreateStringValue in non-test code in src/chrome/

BUG=160586
TBR=jar@chromium.org,dconnelly@chromium.org

Review URL: https://codereview.chromium.org/372103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281939 0039d316-1c4b-4281-b951-d872f2087c98

Currently we call clock_->SetTime() before we flush the renderers. This CL
moves it to right before we call StartPlayingFrom(start_timestamp_). This
makes it easier in a later CL to hide all clock logic into a new Renderer
implementation.

This CL also fixed the PipelineTest.Seek test. Originally we AddTextStream()
in the text which causes a TextRenderer::Read(). But we never satisfy or
abort that Read(). This caused TextRenderer::Pause() to never return the
completion callback. Therefore, the pipeline seek process never finishes.
This test was passing because we SetTime() before we DoSeek(). Now I moved
SetTime() after DoSeek() and this issue is exposed.

BUG=392259
TEST=All existing tests pass.

Review URL: https://codereview.chromium.org/377003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/376933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281937 0039d316-1c4b-4281-b951-d872f2087c98

'Downloading list of known revisions' step is faster. If the script is run with
--use-local-repo option, it will use "git svn find-rev <SHA1>" command to convert git hash 
to svn revision. This method is significantly faster than running the script
without git checkout.

Eg: Command to run:
time ./tools/bisect-builds.py -g 280588 -b 280590 --archive linux64 --use-local-repo

Output:
real	5m16.089s
user	3m50.326s
sys	1m1.190s

time ./tools/bisect-builds.py -g 280588 -b 280590 --archive linux64

Output:
real	10m51.194s
user	0m10.248s
sys	0m1.419s


BUG=390547
NOTRY=True

Review URL: https://codereview.chromium.org/378713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281936 0039d316-1c4b-4281-b951-d872f2087c98

It has no business being in there. Instead let Pipeline track duration
and cap interpolated time values as needed.

BUG=370634

Review URL: https://codereview.chromium.org/375003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281935 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/377693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281934 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/375703008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281933 0039d316-1c4b-4281-b951-d872f2087c98

Currently only hostname is given and it assumes IPEndPoint will have the port number. But
the assumption is wrong.

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/378013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281932 0039d316-1c4b-4281-b951-d872f2087c98

This change plumbs '.installing' and you will be able to access
an installing worker via 'navigator.serviceWorker.installing'.


BUG=379012
TEST=content_unittest --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py  http/tests/serviceworker/installing.html (http://crrev.com/372453002)
TEST=run_webkit_tests.py http/tests/serviceworker/waiting.html

Review URL: https://codereview.chromium.org/369013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/374163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281930 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/373013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281929 0039d316-1c4b-4281-b951-d872f2087c98

Many 32bit bots fail with "bits/predef" not found. Examples:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/builds/25814/steps/compile/logs/stdio
http://build.chromium.org/p/chromium/builders/Linux/builds/51225

BUG=360311
NOTRY=true
NOTREECHECKS=true
TBR=ajwong@chromium.org

Review URL: https://codereview.chromium.org/378183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281928 0039d316-1c4b-4281-b951-d872f2087c98

We weren't respecting the full timeout specified by the Reboot() method. And
apparently timing is different enough on the L-release preview that reboots
get stuck forever without the timeout.

BUG=389362

Review URL: https://codereview.chromium.org/375973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281927 0039d316-1c4b-4281-b951-d872f2087c98

* Only change parent id when normalizing entry. Use PutParentIdPropertyOnly() instead of PutParentId() because the latter resets predecessor and changes ordering.
* Don't create sync node for mobile bookmarks, which only exists with sync enabled.

BUG=385731

Review URL: https://codereview.chromium.org/374183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281926 0039d316-1c4b-4281-b951-d872f2087c98