- 18 Nov, 2020 40 commits
-
-
Robbie McElrath authored
This CL removes the fake FragmentActivity from SiteSettingsFragmentImpl and MediaRouteDialogFragmentImpl, replacing them with a Context that hosts the fragments instead. This is possible now that we've landed the bytecode rewriting that changes the return type of Fragment.getActivity() from FragmentActivity to Activity. Bug: 1123216 Change-Id: I98c2c07eb348d6833ca2e5d976110f7f29b5359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523751 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#828649}
-
Roman Sorokin authored
Instead of triggerring Gaia IME on the Gaia async load - which might happen even if the dialog is hidden. Also fixed ExistingUserControllerAuthFailureTest.CryptohomeMissing test which had a wrong expectations. Should show Gaia reauth page for the missing cryptohome user. Bug: 1140239 Fixed: 1150142 Change-Id: Idc722bfbd4f5b6418f6f2751b32e4bd9cc8ebf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536872Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828648}
-
Kim-Anh Tran authored
Bug: chromium:1110202 Change-Id: Iae6728a93d012704838306ff6824a41b399e24ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545306Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828647}
-
Peter Boström authored
Adds a missing checkbox->SetChecked() call to set the initial state on the views side. Bug: 1150027 Change-Id: I2fcf4d26ccd5358efbd7247c9533877da6643853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546188 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#828646}
-
Dan McArdle authored
Currently, DnsHTTPAttempt does not set the accept-encoding header. URLRequestHttpJob::AddExtraHeaders() has been stepping in, typically choosing "gzip, deflate, br". If the DoH provider honored this request for compression, it would effectively strip padding from the DNS response, which is a privacy leak. To be clear, I have not observed any DoH providers compressing their response. It just seems prudent not to request compression that we do not want. Bug: 1051615 Change-Id: I0cad558f76298b7ed58de70b70b1954cd42b88f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546476Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#828645}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6e353680e14310488251bd90249579e2d1a2d81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546263Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828644}
-
Robbie McElrath authored
This CL updates the bytecode modifications we perform on Fragment.getActivity() to have it call ContextUtils.activityFromContext( getContext()), and modifies compile_java.py to detect compilation errors related to this change and print a message pointing you to documentation about the bytecode modifications. A compilation error will now print: ../...../PasswordEntryEditor.java:144: error: cannot find symbol getActivity().getSupportFragmentManager(), ^ symbol: method getSupportFragmentManager() location: class Activity Expecting a FragmentActivity? See docs/.......md Bug: 1123216 Change-Id: I04016e30fba46c7d5c592e9ab2c5e5fa4c4cfde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508352 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#828643}
-
Matthias Körber authored
Change-Id: I9b1467d5f34d9381c8f944009b8f7511063fa30e Bug: 1150004, 1148749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544706 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#828642}
-
Hirokazu Honda authored
Original V4L2VideoEncodeAccelerator checks that the natural size of every VideoFrame with the dimension to be encoded. They must be the same in single cast case, but can be different in multicast case. The correct check is to compare it with the natural size of the first VideoFrame. In other words, the natural_size must be unchanged during encoding in the same VideoEncodeAccelerator instance. Bug: b:172223525 Test: meet.google.com on trogdor Change-Id: I3c21782b86cddaa788d4daf785793f73ec49db9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541942Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828641}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605657601-ef8205b17022e19a0e2738465ae8904490a43974.profdata to chrome-linux-master-1605679120-9f3476b66a4fad3e32e51dc995f45ad61750f20a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib50c20fbe04914b339a8de85585ddab0f6263066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546640Reviewed-by:
-
Maggie Cai authored
This CL updates the intent picker bubble view code to close and clear the existing intent picker bubble if the code trying to show another intent picker bubble. During testing, I found out that showing a new intent picker bubble when there is already a bubble showing will crash the browser. And there are suspected crash report that possibly relate to this. BUG=1148517, 853604 Change-Id: Ibf720342acf73602608278ca48f71435a9e61e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539808 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
Jaeyong Bae authored
This patch enables applying style to pseudo-elements when a property is defined on ::first-line. Currently, the properties on the ::after and ::before pseudo-elements are not applied on the first-line. So, we support kPseudoIdFirstLineInherited for the ::before/::after elements. Bug: 862423, 892983 Change-Id: I9474eece66921b8073091459cc254d5d1e27a9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517339Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#828638}
-
Antonio Sartori authored
The Content Security Policies code under services/network and the relative mojo types still misses support for a few CSP directives. We need to support all CSP directives in order to use it as a replacement to the Blink types, and also if we want to add Content Security Policies to the Policy Container (see attached bugs). This CL implements support for the directive 'require-trusted-types-for'. Bug: 1021462,1149272 Change-Id: I32880e8b3e35f1db4acf92a40e5d167a5f76870a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539906Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#828637}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2981f64209b4..aaee0317d442 2020-11-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I98f14a012a2f04a5164beb8b20754b100d1c3480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545367Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I4496e16926e171cbaa4bc68b92d39490a07c1cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531811 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#828635}
-
Alice Wang authored
This CL extracts an interface for the AccountPickerDelegate implementation to facilitate the account_picker package modularization in the future. Bug: 1149858 Change-Id: I9ddd1504da50e7feb71289a88831f1128537a28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542788Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828634}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605646753-b6e30e01e5beed347db34dbd1e74ff9cda422393.profdata to chrome-win64-master-1605657601-548324a0b0ab154da49d0cf44438a7e310772c46.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6719157e8e917c490d47b380d4cf4dfc2a446ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545051Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605625046-c4965d9d21c1b70d5de168d81c9caa876a4c61e1.profdata to chrome-win32-master-1605646753-d9430b027373a1a39dfc015bcf61461b4f7377b7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I12647a085f9a08f970825dbf22d3a5bc37734608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545436Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I47860f50a1428ebfe0b5276dc7ad58ad4512bc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532482Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#828631}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6aeb414df947..a1112b326a79 2020-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f2bc3b3edd6f to a0758a1aef12 (5 revisions) 2020-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4f96bf19941b to 2ffff6d024c7 (21 revisions) 2020-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 04515da400d5 to bb96f79d0e15 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Test: Test: Test: ExternalBufferTestES31.*VulkanTest: Test: ProgramPipelineTest.GenerateProgramPipelineObjectEXT* Change-Id: I36b49c2a75e5baa93dc34137c02ddf22def9064b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546264Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ibe63a58f20c536f639c7d5af640df4f37ce460c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494280 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#828629}
-
Kimiyuki Onaka authored
This interface receives the content of /sys/fs/pstore/dmesg-ramoops-0 for crash reporting of kernel crashes of ARCVM. The CL to send the ramoops file is ag/12946959. Bug: 139650101 Test: tast run arc.KernelCrash.\* Change-Id: Ie38d4054f5a4c4d0cb4d45e53d825bb1be21dbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505708Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Ramin Halavati authored
AnnouncementNotificationService unittest is updated to cover ephemeral Guest profile. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I319f7808365157108a984328bf65de586160c151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537692Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#828627}
-
Jiewei Qian authored
This reverts commit 38feda4d. Reason for revert: Observed test failure on Linux ChromiumOS MSAN build. use-of-uninitialized-value during CaptureModeController::Start() This CL makes significant changes to CaptureModeController. See https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21350 Original change's description: > capture_mode: Recording service lifetime and APIs > > This is a follow-up CL to handle requests made on the recording > service CL (https://crrev.com/c/2404145): > - The Record*() APIs of the service should provide the needed client, > video capturer, and audio stream factory, instead of exposing APIs > in the client so that anyone can bind to those capturers. > - The service is launched to handle video recording, and terminated > once recording ends, and all the chunks have been sent. > - A GPU crash is handled by ending the recording. > > BUG=1126586, 1147989, 1143411 > TEST=Manually, existing tests. > > Change-Id: I235cb1f9ee81dbbc42e21d0a222d32bcafa7a0fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536030 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828574} TBR=jamescook@chromium.org,dcheng@chromium.org,afakhry@chromium.org Change-Id: I80c5b69f89fa4eb32d3cbd065729d314d076ae4d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126586 Bug: 1147989 Bug: 1143411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546348 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#828626}
-
Luciano Pacheco authored
Change the initialization to wait for the background page to be ready, which means the load time data is available, to be able to check for the feature flag to launch different HTML files. This is a preparation to enable JS modules for Audio Player behind a feature flag. Add the feature flag AudioPlayerJsModules to util to be able to check in the Audio Player background before launching a new Audio Player window. Bug: 1133186 Change-Id: I9809a200c97a0d7a651f8012dd57904b2ef797ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546344 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#828625}
-
Jiewei Qian authored
This reverts commit 94737673. Reason for revert: Speculative revert for crash caused by https://chromium-review.googlesource.com/c/chromium/src/+/2536030 in Linux ChromiumOS MSan Tests. This CL depends on the above CL, which is being reverted. Original change's description: > capture_mode: Events ending video recording 2 > > In this CL, we handle: > - Imminent suspends. > - User switches in multi-profile sessions. > > BUG=1142994 > TEST=Added new tests > > Change-Id: I31da5c8cfb4f2648b2a34b206673eb59cce69f29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538590 > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828602} TBR=jamescook@chromium.org,afakhry@chromium.org Change-Id: Ic3b0df16d045708402db967727c59a4bb748a3b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546504Reviewed-by:
-
Yuta Hijikata authored
This reverts commit 91a94c7c. Reason for revert: To reland the original patch. Original change's description: > Revert "LaCrOS: Replace defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH)" > > This reverts commit crbug.com/1147680. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > LaCrOS: Replace defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) > > > > The change is mostly mechanical replacing defined(OS_CHROMEOS) with > > BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash > > with some special cases (For those cases please refer to > > http://go/lacros-macros). > > > > The patch is made in preparation to switching lacros build from > > target_os=linux to target_os=chromeos. This will prevent lacros from > > changing behaviour after the switch. > > > > Bug: 1052397 > > Change-Id: I95c93df05b77c03b3686d7bd9430dfde74229761 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461547 > > Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> > > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825716} > > TBR=ajwong@chromium.org,wez@chromium.org,thakis@chromium.org,hidehiko@chromium.org,ythjkt@chromium.org > > Change-Id: I73ddc678f970b05f1805fc728f6ceb6169cc2c71 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1052397, 1147680 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530958 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826100} Bug: 1052397 Bug: 1147680 Change-Id: I4d1578db0f9b7d3ea7df0472ee7fb1eeefac357c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543538Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#828623}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/868f530e6c5c..19da6ff2e87e 2020-11-18 yyanagisawa@chromium.org Roll out new goma client binary VERSION=208 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Iec9e29a823d8fa20facc3493b3502afe9f547c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546323Reviewed-by:
-
Nick Diego Yamane authored
Some compositors, including Exo, wait for the drag offer to be finished and destroyed before deciding when and whether to send dnd_finished or cancelled events [1]. This was not being done in ozone/wayland data drag controller, which led to dnd operations appear to be cancelled while they actually succeeded, affecting both lacros and linux desktop chrome. This patch fixes it by ensuring the offer is destroyed just after finish request for it is sent. Bug: 1141959 [1] https://source.chromium.org/chromium/chromium/src/+/master:components/exo/data_device.cc;l=133-144;drc=cbf5f453d15bf1a934dc0c8c479d9cffdb4261df R=msisov@igalia.com Change-Id: I2efed6b7035a654f618a077d13f03156a376b71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545647Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Maksim Sisov (GMT+2) <msisov@igalia.com> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#828621}
-
Eric Orth authored
Should be capable of handling strictly more cases than the previous logic in DnsResponse, because CNAME validation has less assumptions on the order of received records. Bug: 1147247 Change-Id: Ie1a515806a17d9ba95f2b368b274cf8356c796c9 Fixed: 640596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536270 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#828620}
-
rajendrant authored
The upcoming robots rules based subresource redirect check is asynchronous. So this CL refactors the should redirect image check to a callback. It should be noted that the callback can happen synchronously too, i.e., while the should redirect call is still executing. This CL handles both the cases. Bug: 1144836 Change-Id: I7afc42239e93834ab41128e9ebe611c1fef828ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533287 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#828619}
-
Asami Doi authored
This CL adds a WPT to check if `client.url` of a blob URL worker is a blob URL. The test succeeds when the PlzDedicatedWorker feature is enabled. Bug: 1017034 Change-Id: Ifd391512f2fa7213b7305d686ef3fb819ea5f620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526876 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828618}
-
Fergal Daly authored
A FrameTreeNode may be deleted during navigations (e.g. by an unload handler), NavigateFrameToURL needs to check for this before using the FrameTreeNode object. Fixed: 1149380 Change-Id: I0bc361f7cee17fda0cbef7ec8d2b40a777f3018f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543533 Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#828617}
-
Zain Afzal authored
As part of the go/bl-file-navigation-order effort, this CL dose 2 major things: * Removes openFile from the delegate in favour of existing on the ReceivedFileList. * Removes the concept of the media app only having 1 writable file. The idea that the media app only has 1 writable file was from a older security model which has since been abandoned. As such this CL updates the language used and variable names to better reflect how the media app actually works. Any file can be writable but there is only ever 1 "current" file which is what the app is displaying at any given moment. Part of this change also removes some legacy code which ensured that the "currentlyWritableFile" was always the first file in the list which is not required as the google3 side no longer expects this. Some test code relied on this assumption however and was updated accordingly as were some functions such as "firstReceivedItem" which were always expecting the first file in the file list to be the "current" file. Completely unrelated to this change is the addition of the "suppressCrashReports" codepath, which was added due to the fact that the "FileThatBecomesDirectory" test was triggering a invalid crash report causing the test to fail. This cl seemed to adjust the test timing such that this crash report was getting triggered before the test ended whereas it was ignored previously. BUG: b/151880563, b/165720635 Change-Id: I89c8ebfecab73dab4ffae0a77ceb434489a1b85b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524625 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#828616}
-
Yuki Shiino authored
To sheriffs: This patch may cause test failures on water falls. Please revert this patch in that case. This patch enables PartitionAlloc-Everywhere (aka PartitionAlloc as malloc) on Windows static release builds. Perf results: https://docs.google.com/document/d/16LuLl6wVlJ4w8rKQB7N9_emYiA1NJUm77HaApoFA2Jg/edit?usp=sharing Bug: 1121427 Change-Id: Ib0559095a305ba1c02b43669eedd771d6db8f667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543884Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#828615}
-
Luciano Pacheco authored
Change waitForWindow() test helper to support regex as `windowId` prefix. This is a preparation to allow apps to run with slightly different name in the HTML file to allow switching the HTML file to use JS module. Change the tests `OpenAudioFiles/FilesAppBrowserTest*` to use regex so it can run with `audio_player.html` and `audi_player_modules.html`. Preparing to convert Audio Player foreground page to run with JS modules. Bug: 1133186 Change-Id: I8f93000408f824c119e151e67c562fb4c9a25652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546303 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8f46ecc84fab..6aeb414df947 2020-11-18 reed@google.com add staging flags If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: Ib4f63fbc0ff2b53a914dd788783d99e29fad1964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545049Reviewed-by:
-
Shahbaz Youssefi authored
These tests run the pre-rotation AOSP mustpass list. This testing is currently done on Linux/Nvidia, Windows/Nvidia and SwANGLE. Bug: angleproject:4901 Change-Id: Iaef446559b40128462adfc92bc3a8370e1b529c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515093 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#828612}
-
Sebastien Marchand authored
This is not needed anymore. Change-Id: I610d2d8f195ab7fea15d6ac0eeec9bfe1c18275f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542363Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a388aa297c47..2981f64209b4 2020-11-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I67433c6bbf27b2416bea5de002fa4c044ec9b16a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545438Reviewed-by:
-
