- 11 Jun, 2020 40 commits
-
-
Sadrul Habib Chowdhury authored
Instead of looking at the timestamp to detect whether a frame presentation failed or not, look at the flags. BUG=1093875 Change-Id: I4938ad357236dc9e96fba99829fd201328a64552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237758 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#777498}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b50541b2d6c4..37e6ede65519 2020-06-11 jmadill@chromium.org Minor cleanup to PostSubBuffer sample. 2020-06-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 68b2e15ee016 to b919bc889e1d (3 revisions) 2020-06-11 cclao@google.com Vulkan: Initialize stencil ops with DontCare for color attachments 2020-06-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 8b92af3fd83f to 5fab7f82a548 (5 revisions) 2020-06-11 timvp@google.com Add android:exported to AndroidManifest.xml 2020-06-11 syoussefi@chromium.org Vulkan: Reduce ConvertVertex.comp variations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1084580 Tbr: cnorthrop@google.com Test: Test: CQ Change-Id: I3bd268522eae850655feed97b8e76af5be15c9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241557Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#777497}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ac937d03b0de..33c0c342f60b 2020-06-11 titovartem@webrtc.org Generalize NetworkQualityMetricsReporter to support multiple peers in test 2020-06-11 hbos@webrtc.org [Adaptation] Add ability to inject resources on the PeerConnection. 2020-06-11 xalep@google.com Add a way to force a frame to be sent from SurfaceTextureHelper If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic562ba2f8efc55e474422520600dda462a06ec7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242151Reviewed-by:
-
Mohamed Heikal authored
As a temporary fix for android webview regression b/157318961 this cl rolls back the protobuf lite runtime to 3.0.1 using the codegen plugin. Binary-Size: This is temporary and there is not really much we could do. Bug: 1093059, b/157318961 Change-Id: I2bbaf6d3b434221b667901423c4616e26a7550c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238872Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#777495}
-
Thomas Guilbert authored
This CL removes a few of the media .typemap files, moving them into the BUILD.gn file. This will help with consistency for the upcoming VideoFrameMetadata changes. Bug: 1059389 Change-Id: Ib4461498282add853d1b957cb41a12ec46f43433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239903 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#777494}
-
Shimi Zhang authored
Per Java style guide https://google.github.io/styleguide/javaguide.html#s5.3-camel-case, Javascript is better to be JavaScript. We will need to do a 3-way patching for the AndroidX boundary interface, so adding the addDocumentStartJavaScript() first in this CL, we need to remove the original addDocumentStartJavascript() after aosp/1329732 landed. We also upgrade the feature version to avoiding old AndroidX calling newer WebView or vice versa. Bug: 918065 Test: Covered by existing tests Change-Id: I1f5eee713d521ac5f480eee670f5f5be674de553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240283Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#777493}
-
rbpotter authored
- Add action menu providing options to download the original or edited PDF - Menu only is shown if there are edits and the "SaveEditedPDFForm" feature is enabled. Bug: 1078543 Change-Id: I561175c7608b747c15acd03123aca66761c8157c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213240Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#777492}
-
Andrew Grieve authored
The local one requires non-trivial build steps for it to work. Change-Id: I3e7a00f823f22fc280218c2b96c8eb17942319db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242153 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#777491}
-
Mitsuru Oshima authored
This looked working in native UI as textfield treat them as "select next/previous word".( See the bug for more details) Map directly to "select-to-home/end" shortcuts instead. This also fixes key report issue, where the strict mode rejected the repeated key. Bug: 1093430 Change-Id: I50a9113f3e97f3bc68ac5737a7fa6fa168511eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238782 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#777490}
-
Brian Sheedy authored
Strips the revision that's at the end of some ANGLE driver versions, as it changes frequently and can mess with inexact matching since each revision is treated as a separate trace in Gold. Also reports the driver vendor in the data uploaded to Gold. Bug: 1078914 Change-Id: I745993d8e7318c991cac2625718d5fd24b277a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241996Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#777489}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I38e6743a741d56d0f0993e24c56e86c219a03c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242038Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#777488}
-
Tim Volodine authored
Fix linkage error when compiling trichrome and monochrome apks with webview_includes_weblayer compile flag set to false. BUG=1093328 Change-Id: Ie170892a9ee39537f2127cc08c493d80d9569091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241971Reviewed-by:
-
Becca Hughes authored
Adds support for generating JS protos so that the Kaleidoscope UI can deserialize the protos from the Google API. The generated code needs the protobuf JS library which depends on parts of the closure library so we add that to third_party. BUG=1087037 Change-Id: Iee388e02f0ffcc0d1108a7f816da9f88c01fa58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218554Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#777486}
-
Brandon Goddard authored
This CL adds the showPositiveNumbers param to the gridHighlightConfig to allow the positions of grid labels for rows and columns to be calculated and sent to the overlay to be displayed during grid node highlights. This CL has a corresponding frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2231320 Standard labels: https://i.imgur.com/kwk8RAx.png Labels flipped due to low margin: https://i.imgur.com/AeeS5Nt.png Follow up work: additional parameter to allow for the calculation and display of negative row/column line offsets Bug: 1047356 Change-Id: Ib64f7d4eb65d43a7da612c83b727fbe19079ea3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230922Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#777485}
-
David Black authored
Bug: b:157689497 Change-Id: Ib69db89261ff4751d8722463060f21f24312f2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240306 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#777484}
-
Dave Tapuska authored
It was removed in crrev.com/cdf545cc BUG=1039695 Change-Id: I61c48272bd68a3b81145cdacf9c0a13b57d7cbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241939Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#777483}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77463bb18852..44de5e3f654c 2020-06-11 lovisolo@google.com presubmit_canned_checks.py: Ignore long TypeScript imports. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: If8a40f26d4c9846ff563ad9b36cd87ad85241722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241924Reviewed-by:
-
phillis authored
This adds last_launch_time_ to WebApp and setup setter/getter for the WebAppSyncBridge Bug: 1077642 Change-Id: I2eb28b20b5f2162bdefda23895ef7b042876bf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219400 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#777481}
-
Gang Wu authored
gfx::CreateSkBitmapFromJavaBitmap only support ARGB_8888 and ALPHA_8, So covert all the formats other than this two, then send to native. Bug: 1086990 Change-Id: I140d778725c8faf747d078a5f1dd82bd19b14164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240588Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#777480}
-
Garrett Beaty authored
Bug: 1091004 Change-Id: I930c792e961dad7d5e570d355dd64ee15f00151b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229661Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#777479}
-
Mason Freed authored
This adds the closedRoots option to the getInnerHTML() options bag, which allows serialization of provided closed shadow roots. This is described in the explainer at [1], but is not yet in the spec PR at [2], but I'll be adding it very soon. [1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#closed-shadow-roots [2] https://whatpr.org/dom/858.html#dictdef-getinnerhtmloptions Bug: 1042130 Change-Id: I921127842e9af5657e51f2199a2838c431aafed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239761 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#777478}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8cf15b94780dccd89f6f363898265f2a4e92c876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241460Reviewed-by:
-
behdad authored
This is a reland of 0063a381 The issue with original change is fix and run_perf_tests() method is simplified as the rerun argument is not needed as much. Original change's description: > Reporting the results only for initial run > > For reducing the time of representative perf test, we only rerun the failed stories > and update the results of the initial run based on the reruns. If the > failed stories pass in rerun, the output will be updated to report all > tests as passing. > > The current bug in these tests is that it would report values before > considering the rerun results. So even if the failed tests pass after > rerun, the output is still reporting the failures. This would cause the > return_code to be set as 1 (Failed/Interrupted) while the tests has > already passed via rerun. > > Bug: chromium:1091743 > Change-Id: I9eef7250bc2dad649fef49cf9a5ccd8195190f80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232603 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775682} Bug: chromium:1091743 Change-Id: Iceeeff232f4740d25dcc2799f6e329399e0101ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239534Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#777476}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/30fcc49adc0b..d46dd079207b 2020-06-11 khokhlov@google.com Perfetto tracing agent: Add ftrace CPU scheduling details 2020-06-11 cbruni@chromium.org [wp_page_replay_go] Use go modules If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1032253,chromium:839068 Tbr: sadrul@google.com Change-Id: I80925967d7e56e0b4a66bab24fee680f9581a56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241556Reviewed-by:
-
Tibor Goldschwendt authored
Adds support to submit a query by pressing <ENTER> or <SPACE>. We accomplish this by installing a voice search overlay wide keydown listener to process this keyboard shortcut. Unfortunately, the same keyboard shortcut also triggers the close button, which was the first element focused upon opening the overlay before this CL. To submit a query instead of closing the dialog by default, this CL adds a hidden focusable div that captures the focus upon opening the dialog. This CL also turns the close button into a cr-icon-button, which makes the UI more consistent and makes the button swallow keydown events (that way we don't both submit a query and close the overlay with <Enter> and <SPACE>). + Add <SPACE> keyboard shortcut to trigger links. + Fix bug where any keyboard shortcut other than <CTRL> + <SHIFT> + <.> closes the voice search overlay. Fixed: 1088482 Change-Id: I0c7c40d88503a3ae0d7343a077f8b086968e470b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238781Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#777474}
-
Weilun Shi authored
Removed unused log_manager() function in MetricsService class and use LogStoreForTest instead of the protected log_store() in the MetricsServiceTest. Bug: 1034679 Change-Id: Ib5b3bd252fc867f0602a790d19bdec28103941be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238343Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#777473}
-
Jarryd authored
Change-Id: I61bd62d14c82c388915f712d7309f0b4f99bc715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238855 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
-
dpapad authored
compress="gzip" is (as of r761031) the default behavior for HTML/CSS/JS/SVG files, and therefore there is no need to explicitly specify it. In this CL updating src/content/. Bug: 1068407 Change-Id: Ie01052feb892d9a72507a528f7a324270b5a44bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240107Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#777471}
-
Ben Pastene authored
All tests should now be running in pools with task templates that handle this automatically. So there's no need for mb to do any of this itself. Bug: 812428 Change-Id: Idb210a6abe942415dff5a39402cce485f9a17373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241180Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/25ab22e43971..526424e2cc47 2020-06-11 oksamyt@google.com Merge "[trace processor] Add WebView CPU usage metric" 2020-06-11 lalitm@google.com tp: rename _annotations suffix to _event If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib44708a0da5e9381e0c28b1521a80c6a6166a164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241920Reviewed-by:
-
Qiran Gong authored
Add media::cast::FrameId, which handles the following messages: CastMsg_RtcpCastMessage, CastMsg_RawEvents, CastHostMsg_InsertFrame, CastHostMsg_CancelSendingFrames, CastHostMsg_ResendFrameForKickstart, CastHostMsg_AddCastFeedback. Add media::OverlayInfo, which handles the following message: AcceleratedVideoDecoderMsg_SetOverlayInfo. Add media::VideoPixelFormat, which handles the following message: AcceleratedVideoDecoderHostMsg_ProvidePictureBuffers. Add blink::WebDeviceEmulationParams::ScreenPosition, which handles the following message: WidgetMsg_EnableDeviceEmulation. Add util::StrongAlias<extensions::ActivationSequenceTag, int>, which handles the following messages: ExtensionHostMsg_DidStartServiceWorkerContext, ExtensionHostMsg_DidStopServiceWorkerContext. Add base::UnsafeSharedMemoryRegion, which handles the following message: GpuCommandBufferMsg_RegisterTransferBuffer. Change-Id: I2a36ab93185effc7090f53705d261e86a7090b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237990 Commit-Queue: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#777468}
-
Kevin Ellis authored
Previously, we had a regression where changes to the state of an animation were not always picked up by the compositor. Some WPT tests were written to verify that the compositor picks up the changes; however, these tests are prone to flaking due to the need to take a screenshot while the animation is running to verify the behavior. This patch does not address the flakiness of the ref tests, but ensures proper unit test coverage in the event that the ref tests get disabled. Followup patches will address flakiness in the WPT tests. Bug: 1093812 Change-Id: Iab5c6853e86f0b86cf554b803bbb6c3ab47725c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232800 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#777467}
-
Alex Turner authored
Specifically we add the following high-level metrics: PageLoad.Clients. Ads.AllPages.PercentNetworkBytes (percentage of bytes that are ads) and PageLoad.Clients.Ads.AllPages.NonAdNetworkBytes (total non-ad bytes). These metrics will aid tracking the accuracy of AdTagging over time and also aid in understanding the impact of any proposed cl on AdTagging. Bug: 1090494 Change-Id: Ie912cec6782a8aa883bc3a38db7fa4e48c0067b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226064 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#777466}
-
Xiaohan Wang authored
Currently DecoderBuffer::AsHumanReadableString() prints all fields by default which is not necessary in most debugging scenarios. This CL adds a verbose option so we can control what to display. By default verbose is false. Change-Id: If0478b73e9a08b23323a2a5f282f61d7d7a9fb70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229590Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#777465}
-
Lan Wei authored
Because of Linux memory leak, pointerevent wpt tests pointerevent_boundary_events_at_implicit_release_hoverable_pointers.html pointerevent_releasepointercapture_onpointerup_mouse.html and pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked .html are flaky, we should finish the test in the actions promise's callback to guarantee the actions are all executed before the test finishes to avoid memory leak. Bug: 998948, 1025944 Change-Id: I1ba6cbd8029a6093eefc29c287af86c80cb45ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203144 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#777464}
-
Piotr Bialecki authored
Anchor creation based off of hit test result was incorrectly using unstable native origin (planes' origins may change diametrically from frame to frame) - this CL fixes the issue. Additionally, hit test logic did not correctly treat hit test results as computed based off of plane intersection - the issue did not cause any problems with hit test API, but is problematic for anchor creation API. Changes: - plane-attached anchor creation now accepts native origin information and pose relative to passed in native origin - this is done to ensure that anchor creation uses a frame of reference that is stable w.r.t. the environment (plane pose is not a correct choice as it changes when plane extents are changing) - fixed an issue in ArCoreImpl::RequestHitTest() - it would not report results as computed based off of a plane even if they were - mojom's hit test result now uses pose instead of matrix - pose is directly provided by ARCore SDK and has smaller cognitive load as it does not require considering column-major vs. row-major memory layouts - IDL - anchor creation based on hit test result and on plane no longer accepts initial pose since the spec draft has changed - initial pose was considered confusing and unnecessary since it did not extend the capabilities of the API - JS-exposed anchor creation from XRHitTestResult and from XRPlane no longer accepts an XRRigidTransform - the spec draft was already changed to account for this All other changes (parameter renames, comment updates, fixing call sites to account for parameter count changes, etc.) are related to the above major changes. Change-Id: I5acb872c5a9d9003f1f85173edd82e6e6fa002bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236592 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#777463}
-
David Black authored
Previously, if the AssistantBetterOnboarding feature was enabled, the onboarding view was always shown. In a follow up CL, we will only conditionally show the onboarding view, and otherwise showing our greeting. This CL prepares for that. Bug: b:157689497 Change-Id: Ice53901c04c35170f106b0acc3230072f2608839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240019 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Eugene But authored
This is a follow up cleanup which will allow removing some GN targets. Original CL broke downstream chrome for iOS tree. A change has been landed downstream to prevent the breakage after reland: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/3102155 Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2232862 TBR: yuweih@chromium.org Bug: 1017165 Change-Id: Ibc8504b9077c59a4cb1da5fbe746106758fdcaf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241336 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#777461}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/36248741c28b..88183900a5bd 2020-06-11 johnstiles@google.com Honor return value of `registerChildProcessor` when creating child FPs. 2020-06-11 egdaniel@google.com Fix calling finishedProcs that are null in backend surface APIs. 2020-06-11 fmalita@chromium.org [skrive] Initial binary reader plumbing 2020-06-11 ethannicholas@google.com Fixed SkSL optimization issue 2020-06-11 bungeman@google.com Delete .a file before writing static library. 2020-06-11 johnstiles@google.com Fetch clang-format automatically when compiling .fp files. 2020-06-11 michaelludwig@google.com Implement computeFastBounds in SkLocalMatrixImageFilter 2020-06-11 herb@google.com move test op creation to GrTextAtlasOp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Id75d9f102e55ee8ce4a44fbbb51017ee2cd18f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241919Reviewed-by:
-
Lei Zhang authored
Extend PrintPreview.DestinationAction and PrintPreview.PrintSettingsUi histograms since they remain useful. Add a second owner. Bug: 1089322 Change-Id: I558150b2700c21e81a559ea334b63aa4f662e854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239200Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
