- 29 Nov, 2018 40 commits
-
-
Sylvain Defresne authored
IdentityManagerObserverBridge provides a bridge from C++ to Objective-C for IdentityManager::Observer but lacked methods that were recently added. Fixes this by adding missing overrides. Bug: none Change-Id: I5004e23b18e043a8d8bd5736d394aa1d8222a72d Reviewed-on: https://chromium-review.googlesource.com/c/1354920 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#612182}
-
Antonio Gomes authored
This CL extends the existing simple IdentityTestEnvinroment ctor by supplying an optional TestingPrefServiceSyncable instance. This way tests could still tweak the PrefService instance they hold and other objects, eg PO2TS, SigninManager, AccountTrackerService would be hidden from the tests. BUG=908810 Change-Id: If8257ddc6bdc22481d3530197025592264ffe256 Reviewed-on: https://chromium-review.googlesource.com/c/1351160 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#612181}
-
Morten Stenshorne authored
Only internal data type differences and such things. TBR=atotic@chromium.org,kojii@chromium.org Bug: 889721, 835484 Change-Id: I1b46bb16b5ab39da52ad7b20241441f7a99d0fa2 Reviewed-on: https://chromium-review.googlesource.com/c/1354925Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#612180}
-
Kush Sinha authored
A series of async steps need to be performed for migrating existing users to Chrome OS Account Manager. Please see the attached bug for a Design Document. Add a utility for sequentially running a series of async migration steps, which are run only if the previous step was completed successfully. This utility allows us to specify the migration steps in a declarative style with clear dependencies instead of creating a complex web of callbacks. Bug: 904128 Test: unit_tests --gtest_filter="*MigrationRunnerTest*" Change-Id: I5bd5ddc1fb59060577e535fb115bd4689adfaaa7 Reviewed-on: https://chromium-review.googlesource.com/c/1329964Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#612179}
-
Andrew Grieve authored
Bug: 846432 Change-Id: Iac715f99198a10409018c208588211252aa53e53 Reviewed-on: https://chromium-review.googlesource.com/c/1352819Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612178}
-
Eric Willigers authored
CSS Selectors 4 allows :not to accept selector lists. There is a proposal for invalid complex selectors in the list to be ignored (instead of causing the whole selector to fail parsing. This would affect :is :where :nth-child :nth-last-child, :has and :not, with the main compatibility risk being :not. https://github.com/w3c/csswg-drafts/issues/3264 We add use counters to estimate the Web compatibilty risk. BUG=568705 Change-Id: I708d48d626a6e61cc8c1076d40d2c33bb19496e3 Reviewed-on: https://chromium-review.googlesource.com/c/1354751Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#612177}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/70282bd00ee9..7b49412a6e09 git log 70282bd00ee9..7b49412a6e09 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 primiano@google.com Merge "Minor non functional refactorings to ftrace parser" Created with: gclient setdep -r src/third_party/perfetto@7b49412a6e09 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7be7141fa34ea734fc30e4aefce96f29aeac9d56 Reviewed-on: https://chromium-review.googlesource.com/c/1354983Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612176}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 37ad5a5c. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I5e2f949b1bd958e24f95be080051fe2017d64ec9 Reviewed-on: https://chromium-review.googlesource.com/c/1354960 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612175}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a09745d8346d..f9b825600fd5 Created with: gclient setdep -r src-internal@f9b825600fd5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic7f1bd30e214b2bc083ba482b6bd31179142422a Reviewed-on: https://chromium-review.googlesource.com/c/1354985Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612174}
-
Takuto Ikuta authored
Took from this revision. https://chromium.googlesource.com/infra/infra/+/f140d0c3c6acecf6ca6cd8d66ddad9421158ab40 Bug: 868878, 894045 Change-Id: I0ad0a837b3f1b036611aeca912eade69abb2d1b6 Reviewed-on: https://chromium-review.googlesource.com/c/1354754Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612173}
-
Arthur Sonzogni authored
This fixes https://crbug.com/872284 and adds a regression test. The bug can be triggered when the PDFIframeNavigationThrottle cancels the PDF download. There was some code in ResourceLoader made to ignore the cancellation. It causes the net socket to never been released. Only 6 network socket can be used on a website, so there was some kind of resource starvation. Bug: 872284 Change-Id: I9fcaf8da409da38e0cb4b2e9c6ad57bb2fab911c Reviewed-on: https://chromium-review.googlesource.com/c/1348036 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#612172}
-
Dominik Röttsches authored
Shaping code relies on feature detection to determine whether the font has small-caps support or not. If not, small capitals are synthesized from uppercased letters with scaled-down font size. Add feature detection for AAT fonts on Mac. Now the shaping code can enable the built-in small-caps glyphs for a set of system font that have them. Tests: open_type_caps_support_test.cc unit test for feature detection, fast/text/small-caps-aat.html layout test. Bug: 900955 Change-Id: I9bb31719b0a1b5e81a428030cfdeaf91b8e6d17e Reviewed-on: https://chromium-review.googlesource.com/c/1353927 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Behdad Esfahbod <behdad@chromium.org> Cr-Commit-Position: refs/heads/master@{#612171}
-
David Roger authored
- SigninClient duplicates API that is already in SigninManagerBase::Observer. This CL removes these functions from the SigninClient and uses SigninManagerBase::Observer instead. - Several SigninClient implementations depend on SigninErrorController, but this dependency is conceptually wrong. This CL moves the corresponding code out of SigninClient implementations. Change-Id: I4a09e40a204713ba3cb8ea76e65c46228fc3923d Bug: 836212 Reviewed-on: https://chromium-review.googlesource.com/c/1346950 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
David Roger authored
The previous round of metrics collection showed that the failure rate for ListAccounts is very high. This high failure rate is partially caused by the retry mechanism. This CL adds information about individual retries, so that we can get more information: - see which errors are fixed by retries and which are not, - confirm that retries are indeed the cause for the high failure rate. Bug: 876306 Change-Id: If26b724dedc7aad334738068a20f62c6b3da31a3 Reviewed-on: https://chromium-review.googlesource.com/c/1352252 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#612169}
-
Kent Tamura authored
html.css, quirks.css, and theme*.css are parts of HTML element implementation. So they should be in core/html/ for better modularity. Also, this CL renames some of their basenames: - themeChromiumAndroid.css -> android.css - themeChromiumLinux.css -> linux.css - themeMac.css -> mac.css - themeWin.css -> win.css - themeWinQuirks.css -> win_quirks.css - themeInputMultipleFields.css -> input_multiple_fields.css This CL should not have any user-visible behavior changes. Change-Id: Iff9f5547200f87167c7751c941fe11167345d128 Reviewed-on: https://chromium-review.googlesource.com/c/1351194 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612168}
-
Christian Dullweber authored
The test is still flaky because the previous fix incorrectly ignored "Calculating..." messages. The actual message is "Calculating…" with a fancy ... Bug: 909690 Change-Id: I6e5bc0546534e1ab43772e5a6c33ecfe27b92459 Reviewed-on: https://chromium-review.googlesource.com/c/1355041Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#612167}
-
Javier Ernesto Flores Robles authored
Adds histograms for: How many autofill suggestions exists when a user opens passwords manual fallback. How many autofill suggestions exists when a user opens credit cards manual fallback. How many autofill suggestions exists when a user opens profiles manual fallback. Bug: 905653, 845472 Change-Id: I114fee74ea1f78a8fe08b3e8a373fa8946e0d7ae Reviewed-on: https://chromium-review.googlesource.com/c/1352166 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612166}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e5027d7b45f8..a09745d8346d Created with: gclient setdep -r src-internal@a09745d8346d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4ca05c6e4b77011923762ddc1e72b7d657d91d59 Reviewed-on: https://chromium-review.googlesource.com/c/1354982Reviewed-by:
-
Matt Menke authored
This reverts commit e369ab31. Reason for revert: The CL in question did not cause issue 869227, which is a pre-existing infra problem. Original change's description: > Revert "Generalize for non-address results in HostResolverImpl" > > This reverts commit 07ee5f0f. > > Reason for revert: StartTestServer(SpawnedTestServer::SSLOptions()) > started failing after this CL > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17143 > > [ RUN ] SSLClientSocketReadTest.Read_WithSynchronousError/0 > [56283:775:1128/182253.758810:39802574526192:ERROR:local_test_server_posix.cc(79)] poll() timed out; bytes_read=0 > [56283:775:1128/182253.758860:39802574568901:ERROR:local_test_server_posix.cc(167)] Could not read server_data_len > [56283:775:1128/182253.760826:39802576544202:ERROR:ssl_client_socket_unittest.cc(830)] Could not start SpawnedTestServer > ../../net/socket/ssl_client_socket_unittest.cc:1532: Failure > Value of: StartTestServer(SpawnedTestServer::SSLOptions()) > Actual: false > Expected: true > Stack trace: > 0 net_unittests 0x000000010f41750b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 > 1 net_unittests 0x000000010f416ec9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 > 2 net_unittests 0x000000010e7d9239 net::SSLClientSocketReadTest_Read_WithSynchronousError_Test::TestBody() + 585 > > [ FAILED ] SSLClientSocketReadTest.Read_WithSynchronousError/0, where GetParam() = false (10083 ms) > > Original change's description: > > Generalize for non-address results in HostResolverImpl > > > > Now extensively using HostCache::Entry internally (but only internally > > to preserve flexibility of HostCache) as a generalized results > > container within HostResolverImpl. Added some needed setter/merge > > functionality to Entry for that purpose. Many methods within the > > resolver changed to use Entry for consistency even if they only ever > > deal with address results, eg ResolveAsIP(). > > > > Slightly modified results port-setting functionality to only set port > > to an input port (from |host.port()|) if the port in the results is 0 > > (where before it would set it whenever it wasn't equal to the input > > port). This will be necessary eg for SRV support where DNS provides a > > specific port that needs to be maintained in the results. Also cleaned > > up the port setting to consistently only ever happen just before > > setting results on the RequestImpl and having 0 or a DNS-provided port > > until then. > > > > Bug: 846423 > > Change-Id: I679c0ac915e0f81b49adb5ee769f250be49c9c90 > > Reviewed-on: https://chromium-review.googlesource.com/c/1340835 > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Commit-Queue: Eric Orth <ericorth@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#611963} > > TBR=mmenke@chromium.org,ericorth@chromium.org > > Change-Id: Icc3121b6f6de985fb64ed9b2bee4951faf5378a3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 846423 > Reviewed-on: https://chromium-review.googlesource.com/c/1354746 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612052} TBR=mmenke@chromium.org,ortuno@chromium.org,ericorth@chromium.org Change-Id: Ie2f80d423a5370f976918357b32b8eb772c4f57c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846423 Reviewed-on: https://chromium-review.googlesource.com/c/1354267Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#612164}
-
David Roger authored
On iOS the testing factories are built after initialization, which causes their re-creation. This causes crashes because the destruction happens in a random order and doesn't follow the dependencies. The fix is to add the testing factories before initialization, so that factories are not destroyed. This crash does not happen now, but prevents adding more factories that return true in ServiceIsCreatedWithBrowserState(). Change-Id: I6603ff6cbfecff645b23d879693e6524c7074c0e Reviewed-on: https://chromium-review.googlesource.com/c/1353943 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#612163}
-
Yi Su authored
CollectionViewController to ChromeTableViewController. This CL migrates the PasswordDetailsCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. Bug: 894791,751311 Change-Id: I3f76e28c1e42720d4d316b2a9018c01313646fbb Reviewed-on: https://chromium-review.googlesource.com/c/1346951Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612162}
-
Clemens Arbesser authored
This will allow scripters to use this info for more informative messages to the user, see b/120009771. Bug: 806868 Change-Id: I5b4003961a13e19159313b65529d3c33f1cf1c41 Reviewed-on: https://chromium-review.googlesource.com/c/1354003Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#612161}
-
CJ DiMeglio authored
This CL makes it such that the volume level is read out as a percentage in aria. This CL also amplifies how the accessibility information is given to aria, by setting attributes instead of explicitly creating accessibility nodes. Bug: 905024 Change-Id: I0ee5a91215669f39c7394d3c8f113ae83a74cf00 Reviewed-on: https://chromium-review.googlesource.com/c/1337298Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#612160}
-
Mario Sanchez Prada authored
Implement the following methods at the same time, so that we can also provide decent unit tests that would require of all of them to make sure functionality works as expected: * LegacyStartSigninWithRefreshTokenForPrimaryAccount() * LegacyCompletePendingPrimaryAccountSignin() * LegacyIsPrimaryAccountAuthInProgress() * LegacyPrimaryAccountForAuthInProgress() Also, PrimaryAccountMutatorTests unit tests for each of those methods as part of this CL, based on those from SigninManagerTest, including a new test for ClearPrimaryAccount (i.e. ClearPrimaryAccount_NotSignedIn) to check that it reports FALSE when there is neither a primary account nor an authentication process ongoing (now we can finally implement that). Bug: 906058, 906059, 906063, 906064 Change-Id: I2164c867f35020806225da4e69659364c3429a92 Reviewed-on: https://chromium-review.googlesource.com/c/1342559 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Vadym Doroshenko authored
Bug: 831123 Change-Id: I95c30a908da22585f632ba63d90cf60244287df6 Reviewed-on: https://chromium-review.googlesource.com/c/1354005 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612158}
-
Jérôme Lebel authored
kUseMultiloginEndpoint can only be enabled if kWKHTTPSystemCookieStore is enabled. CookieManager::SetCanonicalCookie() fails to store the cookies. Bug: 902584, 892130 Change-Id: If3ba635f031e7de830c87b7a97fd262a9e6e2cee Reviewed-on: https://chromium-review.googlesource.com/c/1352324 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ac71e34d4ad1..813bfbd06112 git log ac71e34d4ad1..813bfbd06112 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 hao.x.li@intel.com Collect device information on Metal Created with: gclient setdep -r src/third_party/dawn@813bfbd06112 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I80c29ac9dca9a474ee22a8f9917dfd2fef3f1cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1354981Reviewed-by:
-
Mike Reed authored
TBR=vmpstr Bug: skia:2664 Change-Id: Ie4d397f2cc3f997abed9c4614a96333f5956c805 Reviewed-on: https://chromium-review.googlesource.com/c/1351819 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#612155}
-
Greg Thompson authored
BUG=856169 TBR=grt@chromium.org Change-Id: I2e9cf461d6003b2e1a85129ad52b8d2157685b15 Reviewed-on: https://chromium-review.googlesource.com/c/1354449Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#612154}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/275e8750e3d2..e6305f38b584 git log 275e8750e3d2..e6305f38b584 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2c0d6a9404cd..7310da33bc7a (1 commits) Created with: gclient setdep -r src/third_party/skia@e6305f38b584 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I8cfabd4740f7238ceb47192a9690899b3cd883a5 Reviewed-on: https://chromium-review.googlesource.com/c/1354980Reviewed-by:
-
Arthur Sonzogni authored
This is similar to: * https://chromium-review.googlesource.com/c/chromium/src/+/1323109 * https://chromium-review.googlesource.com/c/chromium/src/+/1329163 * https://chromium-review.googlesource.com/c/chromium/src/+/1323070 * https://chromium-review.googlesource.com/c/chromium/src/+/1323092 On request success, it makes the MimeSniffingURLLoader to always send a response's body datapipe, even when it is empty. It also adds a DCHECK to ensure the |source_url_loader| is also behaving the same way. Bug: 831155,826868 Change-Id: I468a24c31142cb0a8d646cd09928f7b03680d779 Reviewed-on: https://chromium-review.googlesource.com/c/1350874Reviewed-by:
-
Adam Rice authored
Allow WritableStream objects to be transferred with postMessage(). Add support for serialization and deserialization of WritableStreams. WritableStreams share the stream_ports array with ReadableStreams, using indexes starting after the last ReadableStream in the array. As with ReadableStreams, the functionality is hidden behind the TransferableStreams blink feature, which much be enabled explicitly for it to work. This CL only contains rudimentary tests. In-depth layout tests will be added later. BUG=894838 Change-Id: I237f740e4750faa5976481baa161c85bacd51687 Reviewed-on: https://chromium-review.googlesource.com/c/1353034Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7920c70b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I57bb9d3b5db64b6914160a8c9d81d1fe35e04936 Reviewed-on: https://chromium-review.googlesource.com/c/1354496 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Noel Gordon authored
util.bytesToString fails with an exception that prevents the file list from drawing for Hindi language users. The exception is due to invalid translation console translations of the SIZE_KB, SIZE_MB strings [1]. Mitigation: process these loadTimeData values before use. Convert them to valid values (prevents the JS exception) and do this once only. [1] The $1 portion of these message strings should not be touched, but translation console is effectively converting them to $one in Hindi. Bug: 908767 Change-Id: Ib5d741e501c3cf00e232b59366050778d732d906 Reviewed-on: https://chromium-review.googlesource.com/c/1353044 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#612149}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b313ee575f99..e5027d7b45f8 Created with: gclient setdep -r src-internal@e5027d7b45f8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3be0a9ee1a12d27ef167f9447724992dd43da4bb Reviewed-on: https://chromium-review.googlesource.com/c/1354637Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7310da33bc7a..5f01324fb627 git log 7310da33bc7a..5f01324fb627 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 syoussefi@chromium.org Vulkan: Allow descriptor pool to allocate different types Created with: gclient setdep -r src/third_party/angle@5f01324fb627 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I16d48555a73677772b397b33885274eeb65426af Reviewed-on: https://chromium-review.googlesource.com/c/1354979Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I0ff6ff3fc2c4e01b1148d92ae87d0a031074c039 Reviewed-on: https://chromium-review.googlesource.com/c/1353882Reviewed-by:
-
Greg Thompson authored
This reverts commit 60efce52. Reason for revert: Lots of tests are failing with a segfault in SideSwipeController updateNavigationEdgeSwipeForWebState; e.g., https://chromium-swarm.appspot.com/task?id=4176d009da672b10&refresh=10&show_raw=1 Original change's description: > [ios] Enable WebKit based side swipe with Chrome side swipe. > > Enables WebKit based side swipe, and only enables Chrome side swipe when the > page swiped page is to or from an NTP. > > Change-Id: I892f7074252ee04b2d0b337ebd744f3ba9388e27 > Reviewed-on: https://chromium-review.googlesource.com/c/1350192 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612042} TBR=justincohen@chromium.org,eugenebut@chromium.org,danyao@chromium.org Change-Id: I00da0d289307497cdc2f49ab4b6336316d345259 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1355039Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: I285bf68f024899c169b87129f988b7a5f82c1cd3 Reviewed-on: https://chromium-review.googlesource.com/c/1354749 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612144}
-
Eric Seckler authored
The ETW tracing agent isn't currently used widely. In light of the move towards perfetto, we've decided to remove it until we can replace it with a new data source (which would provide more selective information about the OS's scheduling behavior, e.g. chrome's CPU time slices). Developers can still export chrome's trace events into ETW for the time being. Bug: 900603 Change-Id: Ie482f4377359f54e166636af65a94dac69767b45 Reviewed-on: https://chromium-review.googlesource.com/c/1341989 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#612143}
-
