- 11 Nov, 2017 40 commits
-
-
Benjamin Pastene authored
See https://chromium-swarm-dev.appspot.com/task?id=39bce1ee054c5e10 R=jbudorick@chromium.org Bug: Change-Id: If635938d30fbe2b527ef972d5c4896b599f42642 Reviewed-on: https://chromium-review.googlesource.com/764575Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#515796}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fbb038b8..47bc08df Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3f73e5981d0087b3421a56c01614cad40d9d5881 Reviewed-on: https://chromium-review.googlesource.com/764830Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515795}
-
Jacob Dufault authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/726240, which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/755333. TBR=jamescook@ TBR=xiyuan@ Bug: 719015 Change-Id: I55c770dcdeb338f43ad409d502aa27c80f4e65eb Reviewed-on: https://chromium-review.googlesource.com/764400 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#515794}
-
Ryan Sturm authored
PreviewsUserData is a class that lives on the URLRequest and is copied to the NavigationHandle via ChromeNavigationData. Bug: 783917 Change-Id: I7a86243bf11d764209db8bd5b8fe46423651446b Reviewed-on: https://chromium-review.googlesource.com/752623Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#515793}
-
Yuzhu Shen authored
So that the resource could be used from both WebUI and extensions. BUG=699569, 718047 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If2ce60b15e0351aba801746cd863e5a2b9e85485 Reviewed-on: https://chromium-review.googlesource.com/762393 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515792}
-
Yuly Novikov authored
This is a reland of 46aa3c25 Crashing test was fixed by https://chromium-review.googlesource.com/764688 Original change's description: > Run angle_perftests on Nexus 5X Perf bot > > Also build angle_perftests on Android builders > > BUG=675997 > TBR=eyaich@chromium.org,dpranke@chromium.org > > Change-Id: I9e73e19599e3cc435f02960839f2e780402d0188 > Reviewed-on: https://chromium-review.googlesource.com/752582 > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515462} TBR=eyaich@chromium.org,dpranke@chromium.org Bug: 675997 Change-Id: I3f9617df32186d1a80937e3f6598af75a54e851b Reviewed-on: https://chromium-review.googlesource.com/764747Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#515791}
-
Joel Einbinder authored
Bug: 668953 Change-Id: I33337f5297c5e17c24540355799d14079401cdfb Reviewed-on: https://chromium-review.googlesource.com/761261Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#515790}
-
Lucas Garron authored
The committed interstitials project uses SSLErrorNavigationThrottle to watch for failing requests that are certificate errors. It defers such requests, and then cancels with the appropriate error code and error page content HTML based on the blocking page it receives from calling SSLErrorHandler::HandleSSLError, via a "blocking page ready callback". To support this, HandleSSLError is updated to pass its constructed blocking page to the blocking page ready callback when the callback is present, *instead* of calling Show() on the blocking page. Since this passes ownership to the SSLErrorNavigationThrottle, we also create a new SSLErrorTabHelper that SSLErrorNavigationThrottle uses to associate a blocking page with its web contents for as long as it'sr needed (i.e. until its navigation has committed and the tab has subsequently navigated away). Bug: 752370 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I6525912a28e48b9268aa0f9798b5e1b276cb25a6 Reviewed-on: https://chromium-review.googlesource.com/621236 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515789}
-
Eugene But authored
Bug: 688063 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If9b10b4e9ab8b975dbce21aec6cf287ef82a6ab9 Reviewed-on: https://chromium-review.googlesource.com/759301Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#515788}
-
Christopher Cameron authored
One of ICCProfileCache's jobs was to mainting a list of displays that had been histogrammed, for each ICCProfile. The simpler solution to this problem is to have ICCProfile's internals be a scoped_refptr that are shared by all profiles with the same data (as much as is possible), and put the set of histogrammed displays in that structure. Replace ICCProfileCache with a simple MRUCache of ICCProfiles. There are some strange acrobatics performed in this cache to ensure that behavior exactly matches previous behavior (including all idiosyncracies). The next patch will change some of these behaviors to simplify logic. Bug: 766736 Change-Id: I1fe2d52fc8b3745d73f87115965914aeec367f61 Reviewed-on: https://chromium-review.googlesource.com/753424Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#515787}
-
Jialiu Lin authored
More specifically, if user clears all their browsing history, kSafeBrowsingUnhandledSyncPasswordReuses pref should be cleared, and change password card should be gone. if user removes individual browsing hitory entries, we should remove corresponding entries in kSafeBrowsingUnhandledSyncPasswordReuses and decide whether to remove change password card based of if this pref is empty. Bug: 782897 Change-Id: I0d099fa019f6f809c573f44cd4f347e5e9670b7e Reviewed-on: https://chromium-review.googlesource.com/759425 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515786}
-
Bret Sepulveda authored
Bug: Change-Id: Ice9ee61f692a9d8ad7dd166f777754dd4b2e147c Reviewed-on: https://chromium-review.googlesource.com/764545Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#515785}
-
Tommy Steimel authored
With the new site muting feature, "Mute tab" in the tab dropdown was replaced with "Mute site", which mutes via a content setting. There are no content settings for chrome:// urls, so this CL disables the "Mute Site" option for those pages. Bug: 782134 Change-Id: Ib95027b3124ae75e49ab6f32556e73d4f2918d04 Reviewed-on: https://chromium-review.googlesource.com/758139Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#515784}
-
Christian Biesinger authored
This reverts commit 6f252376. This fixes the regressions caused by that patch with the following changes: --- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp +++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp @@ -1445,7 +1445,7 @@ void LayoutFlexibleBox::LayoutLineItems(FlexLine* current_line, relaid_out_children_.insert(child); child->LayoutIfNeeded(); - flex_item.cross_axis_size = CrossAxisIntrinsicExtentForChild(*child); + flex_item.cross_axis_size = CrossAxisExtentForChild(*child); + flex_item.cross_axis_intrinsic_size = + CrossAxisIntrinsicExtentForChild(*child); --- a/third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.h +++ b/third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.h @@ -115,6 +115,7 @@ class FlexItem { LayoutUnit flexed_content_size; LayoutUnit cross_axis_size; + LayoutUnit cross_axis_intrinsic_size; LayoutPoint desired_location; bool frozen; --- a/third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.cpp +++ b/third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.cpp @@ -323,8 +323,8 @@ void FlexLine::ComputeLineItemsPosition(LayoutUnit main_axis_offset, child_cross_axis_margin_box_extent = max_ascent + max_descent; } else { - child_cross_axis_margin_box_extent = - flex_item.cross_axis_size + flex_item.CrossAxisMarginExtent(); + child_cross_axis_margin_box_extent = flex_item.cross_axis_intrinsic_size + + flex_item.CrossAxisMarginExtent(); A test was added in crrev.com/c/759300. There's some minor cleanups I want to make, but I will do them separately to minimize the changes in this reland. R=eae@chromium.org Change-Id: I0ac09d68631242efaab38621eabbf39a0402ed48 Reviewed-on: https://chromium-review.googlesource.com/759278 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#515783}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/38d92b59c4b7..e3bfefb41065 $ git log 38d92b59c..e3bfefb41 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 ynovikov Align float access in InterleavedAttributeData perf test 2017-11-09 jmadill Vulkan: Implement Buffer updates. Created with: roll-dep src/third_party/angle BUG=675997 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ied4a28e58bf1761735e0d5504882b2bf8c84ccc6 Reviewed-on: https://chromium-review.googlesource.com/764576Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515782}
-
Eric Karl authored
Certain sequences of drawing commands can lead to crashes on Intel 9th gen GPUs on MacOS. Adding a flush after framebuffer changes works around this. Bug: 783979 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I12ea134a592cf8eddd6e524d5d7d909d24640c40 Reviewed-on: https://chromium-review.googlesource.com/764584 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515781}
-
Zhenyao Mo authored
On Win/Linux, we will fallback to rendering with SwiftShader. On other platforms, we will fallback to software rendering with no gpu process. BUG=783069 TEST=the added tests R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9a60c71fba04ebdb46d92a5a0442a75f4f236e90 Reviewed-on: https://chromium-review.googlesource.com/764000Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#515780}
-
Joel Einbinder authored
Bug: none Change-Id: If3ecb842a31ed70f2dbea29b910c286a60d67bf3 Reviewed-on: https://chromium-review.googlesource.com/671202Reviewed-by:
-
rajendrant authored
Content-Length header is being updated for range responses. This header is not used in data savings calculation for data reduction proxy. So removing that from the test. Bug: 781415 Change-Id: Ia5caca173ad2bff1d2f70624ebb45bb185959170 Reviewed-on: https://chromium-review.googlesource.com/764874Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#515778}
-
Sunny Sachanandani authored
We're seeing access violation crashes in swap chain present. Aliasing the dirty rect and surface size will show these in minidumps. R=piman BUG=776403 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icd67c32b307efcbe18772d5bf036c8c0ad5ffe87 Reviewed-on: https://chromium-review.googlesource.com/764380 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Joel Einbinder authored
Bug: 627874 Change-Id: I8d26a2c1d743a2b551eca0365788ed51fb81886b Reviewed-on: https://chromium-review.googlesource.com/761596Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#515776}
-
Xiaohui Chen authored
Remove kVoiceInteractionPrefSynced pref BUG=None TEST=locally build and run Change-Id: I5caf0e6d4833abdbb2e2ba9828feea22c8697734 Reviewed-on: https://chromium-review.googlesource.com/764573Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#515775}
-
John Abd-El-Malek authored
1) Ensure that renderers that don't have WebUI bindings don't have access to URLLoaders for all of WebUI. Some WebUI schemes, like chrome-distiller or chrome-devtools, don't have WebUI bindings. This is accomplished by having the URLLoaderFactory for webui scheme get constructed with which scheme it's allowed to access. 2) Only renderers serving WebUI schemes that don't have WebUI bindings get a URLLoader for the network. BUG=776887,778846 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I6b432e5ef8659f3799a546913678760eb39b7d5f Reviewed-on: https://chromium-review.googlesource.com/758301Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515774}
-
Rohit Rao authored
Bookmarks was using the window's rootViewController to present context menus. This strategy does not work when BVC is presented instead of contained, so bookmarks is updated to present context menus on top of |self| instead. For safety, this change only takes effect when the BVC presentation experiment is enabled. BUG=768563 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib129197b1aece67b2cc55d58de8e9be79d0af06e Reviewed-on: https://chromium-review.googlesource.com/760481 Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515773}
-
John Budorick authored
https://chromium.googlesource.com/android_tools.git/+log/4a9623af5775..9914c5704717 $ git log 4a9623af5..9914c5704 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 jbudorick Only check out the NDK in android checkouts. Created with: roll-dep src/third_party/android_tools R=agrieve@chromium.org BUG=783607 No-Equivalent-Builders: true Change-Id: I53dac6ccb5bb813596fd4f90e4f05f1e7126a325 Reviewed-on: https://chromium-review.googlesource.com/764389 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#515772}
-
Yuwei Huang authored
WebRTCAudioSinkAdapter passes an empty done closure to AudioStreamConsumer. Different from a DoNothing closure, calling an empty closure will end up crashing the app. This CL fixes AudioStreamConsumer so that it only runs the done closure if it is not null. Bug: 748710 Change-Id: Ied6301b54e694f8d62618e7ed4e16fa2811a4202 Reviewed-on: https://chromium-review.googlesource.com/765010Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#515771}
-
Aidan Wolter authored
When an Android activity moves into the background, we want to keep the cast app alive. The app should stay alive until onDestroy. CQ-DEPEND=CL:756932 TEST=Cast YT, start another app, kill app to bring Cast to foreground BUG=b:68987926 Change-Id: I0235401acdf88a0f497f183493a6467e2b178e7a Reviewed-on: https://chromium-review.googlesource.com/757663Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#515770}
-
Karan Bhatia authored
This CL adds support for simple redirect rules to DNR. Rulesets of more recently installed extensions are given priority while determining the redirect url. Within a single extension, in case multiple rules match, the matching rule with the highest priority determines the redirect url. Note: Like the Web request API, DNR doesn't allow extensions to redirect web socket requests. This also corrects the "DeclarativeNetRequest.ShouldBlockRequestTime.SingleExtension" histogram name and prepends "Extension." to it. BUG=696822 Change-Id: I73903b782952ee539a82ddd34ae413414400cd69 Reviewed-on: https://chromium-review.googlesource.com/756332 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515769}
-
John Abd-El-Malek authored
Bug: Change-Id: I8ad12ac337875215bb04de43612b52a25b6bfafc Reviewed-on: https://chromium-review.googlesource.com/764948Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515768}
-
spqchan authored
Currently the touch bar back/forward items get updated when the page reloads or the active tab has changed. However, this can cause an issue in the future where the back/forward items is not updated. This CL fixes this but making BrowserWindowTouchbar observe the back and forward commands. The back/forward items will be updated according to the commands changes instead of the page loads. A unit test is added in BrowserWindowTouchBarUnitTest for this change. In addition, BrowserWindowTouchBarTest.PageLoadInvalidate is updated so that we have better test coverage. Bug: 783294 Change-Id: Ic554543eb26088a5f4419decd8cc22f970ee2861 Reviewed-on: https://chromium-review.googlesource.com/761710 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#515767}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/d983a9bd20b7..2ee22587f921 $ git log d983a9bd2..2ee22587f --date=short --no-merges --format='%ad %ae %s' 2017-11-10 nednguyen Remove smoothness metric from timeline_based_measurement Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9265fdb05834ffd70305ff6d12c06ad4477745f5 Reviewed-on: https://chromium-review.googlesource.com/764549 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515766}
-
Evan Stade authored
MessageCenterView. - Update login state notification blocker to hide all notifications in message center when screen is locked to maintain the behavior: "Don't make notifications read when opening the message center on lock screen" - Remove methods/variables/structs related to UnreadCount, which is not used anywhere except in tests. - It's questionable whether we have any reason to still track is_read at all, but it's used for UMA in at least one place. Bug: 755413 Change-Id: Ic00a24900992735870338a9544e6af61da744974 Reviewed-on: https://chromium-review.googlesource.com/757132Reviewed-by:James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515765}
-
Erik Luo authored
Sidebar was broken after a recent CL updated onFilterChanged() in ConsoleView. The console sidebar FilterSelected event should call onFilterChanged(), but was not. Bug: none Change-Id: Id8ef38277bec3fb54ca23823b0f9026f5f91beb7 Reviewed-on: https://chromium-review.googlesource.com/764774Reviewed-by:
-
Lei Zhang authored
These are all tests in browser_tests. Those that are not clearly named as such get renamed. Change-Id: I02653316bb942a460bc682157ca687f4b821b645 Reviewed-on: https://chromium-review.googlesource.com/762883Reviewed-by:
-
Jialiu Lin authored
This is a follow-up of https://chromium-review.googlesource.com/753986. As a result of 753986, already-opened chrome://settings page will show change password card upon protected GAIA password reuse events. However if user refreshes the chrome://settings page, change password card disappears. To fix this issue, we need to make 'showChangePassword' value adapt to ChromePasswordProtectionService::ShouldShowChangePasswordSettingUI(..) This CL also refactors ChangePasswordHandler extensively that removes lots of unnecessary code. Bug: 765740 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3078fc74f71fd2e1fea14eb020ddd77e611c05d1 Reviewed-on: https://chromium-review.googlesource.com/758971Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#515762}
-
Yuwei Huang authored
This CL adds a button on the SSO side menu to toggle using WebRTC protocol in the debug build iOS client. It will make it easier to debug the WebRTC client or do side-by-side comparison. This CL also introduces a basic flag setting framework in iOS. Bug: 748710 Change-Id: I6f7799964b49427330953553f048d67a7d31dce1 Reviewed-on: https://chromium-review.googlesource.com/764987Reviewed-by:
-
Ria Jiang authored
HFSM is owned by WindowServer so it's only null in ServerWindow ctor in unittests. Changed to DCHECK host_frame_sink_manager. Updated TestServerWindowDelegate and relavant unittests. Bug: none, related to https: //chromium-review.googlesource.com/c/chromium/src/+/748442 Test: covered by tests Change-Id: I55c24ba88d64c6f5c9afa00d69f46d7cc8298746 Reviewed-on: https://chromium-review.googlesource.com/761497Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#515760}
-
Tarun Bansal authored
In the next CL, the transport RTT estimate would be used to clamp the HTTP RTT estimate only if the number of transport RTT observations were more than a certain threshold. Bug: 753436 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I84d92726b916b3fa1340aa713d5b001c97396830 Reviewed-on: https://chromium-review.googlesource.com/760877Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#515759}
-
Pavel Feldman authored
This changes reliably waits for the inspected page to be loaded prior to engaging for debugging. Prior to this change, inspected page was racing with the test code and base was not reliably set in the inspected page. Network service was making this race run in favor of the test script. Bug: Change-Id: I709b2c0c2ddee1515cb5d4bf5c319aa7917b6f1b Reviewed-on: https://chromium-review.googlesource.com/764402 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515758}
-
danakj authored
See https://chromium-review.googlesource.com/c/chromium/src/+/760558#message-83efb689457770dfabb6d7371847f06f8091dfd7 and https://bugs.chromium.org/p/chromium/issues/detail?id=783087#c24 for explanations, but tl;dr this check would break caching, and shouldn't be there. Before it was used to skip render passes regardless of caching, but incorrectly, and the unittest in https://chromium-review.googlesource.com/c/chromium/src/+/760558 demonstrates that, and fails with that check. This removes the check from the caching block. R=enne@chromium.org, wutao@chromium.org Bug: 782044, 738190, 782042, 783087 Change-Id: Idc5baea6da5e6d663da9c1aa23ce81a55e61168d Reviewed-on: https://chromium-review.googlesource.com/763710 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#515757}
-
