GitLab

Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=bartfab@chromium.org

Bug: 825327
Change-Id: I989f21cb92c8cabe876d054e56bdbe03f0b6f0d6
Reviewed-on: https://chromium-review.googlesource.com/1024767Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553654}

WM_QUIT messages are intended to be used internally by applications to
exit message-pumping loops built using the GetMessage() API.

Chromium MessageLoop/RunLoop have a common cross-platform Quit()
mechanism, and much of our code assumes that loops will run until we
explicitly ask them to Quit(), so we have no need to process WM_QUIT.

We might see WM_QUIT messages injected by other applications, for some
reason, and some code we run will use a GetMessage() loop and exit that
via PostQuitMessage(). If a nested GetMessage() loop triggers multiple
PostQuitMessage() calls before returning then we may end up with our
MessagePumpForUI receiving WM_QUIT unintentionally.

Bug: 720078
Change-Id: I11df406ab4fd1d0a3b56899bf1a710ef51c048e9
Reviewed-on: https://chromium-review.googlesource.com/1020452
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553653}

This is a revert of [1] which caused performance regressions. This patch
reimplements a solution that avoids full tree rebuilds when only hit
testing clip values change in the clip tree.

Typically, when property nodes are updated, we force a full tree
rebuild if nodes are created or destroyed, but not if node values are
simply updated. Clip nodes are an exception to this because changing
their values ends up causing a full tree rebuild. The hit testing clip
rect (aka clip_rect_excluding_overlay_scrollbars) is different though,
and does not need to force a full tree rebuild when it changes. This
patch special-cases the hit testing clip rects to avoid a full tree
rebuild. When overlay scrollbars hide or appear, the hit testing
clip values change but a full tree rebuild is not needed.

[1] https://crrev.com/86d1cc1b33260b95367afdedb6195c842dc8e5c0

Bug: 823999, 830746, 830771
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7ab426aaead0c87a1aedf0980648505d82d40215
Reviewed-on: https://chromium-review.googlesource.com/1026941Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553652}

Migrate MessageLoop::current() to MessageLoopCurrent in /content/renderer/media/stream/media_stream_audio_processor_unittest.cc

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=aluebs@chromium.org

Bug: 825327
Change-Id: I9f324105a770fa05c8a0c621eaf21a58664d5447
Reviewed-on: https://chromium-review.googlesource.com/1024796Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553651}

This CL is a fixup of [1] and also reverts [2], making
all ozone_unittests run on linux.chromeos bots, without any skips,
for both xdg_v5 and xdg_v6 shell implementations.

Basically, CL brings some important code out of DCHECK. It was
not affecting me locally, because I either build with is_debug
or dcheck_always_on.

[1] https://crrev.com/c/976461
[2] https://crrev.com/c/1027030

R=rjkroege@chromium.org
TEST=ozone_unittests

BUG=578890

Change-Id: I18092d09df85e7aa78b85d208ba372504cd8ede9
Reviewed-on: https://chromium-review.googlesource.com/1028030Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#553650}

Bug: None
Change-Id: I35be980d4b325f804ae4cb49b471bbd5ef55d6e9
Reviewed-on: https://chromium-review.googlesource.com/1028134Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553649}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=wolenetz@chromium.org

Bug: 825327
Change-Id: I7b560649fba9f86c99d259101bc7abc2434f294d
Reviewed-on: https://chromium-review.googlesource.com/1024794
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553648}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=groby@chromium.org

Bug: 825327
Change-Id: I7b103879e33e4c71534ca16b1270949ceb70ce9b
Reviewed-on: https://chromium-review.googlesource.com/1024657Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553647}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=mef@chromium.org

Bug: 825327
Change-Id: I2dc4e772428c81ac04ee0be710b65ce8b8d897d5
Reviewed-on: https://chromium-review.googlesource.com/1024476Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553646}

Use VelocityTracker::Strategy::INT1, and scale down the initial fling velocity.

Bug: b/77490018
Test: manual on screen
Change-Id: Icf5dbfaba5810a935bdc105a894e99bef1b5ad03
Reviewed-on: https://chromium-review.googlesource.com/1028474
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553645}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=ben@chromium.org

Bug: 825327
Change-Id: Iff0e9fcf49b0a61b24cbd992b0503365f879a40c
Reviewed-on: https://chromium-review.googlesource.com/1024752Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553644}

This cleans up ui/display to use base::OnceCallback instead of
base::Callback where appropriate.

Bug: 714018
Test: CQ & run chrome on eve

Change-Id: I4231d9266f2d7df41701fe70fa8ef4a9b42b34c4
Reviewed-on: https://chromium-review.googlesource.com/1026553Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553643}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=spang@chromium.org

Bug: 825327
Change-Id: I8c5b885a9ceb8069ff004254848b47d5b6fd55d0
Reviewed-on: https://chromium-review.googlesource.com/1024393Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553642}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=benjhayden@chromium.org

Bug: 825327
Change-Id: I0ab6cebfc8184be74824fcfdb45b220808c049d3
Reviewed-on: https://chromium-review.googlesource.com/1024374Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553641}

Seems to be due to refactoring of IsRunning to discrete states in
https://chromium-review.googlesource.com/c/chromium/src/+/991458.

Change-Id: Ie1b4313ff567d96afbff89fa2ed8ee877c83e457
Reviewed-on: https://chromium-review.googlesource.com/1028470Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#553640}

In dbus::ExportedObject, an assumption was made that no signal could be
received for an exported object, so DCHECK was put there. Now that there
is a use case of D-Bus forwarding by Bluetooth dispatcher, it is fine
that an exported object receives D-Bus signal messages as it is a
property change signal that is handled by dbus::ObjectManager. So we can
just ignore message types other than method in dbus::ExportedObject
rather than DCHECK it.

BUG=835457

Change-Id: Icae03881052b3d7365a9017e5f2b987a058cd356
Reviewed-on: https://chromium-review.googlesource.com/1027081Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@google.com>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553639}

Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/app_controller_mac_browsertest.mm

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=thakis@chromium.org

Bug: 825327
Change-Id: I6aa4991f252ab4079f061f967d142a827c0a7c52
Reviewed-on: https://chromium-review.googlesource.com/1024801Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553638}

Bug: None
Change-Id: I059661fde35652c0fc867bcc60b02bfad3e178d6
Reviewed-on: https://chromium-review.googlesource.com/1026488Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553637}

These tests don't apply to the network service code path because
1) ResourceThrottles aren't used
2) Downloads go through a different path (interception of the URLLoader in NavigationRequest) that make the bug for these tests not possible

Bug: 787614
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia3d620540801d26344fb8453228e911a2c629c10
Reviewed-on: https://chromium-review.googlesource.com/1028364Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553636}

Bug: 836450
Change-Id: Ia502e5b8dcd64531f191b6ac806c5496ce0876ae
Reviewed-on: https://chromium-review.googlesource.com/1026809
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553635}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=khmel@chromium.org

Bug: 825327
Change-Id: I47c48130ebfde9f3fbb8834439a83f419d1faff7
Reviewed-on: https://chromium-review.googlesource.com/1024803Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553634}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=benwells@chromium.org

Bug: 825327
Change-Id: I18dfde173f4dec69a3ab5040a0f62e1e09005fce
Reviewed-on: https://chromium-review.googlesource.com/1024394Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553633}

I believe that in old times when this locale reset was introduced (https://codereview.chromium.org/6347045), MacOS was not excluded for some particular reason just Linux was the main target.
Here (https://bugs.chromium.org/p/angleproject/issues/detail?id=2493) is another reason to force C locale on MacOS too.

Bug=720222

Change-Id: I1cdc92e0b5561e0659e7b1bac7ec27655a2c73f6
Reviewed-on: https://chromium-review.googlesource.com/1025091Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553632}

ImageBitmap resize layout tests write an extensive amount of debug
information to the console, as requested by Skia team. Apparently
sometimes the test finishes before all the degug info are printed
to the console, causing the tests to be flaky on try bots. This
CL hides the debug info behind a test option, so they can be printed
only if necessary.

Bug: 829953
Change-Id: I32955d2b49074cdf68ab7e59766d91fc560286cf
Reviewed-on: https://chromium-review.googlesource.com/1026200Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553631}

Migrate MessageLoop::current() to MessageLoopCurrent in /content/browser/renderer_host/media/video_capture_unittest.cc

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=mcasas@chromium.org

Bug: 825327
Change-Id: I2a142815884495810e2e4b1b9df911a70827e076
Reviewed-on: https://chromium-review.googlesource.com/1024475Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553630}

crrev/c/989249 mistakenly inset the frame of native content the height of the
bottom toolbar.  Instead, native content should appear underneath the bottom
toolbar, but set it's collection view inset so everything is visible on scroll.
This way we can show a blur under the bottom toolbar.

This CL reverts those changes to ios/web to inset native content, and instead
moves the contentInset logic to BVC.  This is somewhat similar to how this
should work when NTP moves out of native content, although the method in which
we set contentInset will change.

Bug: 836205
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3518ad167f9f1ddcc9b65b087fad4869429747f8
Reviewed-on: https://chromium-review.googlesource.com/1026231
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553629}

During navigation, in RenderFrameHostManager::CommitPending, when the
navigation results in creation of a new RenderWidgetHostView, the
sequence of events in that function is that
- the old RenderWidgetHostView is hidden
- the new RenderWidgetHostView takes content from the old one
- the new RenderWidgetHostView is shown

On macOS, this can result in a one-frame flicker where there is no
content present (between the hide and the show). Fix this by adding
a ScopedCocoaDisableScreenUpdates for the duration of CommitPending.
This will make all Cocoa changes in the function be atomic.

In order to include ScopedCocoaDisableScreenUpdates in a non-objective-C
file, move its ScopedCocoaDisableScreenUpdates implementation out of
the header file.

Bug: 829523
Change-Id: If541ef8985cf7990d63a79435b179f84339a9372
Reviewed-on: https://chromium-review.googlesource.com/1024968Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553628}

I'm not sure whether it should be this way - maybe
waiting for the page load (WaitForPageLoad) should
imply waiting for the focus as well; but this does
fix the previously flaky test. I've clarified the
name of the test also, since all this does is to
show that the two HeadlessWebContents instances
are independently focused at the same time.

R=caseq@chromium.com, eseckler@chromium.com

Bug: 828042
Change-Id: I174863b49ae525605a6aacb8750880d02fae3246
Reviewed-on: https://chromium-review.googlesource.com/1026993Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@google.com>
Cr-Commit-Position: refs/heads/master@{#553627}

TBR=ellyjones@chromium.org,liaoyuke@chromium.org

Bug: 828031
Change-Id: Ie98ee83cee2d4c98c29a2ac1290728da5b87c4a7
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/1028482Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553626}

Using wpt-import in Chromium 3972cc6c.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"
afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob."
52308ad8 "Deprecate document.origin"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16261

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=markdittmer

No-Export: true
Change-Id: Ica2f31344885a0a9b97973fd187dfd0efe6c67d6
Reviewed-on: https://chromium-review.googlesource.com/1027903
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553625}

This is in preparation of updating iron-input to its latest version

Bug: 812926
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6cbcb4869fadac14956ac5c9e9a9d3d7289dda46
Reviewed-on: https://chromium-review.googlesource.com/1026639
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553624}

This change fixes changes some platform checks to TOOLKIT_VIEWS and
allows the test to assume that Mac is always running with views
enabled.

Also the information about undo selection restoration has been moved
to http://crbug.com/836490.

BUG=834754,836490

Change-Id: I906e78fb4649c646f79c2d18e6d4222b7a25050d
Reviewed-on: https://chromium-review.googlesource.com/1026881Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553623}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=slan@chromium.org

Bug: 825327
Change-Id: I01b6eb1a65d3989f830b34c989ec5a8bbf0ffe41
Reviewed-on: https://chromium-review.googlesource.com/1024530Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553622}

https://github.com/google/error-prone/releases/tag/v2.3.1

Bug: 834756
Change-Id: I658f503b854ea02fb70f63e3ee110502e6f4d7dd
Reviewed-on: https://chromium-review.googlesource.com/1024915Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553621}

Bug: 835994
Change-Id: I817b6ced87513054339397f825f695019cd68a36
Reviewed-on: https://chromium-review.googlesource.com/1025043Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553620}

During a recent roll of wpt tools, wptserve was broken and it was very
hard to debug. A few changes are made to improve the debuggability and
overall code health of wptserve management in blinkpy.

* Stop discarding the output of wptserve. Set the logging level to info
  (the default is debug) and preserve the output, so that it can be
  dumped out when something goes wrong.
* When checking and killing wptserve, we now poll the process before
  sending the null signal, as `kill -0` a defunct process will still
  succeed. We can now reap zombies much faster :)
* Lastly, _check_and_kill no longer does blocking wait inside. Now,
  _wait_for_action(_check_and_kill) makes more sense and matches the
  pattern in ServerBase better; and we send SIGKILL as a last resort
  (on POSIX).

apache_http.py is modified by the way to replace an unnecessary popen
with run_command. httpd exits immediately after it spawns the daemon,
so there's no use holding onto the defunct main process.

Change-Id: I441d36739451ad1e37afc6afe8f3c089cf224822
Reviewed-on: https://chromium-review.googlesource.com/1026889Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553619}

The tests of the constructors was in the constructor directory.  Time
to move each of these into the individual node directories so they're
associated with the node.

Update the paths as well so we can find audionodeoptions.js.

First step in moving these to WPT.

Bug: 745778
Change-Id: Iccaca6387f8d7359c357c9f22cf56d989d38d7c5
Reviewed-on: https://chromium-review.googlesource.com/1024403
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553618}

Somes time the background color of the title string in
CustomFrameViewAsh does not update. This cl fixes this bug.

Bug: 834465
Test: Manual.
Change-Id: Iee99678c0a947f4db8cbb06611f2fca0600cd72d
Reviewed-on: https://chromium-review.googlesource.com/1024606Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553617}

DownloadTests have been updated to manifest v2.
Remove the allowance for manifest v1 extensions.

Bug: 816679
Change-Id: If536e7da72deb5934305bf0a68b011b6b55582d5
Reviewed-on: https://chromium-review.googlesource.com/1026070Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553616}

Bug: skia:7794
Change-Id: I0d54fe15df6faed64bb057c3e74ebbeffc212616
Reviewed-on: https://chromium-review.googlesource.com/1027904Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553615}