- 28 Nov, 2017 40 commits
-
-
Christopher Grant authored
The mouse moves the reticle, so that's all we should see. This CL hides the system pointer cursor by supplying an empty cursor in its place. BUG= R=vollick Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib6365f14bb30fc2f7235e65a08321f11236fac65 Reviewed-on: https://chromium-review.googlesource.com/791670Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#519688}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/fb09eeb8f1b7..2492984441a3 $ git log fb09eeb8f..249298444 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I51c87fdc2cf3085a9317e8782187ab6cbdadc8c2 Reviewed-on: https://chromium-review.googlesource.com/793290Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#519687}
-
Igor authored
The state keys can't be empty on a device. If the device is enrolled and we receive empty state keys, retry to fetch them. Bug: chromium:778757 Change-Id: I06efd3402218c825b86eb8037d73fc937150da2a Reviewed-on: https://chromium-review.googlesource.com/743721 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#519686}
-
Leonard Grey authored
1) For general efficiency and to avoid the leak mentioned in the linked bug, compare share services via the previously exposed |name| method. 2) Now that |name| is available, restrict the temporary activity spawned while sharing to the Reminders service, since that's the only one that needs it. Bug: 787955 Change-Id: I6d2a38f8b1cba3b3a3a4e1edb9c06408ae9f1c41 Reviewed-on: https://chromium-review.googlesource.com/791333Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#519685}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/37b501d2c9d2..7f1b4f8cc39c $ git log 37b501d2c..7f1b4f8cc --date=short --no-merges --format='%ad %ae %s' 2017-11-28 robertphillips Fix issues related to backend texture/rendertarget creation Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: If7a84a9bbbaf6c3a458c41e10132ff1b1c65feb6 Reviewed-on: https://chromium-review.googlesource.com/793052Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519684}
-
Jochen Eisinger authored
It's not enough to check that the current window has access, if other security checks failed and the entered window shouldn't have access to the current window. BUG=788453 R=haraken@chromium.org,mkwst@chromium.org Change-Id: Iea10c52f20bdc49f00eba067cab69dab06f79f01 Reviewed-on: https://chromium-review.googlesource.com/792934 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#519683}
-
David Roger authored
Checking site isolation only in a few Dice scenarios was actually hard to do, and since we expect site isolation to be enabled by default soon, this CL goes with a simpler approach: completely disable account consistency (including Mirror and fixing auth errors) on Dice platforms when site isolation is disabled. Note that this change does not apply to mobile, where Mirror is still always enabled, regardless of site isolation. The signin component does not have access to the site isolation feature, and thus it is injected from Chrome. The ChromeSigninClient factory does the injection, for two reasons: - configuring the component should be done by "client" code - it should be done only once, and thus is done by the client factory rather than the client itself (because there can be multiple instances of ChromeSigninClient). Bug: 781761 Change-Id: Ia897bead9ab1fcc6915933eeed168d5ece3dda4a Reviewed-on: https://chromium-review.googlesource.com/768871 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#519682}
-
Ioana Pandele authored
Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I049759ea52faf56d7ee7cfbff5e523fb00adf003 Reviewed-on: https://chromium-review.googlesource.com/793156Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#519681}
-
Henrik Boström authored
This reverts commit 07edac9e. Reason for revert: Speculative revert for sync_integration_tests / TwoClientPasswordsSyncTest.SetPassphraseAndThenSetupSync failure on https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/47531 Original change's description: > Migrate away from deprecated RunLoop API > > Instead, we keep around an instance of base::RunLoop and pass it > explicitly for Quit(), which makes sure the code quits the intended loop > and not a nested one. > > Bug: 783774 > Change-Id: I3ea5092699bbae127f581e5c955cb27904d98f0a > Reviewed-on: https://chromium-review.googlesource.com/784790 > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519664} TBR=pavely@chromium.org,mastiz@chromium.org Change-Id: I25ed5a61f5b9e13159af82c4ef6d6f652170d4a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783774 Reviewed-on: https://chromium-review.googlesource.com/793630Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#519680}
-
Ivo Creusen authored
The new interface was added in https://webrtc-review.googlesource.com/c/src/+/17942 It uses optionals and allows passing some needed information to APM, which will prevent stats from getting stuck. TBR=haraken@chromium.org Bug: b/67926135 Change-Id: I816395515a5501158398838bfaee92bda3a67ee1 Reviewed-on: https://chromium-review.googlesource.com/785570 Commit-Queue: Ivo Creusen <ivoc@chromium.org> Reviewed-by:
-
Minjeong Lee authored
Moved Checking Uppercase in header from SpdyStream::SaveResponseHeaders() to HeaderCoalescer::AddHeader() Bug: 695495 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie277eaec092ee1d7541c278a7501d48902473a0d Reviewed-on: https://chromium-review.googlesource.com/775551Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#519678}
-
Vladislav Kuzkokov authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4aadee5620c5520787106260cf516d5a1dc824dc Reviewed-on: https://chromium-review.googlesource.com/788211Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#519677}
-
Patrik Höglund authored
This adds the wiring needed by https://crrev.com/c/753728 to actually disable com init check hooks for the WebRTC bots. Bug: chromium:737090 Change-Id: I7ea209345475e2fd34de969e277ba523483506a9 Reviewed-on: https://chromium-review.googlesource.com/788411Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#519676}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/b9d9a104ca83..230a61040fc8 $ git log b9d9a104c..230a61040 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 perezju [Telemetry] Add AndroidReverseForwarder Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I040a40de6b467f1c70ca9867a48a4185fb96af71 Reviewed-on: https://chromium-review.googlesource.com/793051 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519675}
-
Henrik Boström authored
TBR=eseckler@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789139 Change-Id: Ia2d504b3c5a26bcbf5468db6e1f0d06c99c38aef Reviewed-on: https://chromium-review.googlesource.com/793511Reviewed-by:
-
Javier Fernandez authored
We must treat any 'auto' margin as 0px during the tracks sizing algorithm, as the CSS Grid spec states: - https://drafts.csswg.org/css-grid/#auto-margins Additionally, we have an utility function to compute the grid item's margins when the item still needs to layout. We used the function CommputedStyle::hasMarings to decide whether such margin computation worths. However, we need that function to operate on a specific axis, hence I added a new function adding such logic. Bug: 788471 Change-Id: I5d4e4fc435aa1ffea0003a9a88cfd7a3c1bca114 Reviewed-on: https://chromium-review.googlesource.com/789830 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#519673}
-
Olivier Robin authored
ExtractForms currently extracts forms from same origin iframe. This is useless as: - form activity observer is not installed in iframes - __gCrWeb.common.getFormElementFromIdentifier does not check iframe so fields in iframes cannot be filled. It can also break form extraction (e.g. on the expedia.com web site). Full support of iframe will be implemented once cross origin iframe injection is available. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I16f7a208edfdf6bf2aa5b65ae31e152f1bd370b8 Reviewed-on: https://chromium-review.googlesource.com/785814 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#519672}
-
Greg Thompson authored
AutofillInteractiveTest::PopulateForm has flaky timeouts on CrOS. BUG=516052 TBR=estade@chromium.org Change-Id: I3a010aad9723a50f9affafdd46a931458093c8a8 Reviewed-on: https://chromium-review.googlesource.com/793210Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#519671}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5a92b85d..e1591d9c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2538b3185a5ccd19feb99c6e8a9e88ec6c5eb83b Reviewed-on: https://chromium-review.googlesource.com/793091Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#519670}
-
David Roger authored
SigninManager calls its observers with GoogleSigninSucceeded only the first time the user signs in to Chrome (not in case of a reauth). The logic in the ProfileSyncService was added initially to avoid enabling sync using an old refresh token during a reauth. This CL removes this check as it is now obsolete. Bug: 777774 Change-Id: I78fe5da8d270b099d9bba5fc962d810c00bba409 Reviewed-on: https://chromium-review.googlesource.com/787977Reviewed-by:
-
Henrik Boström authored
TBR=kbr@chromium.org,pavely@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789129 Change-Id: I46ac7f186e52770b09a39be276ee5959ed56a1c5 Reviewed-on: https://chromium-review.googlesource.com/793318Reviewed-by:
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/80adac053cab..fb09eeb8f1b7 $ git log 80adac053..fb09eeb8f --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=689520 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8f6c9cc0f0e78f9c96dedc53b2477e5749660ae9 Reviewed-on: https://chromium-review.googlesource.com/793070Reviewed-by:
-
Yuichiro Hanada authored
GetClientSourceInfo() returns the information about what the TextInputClient is. For example, RWHVA::GetClientSourceInfo() returns the URL of the shown page. This method will be used for collecting IME usage UKM. Bug: 752657 Change-Id: I4ff050e7203ed78f6d78971a79c3420616922453 Reviewed-on: https://chromium-review.googlesource.com/774818 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#519666}
-
Gauthier Ambard authored
This CL adds the Bookmarks and VoiceSearch buttons to the clean toolbar. Bug: 788436, 787861 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9d12e52c3bc1ed269921f68d1ef4261a38cfec50 Reviewed-on: https://chromium-review.googlesource.com/789859 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#519665}
-
Mikel Astiz authored
Instead, we keep around an instance of base::RunLoop and pass it explicitly for Quit(), which makes sure the code quits the intended loop and not a nested one. Bug: 783774 Change-Id: I3ea5092699bbae127f581e5c955cb27904d98f0a Reviewed-on: https://chromium-review.googlesource.com/784790Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#519664}
-
Tetsui Ohkubo authored
This adds UI side support of notification inline reply to NotificationViewMD, which is a View framework notification implementation used in Chrome OS. Several features are missing from this implementation. - Animation - Submit icon on the right side TEST=manual BUG=773586 Change-Id: I65108a5cf6d4cf654972e260ca93f2712bf9fc68 Reviewed-on: https://chromium-review.googlesource.com/776176 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#519663}
-
Mikel Astiz authored
Bug introduced in 55b3fe20 where, for the first time, bookmark observers can get notified with an empty favicon (i.e. the bookmark does not have a favicon). In this case, the UIs that want to fall back to the default icon need to handle it specifically. BookmarkMenuDelegate seems to be the only UI that cares are this particular event. To fix it, we mimic the logic implemented in the very same class, in BookmarkMenuDelegate::BuildMenu(), and treat the null image just like the default icon. Bug: 787363 Change-Id: Idf8fc5d2f2937ab16780a43320dd6689876244fa Reviewed-on: https://chromium-review.googlesource.com/782320Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#519662}
-
Marc Treib authored
There's a lot of search/instant code which isn't used on Android, but was still built and shipped. This CL moves most of it to the non-Android sections of the build files (and #ifdef's out access points where necessary), for the following classes: - InstantService - NTPUserDataLogger - NewTabPageInterceptorService - SearchIPCRouter - SearchTabHelper - [MostVisited]IframeSource - SearchBouncer - SearchEngineBaseURLTracker This saves almost 50kB of binary size on Android: tools/binary_size/diagnose_bloat.py --reference-rev=master HEAD -v MonochromePublic.apk_Breakdown (-49,152 bytes) -23,820 bytes Native resources (no l10n) size -328 bytes Zip Overhead -422 bytes Native resources (l10n) size -24,576 bytes Native code size -6 bytes Package metadata size MonochromePublic.apk_Specifics -49,502 bytes normalized apk size -24,576 bytes main lib size Bug: 787830 Change-Id: I1cf914863e0bd75cc2fa15356fe072beb961368c Reviewed-on: https://chromium-review.googlesource.com/790511Reviewed-by:Jochen Eisinger <jochen@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#519661}
-
Julian Pastarmov authored
A recent CL https://chromium-review.googlesource.com/c/chromium/src/+/763532 fixed an issue that managed policies were not properly overriding promo tabs on first run. This CL extended this treatment to recommended policies as well as it should have been the case already in the first place. BUG=756545 TEST=unit_tests, browser_tests Change-Id: I84b874013481277b51dc83015b2ebbcdbf80fda3 Reviewed-on: https://chromium-review.googlesource.com/787912 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This reverts commit 75e4a319. Reason for revert: After talking with the spec editor, we decided to go back to the old behavior. This is safe because the change has not been to beta/stable yet. Original change's description: > [XHR] Do not replace request content-type "utf-8" charset > > The spec asks us to replace the charset to "UTF-8" only when it is not > equal to "UTF-8" case insensitively. > > https://xhr.spec.whatwg.org/#the-send()-method > > """ > Otherwise, if the header whose name is a byte-case-insensitive match for > `Content-Type` in author request headers has a value that is a valid > MIME type, which has a `charset` parameter whose value is not a > byte-case-insensitive match for encoding, and encoding is not null, then > set all the `charset` parameters whose value is not a > byte-case-insensitive match for encoding of that header’s value to > encoding. > """ > > The new behavior is aligned with Firefox: > https://wpt.fyi/XMLHttpRequest/send-content-type-charset.htm > > Bug: 651750 > Change-Id: Iff716e5ceece20e60bf8e69a73a980a4ea4fc6b9 > Reviewed-on: https://chromium-review.googlesource.com/773942 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518203} TBR=tyoshino@chromium.org,yhirano@chromium.org,foolip@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 651750 Change-Id: I72d4b8e9244dd7098748298800feecebb9a5b481 Reviewed-on: https://chromium-review.googlesource.com/792712Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#519659}
-
Julien Isorce authored
The dri drivers path is the variable 'dridriverdir' in 'dri.pc' If found then translate it to the macro DRI_DRIVER_DIR. It can be useful in various places instead of guessing the path. For now only use it in gpu_sandbox_hook_linux except for ChromeOS. Bug: 787787 Change-Id: I7fef8606a4f2cbc04233af820a91cf12a4c7a9a5 Reviewed-on: https://chromium-review.googlesource.com/785371Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#519658}
-
Julien Isorce authored
Fixes overlap with https://chromium-review.googlesource.com/767375 Added unit test this time. This is a preliminary step for the subsequent CL https://chromium-review.googlesource.com/c/chromium/src/+/766787 Bug: 785201, 788123 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I70620697109fdef7d036be4c26fcecb763ddb4ba Tests: media_unittests --gtest_filter=*Vaapi*SupportedPlatforms* Reviewed-on: https://chromium-review.googlesource.com/788051Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#519657}
-
Sheng-Hao Tsao authored
Original CL (https://chromium-review.googlesource.com/c/chromium/src/+/712134) is reverted by https://chromium-review.googlesource.com/c/chromium/src/+/763309 Patch set 1 is the old CL. Implement JPEG encode acceleration interface with VAAPI VaapiJpegEncodeAccelerator implements JpegEncodeAccelerator. It calls VaapiJpegEncoder to populate necessary VA buffers and submit them via VaapiWrapper. BUG=b:67488323 TEST=Tested on caroline that a YUV image can be successfully encoded. TBR=dalecurtis@chromium.org,jcliang@chromium.org,isherman@chromium.org,blundell@chromium.org Change-Id: Iea718427e1501ebd98727c4b4afe7035a455df54 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/780945Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#519656}
-
Morten Stenshorne authored
TBR=bratell@opera.com,tzik@chromium.org Change-Id: I18ed5a01a9142725c96972a8d774e41f69f6f818 Reviewed-on: https://chromium-review.googlesource.com/792942Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#519655}
-
Henrik Boström authored
Bug filed: https://crbug.com/789111 TBR=horo@chromium.org,chenwilliam@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789111 Change-Id: I63b3f9af581d8f6778b25b6cd4b7540182a5f87c Reviewed-on: https://chromium-review.googlesource.com/793038Reviewed-by:
-
Takashi Toyoshima authored
EndSession will fail if the client is not registered, and it results in leaking the MidiManager instance inside MidiService when the dynamic instantiation mode is enabled. This happens when the StartSession fails and returns non-Result::OK status. Once a failure happens in the MidiManager initialization, the failed MidiManager instance is living until the browser shutdown, and continues to return the same error. This patch changes to register clients even on failure cases, and allows to succeed EndSession call from the failed client. This does not fix the macOS specific dynamic instantiation mode issue, but would help to save it from potential similar cases on all platforms. Bug: 718140 Change-Id: I1b6ddf3020fd9f9a26c4c1f0e30bcd7974be2894 Reviewed-on: https://chromium-review.googlesource.com/788720Reviewed-by:
-
Kinuko Yasuda authored
Started failing after around the new interceptor change. https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/7682 TBR=jam@chromium.org NOTRY=true Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Idf83194c73bb9214655a404b681dad2f40a908f3 Reviewed-on: https://chromium-review.googlesource.com/792320 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#519652}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/884db2336247..b9d9a104ca83 $ git log 884db2336..b9d9a104c --date=short --no-merges --format='%ad %ae %s' 2017-11-27 perezju [Telemetry] Remove PortKeeper Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I088cf6812192876ec056c88a4ef0d215ce1fe303 Reviewed-on: https://chromium-review.googlesource.com/792658 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519651}
-
jdoerrie authored
This change improves U2fDevice by: - Migrating to base::BindOnce() and OnceCallbacks - Using more appropriate datastructures - Removing dead code - Fixing #includes to be absolute Bug: 763303, 714018, 730593, 729950 Change-Id: If577c7f5484896a6115af997fade0c51e555df60 Reviewed-on: https://chromium-review.googlesource.com/787451 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#519650}
-
Tatiana Gornak authored
BUG=788660 Change-Id: I404f1d9efb3e0b1df2119ff3ea7981988ebf3c76 Reviewed-on: https://chromium-review.googlesource.com/788913Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#519649}
-
