- 28 Nov, 2017 40 commits
-
-
Jared Saul authored
Previous CL affected both Chrome Downstream card unmasking *and* PaymentRequest: https://chromium-review.googlesource.com/c/chromium/src/+/780361 Bug: Change-Id: I60fb111109f2c1ee0406158d0558cad4d3a17a95 Reviewed-on: https://chromium-review.googlesource.com/785793Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#519886}
-
Scott Violet authored
Also some other insignificant changes I came across when looking into this. BUG=none TEST=none Change-Id: Ia0b831db631c7663d41ddb828d78338b40d7f228 Reviewed-on: https://chromium-review.googlesource.com/794632Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#519885}
-
Scott Violet authored
The current pattern for test suites that *may* use aura has the test suite create aura::Env. In order to enable mus more broadly we need to make it so that the test suite configures Env appropriate for mus. This patch adds AuraTestSuiteSetup that is meant to setup the necessary state at the test suite level for tests that may use aura. It looks at the command line and potentially enables mus as appropriate. In order to setup env for mus WindowTreeClient needs to be configured, which required moving around some stubs. I had to update AuraTestHelper for mus being configured at the global level. This is mildly complicated by the fact that AuraTestHelper wants to create its own WindowTreeClient in this case. BUG=776514 TEST=covered by tests Change-Id: Ie433e4f6afe58b2aa15bdfb08fe462c6c1a30fad Reviewed-on: https://chromium-review.googlesource.com/792455 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#519884}
-
Erik Luo authored
Screenshot: https://imgur.com/a/d5iLM Bug: 771931 Change-Id: I8b3abd912cedfcc74f9deff87c9e5885cfc26678 Reviewed-on: https://chromium-review.googlesource.com/777841Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#519883}
-
Matt Falkenhagen authored
* Remove content::ServiceWorkerProviderType and typemapping. * Move content::mojom::ServiceWorkerProviderType to Blink. * Give modern names and comments to the type. Bug: 629701 Change-Id: Iab93d2392fdcb45b41cfbfcdd41513131f0109b8 Reviewed-on: https://chromium-review.googlesource.com/792552Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#519882}
-
Jialiu Lin authored
This is a regression introduced by a refactoring CL. SupportUserData key should be unique, but due to this refactoring, one of the data key losts its sameness. This make SetUserData() and GetUserData() consume different keys. This CL fix this problem. Also move the logging of "SafeBrowsing.ReferrerURLChainSize. DownloadAttribution" UMA metric right before report sending to help catch this kind of regression in the future. Bug: 789217 Change-Id: I778926b2d2ede69ad2b7c8327ce835104faa7852 Reviewed-on: https://chromium-review.googlesource.com/794512 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#519881}
-
Jose Dapena Paz authored
There were several typos in AXPlatformNodeAuraLinux implementation of AtkValue interface. Change-Id: Ifdcee50d0425f71f30b651d35197c663723adf8c Reviewed-on: https://chromium-review.googlesource.com/794137Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#519880}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/cde6fc4afe73..11d7efb857ae $ git log cde6fc4af..11d7efb85 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 simonhatch Dashboard - Add webcomponents-lite.js for html imports polyfill. 2017-11-28 simonhatch Pinpoint - Always run ReadValue quest Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1b3ddb70ec2e3d646a64035481acff18d4930a0e Reviewed-on: https://chromium-review.googlesource.com/794594 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519879}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/99acb1c816dc..1ff9b7ffa653 $ git log 99acb1c81..1ff9b7ffa --date=short --no-merges --format='%ad %ae %s' 2017-11-28 dsinclair Remove CollectionSize from fpdfppo. 2017-11-28 dsinclair Remove CollectionSize from fpdf_flatten. 2017-11-28 dsinclair Remove CollectionSize from string_view_template 2017-11-28 dsinclair Remove CollectionSize from JBig2_Context 2017-11-28 rharrison Convert from character stream to visible text indices in GetText Created with: roll-dep src/third_party/pdfium BUG=788103,788220 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iefdff68f09558ee706d0702bf47b8241a7141f4c Reviewed-on: https://chromium-review.googlesource.com/794026 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519878}
-
rbpotter authored
- Change model to be a Polymer UI element - Leverage existing classes to store data - Add behavior for setting/getting settings values Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I30b5aa71363c0bc2820670e8a9f3fb77b5975477 Reviewed-on: https://chromium-review.googlesource.com/783692Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#519877}
-
Fady Samuel authored
This CL adds UMA to track how often the CompositorResizeLock and Surface synchronization fail to synchronize clients within a given timeframe. This CL also tracks the number of times a fallback surface is used within a call to SurfaceAggregator::Aggregate. Bug: 672962 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia6a5e0a102372b7bc87160ebc611a66dee0b58c1 Reviewed-on: https://chromium-review.googlesource.com/794210Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#519876}
-
Ovidio Henriquez authored
This change updates the optional-services-present.html test to not use setBluetoothFakeAdapter. This will help us migrate the tests to the wpt/ directory, since testRunner is not used anymore. This change also updates the files in https://chromium-review.googlesource.com/c/chromium/src/+/769346 to resolve the comments that were made after the CL was submitted. To address the comments, assert_equals is used in request-from-iframe.html instead of assert_unreached, and callWithTrustedClick is placed before the onmessage listener. BUG=509038 Change-Id: I95b846790f7f5b69cf3c76d16638b4d130d77bf8 Reviewed-on: https://chromium-review.googlesource.com/779700Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@google.com> Cr-Commit-Position: refs/heads/master@{#519875}
-
David Dorwin authored
Removing the default entry will cause a compiler error if a value is missing. This also makes it clearer how each value is handled. This CL also makes the values absolute to further enforce consistency with enums.xml and disables obsolete values. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9cdf9b1dffdcb3f4b365676c5ca71cb46fe44f85 Reviewed-on: https://chromium-review.googlesource.com/792262Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519874}
-
Jose Dapena Paz authored
Move AXPlatformNodeWinTest utility methods that are platform independent to a parent class that can be used for other platforms unit tests. This is a preparation change to land later AXPlatformNodeAuraLinux unit tests. Bug: 789099 Change-Id: Ib0592dd96414ee3ad222c04e17d12537fc629fd8 Reviewed-on: https://chromium-review.googlesource.com/793034Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#519873}
-
Raymond Toy authored
Test that insertion of events at the same time as existing events are handled correctly. Bug: 788932 Test: AudioParam/event-insertion.html Change-Id: I0b27ac6f17730f35e552b456e52fa997615e6060 Reviewed-on: https://chromium-review.googlesource.com/791913 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#519872}
-
Kim Paulhamus authored
Correctly return TypeErrors instead of DomExceptions for missing Rp & User Entity elements. Bug: 664630 Change-Id: I464a3d2555f2599299238768a8ef59e8b32cb7f6 Reviewed-on: https://chromium-review.googlesource.com/741863 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#519871}
-
Andrey Lushnikov authored
This patch starts treating *.mjs files as javascript files. BUG=781088 R=dgozman Change-Id: I58222d6b7ad3d1c3c3442048da9cf46692b23172 Reviewed-on: https://chromium-review.googlesource.com/794349Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#519870}
-
Bo Liu authored
Relying on browser compositor for the reset is problematic because reset stops if app is in the background, which also happen to be the time the GPU is most likely to be killed by Android. Move the reset signal to any context creation success directly from the GPU process. ContextProviderCommandBuffer::BindToCurrentThread does more things like registering transfer buffers. But hopefully those don't cause GPU crashes. Bug: 777601 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I360c29c97c7a3222a84cb797c8be2f3fb65200db Reviewed-on: https://chromium-review.googlesource.com/786271Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#519869}
-
Shanfeng Zhang authored
Bug: 734265 Change-Id: Id9690f81213561c1808532c85b41e61ecda81adc Reviewed-on: https://chromium-review.googlesource.com/794412Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Shanfeng Zhang <szhangcs@google.com> Cr-Commit-Position: refs/heads/master@{#519868}
-
Shenghua Zhang authored
Since we are beginning to run external URL test again, and labs now has wifi. We need to re-enable the wifi checker test for swarming_cron use. Bug: 763582 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I261b46c63c63160bfae49590fae9248f5d8ffdab Reviewed-on: https://chromium-review.googlesource.com/794341Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#519867}
-
Devlin Cronin authored
All messaging events (runtime.onMessage, runtime.onMessageExternal, extension.onRequest, extension.onRequestExternal) are handled directly by custom messaging bindings, rather than by the EventRouter. However, runtime.onMessageExternal wasn't marked as unmanaged in the schema. Fix this. Bug: None Change-Id: I438b273c4046f91367fd44e9fcfd8a537ae7f13e Reviewed-on: https://chromium-review.googlesource.com/786899Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519866}
-
Samuel Huang authored
When Supersize assigns tool-prefix by default, but fails to find the tools needed, previously it quietly falls back to using other tools. This CL changes makes this a hard failure instead. For LLVM, also prints instruction on how to download the required tools, now that download_objdump.py is ready. Bug: 723798 Change-Id: Icc7e02deca9800dc7fbf30fbe6314a98c019be25 Reviewed-on: https://chromium-review.googlesource.com/794104 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#519865}
-
Jia authored
This cl adds ui::UserActivityObserver and viz::mojom::VideoDetectorObserver to listen to relevant events when generating idle events. See https://docs.google.com/document/d/123eFd0rUTu0140V6hJKkkWmpqibdIfM-zTtUR5a2qaQ/edit# for more detail. Bug: 784232 Change-Id: I64bae608ea7500406197c3219f26599962256adc Reviewed-on: https://chromium-review.googlesource.com/780480Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Renjie Liu <renjieliu@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#519864}
-
Owen Min authored
Bug: 760296 Change-Id: Icd7907d70667feea0f5398c5c87c6f84e441f472 Reviewed-on: https://chromium-review.googlesource.com/792175Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519863}
-
Dan Sanders authored
Before this change, the testing path invoked RenderWrapper::Stop() by posting a task, which would execute after PipelineImpl::Stop(). The production path also posts a task, but to a different thread, and PipelineImpl::Stop() waits for that task to execute before returning. This change makes the testing path more similar to the production path, by ensuring that RendererWrapper::Stop() executes before PipelineImpl::Stop() returns. The PipelineTeardownTest is also updated so that expectations on the Demuxer that Stop() the Pipeline are posted rather than directly called. This better matches the production behavior where they would be on separate threads and therefore cannot be re-entrant. Bug: 788508 Change-Id: I894ee6c2febb3b739aaa809c6aa0d9388b76b64a Reviewed-on: https://chromium-review.googlesource.com/791860 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#519862}
-
kylechar authored
Fix the logic that decides whether or not to assign temporary references in HostFrameSinkManager. This fixes temporary references not being assigned owners when running with --enable-viz in desktop Chrome. Add a test to verify temporary references are assigned with a remote FrameSinkmanager. Also fix some places in HostFrameSinkManager where |frame_sink_manager_| and |frame_sink_manager_impl_| were mixed up. Bug: 787589 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I2b40fa332f8afc8ff7fa7b62482ef174bcbd239a Reviewed-on: https://chromium-review.googlesource.com/793976Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#519861}
-
Bruce Dawson authored
The base::debug::Alias function is normally used to 'fool' the compiler into retaining an otherwise discardable local variable. In this case base::debug::Alias is used in a completely different way which initially seems wrong, but is actually reasonable. A comment will avoid confusion when auditing uses of Alias. The initial discussion of using base::debug::Alias is here: https://codereview.chromium.org/2810833002#msg7 Bug: 756589 Change-Id: Ib00a1444c217680a69178a8bbf6c710179126e86 Reviewed-on: https://chromium-review.googlesource.com/794298Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#519860}
-
Yuwei Huang authored
This CL updates the open source implementation of the side menu so that it also shows items from SideMenuItemsProvider. This make it easier for developer to debug CRD for iOS on Chromium without checking out ios_internal. Bug: 786625 Change-Id: I784032e905cfdd78eeef122f302f464b443d2153 Reviewed-on: https://chromium-review.googlesource.com/780151Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#519859}
-
Mostyn Bramley-Moore authored
dynamic_annotations is a small library intended to help tsan code coexist with valgrind. This CL makes the linux sandbox code use the RunningOnValgrind() function instead of (multiply) defining its own version, and does not use the annotations which are being phased out. TODO: remove valgrind checks that are no longer needed (perhaps all of these?) Bug: 786831,349861 Change-Id: I39f83d5dc839c54c5bc9297e9a92bd3f84ead726 Reviewed-on: https://chromium-review.googlesource.com/778881 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Julien Tinnes <jln@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#519858}
-
Derek Cheng authored
A valid Cast device address must be private. This is checked using the IPAddress::IsReserved() method, similar to DIAL's device description service. The check is performed in several entry points (some are redundant as extra safety net): - DnsSdRegistry, when it receives an device advertisement from mDNS - CastSocketService, before it opens socket - CastSocketServiceImpl::OpenChannel - CastChannelOpenFunction (entry point for chrome.cast.channel.open) Bug: 786109 Change-Id: Iaad91834cd4149fd345b2ada4e2704a0e158ba49 Reviewed-on: https://chromium-review.googlesource.com/792650 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#519857}
-
Jonathan Backer authored
For OOP-R, we will eventually have a separate decoder that only handles RasterInterface (http://crrev.com/c/778242 and https://goo.gl/Qy3aPL), which is a subset of what a GLES2Decoder handles. This new RasterDecoder will be simpler than a GLES2Decoder and will eventually evolve into something less GL-like. This CL adds a new temporary flag to ease development. In following CLs, --enable-raster-decoder will create a RasterDecoder instead of a GLES2Decoder whenever a client requests OOP-R (--enable-gpu-rasterization --enable-oop-rasterization from the command line). This plumbs through a flag and adds a VLOG where we make the decision to create a GLES2Decoder. Bug: 789238 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1c37ecf2372f6770369ee0618fc221ba7f4b9ef9 Reviewed-on: https://chromium-review.googlesource.com/793985Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#519856}
-
Gheorghe Comanici authored
This CL adds a fallback to display MostVisited URLs when personalized zero-query is enabled with ChromeHomePersonalizedOmniboxSuggestions but the user's default search engine is not Google. Bug: 781994 Change-Id: I489052f3a33e2f97d86138760f8f2d135515c241 Reviewed-on: https://chromium-review.googlesource.com/777502 Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#519855}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1b30125fbc42..9e51906ffb13 $ git log 1b30125fb..9e51906ff --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I422a32985835a92e06ba4c780cbe9a655a3209a7 Reviewed-on: https://chromium-review.googlesource.com/794523Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519854}
-
Matthew Jones authored
This change replaces the usages of ChromeAnimation in the tablet tab strip. Several properties have been added to facilitate animation and much of the logic has been simplified. Particularly, onUpdateAnimation has been removed since most of the logic depending on its param 'jumpToEnd' (which was always false) was unused. BUG=750381 Change-Id: If5c2346545254917cf690f4e5ddbb76a7dde3239 Reviewed-on: https://chromium-review.googlesource.com/791471Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#519853}
-
Eugene Ostroukhov authored
1. Show scroll (if needed) for the top-level component. 2. Disable scrolls for the individual service worker lists. 3. Fix white background for the "Other origin" list Bug: 785136 Change-Id: I55e8ff08c72609b34b0aba8b9e5729d86a54c663 Reviewed-on: https://chromium-review.googlesource.com/776115Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#519852}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/b874a352272a..3fb614bc93c3 $ git log b874a3522..3fb614bc9 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=none The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1a550fb7a4c35c5f61cf6bdd9bacc16456f11128 Reviewed-on: https://chromium-review.googlesource.com/794334Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#519851}
-
Mohamed Heikal authored
process_resources.py and package_resources.py are currently both required to create the final apk. They currently communicate using zipfiles. This ends up having 3-4 zips/unzips during the final build of the same apk in order to perform modifications. This merger allows all the required processing to be done before apk creation with no need for zipping. It also simplifies the process_resources.py script to separate the code that runs during library builds vs apk builds. Bug: 782316 Change-Id: I958c1d107d593b0932275d3c4452c2c51c499b55 Reviewed-on: https://chromium-review.googlesource.com/791152 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#519850}
-
Shanfeng Zhang authored
This should have been caught in https://chromium-review.googlesource.com/c/chromium/src/+/754281 Bug: Change-Id: Icca4f209ce474103d6a8231f36c89a36b27384d2 Reviewed-on: https://chromium-review.googlesource.com/794304 Commit-Queue: Shanfeng Zhang <szhangcs@google.com> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#519849}
-
David Trainor authored
Add an IllegalStateException when we dismiss the IPH bar twice and add a "Caused By" exception to track what the original dismiss site was. This will not fix the bug but should give us more debugging information. BUG=786916 Change-Id: I66f69a2c3318d5ae7a82c386511ed26a1afb85d9 Reviewed-on: https://chromium-review.googlesource.com/792348Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#519848}
-
Donn Denman authored
Cleans up flags for enabling ML for tap suppression in Contextual Search. Now there are just two flags and they are both normal Chrome Features. One feature enables the internal Ranker functionality, but may not have any user-visible effect. The other flag enables enforcement of the model -- providing user-visible tap suppression. Both features must be enabled for full functionality. Also there is a param for the URL of the model to load, and that's associated with the feature to query Ranker. BUG=776156 Change-Id: I06492d82c80000ca34aefa195e187f448ddfb513 Reviewed-on: https://chromium-review.googlesource.com/777725Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#519847}
-