- 24 Aug, 2018 40 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a9a4168ab6e9..1e44d066259f git log a9a4168ab6e9..1e44d066259f --date=short --no-merges --format='%ad %ae %s' 2018-08-24 nastasoiuf@google.com Parser for metrics & splitted components Created with: gclient setdep -r src/third_party/catapult@1e44d066259f The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: Ie92ff83562fd5c711f0d25fae48176d1623244af Reviewed-on: https://chromium-review.googlesource.com/1188442Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585822}
-
Jan Wilken Doerrie authored
This change adds a feature flag for caBLE for Windows and disables it by default. Bug: 821766, 837088 Change-Id: I2f87be1854a3fc64d23c9a0493eaecf0ee73668b Reviewed-on: https://chromium-review.googlesource.com/1187146 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585821}
-
Jérôme Lebel authored
When the user clicks on "Not johndoe@example.com", the sign-in dialog is opened with the identity chooser dialog opened. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic7aff360ee229ebd83063dfbef5b9bc7fe36d345 Reviewed-on: https://chromium-review.googlesource.com/1186739 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#585820}
-
Rune Lillesveen authored
Comments, processing instructions, attr, and doctype nodes should never have style, are never marked dirty, never runs through style recalc and marked clean, and should not have style dirty initially. Attr and doctype nodes will never run through AttachLayoutTree since they can not be descendants of the root element, but since PI and comments can, we need to say that it's OK that they don't need attachment for AttachLayoutTree. Also, don't mark the ancestor chain with ChildNeedsStyleRecalc when inserting such nodes into a tree. This is fixing the TODO introduced in 492730. Bug: 492730, 868810 Change-Id: I4470ce11a94e1390c2c6a9b7d1420c0e28844ade Reviewed-on: https://chromium-review.googlesource.com/1186729Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#585819}
-
Eli Ribble authored
These are currently failing ~20% of the time. Needs more investigation, but disabling for now to avoid flakiness in build system. Bug: 875548 Change-Id: I17ac3ee3cb18c21177c58a1a3a66d6591c0ef1cb Reviewed-on: https://chromium-review.googlesource.com/1187836Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Eli Ribble <eliribble@chromium.org> Cr-Commit-Position: refs/heads/master@{#585818}
-
Josh Karlin authored
The 8.0 list is comprised of the top 1000 rules used from easylist version 201808030717 when run against HttpArchive's July 15th of 2018 list of page requests. Bug: 877148 Change-Id: Ib43639379c1f8b6abeea416345dd3b9468b0354f Reviewed-on: https://chromium-review.googlesource.com/1187069 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#585817}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 33a17747. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23219 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I766667fae4e4e8acc67683f85a92976a3490cc0a Reviewed-on: https://chromium-review.googlesource.com/1188482 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585816}
-
Pavol Marko authored
This typo has been found during syncing protos to the server side. Bug: none Change-Id: Ie11f2dec5062a0c7105151540ccea1e6d65208ac Reviewed-on: https://chromium-review.googlesource.com/1188467Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585815}
-
W. James MacLean authored
Diagnostics to detect source of non-unit page scale factor in OOPIF subframes on CrOS/Android. Will be removed before stable release. Bug: 845097 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I046040e85d2fb2d4e13d425bb093cca11f6a871d Reviewed-on: https://chromium-review.googlesource.com/1185872Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#585814}
-
Ben Wells authored
This change causes all bookmark apps (including PWAs) which are not marked as locally installed to always open in tabs. Apps are marked as locally installed when they were not created on the machine but were synced to the machine, unless the device is Chrome OS - where all apps are marked as locally installed. This change does not affect hosted apps. Bug: 874841 Change-Id: Ia3936bb57e0fec94097fbf2925f676c97b703dc3 Reviewed-on: https://chromium-review.googlesource.com/1185336 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#585813}
-
Maxim Kolosovskiy authored
Change-Id: I97558373de0599230f0d779249573b3590da3f46 Reviewed-on: https://chromium-review.googlesource.com/1183310Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#585812}
-
Jdragon authored
This patch is just a code simplification. It's much easier to write: base::Erase(container, value); base::EraseIf(container, ...); than: container.erase(std::remove(container.begin(), container.end(), value), container.end()); container.erase(std::remove_if(container.begin(), container.end(), ...), container.end()); Bug: 875665 Change-Id: I4eb9f77b58befd58c6c978eb7ce591b5d95bd613 Reviewed-on: https://chromium-review.googlesource.com/1181483Reviewed-by:Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#585811}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d6781dce3d25..8ca60805916f git log d6781dce3d25..8ca60805916f --date=short --no-merges --format='%ad %ae %s' 2018-08-24 oetuaho@nvidia.com Add 2D MS array sampler support to compiler 2018-08-24 oetuaho@nvidia.com Draft ANGLE_texture_multisample_array spec Created with: gclient setdep -r src/third_party/angle@8ca60805916f The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9e6daa2ccfd1bf2ae54d89abb1a1909b73de442d Reviewed-on: https://chromium-review.googlesource.com/1188422Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585810}
-
Sylvain Defresne authored
base::Time::{To,From}InternalValue is deprecated. Use the new (https://crrev.com/c/865569) methods of PrefService to register and manipulation the preference as base::Time. Bug: 634507 Change-Id: I4093149e776d6924d7aaa49a617d4b01c2f3d862 Reviewed-on: https://chromium-review.googlesource.com/1188308Reviewed-by:David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#585809}
-
Ioana Pandele authored
This rename ensures a clear differentiation between VerticalDivider and HorizontalDivider. Skip the presubmit checks since the Text Appearance check fails, even if this change doesn't touch the faulty lines. NOPRESUBMIT=true Change-Id: Ica0d148209966bdffd33b999b0aa300cd0673cf7 Reviewed-on: https://chromium-review.googlesource.com/1186621Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#585808}
-
Sylvain Defresne authored
Passing value by const-reference is unnecessary if the type passed can fit in a register and is copyable. Change method prototype to pass it by value. Bug: none Change-Id: I8fbbd25d79fcc6434ab95678bfc18292290f8694 Reviewed-on: https://chromium-review.googlesource.com/1188223Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2a53275c38fb..60e5b43e85ec git log 2a53275c38fb..60e5b43e85ec --date=short --no-merges --format='%ad %ae %s' 2018-08-24 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 221fa26170ae..8ca60805916f (3 commits) Created with: gclient setdep -r src/third_party/skia@60e5b43e85ec The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I7fbb8412a20a9cc7de416c4710238142dd957cf4 Reviewed-on: https://chromium-review.googlesource.com/1188382Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585806}
-
Thomas Tangl authored
The title for the non-personalized services section is changed to "Other Google services". Bug: 872087 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic6953e95fa39a0b0ea5a5d950d15b63955098432 Reviewed-on: https://chromium-review.googlesource.com/1186624Reviewed-by:
-
Rohit Rao authored
BUG=855320 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4fb596298e417795877400a94fc7d80349c80673 Reviewed-on: https://chromium-review.googlesource.com/1186701Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#585804}
-
Xida Chen authored
Previously in order to prevent a crash, we add some temporary fix in touch_action_filter.cc. With some of the recent committed changes, there should be no more crashing. This CL removes the temporary code for suppressing the crash but keeps DumpWithoutCrashing so that we can get debugging info for the crash. Bug: 851644 Change-Id: I614ae6d20a24b402141563451c51b36d52302d70 Reviewed-on: https://chromium-review.googlesource.com/1185627 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#585803}
-
David Roger authored
Bug: 869938 Change-Id: I74b51073cf85bd167bbe15cef8f410e5c5300d2e Reviewed-on: https://chromium-review.googlesource.com/1184709 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585802}
-
Mike Klein authored
Lots of little tiny diffs from a little tiny gamut change. For https://skia-review.googlesource.com/c/skia/+/148990 Change-Id: Ieb91313059271b3acac97db571427563513fad37 Reviewed-on: https://chromium-review.googlesource.com/1187389Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#585801}
-
Kent Tamura authored
event.h is used in 840+ compilation units, and this CL reduces its pre-processed size by 3.54MB. Bug: 242216 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I85f8e58fbcb96c2056536a68ec4777bfa8521f31 Reviewed-on: https://chromium-review.googlesource.com/1188167Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#585800}
-
Jan Wilken Doerrie authored
This change fixes BluetoothDeviceWinrt::DiscoonectGatt. It does so by working around a quirk in the UWP APIs, that requires dropping all internal references to a given device. See this GitHub issue for further discussion: https://github.com/jasongin/noble-uwp/issues/20 Bug: 821766 Change-Id: I5bf0e4e0ce0e3b43d9cbb10e3b11e378de05e6b3 Reviewed-on: https://chromium-review.googlesource.com/1183234Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#585799}
-
Arthur Hemery authored
Following the direct passing of navigation timings information to the loader: https://chromium-review.googlesource.com/c/chromium/src/+/1127034, we move the remaining loading data down the same path and group them in a new unified structure. Background: Currently, we setup the DocumentLoader with browser provided loading data during the DidCreateDocumentLoader callback. This is modified in this patch, and relevant loading information is provided directly to the DocumentLoader at creation time. This reduces the reliance on the DidCreateDocumentLoader callback and further enables a complete removal of the PendingNavigationParams used to store browser provided informations while waiting for the callback. We do not include these informations in extra_data, to keep a clear separation between information relevant to the loader (ExternalLoadingData) and information that will eventually be stored by the FrameLoader and decoupled from the DocumentLoader (ExtraData). Bug: 789577 Change-Id: I4306c079a80260386547d4fb85ff8f398c811cc4 Reviewed-on: https://chromium-review.googlesource.com/1127783 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585798}
-
Peter E Conn authored
Bug: 871266 Change-Id: Idb5ad9a435f8696eb5bb5f97de24ce05fbba5469 Reviewed-on: https://chromium-review.googlesource.com/1185007Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 03168d86. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23218 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: If8345598e240e21411a867bc432e0df20c00ab80 Reviewed-on: https://chromium-review.googlesource.com/1188084 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Several profile and policy controlled preferences are removed from the persistent storage list for incognito mode. As these preferences are not written from inside an incognito window, the CL is not expected to make any behavioral change and is just cleanup. Bug: 861722 Change-Id: I28ec6eb98241656fe81bbbf81fbad0bc73eddc53 Reviewed-on: https://chromium-review.googlesource.com/1188123Reviewed-by:
-
Ben L. Titzer authored
This the Chromium side of adding usage counter for WASM language features. It depends on https://chromium-review.googlesource.com/c/v8/v8/+/1186721 R=ahaas@chromium.org, rmcilroy@chromium.org Bug: chromium:868844 Change-Id: I3e8ed00300a77e7d1f5a44a4ff30ad555051ca21 Reviewed-on: https://chromium-review.googlesource.com/1186726 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585794}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/199b69092bef..12949bd7d3d6 git log 199b69092bef..12949bd7d3d6 --date=short --no-merges --format='%ad %ae %s' 2018-08-24 treehugger-gerrit@google.com Merge "Only start data sources on registration if the tracing session is enabled" 2018-08-24 primiano@google.com Merge "Update guard to use PERFETTO_BUILDFLAG" Created with: gclient setdep -r src/third_party/perfetto@12949bd7d3d6 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7bfbac3f639655ef6b899d5cdc3f01d8ada70045 Reviewed-on: https://chromium-review.googlesource.com/1188362Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585793}
-
Giovanni Ortuño Urquidi authored
WebAppPolicyManager allows admins to not specify a launch container. When this is the case the installed app should launch in the default container: windows for PWAs and tabs for non-PWAs. Adds a new enum value to PendingAppManager::LaunchContainer to indicate that the default launch container should be used and changes WebAppPolicyManager to set that value when appropriate. Bug: 877398 Change-Id: I4c99d3b53bc7c29a50c6961da78d046bc7ef7819 Reviewed-on: https://chromium-review.googlesource.com/1188203 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#585792}
-
Tanja Gornak authored
The InsatnceId token can become invalid. This CL re-requests the token once a day and notifies the listener (FCMSyncInvalidationLIstener) in case token has become invalid. This CL only passes new token to the appropriate listener, but doesn't act on the change. Bug: 801985 Change-Id: I004983225e22326c6e06cc3b97098d7784d07754 Reviewed-on: https://chromium-review.googlesource.com/1166967 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#585791}
-
Giovanni Ortuño Urquidi authored
Changed BookmarkAppInstallationTask to set forced_launch_type on the BookmarkAppHelper used to install the app. Also adds set_forced_launch_type() to BookmarkAppHelper. When called, BookmarkAppHelper will ignore the default launch type (window for PWAs, tabs for non-PWAs) and also the user set launch type if any. Bug: 876169 Change-Id: I077570c35c00d3581b404daab7e054615ee7fc2a Reviewed-on: https://chromium-review.googlesource.com/1188176 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Ioana Pandele authored
This allows the TextView to expand beyond 48dp if the text needs to be displayed on multiple lines. Bug: 874257 Change-Id: I39a8bbd70bebf8421968e987b3df37ccc9684296 Reviewed-on: https://chromium-review.googlesource.com/1187147Reviewed-by:
-
Giovanni Ortuño Urquidi authored
WebAppPolicyManager would like to skip shortcut creation because there is a separate policy to create them. So we add that option to AppInfo and plumb it all the way down to BookmarkAppHelper Bug: 876175 Change-Id: I09f460efe7c3809856bde77ebe4570de6ae8845e Reviewed-on: https://chromium-review.googlesource.com/1186220 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Pavol Marko authored
Bug: none Change-Id: Iee909eb8c049aa69cb94d41b9170be0dc0272983 Reviewed-on: https://chromium-review.googlesource.com/1115223 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#585787}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b44922e7..8f582e98 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib6f6fc9d34bf7a057a52fce6e7d38602e0a99148 Reviewed-on: https://chromium-review.googlesource.com/1188032Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585786}
-
Giovanni Ortuño Urquidi authored
Changes TestBookmarkAppInstallationTask in pending_bookmark_app_manager_unittest.cc to notify the test that Install is called. Then the test saves a copy of the used AppInfo to compare to the app info originally passed to PendingAppManager. This helps make sure AppInfo is correctly plumbed from PendingAppManager up until BookmarkAppInstallationTask which will use it to install the app. Bug: 876173 Change-Id: Iac87fc6e941f1da239717b306f1be44b18704320 Reviewed-on: https://chromium-review.googlesource.com/1186213 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
Some actions (currently "New Incognito Tab" and "Recent Tabs") open as page in the current tab. Keyboards would be implicitly dismissed by Android but an open Accessory closes only when the page changes. This causes the activity to update its bounds too late and leave a patch on the newly renderd page. Therefore, this CL causes all accessory elements to be dismissed once any action is selected. Bug: 877029 Change-Id: I92a3174c7c7ffcb7e94e3b39b3a26b0eb7a4f1f3 Reviewed-on: https://chromium-review.googlesource.com/1188303Reviewed-by:
-
Hayato Ito authored
BUG=877361 TBR=bokan@chromium.org Change-Id: Id1bd59c7e430c0c65eeab1a4a9b25d39aa0de9ef Reviewed-on: https://chromium-review.googlesource.com/1188008Reviewed-by:
-
