GitLab

Delete redundant non-proto ReadState/WriteState/ConnectState enums.
Add cast protogen rule to extension registration deps.
BUG=

Review URL: https://codereview.chromium.org/589663002

Cr-Commit-Position: refs/heads/master@{#296003}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/08e97a9:78324b1

TBR=pdr@chromium.org,wjmaclean@chromium.org

Review URL: https://codereview.chromium.org/588123003

Cr-Commit-Position: refs/heads/master@{#296002}

Various browser tests currently have to make a connection to a host in order to test
features that only make sense in that context (eg, bump-scroll). These tests would
be more robust if the we could mock the client plugin so that a real connection isn't
needed.

For the most part, I've changed only what I had to to make it possible to mock these
classes; there's a lot more clean-up that could be done, but I don't want to make it
hard to merge things back into trunk.

Review URL: https://codereview.chromium.org/552403004

Cr-Commit-Position: refs/heads/master@{#296001}

BUG=NONE

Review URL: https://codereview.chromium.org/584663002

Cr-Commit-Position: refs/heads/master@{#296000}

allow-hotplug instead of auto means that ifupdown won't wait for 2 min for the
interface to come up, but it'll bring it up as soon as it appears.

R=tonyg@chromium.org,fmeawad@chromium.org
BUG=

Review URL: https://codereview.chromium.org/593623002

Cr-Commit-Position: refs/heads/master@{#295999}

Each enqueued event in the browser-side touch queue maintains a vector
of events that must be ack'ed, allowing each enqueued event to coalesce
with subsequent events delivered from the platform. Currently, the
vector is always populated with the first event, even if no coalescing
occurs. Instead, defer population until coalescing occurs, optimizing
the common case for most events by avoiding an extra heap allocation for
every touch. This can save ~5-10us per forwarded touch event on a typical
Android device.

BUG=384562

Review URL: https://codereview.chromium.org/565033002

Cr-Commit-Position: refs/heads/master@{#295998}

BUG=413853

Review URL: https://codereview.chromium.org/585133002

Cr-Commit-Position: refs/heads/master@{#295997}

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/590693002

Cr-Commit-Position: refs/heads/master@{#295996}

The previous patch https://codereview.chromium.org/584513004 ran on all
metro viewer shutdowns, which would lead to Alt-F4 not being processed
which means that the proper metro process shutdown wouldn't happen,
potentially leaving the "ghost" icon.

Instead, only do the aggressive termination from the process_host side
and only when running test binaries (where we're concerned about having
the viewer be able to run again immediately.)

R=ananta@chromium.org
BUG=411147,416356

Review URL: https://codereview.chromium.org/584213002

Cr-Commit-Position: refs/heads/master@{#295995}

This is already how the bookmark editor sheet behaves. The xib changes:
- Turn off "headers".
- Set the column autoresizing style to "last column only".

BUG=414266
TEST=as in bug

Review URL: https://codereview.chromium.org/586543002

Cr-Commit-Position: refs/heads/master@{#295994}

The coordinates information will be used in trace-viewer to display input
coordinates within the chrome compositor view.

Original patch by Vicentiu Ciorbaru <cvicentiu@chromium.org>

Review URL: https://codereview.chromium.org/569653002

Cr-Commit-Position: refs/heads/master@{#295993}

This change integrates DeviceIfoSyncService and DeviceInfoDataTypeController introduced in an early change
with the rest of the Sync code and removes the old implementation of DEVICE_INFO sync type based on SyncedDeviceTracker.
As a part of this change DEVICE_INFO stops being a specially implemented control type and becomes a priority type
with implementation that follows pattern of the majority of other sync types.
This should help to do some further refactoring including decoupling of DeviceInfo sync code from the browser and moving it to sync_driver component.
This change also adds support for syncing of local device backup timestamp to DeviceInfoSyncService. This functionality was missing when DeviceInfoSyncService was initially introduced.

BUG=395349

Review URL: https://codereview.chromium.org/566623003

Cr-Commit-Position: refs/heads/master@{#295992}

Blink no longer always invalidate synchronously. If an invalidation
requirement is not generated during a frame update, the blink will
schedule an animation and will issue the invalidation in the next
frame update.

webview_plugin should handle scheduleAnimation() to trigger the
next frame update. For now we call container_->invalidate() to achieve
that.

BUG=415926

Review URL: https://codereview.chromium.org/584243002

Cr-Commit-Position: refs/heads/master@{#295991}

BUG=415935
TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.

Review URL: https://codereview.chromium.org/588523002

Cr-Commit-Position: refs/heads/master@{#295990}

BUG=304341
TEST=Interstitial pages still work.

Review URL: https://codereview.chromium.org/587933002

Cr-Commit-Position: refs/heads/master@{#295989}

Convert some uses of AttachmentIdList to AttachmentIdSet.

Remove the no longer needed UploadAttachments method from
GenericChangeProcessor.

BUG=372622

Review URL: https://codereview.chromium.org/582913002

Cr-Commit-Position: refs/heads/master@{#295988}

Revert of Enable ASan default options on Mac. (patchset #4 id:60001 of https://codereview.chromium.org/581983003/)

Reason for revert:
This CL broke ui_unittests on both Mac ASan and Mac ASan 64 bots:

/Volumes/data/bool/build/slave/Mac_ASan_Tests__2_/build/src/out/Release/ui_unittests --brave-new-test-launcher --test-launcher-bot-mode --verbose --test-launcher-print-test-stdio=always --gtest_print_time --test-launcher-summary-output=/tmp/tmpnPVxX8
dyld: Library not loaded: @executable_path/../Versions/1.0.0.0/ui_unittests Framework.framework/ui_unittests Framework
  Referenced from: /Volumes/data/bool/build/slave/Mac_ASan_Tests__2_/build/src/out/Release/ui_unittests
  Reason: image not found

http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%282%29/builds/5393/steps/ui_unittests/logs/stdio

Original issue's description:
> Enable ASan default options on Mac.
>
> This CL links libsanitizer_options into every executable built with ASan on OSX.
> The existing implementation of __asan_default_options for Chromium.app is merged with that in sanitizer_options.cc
>
> Also now use_sanitizer_options is only set when building with sanitizers so that there isn't an unconditional dependency on an empty object file in every executable in non-sanitizer builds.
>
> BUG=302040
> R=cpu@chromium.org
>
> Committed: https://crrev.com/0640a5d19ef72aec62787423e8a7c78c4f62b955
> Cr-Commit-Position: refs/heads/master@{#295958}

TBR=cpu@chromium.org,earthdok@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=302040

Review URL: https://codereview.chromium.org/593683004

Cr-Commit-Position: refs/heads/master@{#295987}

BUG=None
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/587953002

Cr-Commit-Position: refs/heads/master@{#295986}

A copy and paste error meant it used the link output file for dependency tracking. This is valid but inefficient, which was why it wasn't caught. Added a new test for this case

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/583363003

Cr-Commit-Position: refs/heads/master@{#295985}

It was accidentally enabled with the switch to recipes.

BUG=416502
NOTRY=True
TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/587533004

Cr-Commit-Position: refs/heads/master@{#295984}

I noticed this while looking through isolate files. Since the test target is in content, the isolate file should be alongside.

Review URL: https://codereview.chromium.org/573073003

Cr-Commit-Position: refs/heads/master@{#295983}

Followup to an old CL: 7283013, which attempted to delete this file.

Review URL: https://codereview.chromium.org/587103004

Cr-Commit-Position: refs/heads/master@{#295982}

In common openBookmarkFolder: function, check if button is offTheSideButton and
event is NSOtherMouseUp, if so, open just the folder menu instead of opening all
bookmarks under it.

BUG=46682
R=asvitkine@chromium.org

TEST=
1) Launch chrome and add more bookmarks to Bookmarks bar so that offTheSideButton
is visible.
2) Middle click on the button and observe.
3) It should just open its folder menu instead of opening all bookmarks under it.

Review URL: https://codereview.chromium.org/583223002

Cr-Commit-Position: refs/heads/master@{#295981}

Revert of Swarming configuration files for chromoting integration tests (patchset #4 id:60001 of https://codereview.chromium.org/498373003/)

Reason for revert:
This is slowing down the trybots because it's uploading these files even though they're not used on trybots. look at how gpu isolates that are only used on the GPU builders are handled (there's a gyp variable which is only set by the builders which run these tests)

Original issue's description:
> Swarming configuration files for chromoting integration tests.
>
> BUG=
>
> Committed: https://crrev.com/d90ba4c4e4ddf5c4cbb6cf812c9571d628e30567
> Cr-Commit-Position: refs/heads/master@{#292785}

TBR=maruel@chromium.org,anandc@chromium.org,chaitali@chromium.org,anandc@google.com,leilei@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/591163002

Cr-Commit-Position: refs/heads/master@{#295980}

It was unintentionally enabled with the switch to recipes.

BUG=388885
TBR=dtu@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/596483002

Cr-Commit-Position: refs/heads/master@{#295979}

Scrollbar animation is required if scrollbar parameters are changed.
If any of the scrollbar parameters are changed that should trigger the
scrollbar animation. If any of the scrollbar parameter is not changed,
that doesn't require scrollbar animation. Current Patch ensures that
scrollbar is animated only when any of the scrollbar parameter is
changed.

BUG=414238

Review URL: https://codereview.chromium.org/571873003

Cr-Commit-Position: refs/heads/master@{#295978}

Windows does this, Mac doesn't. ¯\(°_o)/¯

BUG=NONE

Review URL: https://codereview.chromium.org/590133003

Cr-Commit-Position: refs/heads/master@{#295977}

Revert of [Mac] Remove unnecessary button on 'Bookmark all tabs' window (patchset #2 id:20001 of https://codereview.chromium.org/583633002/)

Reason for revert:
Nonono you can't just hack out lines from xib files! https://codereview.chromium.org/586543002/ rebuilds the xib file in Xcode to accomplish this and more.

Original issue's description:
> [Mac] Remove unnecessary button on 'Bookmark all tabs' window
>
> Remove unnecessary button on 'Bookmark all tabs' window which appears
> before "Bookmarks Bar"
> XIB Changes:
> Removing the line in the following .xib file which is responsible for the appearance of empty button.
> chrome/app/nibs/BookmarkAllTabs.xib
>
> BUG=415554
> R=asvitkine@chromium.org
>
> TEST=
> 1) Launch chrome, open 2-3 tabs.
> 2) Right click on last tab and select 'Bookmark all tabs'
> 3) Empty button shouldn't be shown.
>
> Committed: https://crrev.com/0ce925fc1ee0f53142313d1b63b32dafbeeeaace
> Cr-Commit-Position: refs/heads/master@{#295714}

TBR=asvitkine@chromium.org,shilpa.shri@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=415554

Review URL: https://codereview.chromium.org/592833002

Cr-Commit-Position: refs/heads/master@{#295976}

Change the logic for determining if we should default to
custom window frames (as opposed to using WM-drawn
titlebars):

a) Don't use custom frames for window managers that don't
   support EWMH (Extended Window Manager Hints).
b) Don't use custom frames for EWMH-supporting tiling WMs and
   a few other WMs that don't play well with custom frames.
c) Otherwise, use custom frames.

Previously, custom frames were only used for a hardcoded set
of EWMH-supporting window managers.

BUG=345482

Review URL: https://codereview.chromium.org/578443004

Cr-Commit-Position: refs/heads/master@{#295975}

New ExtensionManagement preference is a policy-controlled dictionary preference for management of extensions.
Current implementation covers all legacy extension management preference (installation_mode, install_sources, allowed_types).

This CL includes extension preference parsing, definition of constants strings for properties/string enums in the new dictionary value, and a test helper class for manipulating it in unit tests.

BUG=177351

Review URL: https://codereview.chromium.org/559603002

Cr-Commit-Position: refs/heads/master@{#295974}

Without this, the compiler complains about glDeleteTextures etc not being
declared.

BUG=none
R=ccameron@chromium.org

Review URL: https://codereview.chromium.org/587193005

Cr-Commit-Position: refs/heads/master@{#295973}

In layer unittest ReadPixel loops multiple times to wait to a readback.
This causes flake on cros valgrind bot. Instead use RunLoop to wait for
readback.

The flake is exposed if ui::Compositor uses Scheduler (CL 535733002)

BUG=403528

Review URL: https://codereview.chromium.org/587863002

Cr-Commit-Position: refs/heads/master@{#295972}

BUG=

Review URL: https://codereview.chromium.org/587173008

Cr-Commit-Position: refs/heads/master@{#295971}

Revert of Let --js-flags work when Harmony is enabled in about:flags (patchset #2 id:20001 of https://codereview.chromium.org/588543003/)

Reason for revert:
Breaks unit_tests

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/3714

Original issue's description:
> Let --js-flags work when Harmony is enabled in about:flags
>
> R=jochen@chromium.org
> BUG=
>
> Committed: https://crrev.com/727cae88098c3fd91df47afa64cb756b54050b20
> Cr-Commit-Position: refs/heads/master@{#295960}

TBR=jochen@chromium.org,erik.corry@gmail.com,erikcorry@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/589093003

Cr-Commit-Position: refs/heads/master@{#295970}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a392c9d..a29b5d8

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/590123003

Cr-Commit-Position: refs/heads/master@{#295969}

Also depend on chromium_builder_perf instead of chromium_builder_qa
since it's likely we'll start running Telemetry tests on our bots
in the near future.

BUG=

Review URL: https://codereview.chromium.org/587173004

Cr-Commit-Position: refs/heads/master@{#295968}

BUG=415179
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/556853003

Cr-Commit-Position: refs/heads/master@{#295967}

Previous change forgot to remove a file from BUILD.gn

https://codereview.chromium.org/479873002

BUG=None
NOTRY=true
TBR=jam

Review URL: https://codereview.chromium.org/587193004

Cr-Commit-Position: refs/heads/master@{#295966}

BUG=413271
TEST=Ensure new-profile-management is disabled. Sign in to a profile.
Enable new-profile-management. Lock an account. Take the machine
offline. Try to unlock your account (with the right or wrong password),
and receive a message specifying that your password cannot be
verified because you're offline.

Review URL: https://codereview.chromium.org/591533002

Cr-Commit-Position: refs/heads/master@{#295965}

Moving parts connected to screenshot testing from login_ui_browsertest.cc to separate files. Uses BrowserTestBase::Admixture added in https://codereview.chromium.org/468493003/.

BUG=395653

Review URL: https://codereview.chromium.org/441263002

Cr-Commit-Position: refs/heads/master@{#295964}