GitLab

BUG=444540

Review URL: https://codereview.chromium.org/819083002

Cr-Commit-Position: refs/heads/master@{#309425}

Currently these tests are utilizing the content::RenderViewTest as the base class
whereas all other *_browsertest.cc are using ChromeRenderViewTest as the base class.

Due to this, the migration of inline CSS to GRD being done in [1] is failing
for browsertests target as listed here [2] in the build log.

In order to fix this, these tests should use the ChromeRenderViewTest as their base class.
In doing so, the ChromeRenderViewTest loads ChromeContentClient which in turn loads the correct
pak file i.e. resources.pak required for the migration.

This CL adds the extensions/DEPS rule to allow the inclusion of chrome_render_view_test.h.

[1] https://codereview.chromium.org/573553002
[2] http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/14184

Review URL: https://codereview.chromium.org/818563003

Cr-Commit-Position: refs/heads/master@{#309424}

The viewer would crash because MojoMain was moved into a html_viewer
namespace. The MojoMain should remain in the default namespace.

BUG=444099

Review URL: https://codereview.chromium.org/816463005

Cr-Commit-Position: refs/heads/master@{#309423}

Due to this test currently being a browser_test, its causing issues in migration of inline CSS
resources to be part of GRD resources [1]. In order to fix this, this test has to be a component_browsertests.

BUG=283846

R=jochen@chromium.org
R=blundell@chromium.org

[1] https://codereview.chromium.org/573553002

Review URL: https://codereview.chromium.org/819573002

Cr-Commit-Position: refs/heads/master@{#309422}

TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/816373002

Cr-Commit-Position: refs/heads/master@{#309421}

Cr-Commit-Position: refs/heads/master@{#309420}

BUG=
TBR=robertphilips@google.com

Review URL: https://codereview.chromium.org/824633002

Cr-Commit-Position: refs/heads/master@{#309419}

|oobe_timer_| kept running after StopDetection() call. So in fact demo mode
detection remained active.

BUG=439956
TEST=Run 'chromeos=1' debug build with options --derelict-detection-timeout=10 --derelict-idle-timeout=10 --oobe-timer-interval=10. Enroll into enterprise domain, wait for 10 seconds at "Your device has successfully been enrolled." screen. Nothing should happen.

Review URL: https://codereview.chromium.org/821013002

Cr-Commit-Position: refs/heads/master@{#309418}

BUG=370433
TEST=unit_tests, components_unittests
R=avi@chromium.org

Review URL: https://codereview.chromium.org/814833007

Cr-Commit-Position: refs/heads/master@{#309417}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/59fc6ad..1111d8c

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/819043002

Cr-Commit-Position: refs/heads/master@{#309416}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/49a9dd4..59fc6ad

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/806223007

Cr-Commit-Position: refs/heads/master@{#309415}

R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/797503003

Cr-Commit-Position: refs/heads/master@{#309414}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/802003004

Cr-Commit-Position: refs/heads/master@{#309413}

One more follow-up patch for
https://codereview.chromium.org/761923004/#msg18
https://codereview.chromium.org/814513003/

- Split EmbeddedWorkerDevToolsManager into two, Shared- and ServiceWorkerDevToolsManager, and made them inherit from EmbeddedWorkerDevToolsManager
- Renamed EmbeddedWorkerDevToolsAgentHost to WorkerDevToolsAgentHost
- Renamed EmbeddedWorkerDevToolsManager to WorkerDevToolsManager

BUG=443470
TEST=SharedWorkerDevToolsMangerTest\*

Review URL: https://codereview.chromium.org/817653002

Cr-Commit-Position: refs/heads/master@{#309412}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3b40ee6..6cc53f3

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/817993002

Cr-Commit-Position: refs/heads/master@{#309411}

The test is failing there.

TBR=ckehoe@chromium.org
NOTRY=true
BUG=444516

Review URL: https://codereview.chromium.org/820973002

Cr-Commit-Position: refs/heads/master@{#309410}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/16b8af1..49a9dd4

TBR=

Review URL: https://codereview.chromium.org/815933003

Cr-Commit-Position: refs/heads/master@{#309409}

Cr-Commit-Position: refs/heads/master@{#309408}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9dc272a..16b8af1

TBR=

Review URL: https://codereview.chromium.org/787763015

Cr-Commit-Position: refs/heads/master@{#309407}

Test is ServiceWorkerCacheStorageManagerTest.StorageMatchCacheNotReferenced.

TBR=falken@chromium.org
NOTRY=true
BUG=444503

Review URL: https://codereview.chromium.org/784323004

Cr-Commit-Position: refs/heads/master@{#309406}

Revert of Revert of Adding CopresenceState (patchset #1 id:1 of https://codereview.chromium.org/824593003/)

Reason for revert:
Reverting the revert as it causes compile failures. Will disable the test under valgrind instead.

Original issue's description:
> Revert of Adding CopresenceState (patchset #10 id:180001 of https://codereview.chromium.org/764673003/)
>
> Reason for revert:
> AudioDirectiveListTest.AddDirectiveMultiple started failing consistently on the linux valgrind memory fyi bot after this change.
>
> See http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%282%29/builds/41365 for details.
>
> I can't see any good reason why it would be failing in this way, on this bot, after this change, but I don't have time to investigate deeply.
>
> Original issue's description:
> > Adding CopresenceState, a central place to track the internal state of the copresence component. Classes can register to be notified of state changes (e.g. new directives or tokens). This provides the backend for the new debug UI.
> >
> > BUG=420889
> >
> > Committed: https://crrev.com/e8b0dbdbe00fd4cdfcc7db4fd4721ed74be4f928
> > Cr-Commit-Position: refs/heads/master@{#309315}
>
> TBR=rkc@chromium.org,xiyuan@chromium.org,ckehoe@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=420889
>
> Committed: https://crrev.com/6b12c01b7bacec4b74594fb3437d3dbc01cc484c
> Cr-Commit-Position: refs/heads/master@{#309403}

TBR=rkc@chromium.org,xiyuan@chromium.org,ckehoe@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420889

Review URL: https://codereview.chromium.org/806853003

Cr-Commit-Position: refs/heads/master@{#309405}

The reason for this change is same as http://crrev.com/806393002.

BUG=444485
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/video_player/js/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/821623002

Cr-Commit-Position: refs/heads/master@{#309404}

Revert of Adding CopresenceState (patchset #10 id:180001 of https://codereview.chromium.org/764673003/)

Reason for revert:
AudioDirectiveListTest.AddDirectiveMultiple started failing consistently on the linux valgrind memory fyi bot after this change.

See http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%282%29/builds/41365 for details.

I can't see any good reason why it would be failing in this way, on this bot, after this change, but I don't have time to investigate deeply.

Original issue's description:
> Adding CopresenceState, a central place to track the internal state of the copresence component. Classes can register to be notified of state changes (e.g. new directives or tokens). This provides the backend for the new debug UI.
>
> BUG=420889
>
> Committed: https://crrev.com/e8b0dbdbe00fd4cdfcc7db4fd4721ed74be4f928
> Cr-Commit-Position: refs/heads/master@{#309315}

TBR=rkc@chromium.org,xiyuan@chromium.org,ckehoe@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420889

Review URL: https://codereview.chromium.org/824593003

Cr-Commit-Position: refs/heads/master@{#309403}

window.IN_TEST is not defined in gallery app. It caused a warning of closure compiler, and IN_TEST flag should be set true also in tests of gallery app.

BUG=433728
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default
out/Release/browser_tests --gtest_filter=*GalleryBrowserTest*

Review URL: https://codereview.chromium.org/817233002

Cr-Commit-Position: refs/heads/master@{#309402}

The checkbox which was referred in the previous version of the string has been
moved long long time ago.

TEST=Tested manually.
BUG=441438

Review URL: https://codereview.chromium.org/809343004

Cr-Commit-Position: refs/heads/master@{#309401}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c6e6ddb..9dc272a

TBR=

Review URL: https://codereview.chromium.org/784323003

Cr-Commit-Position: refs/heads/master@{#309400}

This is a chromium-side part.

BUG=441006
R=dstockwell@chromium.org
R=ajuma@chromium.org
TEST=ManualTests/animation/compositor-animation-steps.html

Review URL: https://codereview.chromium.org/809523004

Cr-Commit-Position: refs/heads/master@{#309399}

Revert of [chromedriver] Add shadow DOM support to chromedriver. (patchset #4 id:60001 of https://codereview.chromium.org/480483002/)

Reason for revert:
This CL breaks ElementEqualityTest.testAnElementFoundInADifferentFrameViaJsShouldHaveSameId and ElementFindingTest.testAnElementFoundInADifferentFrameViaJsCanBeUsed

Original issue's description:
> [chromedriver] Add shadow DOM support to chromedriver.
>
> BUG=chromedriver:852
>
> TEST= added some unit tests (beginning with testShadowDom) to chrome/test/chromedriver/test/run_py_tests.py
>
> R=samuong@chromium.org
>
> Committed: https://crrev.com/713e22356d84f46633890df2be12860b0d6a16ee
> Cr-Commit-Position: refs/heads/master@{#309002}

TBR=mcharsley@google.com
NOTREECHECKS=true
NOTRY=true
BUG=chromedriver:852

Review URL: https://codereview.chromium.org/824603002

Cr-Commit-Position: refs/heads/master@{#309398}

For some performance tests, we need to control the rate of the
input frames, instead of feeding those frames at the full speed.
For example, this can simulate the frames coming from a video
capture device. So that we can measure the CPU usage and the power
consumption in these scenarios.

BUG=chromium:350255
TEST=Run the test on peach-pit

Review URL: https://codereview.chromium.org/769133003

Cr-Commit-Position: refs/heads/master@{#309397}

WebThread::Task can contain RefPtr to a thread-unsafe-reference-counted object
(e.g. WorkerThreadTask can contain RefPtr to WebKit's StringImpl).
This caused a race condition:

[A] When WebThread::Task::run is executed, more RefPtr's to the refcounted
    object can be created and the reference counter of the object can be
    modified via these RefPtr's (as intended) on the thread where the task
    is executed.
[B] However, base::Closure still retains the ownership of WebThread::Task
    even after WebThread::Task::run is called.
    When base::Closure is deleted, WebThread::Task is deleted and the
    reference counter of the object is decreased by one, possibly from a
    different thread from [A], which is a race condition.

This CL removes the ownership of WebThread::Task from base::Closure after
WebThread::Task::run is executed by using scoped_ptr and base::Passed.
This removes the reference counter modification of [B] and hence removes the
race condition.

BUG=390851

Review URL: https://codereview.chromium.org/807423002

Cr-Commit-Position: refs/heads/master@{#309396}

BUG=433728
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/797553004

Cr-Commit-Position: refs/heads/master@{#309395}

The test is failing consistently on the MSAN bots.

TBR=ranj@chromium.org
NOTRY=true
BUG=444477

Review URL: https://codereview.chromium.org/819833002

Cr-Commit-Position: refs/heads/master@{#309394}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/caad676..c6e6ddb

TBR=

Review URL: https://codereview.chromium.org/815183003

Cr-Commit-Position: refs/heads/master@{#309393}

The cause of this bug was that class name of Ribbon element was mistakenly deleted in http://crrev.com/815053003 and CSS to hide this element becomes not applied.

BUG=444474
TEST=Manually tested.

Review URL: https://codereview.chromium.org/815853003

Cr-Commit-Position: refs/heads/master@{#309392}

I forgot removing these when doing:
https://chromium.googlesource.com/chromium/src/+/13f5f5e58cf2b2bf9a5ad9918a37294d38bb2c4c

BUG=338338
TEST=compiles
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/791903004

Cr-Commit-Position: refs/heads/master@{#309391}

r307806 introduced a bug where a user was unable to create shortcuts
from the chrome://extensions page on Windows/Linux. This patch fixes it
by searching for all extensions, rather than just enabled ones.

BUG=443882

Review URL: https://codereview.chromium.org/819823002

Cr-Commit-Position: refs/heads/master@{#309390}

The GFX (GEN 7) in Intel BayTrail has poor performance with MSAA, due to
some hardware architectural limitation. We tend to think this GFX is not
suitable for MSAA, so this CL would disable it. See more details in related
issue.

BUG=443517

Review URL: https://codereview.chromium.org/788143005

Cr-Commit-Position: refs/heads/master@{#309389}

Gallery instantiates EntryListWatcher to delete gallery items at the time when
the corresponding entry is removed on the files app.

The CL also fixes the 'splice' event handling of UI classes in Gallery, which is
called when the Gallery.Item is removed from ArrayDataList by EntryListWatcher.

BUG=436350
TEST=None

Review URL: https://codereview.chromium.org/813263002

Cr-Commit-Position: refs/heads/master@{#309388}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cc7a400..caad676

TBR=

Review URL: https://codereview.chromium.org/823513002

Cr-Commit-Position: refs/heads/master@{#309387}

Revert of Fix crash after Launcher drag/drop (take 2) (patchset #1 id:1 of https://codereview.chromium.org/792883006/)

Reason for revert:
The new test is still causing problems. See http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/44030.

The test appears to be flaky. It has failed on that bot on 4 of the 6 runs since this change landed.

BTW I'd add calamity@ to any reviews of dragging in the launcher as he has fixed many bugs there and is aware of many subtleties in the code.

Original issue's description:
> Fix crash after Launcher drag/drop (take 2)
>
> BUG=439055
> TEST=In Launcher, drag app to solitary folder on second page
>
> This is a retry of https://codereview.chromium.org/780023002/ ,
> which was reverted after commit due to a failed valgrind test.
>
> Committed: https://crrev.com/62e30ca368387d4edbbbf5c721f30881586b2387
> Cr-Commit-Position: refs/heads/master@{#309235}

TBR=jennyz@chromium.org,glevin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=439055

Review URL: https://codereview.chromium.org/820943003

Cr-Commit-Position: refs/heads/master@{#309386}