- 09 Sep, 2019 40 commits
-
-
https://crbug.com/996337Lucas Furukawa Gadani authored
Bug: 996337 Change-Id: I18d8fee2f27842abd3ab48cb5bde90815afba5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785078 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#694873}
-
Haiyang Pan authored
It looks like this target does not apply to x86. See https://cs.chromium.org/chromium/src/chrome/android/BUILD.gn?rcl=833be61e91e914e4e84dd2f2a86d35433746b8c8&l=2160 and https://cs.chromium.org/chromium/src/chrome/android/static_initializers.gni?rcl=909cd47e9565dc8cca8b1ca5e7647203b325c851&l=15 Bug: 997376 Change-Id: Id2f6c5dc9112a058bb6ef3d85569faeeafcd04ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790431Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#694872}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /media. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=sandersd@chromium.org Bug: 891670 Change-Id: I6a3dfc2fa21be93d5ebb050de7df8db034dd8cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787198 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694871}
-
James Darpinian authored
Clusterfuzz found a null dereference crash here. In the case where the context is lost, uniforms_es3_ can be invalid. Bug: 1001285 Change-Id: I8c9984ccf13e4c26252017efbd0ec39a486a73a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792139 Auto-Submit: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#694870}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ddef8d1b6b07..9e380fd484db git log ddef8d1b6b07..9e380fd484db --date=short --no-merges --format='%ad %ae %s' 2019-09-09 sprang@webrtc.org Improve performance of RtpPacketHistory 2019-09-09 ilnik@webrtc.org Reland "Refactor FEC code to use COW buffers" 2019-09-09 sprang@webrtc.org Remove usage of RtpRtcp::SetSSRC() in RtpRtcpImplTest 2019-09-09 andreidumitru@google.com Add option to enable retransmission for all temporal layers in the constructor for rtp_sender_video. 2019-09-09 eshr@google.com Add qualityLimitationResolutionChanges stat 2019-09-09 orphis@webrtc.org Connect the stable target rate to the video encoders Created with: gclient setdep -r src/third_party/webrtc@9e380fd484db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I9af999abb9d9d2f1b7314fc027cc03e591ad786a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694869}
-
Gayane Petrosyan authored
This is a reland of f5a9a694 Original change's description: > [Cleanup] Move complex color calc out of searchbox_extension.. > > In this CL the logo and shortcut color calculation is split into 2 parts. > The color calculation based on the theme is moved to themes, and > defaults are moved to ThemeProperties. > The logo and shortcut colors can be overridden when custom background is > set. This logic is moved to instant_service. > > NTP text and logo_alternate logic is also moved out of > searchbox_extension. > > Bug: 983717 > Change-Id: I12b938ba8a833bd920cf224171163781889989a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759150 > Reviewed-by: Oliver Chang <ochang@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691869} TBR=ochang@chromium.org Bug: 983717 Change-Id: I1a72f7e4d7c48289ed9cb8b0341b448c03b025f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778856 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#694868}
-
Sigurdur Asgeirsson authored
Bug: 910288 Change-Id: I99c2917452ef0f16f391fb0d0592be07480ccafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791269Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694867}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/efce0d1b7657..6a860326887f git log efce0d1b7657..6a860326887f --date=short --no-merges --format='%ad %ae %s' 2019-09-09 brucedawson@chromium.org Handle GOMA_DISABLED more precisely Created with: gclient setdep -r src/third_party/depot_tools@6a860326887f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:b/140312943 Change-Id: I0d8d28c96997af61759196d10f65dd814435e9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793223Reviewed-by:
-
Rahul Singh authored
This CL changes how we overload caption styling on Windows. Going forward, we will overload a caption styling property only when a user explicitly sets it in Settings (set to something other than Default). Previously we always overloaded styling with OS preferences, even when a property was set to Default. This change aligns with changes to macOS behavior that went in recently https://crrev.com/c/1764966 Bug: 1000515 Change-Id: Ibdaaa8a40653543367eb655bd6b0945d78dd516c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786870Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#694865}
-
Gary Kacmarcik authored
This cl also removes some support for the ICE protocol to simplify the display handling code. Change-Id: I64523c0fc766cd80acdaae832c8f0fa08bb59757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790274 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#694864}
-
Sidney San Martín authored
Sometimes, a browser window isn't considered "on the current space" during the fullscreen transition at the moment the exclusive access bubble is displayed. Fix by checking again at the end of the transition. Bug: 1000882 Change-Id: Ia2ef081098ca84f975dd26dfa6bf2615a3094af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790378 Auto-Submit: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694863}
-
Kristi Park authored
This reverts commit d4a3f593. Reason for revert: Encountering issues such as http://crbug/1002013 Original change's description: > [NTP] Fix bottom border of focus ring in richer picker > > Before: http://screen/VS5BsT3hGH1.png > After: http://screen/9x05VZFtAkS.png > > Bug: 997665 > Change-Id: If76461a2b26ebad7ad48d9bd157af4d7a76d8070 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772124 > Commit-Queue: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Auto-Submit: Kristi Park <kristipark@chromium.org> > Reviewed-by: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690525} TBR=kristipark@chromium.org,kmilka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 997665,1002013d Change-Id: I4500159c78eca3429528a4aa55071ff3a43d9b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790146Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#694862}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new Mojo types. - Apply pending_receiver to CreateGpuMemoryBufferFactory Bug: 955171 Change-Id: I84cb8e73efcfa2d499bc8f568d5586744e8be7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792023 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#694861}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28d40b2e7ade..3fdfe2823866 git log 28d40b2e7ade..3fdfe2823866 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 brianosman@google.com Simplify GPUSink constructors by just passing the config object Created with: gclient setdep -r src/third_party/skia@3fdfe2823866 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I6a7eacecb9c1ad1cb2cbb0ea95cf1054b34c7fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793226Reviewed-by:
-
Saman Sami authored
The tests were disabled due to timeout when native Vulkan is used, so use swiftshader instead. Bug: 940723 Change-Id: Ida3745c7d6d480aebf1a56498b3242a1b77353d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790198 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#694859}
-
Esmael El-Moslimany authored
Bug: 980856 Change-Id: Ia28c8b4fe90b7fdad5c43660e3a4006a8673c321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788225 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#694858}
-
Adithya Srinivasan authored
Follow up to https://crrev.com/c/1789532, actually marks the tests as disabled. Bug: 997634 Change-Id: I15918a7ce52be12dcb8a1af2ad20affe28a56f67 Tbr: treib@chromium.org, olka@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793245Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#694857}
-
Derek Beckett authored
There are some device protos which have the same field names (e.g. enabled). Currently the policy_server cannot differentiate between them. This will all setting these by: "groupname.fieldname", e.g: "device_power_peak_shift.enabled". TEST=Locally deployed and tested BUG=TBD Change-Id: I9565f3082ed192e787b2a00efec1ae29ebe195f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790534Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Derek Beckett <dbeckett@chromium.org> Cr-Commit-Position: refs/heads/master@{#694856}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/03038a48..e6d242c0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I25eac74326f61f2d300a55890cd830c925485759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792850Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694855}
-
Brian Sheedy authored
Adds several notes about running swarmed tests with extra arguments in docs/workflow/debugging-with-swarming.md. Change-Id: I751e0237399ff96626ef699b9a66e598eb07ab5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793282 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#694854}
-
Tom Anderson authored
Fixes this error: [ 375s] In file included from ../../base/task/common/intrusive_heap.h:8, [ 375s] from ../../base/task/thread_pool/task_source.h:17, [ 375s] from ../../base/task/thread_pool/task_tracker.h:27, [ 375s] from ./../../base/task/thread_pool/service_thread.cc:14, [ 375s] from gen/base/base_jumbo_28.cc:5: [ 375s] ../../base/containers/intrusive_heap.h:152:36: error: enumerator value '-1' is outside the range of underlying type 'size_t' {aka 'long unsigned int'} [ 375s] 152 | enum : size_t { kInvalidIndex = -1 }; [ 375s] | Change-Id: I6044fb704931b2f8416f6b19a247ae297cd7b0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792763 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#694853}
-
Livvie Lin authored
This mode will be triggered from PrepareErrorPage in a follow-up CL. Currently, this new code path doesn't change any behavior because a null callback from AllowCertificateError will follow the usual Show() logic. Bug: 987407 Change-Id: I32c2e1bd0fadb7540204e659b218d0138f168260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769353 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#694852}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3c6c057c3feb..ec283489193a git log 3c6c057c3feb..ec283489193a --date=short --no-merges --format='%ad %ae %s' 2019-09-09 simonhatch@chromium.org Pinpoint - Create single set of hidden inputs Created with: gclient setdep -r src/third_party/catapult@ec283489193a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:1001757 Change-Id: Iebf26a9847474abb27423e097718f85397738ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791624Reviewed-by:
-
Tommy Li authored
This makes some minor refactors to the usage of AutocompleteController::in_start_. 1. It delays setting it to false until after the UpdateResult call within the synchronous pass. This is more accurate, and also allows in_start_ to be used as a synonoym of in_synchronous_pass_. 2. It also moves in_start_ to be an early exit condition for OnProviderUpdate. It likely doesn't need to be checked there at all, since the comments indicate it's likely ALWAYS false when OnProviderUpdate is called. These refactors help pave the way for the feature to preserve the default match during the asynchronous pass, by clarifying in the code when the synchronous vs. asynchronous pass occurs. Bug: 398135 Change-Id: I8f8c61b8233b1c049338dac448b6ef8f1b0e3b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789823Reviewed-by:Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#694850}
-
Javier Fernandez authored
When calculating the min-content contribution of a grid item of an auto sized grid track we must consider the grid item's margin. When the grid item's area is indefinite, a percent margin is resolved to zero. However, when performing a relayout, the percent margin may be solved against the previously computed grid area, since the grid item has already an OverrideContainingBlockLogicalWidth value. In order to re-compute the percent margin properly, we need to clear the previously override value. It's important be careful of not clearing the override value set during intrinsic size, since we need it for the actual layout phase. Hence, we only reset the 'override' value when we are executing a definite strategy. Bug: 834643 Change-Id: Ib936b26bee1da76afbdc886eb775746e13d40988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782840 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#694849}
-
Adithya Srinivasan authored
Bug: 1001446 Change-Id: Ia2c182bd2f622ccd07196770b443e92c610e3130 Tbr: mlamouri@chromium.org, msramek@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793232Reviewed-by:
-
rbpotter authored
- Autogenerate Polymer 3 cr-expand-button and tests - Add to demo page - Autogenerate modulized focus_without_ink, since the button depends on this file. - Update the js_modulizer script to add a way to ignore some lines Bug: 965770 Change-Id: I08b0613b3140b773039855af0105fecb72860987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788321Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#694847}
-
Henrique Ferreiro authored
Convert the implementation and all users of the ash::mojom::AssistantAlarmTimerController, AssistantNotificationController and AssistantScreenContextController. Bug: 955171 Change-Id: I19142850f1cd445f6d43a4caf4c7bd88415680c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789386Reviewed-by:
-
Sadrul Habib Chowdhury authored
Add the checkerboarding metrics in the rendering benchmarks. Adding these extra histograms do not affect the size of the output traces by much. Below are some sample trace-sizes from pinpoint (10 traces for each story): . On windows: - amazon_pinch: 56.32MB -> 56.32MB - twitter_pinch: 58.68MB -> 57.49MB . On pixel 2: - bouncing_balls_shadow: 41.69MB -> 41.74MB - bing_mobile: 57.08MB -> 57.14MB BUG=984592 Change-Id: I3fdb065f8b85814a7b900c46b14f569ec406c243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785418Reviewed-by:Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#694845}
-
Robert Liao authored
BUG=865318 Change-Id: I03ebbfdc95622f986e6271dbede4d1bfa740c5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788198 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#694844}
-
Leon Han authored
BUG=520391 Change-Id: I5b9a807081657f2d211575a282ae7fa7f45c71ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791927 Auto-Submit: Leon Han <leon.han@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#694843}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/44e6523d7ff3..cebb9635a5d5 git log 44e6523d7ff3..cebb9635a5d5 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 jmadill@chromium.org GN: Expose XCB surface extension on Linux. Created with: gclient setdep -r src/third_party/swiftshader@cebb9635a5d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140251624 Change-Id: I90a2718722f7687e3d945c6389a6384ef256edb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792000Reviewed-by:
-
Andrew Grieve authored
.part.end is a new section introduced by "partitioned libraries", a part of DFMS. It's a NOBITS section, so needs to be counted the same as .bss. This fixes some CQ runs failing due to: AssertionError: Padding was: $SOME_SMALL_NEGATIVE_NUMBER Bug: 1002085 Change-Id: I49e892d22f8888fd991202d99bc67e342c06db52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791999 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#694841}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/bookmarks. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. Edit: Revert changes to BookmarkNodeDataTest and BookmarkUtilsTest which rely on base::ThreadPool. R=sky@chromium.org Bug: 891670 Change-Id: I8a37c3ecc469fcbbdc52b80724f5d8b073e30414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786903 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a0b94071e6bd..ac68e9c3dd09 git log a0b94071e6bd..ac68e9c3dd09 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 lalitm@google.com trace_processor: migrate track table to new table macros 2019-09-09 lalitm@google.com trace_processor: make inserting into macro tables more explicit 2019-09-09 lalitm@google.com Merge "trace_processor: refactor Column to reduce boilerplate when adding types" 2019-09-09 hjd@google.com Merge "ui: Show full timestamp" Created with: gclient setdep -r src/third_party/perfetto@ac68e9c3dd09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627,chromium:135177627 Change-Id: If7b064422fdcbcddc16a9798adbc047f3dc9274e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792001Reviewed-by:
-
Yun Liu authored
Revert this if capacity is not enough. Bug: 731759 Change-Id: Ia757461849ff14f277b23f3f6869e9d7c4e2bd61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790729Reviewed-by:
-
Mohammad Refaat authored
The problem is the fullscreen VC is presented the ContentView is stashed to another window to keep the renderer from being killed. Then when when that VC is dismissed the contentView is inserted on the top of the container view, and that will cover any other view that was presented on the container view. The solution is to insert the contentView on the back of the container view. Bug: 982845 Change-Id: I65e1cb20cb7cdbb6396678cbc3fc26108a932a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788242Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#694837}
-
Daniel Rubery authored
This CL marks the following histograms as obsolete: SBClientDownload.DownloadFileHasDetachedSignatures SBClientDownload.ZipFileFailureByType SBClientDownload.ZipFileSuccessByTyep Since they are historically stable and not being used It extends the lifetime of: SBClientDownload.ZipFileSuccess Since it shifted dramatically in M75. Bug: 988809 Change-Id: I3add7ec4972d6be4ac0f4492f91cdfb643c88619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784970Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#694836}
-
Brandon Wylie authored
This will be helpful in methods such as typeInOmnibox, which rely on the assumption that the omnibox will have focus. Putting it in its own util file because it seems generally useful. Bug: 1000315 Change-Id: I7cb390046462c584ad48785963941fce133da0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784882 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#694835}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2aaf66e4644a..ddef8d1b6b07 git log 2aaf66e4644a..ddef8d1b6b07 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 titovartem@webrtc.org Add support of displaying video during the PC level test Created with: gclient setdep -r src/third_party/webrtc@ddef8d1b6b07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ib363502b20bc8cf7ee95fb2dea2ec71b7a87cf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792447Reviewed-by:
-
