GitLab

BUG=none
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11817022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175859 0039d316-1c4b-4281-b951-d872f2087c98

This is a step toward making third_party/khronos/gl2.h and gl2ext.h
have as few modifications as possible.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11782020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175858 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168820
TEST=open lots and lots of tabs. The close button stays centered in
the selected tab, and the background tabs don't become so small that
they look clipped. If too many tabs are opened, they just wander
out of the window to the right, like previously -- this time do this
on a retina display.

Review URL: https://codereview.chromium.org/11821030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175857 0039d316-1c4b-4281-b951-d872f2087c98

chromium.perf bots don't run any tests through bb_tests, so they
stopped running device_status_check.  Fix this by running
device_status_check always if bb_tests is called.

R=cmp
NOTRY=true

Review URL: https://codereview.chromium.org/11827025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175856 0039d316-1c4b-4281-b951-d872f2087c98

This version has a shorter bottom-edge shadow which makes the windows look
better when they are at the bottom of the screen near the launcher. It also
eliminates some subtle noise in the RGB channels.

BUG=168300
TEST=manual, shadows look correct on normal and high resolution displays

Review URL: https://codereview.chromium.org/11824033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175855 0039d316-1c4b-4281-b951-d872f2087c98

Use the Chrome style rather than the NaCl style.

Also remove "struct" keywords and use a C++-style cast.

BUG=none
TEST=build

Review URL: https://codereview.chromium.org/11828010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175854 0039d316-1c4b-4281-b951-d872f2087c98

I keep having to look this up from the implementation

BUG=none
TEST=none
TBR=sky@chromium.org - it's just a comment

Review URL: https://codereview.chromium.org/11820027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175853 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergiu@chromium.org
BUG=169042
TEST=none
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11826029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175852 0039d316-1c4b-4281-b951-d872f2087c98

R=achuith@chromium.org
BUG=None
TEST=PromoResourceServiceTest.NotificationPromoTest passes on bots and doesn't
hurt achuith@'s eyes so much.


Review URL: https://chromiumcodereview.appspot.com/11823007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175851 0039d316-1c4b-4281-b951-d872f2087c98

By reusing the ui_test_utils::WaitForBookmarkModelToLoad() function we don't
need to rely on content::NotificationRegistar/Service nor use
chrome::NOTIFICATION_BOOKMARK_MODEL_LOADED.

BUG=144783
R=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11787025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175850 0039d316-1c4b-4281-b951-d872f2087c98

(SystemMenuModelBuilder) and makes BrowserFrame implementation use
it. BrowserFrame also provides support for showing the system menu via
views::MenuRunner. This is used everywhere but BrowserFrameWin and
BrowserDesktolpRootWindowHostWin. Both of these use the system menu.

BUG=none
TEST=make sure system menu (right click above tab strip) works on
windows and chromeos.
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11819008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175849 0039d316-1c4b-4281-b951-d872f2087c98

This failure is caused by crrev.com/175642.

So we use file_util::AbsolutePath() to map the path before passing it to ReadFileToString.

BUG=168936
TEST=gpu bots
Review URL: https://codereview.chromium.org/11820034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175848 0039d316-1c4b-4281-b951-d872f2087c98

out/Debug is the current preferred place to put binaries, but keeping
sconsbuild/Debug in the search path because that's where the build
system currently puts it.

More specifically, scripts/slave/extract_build.py extracts builds to src/sconsbuild/Debug rather than src/out/Debug
Review URL: https://codereview.chromium.org/11824011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175843 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175840 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r10534: (mseaborn) Mac: Fix an off-by-one corner case in handling single-stepping on x86-32
r10535: (mseaborn) Thread suspension: Fix querying registers for another Mac OS X corner case
r10536: (mcgrathr) toolchain_build: Update binutils and gcc revisions
r10537: (mseaborn) GDB tests: Improve error reporting when GDB's "reason" field is missing
r10538: (eliben) Fix pnacl driver tests to look for x64 host dir when x86-32 isn't built
r10539: (jfb) ARM: delete stale files and code.
r10540: (mcgrathr) Disable performance tests under qemu
r10541: (mcgrathr) Segregate trusted/untrusted values of MXCSR
r10542: (mcgrathr) Disable run_performance_test via tests_to_disable_qemu not is_broken
r10543: (petarj) [MIPS] Update pnacl_llvm_rev and pnacl_gcc_rev
r10544: (eliben) Moved pnacl driver tests to a sub-directory separate from driver scripts.
r10545: (kschimpf) Fix uses in ARM table: parallel_addition_and_subtraction_unsigned
r10546: (kschimpf) Automatically generate actual decoders from information in the ARM decoder table.
r10547: (sbc) Remove output chatter from ld_bfd.py run.
r10548: (sbc) Add libspeechd-dev to ARM root image.
r10549: (kschimpf) Add uses to ARM table packing_unpacking_saturation_and_reversal
r10550: (mseaborn) MIPS trusted toolchain: Don't skip QEMU patch if the file is missing
r10551: (mseaborn) GDB test: Increase sleep time to reduce the chance of a flaky failure
r10552: (mseaborn) Thread suspension: Disallow setting register state during context switch
r10553: (jvoung) Allow overriding driver env with test settings.
r10554: (mcgrathr) Put code chunks to be copied in rodata, not text
r10555: (mseaborn) Enable most of the GDB tests on ARM
r10556: (mcgrathr) toolchain_build: Update binutils revision
r10557: (kschimpf) Add uses to ARM table branch_branch_with_link_and_block_data_transfer.
r10558: (jfb) Update LLVM's known failures.
r10559: (mcgrathr) toolchain_build: Update gcc revision
r10560: (jvoung) Make LLC use default opt level when pnacl-driver is only used for linking.

BUG=none
TEST=nacl_integration

Review URL: https://codereview.chromium.org/11827011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175838 0039d316-1c4b-4281-b951-d872f2087c98

> Make RenderWidget responsible for the composited view's lifetime
> 
> Chromium side of https://bugs.webkit.org/show_bug.cgi?id=105071.
> content::RenderWidget constructs a WebLayerTreeView when WebKit
> asks it and then retains ownership. This has to be destroyed
> before the WebWidget is closed since the WLTVClient is (currently)
> a WebKit object.
> 
> BUG=156175
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175303
> 
> Review URL: https://codereview.chromium.org/11575049

Broke interactive_ui_tests:ExtensionApiTest.NotificationsHasPermissionManifest
on windows

TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/11778068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175834 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160902

Review URL: https://codereview.chromium.org/11742012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175833 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 4c3f35e3.

Temporarily roll out to see if it caused the performance regression.

TBR=darin,ojan
BUG=169028

Review URL: https://codereview.chromium.org/11821029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175832 0039d316-1c4b-4281-b951-d872f2087c98

The issue was that kExpirationYearInFuture was using system time, but the
expiration check in field_trial.cc was using build time. This CL changes
the constant to be named kExpirationYearNotExpired and sets it based on
build time.

BUG=168799
TEST=New unit test.

Review URL: https://chromiumcodereview.appspot.com/11783033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175831 0039d316-1c4b-4281-b951-d872f2087c98

It's hidden under a flag since it's still work in progress.

BUG=161052
TEST=run chrome with --enable-new-message-center-bubble flag and see the design of the bubble.


Review URL: https://chromiumcodereview.appspot.com/11773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175829 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169031
TBR=scherkus@chromium.org

Review URL: https://codereview.chromium.org/11817021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175828 0039d316-1c4b-4281-b951-d872f2087c98

Chromium side of https://bugs.webkit.org/show_bug.cgi?id=105071.
content::RenderWidget constructs a WebLayerTreeView when WebKit
asks it and then retains ownership. This has to be destroyed
before the WebWidget is closed since the WLTVClient is (currently)
a WebKit object.

BUG=156175

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175303

Review URL: https://codereview.chromium.org/11575049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175827 0039d316-1c4b-4281-b951-d872f2087c98

According to the comment at preferences.cc:96, some accessibility prefs may be already registered in WizardController::RegisterPrefs. But the magnifier prefs are never registered there, hence we can remove if statements.

BUG=none
TEST=launch ChromeOS, and login.

Review URL: https://chromiumcodereview.appspot.com/11820018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175826 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 175782
> > InspectorTimeline improvements
> > 
> > - Split out inspector-neutral parts of InspectorTimeline in preparation for
> >   about:tracing-based timeline
> > - Use event.name instead of type, which is in keeping with trace-viewer
> > - Use ms on units since the rest of telemetry uses seconds, but
> >   for precision reasons, ms makes sense to stick with
> > - Move arguments to event.args so that params get consistent treatment
> >   e.g. event.foo['bar'] is less consistent than event.args['foo']['bar']
> > - Improved test coverage of model, events, parsing
> > - event.self_time which represents
> > - drop events lacking start- or end- times
> > 
> > R=bulach@chromium.org
> > NOTRY=True
> > 
> > Review URL: https://chromiumcodereview.appspot.com/11818024
> 
> TBR=nduca@chromium.org
> Review URL: https://codereview.chromium.org/11733008

TBR=sullivan@chromium.org
Review URL: https://codereview.chromium.org/11817019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175825 0039d316-1c4b-4281-b951-d872f2087c98

Because of relative paths, see 
https://codereview.chromium.org/11782005/

Has paths like
/Volumes/data/b/build/slave/WebKit_Mac10_6/build/src/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/../Resources/missingImage.png


BUG=168890
TEST=webkit tests green
Review URL: https://codereview.chromium.org/11817018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175824 0039d316-1c4b-4281-b951-d872f2087c98

Added TapSuppressionController parameters to GestureConfiguration and
used them in TSC.
Removed command line options for configuring TSC, because now they can
be configured through UI.
Added the ability to configure integer parameters through UI, since TSC
parameters are integers.

BUG=162031

Review URL: https://chromiumcodereview.appspot.com/11745006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175823 0039d316-1c4b-4281-b951-d872f2087c98

Allow multiple WebUIControllerFactory objects to be registered. This makes is possible to implement webui inside content.
Review URL: https://codereview.chromium.org/11783038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175822 0039d316-1c4b-4281-b951-d872f2087c98

After some refactoring, the socket_count is now hardcoded to 1,
so we can assume there is only a single socket and avoid using
a vector as well.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=3241

Review URL: https://codereview.chromium.org/11787029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175821 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary to allow the renderer processes to use NEON
instructions on ARM devices that support them in libraries like
Skia.

The main issue is that on JellyBean and higher, the renderer
process runs in a sandbox that prevents it from accessing the
filesystem, including /proc/ which is the only way to query the
kernel for the features detected by the CPU.

To overcome this, send the result of the probe to each renderer
process, which will use the new android_setCpu() function
introduced in https://gerrit.chromium.org/gerrit/#/c/39370/

Note that this requires that third-party libraries use the
android_getCpuCount() and android_getCpuFeatures() function
to get this data at runtime.

BUG=164154
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11503013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175820 0039d316-1c4b-4281-b951-d872f2087c98

Adds the picture width and height to record and raster trace events used by the picture pile to help
with debugging.



Review URL: https://chromiumcodereview.appspot.com/11830010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167651
TEST=Manual tests on Linux ChromeOS build and Lumpy.


Review URL: https://chromiumcodereview.appspot.com/11672007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175818 0039d316-1c4b-4281-b951-d872f2087c98

BUG=159192
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11827006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175817 0039d316-1c4b-4281-b951-d872f2087c98

It has caused pain in the past and is currently not used on the bots.

BUG=168653
TEST=run_tests.py, run_tests.py -e -n 2

Review URL: https://codereview.chromium.org/11794039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175816 0039d316-1c4b-4281-b951-d872f2087c98

way the code can work on aura too.

BUG=none
TEST=make sure context menu to select columns in task manager still works.


Review URL: https://chromiumcodereview.appspot.com/11821010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175815 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a typo in SessionStateControllerImpl2 where the
wrong duration was being used for the
restore-brightness-and-grayscale animation displayed when
the user releases the power button before holding it long
enough to shut down (it was using 150 ms; this changes it to
500 ms).

It also corrects a similar typo in the undo-move-windows
animation (with no intended changes, though) and changes the
tween type for the abort-shutdown animation to make it less
flickery.

BUG=168793


Review URL: https://chromiumcodereview.appspot.com/11783032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175814 0039d316-1c4b-4281-b951-d872f2087c98

On guest mode, NOTIFICATION_SESSION_STARTED event is not fired. We use NOTIFICATION_PROFILE_CREATED instead.

BUG=167156
TEST=manual

R=zork@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11791016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175813 0039d316-1c4b-4281-b951-d872f2087c98

> InspectorTimeline improvements
> 
> - Split out inspector-neutral parts of InspectorTimeline in preparation for
>   about:tracing-based timeline
> - Use event.name instead of type, which is in keeping with trace-viewer
> - Use ms on units since the rest of telemetry uses seconds, but
>   for precision reasons, ms makes sense to stick with
> - Move arguments to event.args so that params get consistent treatment
>   e.g. event.foo['bar'] is less consistent than event.args['foo']['bar']
> - Improved test coverage of model, events, parsing
> - event.self_time which represents
> - drop events lacking start- or end- times
> 
> R=bulach@chromium.org
> NOTRY=True
> 
> Review URL: https://chromiumcodereview.appspot.com/11818024

TBR=nduca@chromium.org
Review URL: https://codereview.chromium.org/11733008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175810 0039d316-1c4b-4281-b951-d872f2087c98

Currently SSLCertRequestInfo provides a list of applicable client certificates,
filtered against server request. This patch adds the server criteria to the
class as a part of a larger refactoring effort.

BUG=65546

Review URL: https://chromiumcodereview.appspot.com/11739004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175807 0039d316-1c4b-4281-b951-d872f2087c98

adding it to the whitelist for managed users.

This CL adds two user preferences (kManagedModeWhitelist and
kManagedModeBlacklist) which contain URL patterns which should be allowed
or blocked. The user preferences are used only to persistently store the
lists and the checking is done by the ManagedModeURLFilter, which uses
policy::URLBlacklist objects. The code takes care that the preferences and
the URLFilter are kept in sync all the time. It also contains the functions
needed to interact with these lists (adding, removing or checking).

It also adds a preview infobar which pops up when the user clicks Preview
on the interstitial. If the user clicks allow then the website is added
to the whitelist. The domain gets added plus all redirects that lead to
that page. The user is able to click navigate around the website without
getting another interstitial as long as he does not navigate to a different
host name.

BUG=168772

Review URL: https://chromiumcodereview.appspot.com/11299035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175806 0039d316-1c4b-4281-b951-d872f2087c98

This test was crashy on Windows, but the call stack was insufficient
to diagnose. As there have been some infobar refactorings since this
test was disabled, let's reenable it.

TEST=GeolocationBrowserTest.NoInfoBarBeforeStart
BUG=66400


Review URL: https://chromiumcodereview.appspot.com/11573009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175805 0039d316-1c4b-4281-b951-d872f2087c98