GitLab

The feature continues to be disabled by default for mobile platforms.

Bug: 1044212
Change-Id: Ia4e1056a9c54786071d236a0df007060b8faf287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264797
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782210}

Adds the "ask when to download" setting in download setting page.

Bug: 1078454
Change-Id: I8974413fc720694ca1cb39cd3ba740d47c480e6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265174
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782209}

Previously, a query for "Google" would only show results related to the
Google Assistant. This CL downgrades the default ranking for several of
these search tags so that other Google-related content is surfaced.

Fixed: 1096809
Change-Id: I75c2ade1a5997742fa18840a2d81e5ca112ccf40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265438
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782208}

The new VD-based video decoder was initially built to support stateless
(slice-based) decoders, but it is now able to handle both stateless and
stateful ones now. Rename its source files to a shorter and more
accurate name.

BUG=b:149663704
TEST=VDAtest --use_vd runs on Hana-kernelnext.

Change-Id: Ief2250ee88d7c64a5b98b3dd57cef61e861a9eb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262752
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Fritz Koenig <frkoenig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782207}

This makes text-to-speech stop if the hosting WebContents is
hidden, which differs from Clank (Clank stops when all activities
are hidden). I think stopping when hidden is good for the current
use case, but will need to be revisted at some point.

BUG=1025626
TEST=wpt tests should cover this

Change-Id: I631da77676f7822583e379cf2e51d5534d8199cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264621
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782206}

I want to use this to make the new fyi bot use the 11 SDK.

Downstream projects will have to add

  'mac_xcode_version': 'default',

to the `vars = {` section of their toplevel DEPS section to roll
in build/ with this change.

Bug: 1098738,1098454
Change-Id: I3939da4c83d733c6c08deded4520e824dbd89043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264867
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782205}

The flag was technically removed but some crumbs stayed behind.

Bug: None
Change-Id: Iceff8d8a307761d3829cd59ee9144e85d1d7a4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261692
Commit-Queue: David Trainor <dtrainor@chromium.org>
Auto-Submit: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782204}

This changes the following:
. only start utterances that were created from a WebContents if the
  WebContents still exists and is not hidden.
. stop utterances if the WebContents is destroyed.
. Makes TtsPlatformImpl.java work without ApplicationStatus.
  ApplicationStatus is not used in webview/weblayer.
. Adds the ability to stop speaking if the hosting WebContents is
  hidden. I will make this the default in WebLayer, where there is no
  ApplicationStatus and it's not as clear that speaking should continue
  if the WebContents is hidden.

Patch that enables TTS for WebLayer is here:
https://chromium-review.googlesource.com/c/chromium/src/+/2264621

BUG=1025626

Change-Id: I061cadfb50c35dff64a76e2b9953ef60aff36bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261098
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782203}

The flaky part of this test is the same implementation as the other
tests in this file. The test is not flaky locally. Re-enable the test,
but also improve error logging to better debug this issue if it
re-occurs.

Fixed: 1098758
Change-Id: I9f09329f155a9b0824b88ed05cea4801cf6195b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264625
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782202}

Accidentally used 'betty-arc-r' when adding the configs in
crrev.com/c/2258681 instead of the correct 'eve-arc-r' board. Whoops.

This replaces the typos.

Bug: 1092973
Change-Id: Id4cc7d116cda526dfd3de4232b90041b20f71830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264948
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782201}

This patch changes "editing/deleting/delete-line-011.html" to utilize
|selection_test()| for ease of maintenance and enabling EditingNG.

Bug: 679977, 707656
Change-Id: Idea7bfc5d30c9b6b1b33ccc07928097347299127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262078
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782200}

These are currently in Gatekeeper. The Gatekeeper version will be
removed once this is live.

Bug: 1094768
Change-Id: Iceac783b4d307c1a09655dba7f901683b994e2ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262554Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Owen Rodley <orodley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782199}

On some platforms, printing backends may have printer settings that
are intended to be sent during print jobs, but those are currently
dropped. Place those settings/options in the job settings in the
|advanced_settings| field and send them in Linux print jobs. That way
the lpoptions can be sent.

Bug: 466717
Change-Id: I9950cd352dad00897d8378df24d405c6b6341525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240282Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782198}

This is a reland of 30e7e503

TBR=ellyjones@chromium.org,dcheng@chromium.org,huangs@chromium.org,steimel@chromium.org

Original change's description:
> [Kaleidoscope] Add native parts to OSS repo
>
> Add the Kaleidoscope native parts to the OSS repo.
>
> BUG=1044741
>
> Change-Id: I8562c8e35db2d1fa0ef8ce140ddbbc57ca7a9991
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255563
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#782073}

Bug: 1044741
Change-Id: I469ed19af1e056f7b62c7abc764933e707b94e94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264608Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782197}

https://chromium.googlesource.com/openscreen.git/+log/d626fbec817d..dd834a700e0c

2020-06-24 rwkeane@google.com Force CodeCoverage Full Build

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I637f1398cc26ec2c048e232586f67193c83a90b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265572Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782196}

Roll Chrome Win64 PGO profile from chrome-win64-master-1593028798-f93250a81e374d70a67d584bcb245354b4612f62.profdata to chrome-win64-master-1593032304-90202fa1b4038f00c77b47bcef25599006092a46.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I50212f1398d264f073ea14d49fc2a3c178c9420f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265557Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782195}

All uses of it are for main frame. We do not want any new uses of it, so
renaming makes things clearer. Also, add a DCHECK to enforce it.

Change-Id: I7c34f4b6bc7bbf3f02572a684aeb3ecb34e090c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263512Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Auto-Submit: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782194}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I0ec739e8176d747c5b6fee4d4052e0e9a066d90b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265485Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782193}

Disable failing test.

Bug: 1058255
Change-Id: I608bd247ee19cfdabb972e5f8dc6122286d4c703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264937
Commit-Queue: Chong Gu <chonggu@google.com>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782192}

The Epson "Ink" PPD attribute is causing bloated monochrome print jobs.
Temporarily remove support until a fix is found.

Bug: 1081705
Change-Id: I9f45384ece665209e27489b847ad57849ba1321c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265436Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782191}

https://skia.googlesource.com/skia.git/+log/2639a144ff41..34878824fc18

2020-06-24 michaelludwig@google.com Revert "Implement Skottie vs Lottie perf tool"
2020-06-24 bsalomon@google.com Add another make_get_error_with_random_oom valgrind suppression
2020-06-24 egdaniel@google.com Revert "Make glPatchParameteri required when tessellation is supported"
2020-06-24 michaelludwig@google.com Revert "Simplify GrClip API"
2020-06-24 jmbetancourt@google.com update gradle version for android projects
2020-06-24 senorblanco@chromium.org Fix RTHeight for SkRuntimeEffectSimple case.
2020-06-24 egdaniel@google.com Fix d3d PromiseImageTest
2020-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 92379bff49c2 to 8ab3719fc486 (2 revisions)
2020-06-24 brianosman@google.com Reland "Remove SkSpecialImage::makeTextureImage"
2020-06-24 johnstiles@google.com Add support for magenta highlights on shader mouseover in Metal.
2020-06-24 stani@google.com Implement Skottie vs Lottie perf tool
2020-06-24 michaelludwig@google.com Revert "simplify freeAll"
2020-06-24 rmistry@google.com Update path to fix Android ASAN bots
2020-06-24 bsalomon@google.com Add GrContext::oomed() and implement for GL and VK.
2020-06-24 johnstiles@google.com Fix crash in Viewer when attempting to view shaders in Metal.
2020-06-24 johnstiles@google.com Rename MakeResult so that it can be used more broadly.
2020-06-24 robertphillips@google.com Add GM::gpuSetup call in fm
2020-06-24 michaelludwig@google.com Simplify GrClip API
2020-06-24 robertphillips@google.com Misc changes to get *ooprdll configs running
2020-06-24 mtklein@google.com update ApplyMatrix signature
2020-06-24 egdaniel@google.com Make sure we hold refs to sampled textures in d3d.
2020-06-24 robertphillips@google.com Revert "Ignore calls to freeGpuResources on abandoned contexts"
2020-06-24 brianosman@google.com Revert "Remove SkSpecialImage::makeTextureImage"
2020-06-24 jvanverth@google.com Disable one more D3D test
2020-06-24 robertphillips@google.com Update viewer to call the gpuSetup GM entry point
2020-06-24 kjlubick@google.com [canvaskit] High performance Path APIs
2020-06-24 fmalita@google.com Reland "[skottie] skottie_tool updates"
2020-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9daab8cbffb7 to 1496de215a39 (13 revisions)
2020-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9167e1e22a46 to eb0a25a189b7 (3 revisions)
2020-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from adf736e2 to 66992a84 (532 revisions)
2020-06-24 fmalita@chromium.org [skrive] Parse ellipse data
2020-06-24 reed@google.com add simple pathbuilder
2020-06-23 brianosman@google.com Supply device and local coords to SkShader_Base::onProgram
2020-06-23 scroggo@google.com Roll NDK to r21d
2020-06-23 jvanverth@google.com Adjust which Direct3D tests are disabled
2020-06-23 jvanverth@google.com Disable PromiseImageTextureShutdown test for D3D
2020-06-23 herb@google.com make internal shared methods
2020-06-23 csmartdalton@google.com Make glPatchParameteri required when tessellation is supported
2020-06-23 herb@google.com simplify freeAll
2020-06-23 brianosman@google.com Remove SkSpecialImage::makeTextureImage
2020-06-23 kjlubick@google.com [demos] Move to subdir

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1093997,chromium:812428
Tbr: lovisolo@google.com
Test: Test: ran run_perf.sh and it outpus perf metrics
Change-Id: I5a5830bbcac8ef05570c7f5de4467985b290934d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264930Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782190}

This reverts commit 25269f24.

Reason for revert: test testSetUp_SuppressingSignInPromo fails constantly in android-arm64-proguard-rel (and fyi builder android-marshmallow-x86-fyi-rel) since
* https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2020
* https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/767

Original change's description:
> [HomepagePromo] Add finch param supressing_sign_in_promo
> 
> Adding the option for homepage promo to suppress the sign in promo when
> user is not signed in.
> 
> Bug: 1068831
> Change-Id: I854109c4623c47f98aab1faa34f94f2d55961474
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252379
> Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#781109}

TBR=twellington@chromium.org,wenyufu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1068831
Change-Id: I97f226e93962469cc8a705e922a3db72d7e84cd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265398Reviewed-by: Haiyang Pan <hypan@google.com>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#782189}

Roll Chrome Mac PGO profile from chrome-mac-master-1593021431-7b0ea0cd42ff146f154f99cb6b34c129710780a4.profdata to chrome-mac-master-1593043069-f3715f15f4d35968d8c3bf9fcf15b306aa3a92c4.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I3b76f8af9939a80066b89b3689a164f620e1aee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265486Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782188}

See attached bug for screencasts of before/after (note that the After screencast comes first).

Notable differences:
- It's now possible to drag past the last few tabs in the tabstrip (bug fix).
- There is no longer a big gap to the left of the dragging header when dragging right. This essentially makes the header feel like it's the size of a tab, whenever the slots switch.

Remaining issue:
- Dragging past a group (expanded or collapsed) still leaves a big gap to the left of the dragging header. This is an existing issue that I'm not prioritizing, since it's not strictly a bug and the solution is likely in a different part of the code.

Bug: 1095799
Change-Id: Ieff4b9cba9d5568a0c1aefcdb67525d156c0668a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265556Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782187}

This CL adds a job id for download later job, also does some refactor
for auto resumption handler test, which prepares for adding the
scheduling logic to auto resumption handler.

Bug: 1078454
Change-Id: I6eb27477ba7b12ef657bdcfe3a4f11fc9ad3d6ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262124Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782186}

Bug: 1068400
Change-Id: Id88ff78abbb1e5906208d13bd7034ddefd3ba038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258332Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782185}

- Test WeakPtr before using it
- Previous code was DCHECK'ing but that was incorrect

BUG=1086012
TEST=manual

Change-Id: Id1aefa57f9b92580fd47d1aeb213ca922bf78116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265243
Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782184}

DOMWindowSppechSynthesis exists only to act as a Supplement to hang
the SpeechSynthesis off a LocalDOMWindow. There's no need for two
objects here: the SpeechSynthesis can be the Supplement<LocalDOMWindow>,
so long as it implements the static getter required by the IDL.

This also allows us to take a LocalDOMWindow& in the SpeechSynthesis
constructor, which removes the need to DCHECK what kind of
ExecutionContext the constructor is given.

Change-Id: I5ae8ef8877a0d4f308475ec76dfc3b661e6bbb3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261712
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782183}

This cl refetches missing icons for already installed payment apps with
web app manifests. Screencast of the fix is attached to the bug.

Bug: 1069010
Change-Id: Ibd1e191f199295fb8301a4202cc7512b66408f05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264860
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782182}

This does not align with the spec [1], which uses the term "Master". However,
given that:
 1. This is not a web-observable name for this concept.
 2. Chromium is the only engine that ever supported HTML Imports.
 3. HTML Imports is deprecated and due for removal by M88.
...this rename seems fairly innocuous.

[1] https://www.w3.org/TR/html-imports/#dfn-master-document

Fixed: 1099013
Change-Id: I433747b2d707b8c9858dd15a7506aead064ae615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264611
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782181}

This CL shows the lookalike interstitial for domains such as
þook[.]com where the character þ is only allowed in Icelandic TLDs
(.is).

Bug: 1095120
Change-Id: Ied9ce3fb1147ee041bd3cd167d722888a76469e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258968Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782180}

- Fixes a unintended behavior in where cancelling a print job through
  the print management app would display an error message in the
  print job notification.

Bug: 1053704
Change-Id: I522542cf997a77e22a79c6f8e72e64f3ef5773c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262415Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782179}

Five histograms are added.
GPU.DirectComposition.CreateVideoProcessorEnumerator
GPU.DirectComposition.DcompDeviceCreateSurface
GPU.DirectComposition.UploadVideoImages.CreateCopyTexture
GPU.DirectComposition.UploadVideoImages.CreateStagingTexture
GPU.DirectComposition.VideoDeviceCreateVideoProcessor

Remove two DisableOverlays() in CreateDecodeSwapChain. If the creation
fails, it will go to CreateSwapChain for YUY2 or BGRA. If all fail,
overlays will be disabled at the last step before returning to the
Renderer.

Bug: 1091958
Change-Id: I1def688d6012255e1fdea02983f499d80d2ccb4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263272
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782178}

* Add a kConnectOnce mode to ScopedSingleClientServiceBinding.
* Change the SetOnLastClientCallback() method in
  ScopedServiceBinding to take a RepeatingCallback.
* Clarify SetOnLastClientCallback() behavior.

Bug: 1096731
Change-Id: I26c2ba8f8091ba6c3b02e85752651a1b01fa26fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252953
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782177}

This CL re-enables Polymer3 bluetooth test that was disabled because it
was flaky. It also fixes the issue that caused the flakiness.

The test was disabled in this CL https://chromium-review.googlesource.com/c/chromium/src/+/2254139

Added metrics_recorder, os_route, os_settings_routes to closure compile

Fix: 1097021
Change-Id: I5649cf8ff1aa5890f214dd38997611a070eecf53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261140
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782176}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Id597e8fca1dcd3d7399065945e332eb53a8b38a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264929Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782175}

This CL reverts screen.cc and screen.h to how they were before:

https://chromium-review.googlesource.com/c/chromium/src/+/2192758

Bug: 973801
Change-Id: I55b733a192979860e5c2bb3c99eca370cb7092f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260934Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#782174}

This is a reland of I8c607c310d540b6b491ff07c20147f9ba1ecdb7a

There is no new changes. Only resubmit 2261093 and resolve the conflicts in 2261258

Original change description:

Add supports to Lens Shopping experiments for google.com
- enable lens shopping experiments variants for google.com
- add unit tests to LensUtilsTest for shopping intent


Bug: 158099013
Change-Id: Iaa736dc0926f5c6a4af54af11f5964b511e9c992
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265372Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Yu Su <yusuyoutube@google.com>
Cr-Commit-Position: refs/heads/master@{#782173}

virtual/controls-refresh/datetimelocal-picker/datetimelocal-month-switcher-buttons-invalid.html has been timing out sporadically.  It's not clear whether this is because the test occasionally just takes too long, or if there's a legit bug that sometimes just causes it to get stuck.

I've divided the test's 5 sub-tests into 3 separate files, grouping by the type of case that the sub-tests handle.  This will either further isolate whatever bug is causing the flakiness, or will eliminate it altogether if the cause was that the combined test was taking too much time.

Bug: 1093197
Change-Id: I3c88801739e1aefd70756c1f2b44ed91827db0fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258896Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#782172}

The runner_logs.py IsEnabled() function should check both that _instance
is not None and that the instance._log_dir directory is not None instead
of only checking _instance.

This is because if the test runner scripts --runner-logs-dir argument is
not set, the runner_logs.py _instance is created with its _log_dir
member initialized as None.

Bug: 1067356
Change-Id: Id9fe98e0e31d8ce2256ef3bd3b24f895983a14b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261635Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Stephen Roe <steveroe@google.com>
Cr-Commit-Position: refs/heads/master@{#782171}