- 24 Jan, 2018 2 commits
-
-
Xi Cheng authored
Bug: 795672 Change-Id: I31c81b44d915e49e9f8b381ff14df44939fa99e4 Reviewed-on: https://chromium-review.googlesource.com/879074Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#531392}
-
Mitsuru Oshima authored
Do not lock the cursor when dragging a window whose state is controlled by a client, which may set its own cursor during drag. Better fix is to add custom cursor API that supports density change. We'll address it as a part of cursor improvement work. (b/80666810, crbug.com/721601) BUG=804471 TEST=manual Change-Id: I4ddb5a96d820cca1fa08528adf8e311c5a0960e7 Reviewed-on: https://chromium-review.googlesource.com/881526Reviewed-by:
Dominik Laskowski <domlaskowski@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#531391}
-
- 23 Jan, 2018 38 commits
-
-
Yoshifumi Inoue authored
This patch moves |LocalFrame::RangeForPoint()| to |Editor| class as member function with removing unused #include directives in "LocalFrame.cpp" due by this patch to reduce usage of |VisiblePosition| outside editing for improving code health. Bug: 657237 Change-Id: Ie7e94efbcb65cf3f272301555d5fe61888a81533 Reviewed-on: https://chromium-review.googlesource.com/880244Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#531390}
-
Tom Anderson authored
BUG=None R=sky CC=tonikitoo@igalia.com,msisov@igalia.com CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ozone_compile_only_ng Change-Id: I2f2768169a029b76e51aff1d3a695d84b8edcabf Reviewed-on: https://chromium-review.googlesource.com/881951Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#531389}
-
Zhiling Huang authored
When passing content type to google storage helper, we need to specify that we are passing in content type. Otherwise google storage helper's upload function will consider content type as gs_args and then cause an error. Bug: 799598 Change-Id: Iac18782af63d38b66b4094ab32472f1debb68f92 Reviewed-on: https://chromium-review.googlesource.com/862882Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#531388}
-
Trent Apted authored
We are going to have some code that needs to work either with (mac_views_browser) views browser windows or Cocoa browser windows. Before r530907 mac_views_browser builds managed to always get a nil BrowserWindowController. That worked with objc_msgSend even though it was never linked in. But r530907 adds a static method call, which wants the BrowserWindowController @implementation. We need a way to disallow browser_window_controller.h from being included at all, before it can be phased out. This CL sets up a file to help consumers that need to work with both browser window types to remove their browser_window_controller.h dependencies. For now, it's used enough just to fix the mac_views_browser compile regression. Bug: 804674 Change-Id: I0ce2b94a8d74c8f3f8b7dacec580366819c5aa29 Reviewed-on: https://chromium-review.googlesource.com/880426Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#531387}
-
Harald Alvestrand authored
Make a number of stats optional because their generation depends on specific states; they're not always present. Check a number of stats only if the kind is the right one. Bug: None Change-Id: I7f3e307b0f0f14df0f62bc2ac3a226018640f873 Reviewed-on: https://chromium-review.googlesource.com/880983Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#531386}
-
Daniel Cheng authored
This means that tests may no longer rely on LazyInstance<T> to clean up global state between tests. Tests that depend on globals but need a clean test environment should use explicit test hooks to reset this state. Only one test depends on DestructorAtExit for correct functionality. cast_audio_backend_unittests creates several mocks that are owned by a base::LazyInstance. Since Gmock verifies expectations in destructors, switching all LazyInstances to leaky ones breaks this verification. The solution is to manually verify and check the expectations at the end of the test. Note that while the mock objects are annotated as leaked for Gmock, that does not mean the cast_audio_backend_unittests will leak arbitrary amounts of memory. The test fixture already configures StreamMixer for each test run; this setup will clear up any leftover objects from the previous test. DestructorAtExit will be removed in a followup. Bug: 698982 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I822ce507dbb98067a788466e7c8fcc96c3a64ef9 Reviewed-on: https://chromium-review.googlesource.com/874994 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#531385}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5ed1942e. With Chromium commits locally applied on WPT: e8a79119 "Fixed wpt csp reporting tests and moved over chrome internal ones" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/10757 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ecobos@igalia.com: external/wpt/css/css-display jfernandez@igalia.com: external/wpt/css/css-align kojii@chromium.org: external/wpt/css/css-scoping meade@chromium.org: external/wpt/web-animations rego@igalia.com: external/wpt/css/css-ui tyoshino@chromium.org, yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=jsbell No-Export: true Change-Id: I1ec2d92b8637c03f9e0be741c1ce40a2be660093 Reviewed-on: https://chromium-review.googlesource.com/881762 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531384}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4d4731c620ea..9b85f4ba6fdd $ git log 4d4731c62..9b85f4ba6 --date=short --no-merges --format='%ad %ae %s' 2018-01-23 dsinclair Merge CXFA_WidgetAcc into CXFA_Node 2018-01-23 dsinclair Remove CXFA_WidgetAcc from CXFA_FFDocView methods 2018-01-23 dsinclair Cleanup CXFA_FFDocView header 2018-01-23 dsinclair Remove unused CXFA_FFDocView::ProcessWidgetEvent 2018-01-23 dsinclair Remove CXFA_FFDocView::GetWidgetAccByName 2018-01-23 dsinclair Use accessor for WidgetAcc 2018-01-23 dsinclair Convert CXFA_WidgetAccIterator to CXFA_ReadyNodeIterator 2018-01-23 dsinclair Remove CXFA_WidgetAcc from CXFA_FFField::CalculateNode Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9e5c17b55282293199630ec5badd69659f2b552a Reviewed-on: https://chromium-review.googlesource.com/881825 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531383}
-
Joel Einbinder authored
Change-Id: I5d97844c2c02cee00a2a68b1263eff129caf3657 Reviewed-on: https://chromium-review.googlesource.com/875560Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#531382}
-
Miriam Gershenson authored
This reverts commit 0532f223. Reason for revert: Full launch needs to be rolled back and retried in a future milestone due to a bug. The experiment cleanup here was premature. Original change's description: > Enable "AsyncDns" feature by default on Android > > Also clean up Android-specific experiment code, but leave the > base::Feature. > > Bug: 768874 > Change-Id: Ic7b81a878e3e81bc1a5c2c2fae242df23c5387ca > Reviewed-on: https://chromium-review.googlesource.com/868077 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Miriam Gershenson <mgersh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#529866} TBR=isherman@chromium.org,mgersh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768874, 805020 Change-Id: Ib67c727aef748b4e80714e6128c3bfbdc24d3544 Reviewed-on: https://chromium-review.googlesource.com/881206Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531381}
-
Ria Jiang authored
1. Since we want to turn on viz hit-test both with and without viz display compositor, changing RenderWidgetHostInputEventRouter to use use-viz-hit-test flag instead. 2. Add use-viz-hit-test flag to viz-component switches. Bug: 804888 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I65e268d826cc57e289d1579291066cc8c58f6203 Reviewed-on: https://chromium-review.googlesource.com/879843 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#531380}
-
Xiangjun Zhang authored
This is a prerequisite for the coming mirroring service CLs to not depend on content. Moved the interfaces to media/capture/mojo/. No functional change. Bug: 734672 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie7a1d618920860cba08f1708f6cd9486db0b4956 Reviewed-on: https://chromium-review.googlesource.com/872101Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#531379}
-
Pavel Feldman authored
Bug: 800613 Change-Id: I5549e2027929480b23c3a8d9ad05fecbe37bbfba Reviewed-on: https://chromium-review.googlesource.com/881549Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531378}
-
Ryan Sleevi authored
Previously, is_issued_by_known_root took a per-platform approach, attempting to determine whether or not (for given the platform), a certificate was issued by a known root. Programmatic policies such as HPKP or enforcement of the Baseline Requirements was then gated on this functionality, and reporting errors or additional details was similarly limited to that set of known roots. However, this results in inconsistency across platforms - a given certificate may be a known root on Windows, while returning false on other platforms, giving an inconsistent security experience and inconsistent user experience, even though the set of expectations for that root cert/CA remain the same. In order to align behaviour, all platforms now consider the set of unified trust anchors for all platforms, in addition to the runtime determination (when available) to determine the status. This will reduce the false-negative case across platforms. To avoid situations in which the static/compiled in list drifts from the OS (e.g. due to emergency updates or pre-release versions), the OS will still be consulted, but it will be as a fallback to the internal list. BUG=798186 TBR=isherman@chromium.org Change-Id: I46e7abf044682b3583bd3ea50369891f5c56c0a6 Reviewed-on: https://chromium-review.googlesource.com/854014 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#531377}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/dd21ecf80a62..d66e193930dd $ git log dd21ecf80..d66e19393 --date=short --no-merges --format='%ad %ae %s' 2018-01-17 oetuaho Allow creating EGL pbuffers from typeless D3D textures Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ibf8d1467c1ec3f7b751d30abac3927302a08a0f6 Reviewed-on: https://chromium-review.googlesource.com/881560 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531376}
-
Marijn Kruisselbrink authored
This way I won't need to bug top-level core/ OWNERS just to add new unit tests for fileapi code. Bug: none Change-Id: I877e42443fd8e819029674d7dc2b6e6b58a1f1b7 Reviewed-on: https://chromium-review.googlesource.com/881941 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531375}
-
Chris Kuiper authored
This fixes a number of small issues (like proper rounding), tweaks a few settings and introduces a new way to obtain and maintain reference timestamps for rendering delay interpolation. In full detail, this change does the following: 1) Significantly increases the frequency of getting a new timestamp. The Android Audio guys confirmed that this has no impact on performance. 2) Reduces the maximum amount a timestamp may deviate to be considered stable (for starting up only). 3) Does proper rounding when doing integer divisions. E.g., when converting from nsecs to usec do usec = (nsecs + 500) / 1000. 4) Changes the reference timestamp format and logic. Previously we stored the full timestamp object {nanoTime, framePosition} returned from AudioTrack.getTimestamp() and interpolated the rendering delay from there. Now, using the sample rate, we transform this back to framePosition=0, i.e. {nanoTime', 0}, and just store the nanoTime' value as the reference timestamp. This simplifies the logic of comparing timestamps, storing them, and doing timestamp math. 5) Uses a lowpass filter when updating the reference timestamp with a new timestamp read from the AudioTrack. That means every time we read a new timestamp we update the reference timestamp as follows: ref_timestamp = 0.95*ref_timestamp + 0.05*new_timestamp. This reduces the impact of jittery timestamps, especially for the cases described in the bug. Also, on underrun it now waits for a new stable timestamp before setting a new reference timestamp. This just uses the same stability logic as for starting up, but it should be improved in the future to speed this up. Note that underruns are not expected since the multizone code is supposed to prevent such by writing silence frames. But we have noticed some occasionally on high CPU load, so we need to handle that. Bug: [internal] b/72341571 Test: Running multizone certification test cases on a mix of speakers. Change-Id: I1977f5211d6b6c9ca3e291326cc062181515bf4e Reviewed-on: https://chromium-review.googlesource.com/879734Reviewed-by:Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#531374}
-
Peter Kasting authored
This changes all infobars to a white background, instead of having some be yellow. BUG=686285 TEST=none TBR=benwells, vasilii, droger Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5b393c27bba8e7ee103b0a3cdcedc0609e7748d5 Reviewed-on: https://chromium-review.googlesource.com/875259Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#531373}
-
Stephen White authored
No user-visible change. BUG=805031 Change-Id: Ia29f46bd96661661f726798723f395ff8ddab77d Reviewed-on: https://chromium-review.googlesource.com/881866Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#531372}
-
Chris Cunningham authored
The deleted tests are covered by the remaining wpt/html/semantics/embedded-content/media-elements/mime-types/canPlayType.html TEST: Pass canPlayType.html WPT test. Change-Id: I888c725194ae9fd4007e140f07f0639eb69495c1 Reviewed-on: https://chromium-review.googlesource.com/879138Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#531371}
-
WC Leung authored
The captioned test was disabled in Linux ASAN because of flakiness. Two possible causes were identified: - Possible race between DownloadHighResAvatarTest and LoadAvatarFromDiskTest because the path returned by GetPathOfHighResAvatarAtIndex is not inside the unique temp directory. - The directory holding the test icon is not created before running base::WriteFile. This CL fixes the above issues, and changed "const char* bitmap" to "const char bitmap[]" because of issue 795518. Bug: 794821, 795518 Change-Id: I0deb2c8acddea86fb94ca27a363afa132f0ac6fc Reviewed-on: https://chromium-review.googlesource.com/868411Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: WC Leung <lwchkg@chromium.org> Cr-Commit-Position: refs/heads/master@{#531370}
-
Theresa authored
Switch SnackbarView.java isChromeHomeEnabled checks to isChromeModernDesignEnabled. BUG=803096 Change-Id: I153691a9a0e70dc04c21468887c771af8314c8bc Reviewed-on: https://chromium-review.googlesource.com/881543Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#531369}
-
George Burgess IV authored
(This is also the third attempt roll to a newer AFDO profile, which we're currently using internally.) While the gs bucket that holds these profiles is restricted to Googlers only, our Chrome OS friends jump through hoops specifically to make these AFDO profiles world-readable. So, all of the crazy redaction and such that we're currently doing is entirely unnecessary. Woo! As noted in the script, due to the permissions setup, actually accessing these profiles is a bit awkward. But it's workable. also ran update_afdo_profile.py on a few profiles from a non-Google machine, and it succeeded on the ones I tried. Also ran build/install-build-deps-android.sh. Bug: 804479 Test: `gclient runhooks` and built for Android with/without clank. I Change-Id: I20d973b62251ebe249e80fad6051bd3a6805aa12 Reviewed-on: https://chromium-review.googlesource.com/879849 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#531368}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/b17642956773..296e7c3a900b $ git log b17642956..296e7c3a9 --date=short --no-merges --format='%ad %ae %s' 2018-01-23 nednguyen Add logging when web_page_replay_go try to read archive 2018-01-23 dtu [pinpoint] Average result_values for comparison. 2018-01-23 nednguyen Make ReplayServer._CleanUpTempLogFilePath quits gracefully if log file already cleaned Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I39bcc6237dbdf43d9f12948888f4f6a00bfd37f3 Reviewed-on: https://chromium-review.googlesource.com/881955 Commit-Queue: <catapult-deps-roller@chromium.org> Reviewed-by: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531367}
-
Quinten Yearsley authored
This has probably be unused for sometime. We proposed removing it early last year: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/J-oJz1zL-HA Relatedly, webkit-patch layout-tests-server can be removed in another CL. Bug: 704384 Change-Id: I706835aac9cc0f7c1d5c80b5fffb6966352da556 Reviewed-on: https://chromium-review.googlesource.com/847641Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#531366}
-
Robert Ma authored
The new version of the test (not imported yet) trips a DCHECK. Since we currently cannot rebaseline DCHECK failures, we have to mark the test as Crash manually to unblock wpt-import. TBR=domenic No-Try: True Bug: 805061 Change-Id: I58b7054eed776a63252610fc4afc7fbaf3a87a35 Reviewed-on: https://chromium-review.googlesource.com/882124Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#531365}
-
Vladimir Levin authored
This patch extracts the container/containing block logic for absolute positioned elements into a common function and adds similar functionality for fixed positioned elements. This is a step towards making filtered elements be containing blocks for absolute and fixed positioned elements. This is required since LayoutInlines may be filtered, thus becoming containers but not containing blocks. R=chrishtr@chromium.org, eae@chromium.org Bug: 795549 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I97cb3690f70abf7ebe871bf3644efb2179a9aeda Reviewed-on: https://chromium-review.googlesource.com/879583Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#531364}
-
Dominic Mazzoni authored
It's not necessary, as a role of "button" with the "has pop up" state is fully supported and sufficient. The button_drop_down role wasn't even being mapped correctly on Windows, leading to inconsistent feedback with some screen readers. Bug: 766856 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib7f631a759ab44ffc3307204bcc74a9471afc22a Reviewed-on: https://chromium-review.googlesource.com/842475Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#531363}
-
Doug Arnett authored
Logs when a previews type is committed or the Cache-Control:no-transform directive is seen to the intervention-internals page Log tab. Bug: 799653 Change-Id: Ia796cbfa086a723bfe205303d0c53d19c98b6975 Reviewed-on: https://chromium-review.googlesource.com/874490Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#531362}
-
bsheedy authored
Ports most of WebVrInputTest to WebXrInputTest. Currently does not port testControllerClicksRegisteredOnDaydream, testScreenTapsRegisteredOnCardboard, or testFocusUpdatesSynchronously since they rely on things in WebVR that don't currently have an implemented equivalent in WebXR (input and autopresent). Bug: 804043 Change-Id: I028de411cd7bf6d9ecc931a276052961d96864d4 Reviewed-on: https://chromium-review.googlesource.com/881834Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531361}
-
Kayce Basques authored
Bug: 801271 Change-Id: I4dd17eb097e9d5992717a9127df8d5f7995dace4 Reviewed-on: https://chromium-review.googlesource.com/862364Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Kayce Basques <kayce@chromium.org> Cr-Commit-Position: refs/heads/master@{#531360}
-
Weidong Guo authored
This is a reland of f44d3b6d. Original change's description: > Reland "New style app launcher folder" > > This is a reland of 14bacdda. > > Original change's description: > > New style app launcher folder > > > > Changes: > > 1.Enable pagination in folder > > * Maximum 16 items in one page and maximum 3 pages. > > * Make PageSwitcher support growing both vertically and horizontally. > > * Add PageSwitcher in folder view. > > > > 2.Add a invisible FolderBackground so that the user can tap/click > > outside folder to exit it. > > > > 3.Make folder size dynamically change based on items number within it > > * Shape the folder close to a square (cols_num := sqrt(apps_num - 1) + 1). > > * Align the opened folder’s center with the closed folder’s (folder icon) > > center. Then adjust the folder bounds to fit inside its parent view. > > > > 4.Change other small UIs based on specs. > > > > 5.Add test coverage: > > * Click folder background to exit folder. > > * Page resets to 0 when reopen a folder. > > * Folder cols and rows for different number of items within it. > > > > 6.Fix test for focus movement inside folder and maximum number of apps > > within a folder. > > > > Design doc: > > go/applist-folder > > > > Specs: > > Please check crbug.com/796370 > > > > Implementation video: > > https://www.youtube.com/watch?v=E-LyaZLoS90 > > > > Bug: 796370 > > Change-Id: I33250b40b3c5021301d71c8e877e9d1f73afa100 > > Reviewed-on: https://chromium-review.googlesource.com/835283 > > Commit-Queue: Weidong Guo <weidongg@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#530803} > > TBR=xiyuan@chromium.org > > Bug: 796370 > Change-Id: Icfc08e87b929a4a2eec9c9bb592df00289be2f7d > Reviewed-on: https://chromium-review.googlesource.com/878983 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530920} Bug: 796370 Change-Id: I746c2c7552b96561344c974cbe65daa70aa80e44 Reviewed-on: https://chromium-review.googlesource.com/881275 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#531359}
-
Scott Violet authored
This is a precursor to loading local state, about flags and field trials earlier, before BrowserProcess has been created. BUG=800358 TEST=none Change-Id: I647643d81702d6520401729916ed0a9f8311e5af Reviewed-on: https://chromium-review.googlesource.com/879029Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#531358}
-
Mohamad Ahmadi authored
Bug: 799031, 684139 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3dbb7c648c4ac1ceebba4e6ff819a032287cddbc Reviewed-on: https://chromium-review.googlesource.com/876999Reviewed-by:
Mike Baxley <baxley@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531357}
-
Manuel Rego Casasnovas authored
This patch adds percentage support to column-gap property. Most of the changes are related to the parsing logic, the column-gap property now accepts both length and percentages, on top of the "normal" initial value. A new utility class GapLength has been added, as it'll be useful to implement row-gap in the future. Apart from that the muticolumn layout code has been modified to resolve the percentage gaps (treating them as zero while computing preferred widths) and resolving them during layout. This doesn't follow the current text on the spec, but there is an ongoing discussion that might cause the text is changed: https://github.com/w3c/csswg-drafts/issues/509#issuecomment-355242101 We could update the implementation once we have a definitive answer from the CSS WG. Added a new WPT test to check the behavior under different sizing conditions. BUG=799413 TEST=external/wpt/css/css-multicol/multicol-gap-percentage-001.html Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Icccd046e913353b6f525481046a41ad125aea5ff Reviewed-on: https://chromium-review.googlesource.com/878199Reviewed-by:
meade_(do not use) <meade@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#531356}
-
Joe Downing authored
This reverts commit dacf14c4. Reason for revert: Causing failure on Linux MSAN builder: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/7431 Original change's description: > Mac: teach GpuMemoryBufferVideoFramePool to handle XR30 > > This CL teaches GpuMemoryBufferVideoFramePool to handle XR30 > formats, when context capabilities' image_xr30 is enabled > and the incoming data is of 10 bit per component type. > > This CL also enables the necessary checks in the gles2 and > GpuMemoryBuffer support to recongnise this format in Mac only > (other platforms coming soon). > > Test with high bit depth videos e.g.: > 'http://crosvideo.appspot.com?codec=vp9.2&loop=true' > and media/test/data/... > - bear-320x180-hi10p-vp9.webm > - bear-320x180-hi10p.mp4 (this is an H.264 part 10, 10bpc) > - blackwhite_yuv420p_hi10p.mp4 > - bear-320x180-hi12p-vp9.webm > > Also covered in e.g. content_browsertests' > MediaColorTest.Yuv420pHighBitDepth > which would fail if the colors were inverted. > > Bug: 797347 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I8e73a7558d5506875d1547983d4e5e796a543aeb > Reviewed-on: https://chromium-review.googlesource.com/862326 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531293} TBR=dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,rsesek@chromium.org,piman@chromium.org Change-Id: Ibc1979309377edc919206dbffd9f8a1258bf6acd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 797347 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/881588Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#531355}
-
Ryan Sleevi authored
Ballot 193 / BR version 1.4.4 limits the lifetime of certificates to 825 days if issued on or after 2018-03-01. Update the lifetime enforcement in CertVerifyProc::HasTooLongValidity() to enforce this date range, in addition to the existing tests. Unlike the existing calculations, which are based on months, and thus inherently fuzzy as to what constitutes a month (see CA/B Forum archives), this is based on base::TimeDelta functions, which measures in microseconds and ignores leap seconds. BUG=799896 Change-Id: I260ac3b46cbcf066fea286231ed0c7045608879c Reviewed-on: https://chromium-review.googlesource.com/853893 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531354}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/6daa27815625..5864639a4650 $ git log 6daa27815..5864639a4 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I97444a824e109ab8cd04369a7594f9f04b0133f4 Reviewed-on: https://chromium-review.googlesource.com/881924 Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#531353}
-