- 09 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f0f79e083662..378653f844d4 2020-12-09 xinghua.cao@intel.com D3D: throw a perf warning for uniform block If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Ib071c0c50127b66ef568382fcc74ba98de2368ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582183Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835355}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/53c2ae23b73c..c3ea632dc5db 2020-12-09 mathias@chromium.org Add <title> to entrypoint HTML document 2020-12-09 chrche@microsoft.com Make collect-strings work with .ts files 2020-12-09 chrche@microsoft.com [Loc] Migrate input to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655,chromium:864768 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I29bac46d10e050efea759bc67bc31061ebe1384b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582685Reviewed-by:
-
Illia Klimov authored
Flash has been removed from Chrome almost entirely. Ephemeral provider was used only by these two content settings - PLUGINS and PERIODIC_BACKGROUND_SYNC. PERIODIC_BACKGROUND_SYNC is no longer registered and PLUGINS is deprecated. Bug: 1149381 Change-Id: Iae296732d1caaf9ff8e55ab484bbf8384e79a33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577782Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Illia Klimov <elklm@chromium.org> Cr-Commit-Position: refs/heads/master@{#835353}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607493425-f89e2101ace78ecc71e64b80849cb2e4ad48ac79.profdata to chrome-win64-master-1607525538-a962c6e7f864d3587aeaa1e7bb0caf9929474c9a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I08ceb0821bdf353a821b44486c87787ed8479658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582179Reviewed-by:
-
Yaron Friedman authored
BUG=783819 Change-Id: I57be107bbf7203b41b40d570ff4c4aa28beab644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577589 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#835351}
-
Andrew Xu authored
This CL does the following things: (1) Note that a clipboard history menu item is removed asynchronously. This CL ensures that only the menu item finally selected is announced. (2) This CL also changes the a11y announcement when a manu item is removed. Bug: 1150503 Change-Id: I0ea16ff1b93cdb3a749833c2e0b08a3616e79108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513749Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835350}
-
Jeffrey Kardatzke authored
BUG=b:153111783 TEST=HEVC 10bit files play on volteer Change-Id: Iaeb7e3d423f0c8b9b0672203f0637fb21c4f61ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582802 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#835349}
-
Nektarios Paisios authored
Once a getter method is not marked const, it could force other parts of the codebase to drop const as well, requiring a larger refactoring to fix in the future. Also took the opportunity to add a comment describing the related member variables and clarify some other comments. Split out from a larger patch dealing with ignored Views. AX-Relnotes: n/a. TBR=aleventhal@chromium.org, dmazzoni@chromium.org Change-Id: Ic7c4f6d38f83ef2a22401b0edd342cef5f61c58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581220Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#835348}
-
George Burgess IV authored
This target comprises 1.17% of our total Chrome samples on CrOS, but isn't optimized for speed. It may be worthwhile to optimize it in this way. Bug: 1143481 Change-Id: I9432b15330ab4fadf79a643a3abc54e8b59ed0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507829Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#835347}
-
Julian Pastarmov authored
This changes the level of the policy to recommended if it is set to enabled and the level isn't recommended to make the policy compliant with the privacy expectations of the browser. Bug: 1155602 Change-Id: I133a7cd58a729fae06c151c742569cf5c80cb500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575056 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#835346}
-
Amanda Deacon authored
This is a very small change which affects 30 bugs. All 30 bugs relate to near-expiring histograms with the suffix CpuTimeMicrosec or TotalMemoryDeltaKb. View the relevant bugs: https://bugs.chromium.org/p/chromium/issues/list?sort=summary%20id&q=owner%3Aamandadeacon%40chromium.org%20%22Check%20expiry%22&can=2 Bug: chromium:1151993, chromium:1151994, chromium:1151995, chromium:1151996, chromium:1151997, chromium:1151998, chromium:1151999, chromium:1152000, chromium:1152001, chromium:1152002, chromium:1152003, chromium:1152004, chromium:1152005, chromium:1152006, chromium:1152007, chromium:1152008, chromium:1152009, chromium:1152010, chromium:1152011, chromium:1152012, chromium:1152013, chromium:1152014, chromium:1152015, chromium:1152016, chromium:1152017, chromium:1152018, chromium:1152019, chromium:1152020, chromium:1152021, chromium:1152022 Change-Id: Id0f3ee9d6fb988ffe3ede8e4ddc32852a1b0cb00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580379Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Amanda Deacon <amandadeacon@chromium.org> Cr-Commit-Position: refs/heads/master@{#835345}
-
Jesse Schettler authored
Bug: 1153405 Change-Id: I076eb7e4868a9671553426a0a247116fd20bb54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583102 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#835344}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607515179-092361bc7a185424dad74bccdfea645817af1d61.profdata to chrome-mac-master-1607536746-da55b5a139e52763d98214355eab95e70f45f788.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id0c43f51a9e0a83203453e94f8daf565389bfdbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582689Reviewed-by:
-
Rune Lillesveen authored
This line was added for a wpt import not changing this test or code. The test was actually renamed and modified[1] and there was an existing line for it. [1] https://crrev.com/aa3b0d88e9377209b6d53345c792528805a59c46 Bug: 1156501, 846656 Change-Id: I411b9c32fc8387f8d80f5d5443f640782377fc46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574988Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#835342}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f87c8f0d0c37..3bb1e43440ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC skare@google.com,anthonyvd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150968 Tbr: skare@google.com,anthonyvd@google.com Change-Id: Iec48a0b8030cc1b825f7e5d5136f39712ef1dc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582527Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Travis Skare <skare@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835341}
-
Vladimir Levin authored
This patch adds an intermediate class to help with the document transitions. The idea is that Blink would create this request, and transfer it to the compositor on commit. When the compositor decides to submit a frame to viz, it would then construct viz directives from this request and send it over to viz. This patch also adds an include and a type usage in Blink to ensure presubmit is happy. R=khushalsagar@chromium.org Bug: 1150461 Change-Id: I8e2bcc18b8bd9f1de0d057a8bf608365ac5aa10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574600Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#835340}
-
Max Curran authored
load. This CL adds tracking of the time between calls to LogTranslationStarted and LogTranslationFinished of the TranslateMetricsLoggerImpl class. The maximum such time is stored for each page load, and will later be logged via UKM. Note that this time corresponds to the what the user experiences between requesting a translation and the page being updated with the translation. Full design doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing Bug: 1114868 Change-Id: I142300e2f472c1de713e9035b5669f1e3d2c2c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572121 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#835339}
-
Sigurdur Asgeirsson authored
This is a reland of 7fb78e28 The crashes and DCHECKs should be fixed with https://crrev.com/c/2581939. Original change's description: > PM: Enable service worker relationships. > > This change is to get some DCHECK crashes on Albatross. It will be > reverted after it's been on Canary for a day or so. > > Bug: 1143281 > Change-Id: I6d125dfbae9699e7292a9aa0336070b005bd03c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571638 > Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833405} Bug: 1143281 Change-Id: I52a8332dcd151cd42d6e85f5bbaf4dc094e7d995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582726 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#835338}
-
Ryan Hansberry authored
These metrics are currently prefixed with "Nearby.Share". Nearby Share is an application that depends on the Nearby Connections library. In reality, these metrics actually instrument an implementation of the Nearby Connections library, not an application like Nearby Share, and should instead be prefixed with "Nearby.Connections". This mistake was made because this logic resides in a 'nearby_sharing' directory, which is an unfortunate historical artifact. All of this logic needs to eventually be migrated to a more generic location, but more urgently, these metrics need to be migrated to their correct prefix. The previous metrics, prefixed with "Nearby.Share", have only been deployed to dev-channel, for a week, and will never be used, so I have not applied aa 'obsolete' label to them, opting instead to outright remove them. Bug: 1123172 Change-Id: Ia22407469f4bc9a7f84813c17e37a5ce5d888624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580907Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#835337}
-
Yuheng Huang authored
Add this metric to track time and frequency of infinite list update. Use benchmark_value instead of benchmark_begin and benchmark_end to avoid event interference by overlap. Bug: 1099917 Change-Id: I5e623acc723cd220da1fa1b06a1a8d6cbd749856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580508Reviewed-by:
Roman Arora <romanarora@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835336}
-
Joe Downing authored
I noticed today that the file logger in Windows still wrote a file after I disabled it via the registry. I tracked the issue down and it's because the current impl starts the file/event log loggers if the registry key exists (instead of checking for existence and then checking the value). This CL fixes that by only creating the logger instance if the pertinent reg key exists and has a non-zero value. Change-Id: I2dabd7c52af831af228fbc2217ced7fd14126ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582425 Auto-Submit: Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#835335}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bfb5e2c0. With Chromium commits locally applied on WPT: 8a17eed8 "Fix sandbox flags inheritance with javascript-url." bf9563fb "Revert "IO: Use pre-margin target rect for an empty check for intersection threshold"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ia4e3c6fcdd864c910628734ab4b65599a4d55abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581687Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835334}
-
Jeffrey Kardatzke authored
Obviously the wrong variable name was used here, fix it. Fuzzer caught this. BUG=chromium:1157168 TEST=Fuzzer test passes now Change-Id: I55a33b1ec1ddaf5f7f30e27608b87b57ddcb062c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582507 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#835333}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/eb597ff5b7f6..8837f2e7f4f0 2020-12-09 natsu@google.com Update AHB default YUV dataspace to YCBCR_709 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I16782ea4d5c9393ffe23a159e677bcd60798443b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582185Reviewed-by:
-
Nina Satragno authored
Do not call AuthTokenRequester::InternalUVLockedForAuthToken() until an authenticator has been selected. This fixes a bug where tapping an authenticator that was not uv-locked would still show a uv-locked warning if another uv-locked authenticator was also plugged in. Fixed: 1154872 Change-Id: I518c57524513ea3663b0c0d6d39f0ccaf7ef17ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580144 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#835331}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //third_party/blink/web_tests/. Bug: 1113033 Change-Id: Icd19286adba43b2f52ef49b874dd8116de00dbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572728 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#835330}
-
Andrew Grieve authored
There are several kinds of exceptions that can occur when loading classes. Bug: 1156583 Change-Id: I8440a21ab1146e9f50a9f389c2e6d32f46330237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579953 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#835329}
-
David Tseng authored
This change introduces the ideas of explicit and implicit timepoints. An explicit timepoint is a time delta from the beginning of playback paired with a character index into the spoken string. An implicit timepoint is simply a character index into the spoken string which is annotated on a particular audio buffer. Both types of timepoints achieve the same goal of letting a TtsEventObserver know about when playback has reached a specific character within the spoken string. Prior to this change, implicit timepoints were the only type of timepoint. All tts stream types (playback and Google), did not need explicit timepointing. As of the latest Google tts models, however, explicit timepointing is needed because the latest Google tts engine exposes multiple timepoints on a single audio buffer, breaking the assumption that timepoints are coupled to their audio buffres. This change does not attempt to choose between timepoint types to eliminate one or the other; that can be deferred to a future change given proper motivation. Misc notes Implicit timepoints have some advantages. It will make it easier to write more sophisticated features such as seeking into the audio buffers queue by character index. It also reduces the playback tts stream interface, which may eventually turn into the public api surface for a playback tts extension api. Explicit timepoints also have some advantages. They can allow the tts service to reason about all timepoints for a given sentence at once or provide them to the tts caller for additional logic. Test: chromeos_unittests --gtest_filter=Tts*.* (coverage for both types of timepoints). Manually on-device. Bug: b/174804378 Change-Id: I548c20f642317516795d494b10cd47a3dcee0e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577538 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#835328}
-
dpapad authored
Bug: 1148478 Change-Id: I4cfaac4bf9c81993592e4e191957d2eab21b1002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580184Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#835327}
-
edchin authored
This was originally created in Aug 2017 in this CL: https://chromium-review.googlesource.com/603690 This metric is no longer being used and has already expired 9 months ago. Per go/histogram-expiry-guidelines: "If the histogram is not in use now, but might be useful in the far future, remove it." Change-Id: I6903617fcfaf8ca3d9c46433386d7ccca508105f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580697 Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#835326}
-
Michael Savigny authored
This CL adds the'use_rbe' gn argument, that when set to true will use re-client to do remote execution. Bug: 1149386 Test: Manually built chromium with use_rbe=true and local config file. Change-Id: Ibb1d1d89a713de7b7900bc21db7b66169ef8ad01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562678 Commit-Queue: Michael Savigny <msavigny@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#835325}
-
Raymond Toy authored
Extend expiration by 6 months for WebAudio histograms expiring on 2021-01-06. Bug: 1152046, 1152047, 1152048, 1152049, 1152050, 1152051, 1152052 Change-Id: I62f01eadf5bc891c5b4de3039c0ce80f2b3a0557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577878Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#835324}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //third_party/blink/web_tests/. Bug: 1113033 Change-Id: Ia6928e6b0683ed63c4bc747ad6143488076e4a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572727 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Mei Liang authored
Bug: 1153604 Change-Id: I7e61b9da34f239c53a902aba8473d690dcaeeecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580403Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#835322}
-
David Black authored
Screenshot: http://shortn/_elXItqeFbl Bug: 1154347 Change-Id: I2ebf4724c6146bd43d4381d7f12e3410c4591246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581026 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#835321}
-
Egor Pasko authored
From a comment remove a confusing mention of an old method doInBackground(), removed since. This reference points at the comment that was introduced at e0825567 (from 2012) and was saying: """ // We're loading the .so in a background thread. Potentially, this // can break native code that relies on static initializers using // thread local storage, as the library would normally load in the // main thread. If do we hit such cases we should remove those static // initializers, as we chrome has banned them. // (Worst case, we can go back to just warming up the file in the system // cache here and do the actual loading in onPostExecute().) """ Since then in many other places we are relying on *not* having static initializers touching TLS. We have very few static initializers in 2020, if any, and guard against adding them. This note is no longer important. Bug: 1154224 Change-Id: I8e9059d73e71b6e5f779037d0d8cfa6f08a745a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574739 Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#835320}
-
Danila Kuzmin authored
Extract offline login flow (offline-gaia) to a separate file. Make it available only when the device already has registered users. Create a screen class and handler for it. Bug: 1113152 Change-Id: I08fe0ad60adf05068dcc502f19e875e0d8fce909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450314 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#835319}
-
Sahir Vellani authored
Users will now be able to use middle click autoscroll to scroll a parent div if the inner-most scroller is unable to scroll in that direction. If there is no delta-consumable scroller, the top-most autoscrollable scroller will be latched. Bug: 1107648 Change-Id: Iccd4efec3b1ce5d09c701d3d46052176275dbc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488042Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#835318}
-
Victor Vasiliev authored
Change-Id: I3d4c8ff60b76182200f826a040d018edc61dc869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579827Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#835317}
-
kenkangxgwe authored
This is a fixup for b2af6d84. - add/remove macros. - avoid inline virtual function. Bug: b/162546246 Bug: b/173504008 Test: None Change-Id: I3aa2767efc30bf0e677462f395be50dbefc4117f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581438Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Mingyu Kang <kenkangxgwe@google.com> Cr-Commit-Position: refs/heads/master@{#835316}
-
