- 07 Oct, 2020 40 commits
-
-
Mike Jackson authored
Removes the parameterization for all tests in the manifest_update_manager_browsertest.cc file, now that kDesktopPWAsWithoutExtensions flag is always true. Bug: 1065748 Change-Id: Iff13ff4b394a184fbd5b89b76b15475e017591e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453378Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814551}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/15f1e5d585c5..e90aefd498fb 2020-10-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7a9dea1f87df983280c73daa48897b39f95595ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454805Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814550}
-
Shrek Shao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/91b544d..1a111c2 TBR=kbr@chromium.org Bug: 1135785, angleproject:5038 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I618c5db369e68f8088a215f0a9b74f1e82b09636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455029Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#814549}
-
Joel Hockey authored
Some test logs show an error clicking on 'photos' folder after going back to the root of MyFiles, so adding a waitForFiles call immediately after clikcing MyFiles to wait for all files (including photos) to be visible. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8867151645799555504/+/steps/browser_tests__with_patch_/0/logs/Flaky_failure:_FileManagerUITest.CrostiniShare__status_SUCCESS_TIMEOUT_/0 And while I'm here, fix the comment in filemanager_uitest.cc. The --disable-web-security flag allows files to be loaded, but has no affect on chrome:// urls - I don't why I ever wrote that (⌒_⌒;) Bug: 1135410 Change-Id: I9f5a97bb0a209a9590a2a55721cc420cec19ceb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454551 Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#814548}
-
Xianzhu Wang authored
Make PaintArtifactCompositor (PAC) almost ready for unified PaintController for pre-CAP and CAP. Now PaintArtifactCompositor takes a vector of PreCompositedLayerInfo as input. In pre-CAP the vector contains information from GraphicsLayers. In CAP the vector contains one entry as if we created a layer containing everything that needs full layerization. It's flexible to combine the two situations. Actually CompsoiteSVG is already using the combination. In next steps, we'll paint all GraphicsLayers into one LocalFrameView::paint_controller_ instead of multiple ones, and pass PaintChunkSubset of each GraphicsLayer to PAC::Update(). We can also let PAC manage all cc::Layers, after we let PAC generate all properties of cc::Layers. Bug: 1132717 Change-Id: I103ceaf7eefdafb7ada70ddad6f4ee7c346e380b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434768 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814547}
-
Sunggook Chue authored
When user uninstall a PWA from Windows Settings or Control, it also uninstall PWA from browser registrar. The detailed design spec: https://docs.google.com/document/d/1XjFYnHXCJt08UsbWrQKw5vLW3_vQumOPrB7A9bpHq_s/edit?usp=sharing Bug: 957043 Change-Id: I927213c847033ddf5767679f3d7081d2c6760343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316848 Commit-Queue: Sunggook Chue <sunggch@microsoft.com> Reviewed-by:
Phillis Tang <phillis@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#814546}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metatada from OWNERS files for //dbus. R=hashimoto@chromium.org Bug: 1113033 Change-Id: I5bf308445d3e27bb51792bd7c8c70e8d052b0049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454690 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#814545}
-
Jason Lin authored
The implementation is based on UX design [1]. The notifications use some specific notifier Ids to avoid being counted by the systray notification counter when they are displayed. [1] https://docs.google.com/presentation/d/1MWWejK-y2vnBN3Wg__Kd_LIiAcIF3VctzMowMI3wM4w/edit#slide=id.g91c6bdd2e4_0_12 Bug: b/167491603 Change-Id: Ie8a996604d815b387dccba57648d48b8e3ef3881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400794 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#814544}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f8200abfd9a..8e79d255b3b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1133955 Tbr: yosin@google.com Change-Id: Iba9210665f2fc680dc9bd92d85f1c43ca1ae9e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454799Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814543}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ibaa2e58f06c667eedac98bf320cef0411fdc114b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454696Reviewed-by:
-
Chan Li authored
Bug: 1108016 Change-Id: I8988641e2db1cadd3c35898a504c804d4dc4cf5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453372Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#814541}
-
David Munro authored
Add a flag to signal Tremplin to reset the LXD database when starting LXD. Bug: chromium:1057869 Test: Deploy, set flag, check DB is reset Change-Id: If1e25d59f932271db170ce0430ac8b3a634d6edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426666 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#814540}
-
Dylan Cutler authored
This method is meant for cases where we want to copy the properties of an existing cookie already in the cookie store to another instance of CanonicalCookie. Bug: 1102874 Change-Id: I1ab8f732538e4e33bc8a3a350ee547962bf36850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452969 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#814539}
-
Clark DuVall authored
This change converts all Service and IntentService subclasses to the SplitCompat versions in the //chrome directory. Note that gerrit is not doing a good job of detecting renamed files here, so Patchset 1 contains strictly the moved service files, and future patchsets have the diffs from that. I would recommend reviewing with the base set to Patchset 1. Bug: 1126301 Change-Id: I7b35bb65a54039c554a31a59ebe3e0079a6e2d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454491 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#814538}
-
Alex Gough authored
This is a reland of a358e673 Original change's description: > Adds mojo_base.mojom.ReadOnlyFile > > Adds a mojo ReadOnlyFile that won't serialize if it can be written. > > The expectation is that this handle will then be sent to another process > which lacks the rights to add any write permissions to the handle. This > may not be true on all platforms but is useful where this holds. > > Code to check for readonly-ness is implemented within mojo rather than > base::File as it is (a) difficult to say in general what it means to be > readonly, and (b) not possible on every platform. > > Bug: 1130762 > Change-Id: I6f00934005da7e433af4fee94454dfcd28dfd3c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417549 > Commit-Queue: Alex Gough <ajgo@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Matthew Denton <mpdenton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813987} Bug: 1130762 Change-Id: I4ae14a37b57867e6b02ad2e3f69d248032e0c3c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450893Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#814537}
-
Yann Dago authored
Use the new COM interface to show the updater's policies and conflicts. Use the new interface to get the updater's version and the last time policies were fetched. Maintain compatibility with IPolicyStatus so that machine with older versions of the updater still show policies. Bug: 1032756 Change-Id: Iadb2199bcdc704a426e80e00e2bb8aa5b21e0648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380582 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814536}
-
Jesse Schettler authored
Add a scan button to the scanning app. When the button is clicked, use the ScanService to perform a scan with the selected scanner and settings. Bug: 1059779 Change-Id: I52231a5a49fa01a2b56e42bcf2f9842fdf54ddf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437103 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#814535}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/49a547f7e235..56a6120b0faf 2020-10-07 mtklein@google.com retry³ absl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I98c143520209f6725c32c623d6d68451c88515de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454798Reviewed-by:
-
Joel Einbinder authored
Some user input (wheel and touch events) can be discarded by the compositor if nothing appears to be listening. When automating the browser, the input could be sent immediately after configuring the DOM to listen for it. Change-Id: I680a802051b7843f2de93f4aed2b24315aa24d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437695 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#814533}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I0f1026e2570f622c0261e359d5bb0e9a8f7e318c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453374Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814532}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/701fe246df25..8274c1978a88 2020-10-06 yyanagisawa@chromium.org Roll out new goma client binary VERSION=206 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ibe30d4d2507c2993490eb1ece67b19544aee9da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453862Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4265.0-1601289755-benchmark-87.0.4278.0-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idf0012a42c52de56843405f4723cf6d763f961d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454800Reviewed-by:
-
bttk authored
Making Toolbar interact with LocationBar only through those interfaces uncovered which LocationBar* and View methods are used. Next these interfaces can be replaced by Coordinator objects. Bug: 1133482 Change-Id: Iececeed429fee66f7adbeb515a328403ef1b1aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444470Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#814529}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602007017-f47632c7e04b048b996f98c97bed5ef2bab09ddf.profdata to chrome-linux-master-1602028663-b1557222162a5cc9fe20bab7e0f808c4540fc966.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I668a0eedbde2087522907110720ca30117df9a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454796Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/eee0513a73bc..70800603f250 2020-10-06 btolsch@chromium.org Change gcc bot to FYI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135534 Tbr: jophba@chromium.org Change-Id: I33919bb5a95865b00cd37c23fe139824f969135d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454539Reviewed-by:
-
Bettina Dea authored
Bug: 1135838 Change-Id: Ie1c0b2e6c866282b5233edf2b8fbe513d7f2d1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454730Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#814526}
-
Alan Cutter authored
This CL updates WebAppTabStripBrowserTests to not use a service worker. These tests seem to be hitting an unrelated CacheStorageCache mojo connection crash. Bug: 1119809 Change-Id: I2336e873645d77126760d73ab40fb99e0240411e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449661 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#814525}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If129a997b64bbb3509e5681676bebf2de47612ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454794Reviewed-by:
-
Ian Wells authored
This reverts commit 9479572b. Reason for revert: This change was meant to be reverted immediately. Original change's description: > Temporarily disable building feedv2 > > Feedv2 was enabled in June, and now Pinpoint is having merge conflicts > when rebasing new patches onto pre-Elements base commits. The purpose > of this CL is to provide a more recent no-Elements base commit for perf > testing. > > I will revert this change as soon as it lands. > > Change-Id: I901ce90cd244a28d3213f377e9348c323cad9089 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453804 > Commit-Queue: Ian Wells <iwells@chromium.org> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814505} TBR=carlosk@chromium.org,iwells@chromium.org Change-Id: I798dfaa48c742571788e6a287050e16aa0c77b18 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453373Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#814523}
-
Ricky Liang authored
This CL adds two feature flags: - spectre-v2-mitigation: Enabled by default This flag can be used to control whether the mitigation is enabled through sandbox_bpf. The per-platform settings can use this flag to selectively disable the mitigation for performance. - force-spectre-v2-mitigation: Disabled by default This flag takes the highest priority and can be used to override the above flag. Setting this flag to enable ensures that Spectre v2 mitigation is enabled regardless of the per-platform settings. Bug: b:169104787 Test: Toggle chrome://flags#spectre-v2-mitigation and chrome://flags#force-spectre-v2-mitigation and verify the sandbox behavior. Change-Id: I3615c69e610c10d98c3495986ff8b673b6e20db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428298Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#814522}
-
Miyoung Shin authored
This is precursor CL of https://crrev.com/c/2379270, and adds the reference count's map to remove the object from the registry when the reference count is zero. Bug: 1105925 Change-Id: I5b04c1fe17c4376dad97dedf3f5750e05f611c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417740 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#814521}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602007017-ff22e69e8516bb0ed861dff91d905b52f8e377d9.profdata to chrome-mac-master-1602028663-1c726c728b4525c73e7ec5c77c97e6198df9f35c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I11039cc2ea2d7fc7551c982dcbd4bafdd60fd611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454793Reviewed-by:
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //chromecast. Bug: 1113033 Change-Id: Ifa61957df0169b570e1e5378f7efb494a8bd3a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441120Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#814519}
-
Tsuyoshi Horo authored
Bug: 1128270 Change-Id: I29d6caaba1093baf46d3ac6086db3aca7a4cb4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449676Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#814518}
-
Elaine Chien authored
Bug: 772945 Change-Id: I852f6f68d1faac5940b3d8a38acca7a5e180d66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447097 Commit-Queue: Elaine Chien <elainec@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
-
Scott Little authored
This CL adds metrics recording which prefs blocklists affect hrefTranslate translations, even if those blocklists don't end up preventing translation from happening. This CL also splits the kNotAutoTranslated enum value that can be recorded for Translate.HrefHint.Status into the two separate values kUiShownNotAutoTranslated and kNoUiShownNotAutoTranslated. Bug: 1131240 Change-Id: Ibeb9adffe4452419559ba0fe451eb7e31e664c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450847Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#814516}
-
Christopher Cameron authored
The ui::Compositor recycling path involves resizing the surface to be 0x0 and ignoring in-flight swaps. This is delicate logic that probably doesn't work with SkiaRenderer. There are two DCHECKs that are hit when this is enabled that aren't when it isn't. ui::Compositor recycling was designed to work around poor design decision that dates back at least 8 years. This is the design where the GLRenderer and all its state (shader cache, etc), is a per-compositor object, and there are compositors for every tab (historically) and every window (currently). A concrete example of where this causes problems: If the user presses a key in the omnibox, then before any content can be rendered, a whole bunch of shaders have to be compiled, because it's a new compositor. If the GLRenderer were a global object shared by all compositors, this wouldn't happen. With SkiaRenderer, we happen to have sort-of solved this problem, by moving all of the GLRenderer state (DirectRenderer state, to be more accurate) into a single GrContext that happens to be shared between all compositors. So, rather than try to understand exactly how the delicate dance of ui::Compositor recycling breaks on SkiaRenderer, just disable it. Bug: 1135663, 1135399, 1135386 Change-Id: I0d5bf93aaf4584ef26af0e38da40deec0ef9bb16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454089Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#814515}
-
Lucas Radaelli authored
This change fixes a bug where an invisible AxNode was being remapped to a hidden Fuchsia node, where an ignored AxNode actually matches the expected behavior. Documentation for invisible: https://chromium.googlesource.com/chromium/src/+/lkgr/docs/accessibility/offscreen.md Test: AXTreeConverterTest.* Bug: 1135817,fuchsia:60693 Change-Id: Ice78a489a16d4edd357a9181d7bf3d23a32ffb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454092Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Cr-Commit-Position: refs/heads/master@{#814514}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: If173681ac45d547a4c5665e07e439a26b997f231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454839Reviewed-by:
-
Daniel Ng authored
This cl introduces the basic architecture to support the borealis starter flow. It introduces the borealis context manager, which is intended to manage the start up flow of the Borealis VM and be the source of truth for run-time information about the Borealis VM. See go/borealis-starter-flow for additional context. Tests: Wrote and ran tests Bug: b:168425531 Change-Id: I88bece091d5d9a5af4a121ff498c2ebdc504cff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434020 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#814512}
-
