GitLab

This is only fixing packaged apps, the bug is not affecting hosted apps.

BUG=314803

Review URL: https://codereview.chromium.org/123733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243887 0039d316-1c4b-4281-b951-d872f2087c98

It does not build entirely yet, but get us closer.

../../third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp:
In constructor 'WebCore::OriginAccessEntry::OriginAccessEntry(const
                WTF::String&, const WTF::String&,
                WebCore::OriginAccessEntry::SubdomainSetting,
                WebCore::OriginAccessEntry::IPAddressSetting)':
../../third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp:55:86:
error: no matching function for call to
'blink::WebPublicSuffixList::getPublicSuffixLength(WTF::String&)'
../../third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp:55:86:
note: candidate is:
../../third_party/WebKit/public/platform/WebPublicSuffixList.h:40:20:
note: virtual size_t
blink::WebPublicSuffixList::getPublicSuffixLength(const
                blink::WebString&)
../../third_party/WebKit/public/platform/WebPublicSuffixList.h:40:20:
note:   no known conversion for argument 1 from 'WTF::String' to 'const
blink::WebString&'

BUG=328717
TEST=gn, ninja -C out/Default blink_platform
R=brettw@chromium.org
TBR=darin

Review URL: https://codereview.chromium.org/119723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243886 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243883 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rossberg@chromium.org

Review URL: https://codereview.chromium.org/131433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243882 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes fullPaths from the file views, by using the volume manager and the getLocationInfo() method instead.

BUG=320967
TEST=Tested manually.

Review URL: https://codereview.chromium.org/130533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243881 0039d316-1c4b-4281-b951-d872f2087c98

code base.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/130003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243880 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332301

Review URL: https://codereview.chromium.org/129723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243879 0039d316-1c4b-4281-b951-d872f2087c98

The actual command-line switch was renamed to this in SVN 230100. This
just fixes about:flags so it shows the correct name.

BUG=332323

Review URL: https://codereview.chromium.org/129703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243878 0039d316-1c4b-4281-b951-d872f2087c98

which is extremely slow.

BUG=248032
R=yoz@chromium.org

Review URL: https://codereview.chromium.org/129603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243877 0039d316-1c4b-4281-b951-d872f2087c98

The code is dead and we have no plan to implement RTP recording in the near term.
So removing to avoid confusion.

BUG=

Review URL: https://codereview.chromium.org/129533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243876 0039d316-1c4b-4281-b951-d872f2087c98

in the lock rank checking code in PRRWLock.

Remove the suppression for the memory leak in _PR_SET_THREAD_RWLOCK_RANK.

R=agl@chromium.org,thestig@chromium.org
BUG=124445,331625
TEST=none

Review URL: https://codereview.chromium.org/129413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243875 0039d316-1c4b-4281-b951-d872f2087c98

Change Browser so that entering a with block calls Start(). This better matches the already existing behavior where exiting a with block calls Close().


BUG=None.
TEST=tools/telemetry/examples/list_available_browsers; tools/telemetry/examples/telemetry_perf_test.py --browser=system; tools/perf/run_benchmark tab_switching.top_10; tools/perf/run_tests; tools/telemetry/run_tests

Review URL: https://codereview.chromium.org/128653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243874 0039d316-1c4b-4281-b951-d872f2087c98

Previously the logic of progress center is implemented in ProgressCenter.  But
the logic does not follow the item's animation states so another logic is needed
in the ProgressCenterItemPanel and it is getting more complex.

This CL adds ProgressCenterItemGroup to manage the states of items. This class
responsible for creating the summarized item for the close view of progress
center and controling life time error items.

This CL also adds the test of the group. 
It does not start to use the group actually.

BUG=315438
TEST=file_browser_jstest

Review URL: https://codereview.chromium.org/127763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243873 0039d316-1c4b-4281-b951-d872f2087c98

This CL creates the signin layered component. It additionally componentizes
TokenWebData and moves it into the signin component. The refactorings performed
on TokenWebData are identical to ones performed on AutofillWebDataService:
- threads are injected rather than being obtained from content::BrowserThread
- //chrome code gets the TokenWebData for a Profile via WebDataServiceFactory
instead of TokenWebData::FromBrowserContext.

This CL is an unchanged reland of https://codereview.chromium.org/109783003/,
which had been speculatively reverted to see if it was causing ChromeOS build
failures. The speculative revert unfortunately stuck as it happened to land in
the same run as the CL that actually fixed the (unrelated) ChromeOS build
failures: https://codereview.chromium.org/129343003/.

BUG=332107
TBR=noamsml

Review URL: https://codereview.chromium.org/130813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243872 0039d316-1c4b-4281-b951-d872f2087c98

So that we can rely on IPC_MESSAGE_CLASS(msg) check to
determine which messages we want to relay onto another thread.

Mostly just shuffling,
- Separated EmbeddedWorker messages out of service_worker_messages.h into embedded_worker_messages.h
- Added a new message class for that
- Created a new directory content/common/service_worker (and OWNERS file) as now we have multiple header files for SW under common/

BUG=313530

Review URL: https://codereview.chromium.org/127583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332414

This reverts commit d3beaabc.

NOTRY=true

Review URL: https://codereview.chromium.org/128433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243870 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243869 0039d316-1c4b-4281-b951-d872f2087c98

This pulls Android-specific targets out of remoting.gyp into a new
gypi file.

Review URL: https://codereview.chromium.org/129943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243868 0039d316-1c4b-4281-b951-d872f2087c98

r243376 Add icu.isolate
r243425 Fix icu link warning on Windows

TBR=jshin@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/128403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243867 0039d316-1c4b-4281-b951-d872f2087c98

Their visibility was controlled separately but r242610 changed
this.

This is intentionally false instead of is_auxiliary_text_visible()
of candidate_window_ because that field is not updated at that point.

BUG=332275
R=hsumita@chromium.org, komatsu@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/128863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243866 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the debug info is assumed to include only layout rects.
This is a bummer. This CL allows for blink to return an arbitrary JSON
object that will simply be merged into the base::DictionaryValue
we populate for about::tracing. This will allow us to return
arbitrary debug info for tracing from blink.

BUG=None

Review URL: https://codereview.chromium.org/128303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243865 0039d316-1c4b-4281-b951-d872f2087c98

- Add content_security_policy and security_policy_type to ViewHostMsg_CreateWorker_Params and WorkerProcessMsg_CreateWorker_Params.
 It is needed because WorkerMsg_StartWorkerContext will be removed.
- Implement workerScriptLoaded, workerScriptLoadFailed and selectAppChacheID.
- Queue WebMessagePortChannel in WebSharedWorkerStub::OnConnect
  When we will add the script loading code in WebSharedWorkerImpl, the worker process can't respond to the connection request which is sent soon after the SharedWorker is created.
  So we have to create WebMessagePortChannelImpl in WebSharedWorkerStub::OnConnect.

This is step 2 of moving the worker script loading code from the renderer process to the worker process.
See: http://crbug.com/329786

BUG=329786

Review URL: https://codereview.chromium.org/115713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243864 0039d316-1c4b-4281-b951-d872f2087c98

The dependency is unnecessary and causes build error in the standalone webrtc project due to missing base.gyp when SCTP is enabled (it depends on usrsctp.gyp, which depends on system.gyp). All system.typ needs from base.gyp is the "include_dirs" pointing to ".." relative to "base". So we can remove the dependency on base.gyp and add "include_dirs":["../.."] instead.

BUG=

Review URL: https://codereview.chromium.org/128933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243863 0039d316-1c4b-4281-b951-d872f2087c98

"-std" has value which is not equal to default value "c++11" for some variants
of Chrome build. At least for "chromeos=1 clang=1" build "-std=gnu++11" is set.
So not passing "-std" to YCM caused compilation error inside YCM, hence there
were some problems with completion.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/104503016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243862 0039d316-1c4b-4281-b951-d872f2087c98

The synthetic swipe and scroll gestures have a parameter that controls the speed
of the gesture (in pixels per second). This patch exposes that parameter to the
corresponding page actions in Telemetry.

BUG=326522

Review URL: https://codereview.chromium.org/128073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322682
TEST=covered by existing unit tests

Review URL: https://codereview.chromium.org/127963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243860 0039d316-1c4b-4281-b951-d872f2087c98

In the save file dialog, the file name input has a initial focus.  Previously,
the file name input has a tabindex=10, and when the focus goes back to the
document, it moves to the file name input again because of the refocus method of
Filemanager class.

This CL change the tabindex of elements on the save-as dialog's footer and allow
users to explorer all controls in Files.app.

BUG=332051
TEST=manually

Review URL: https://codereview.chromium.org/127843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243859 0039d316-1c4b-4281-b951-d872f2087c98

I'll land this on the tip-of-tree, and then revert it.  We'll then apply
it to the dev branch so that there is no chance of accidentally getting
security dialogs on Windows.

This should reduce the bug to P2, and allow a more complete resolution
of the bug.

r=rch
BUG=329255

Review URL: https://codereview.chromium.org/127463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243858 0039d316-1c4b-4281-b951-d872f2087c98

On Windows, Widget::InitParams::force_show_in_taskbar is now respected,
so it is possible to override the default without having to directly set
HWND properties.

This should not change any behaviour (just a refactor).

Previously, we had a special case where the message center would turn
off showing in taskbar, and app launcher would turn it off for <= Vista.
Now we have just one special case: app launcher turns it on for >= Win7.

BUG=332277

Review URL: https://codereview.chromium.org/127133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243857 0039d316-1c4b-4281-b951-d872f2087c98

Remove ResourceUpdate::CreateFromCanvas().
|canvas| member variable of ResourceUpdate is not used by ResourceUpdateController.
Also all customer of ResourceUpdate can pass SkBitmap.

R=enne@chromium.org, danakj@chromium.org
BUG=NONE
TEST=cc_unittests --gtest_filter=ResourceUpdateControllerTest.*

Review URL: https://codereview.chromium.org/127053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243856 0039d316-1c4b-4281-b951-d872f2087c98

Add a check if the user tries to create a profile with the
name of an already existing supervised user. In that case,
the user is not allowed to create a new such supervised user
profile, instead he can directly import the existing supervised
user.
A screenshot can be found in the bug description.

BUG=282464
TEST=browser_tests

Review URL: https://codereview.chromium.org/125993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243855 0039d316-1c4b-4281-b951-d872f2087c98

This change is partially a cleanup and implementation of UdpTransport
for Cast. As the name suggests it is a UDP transport mechanism for
Cast using net::UdpSocket.

A behavior change is that a Cast receiver can have sender IP address
optional. Only after a packet is received that it can send packets. It
will reply only to that address and ignore packets coming from a
different address.

If a sender address is given to Cast receiver then there is no change.

BUG=331989

Review URL: https://codereview.chromium.org/125713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/125643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243852 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332675
R=bauerb@chromium.org,inferno@chromium.org

Review URL: https://codereview.chromium.org/131073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243851 0039d316-1c4b-4281-b951-d872f2087c98

Moves the creation of PrintingControllerImpl into the UI thread.
Before, it wasn't being created in the UI thread, and for some reason
PrintingControllerImpl#create wasn't failing its UI thread assertion.
It did start to fail for N4 with KitKat, so this fixes the issue and
re-enables the test.

BUG=330291

Review URL: https://codereview.chromium.org/123883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243850 0039d316-1c4b-4281-b951-d872f2087c98

This makes the --url option generally available, and adds tests for
starting Chrome with a URL, with and without a simultaneously
restoring a session.

Note:- As part of this I have added to telemetry the ability
to specify different browser options for each page, and to
specify the startup URL in the page set (this could easily
be extended to other browser options). This was needed to
avoid having to create 6 separate benchmarks to test
different combinations of URLs and sessions to be restored.

BUG=298052

Review URL: https://codereview.chromium.org/113563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243849 0039d316-1c4b-4281-b951-d872f2087c98

Process wrapping on Android currently conflicts with SELinux.

TEST=ASan content_shell test on KLP Android
BUG=325685
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/120733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243848 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes working on fullPath from the isMovable() method. Instead the volume manager is used.

TEST=Tested manually, also partly covered by browser tests.
BUG=329435

Review URL: https://codereview.chromium.org/130353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243847 0039d316-1c4b-4281-b951-d872f2087c98

R=enne@chromium.org
BUG=NONE
TEST=NONE (No functional change)

Review URL: https://codereview.chromium.org/130213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/130183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243845 0039d316-1c4b-4281-b951-d872f2087c98