GitLab

Bug: 
Change-Id: I79db155731d01055cf6121b14b18fbd550d62a6f
Reviewed-on: https://chromium-review.googlesource.com/518664Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475818}

Currently, the ruby-position property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ERubyPosition enum and use the generated
CSSValueID <-> ERubyPosition mappings.

BUG=628043

Review-Url: https://codereview.chromium.org/2915683002
Cr-Commit-Position: refs/heads/master@{#475817}

Revert of Enable redirection of SequencedWorkerPool to TaskScheduler in TestBrowserThreadBundle. (patchset #3 id:40001 of https://codereview.chromium.org/2769693002/ )

Reason for revert:
Caused ServiceWorkerResourceStorageDiskTest.* tests in content_unittests to crash.

See https://bugs.chromium.org/p/chromium/issues/detail?id=727994

Reverting locally fixed the crashes, so I'm going to revert this CL.

Original issue's description:
> Enable redirection of SequencedWorkerPool to TaskScheduler in TestBrowserThreadBundle.
>
> Motivation:
> - Redirection of SequencedWorkerPool to TaskScheduler is enabled in
>   browser tests and on Canary and Dev. It makes sense to enable it
>   in unit tests too.
> - It is not possible to wait until there are no more blocking pool
>   *and* TaskScheduler tasks (new tasks in the blocking pool during
>   a FlushForTesting() call on TaskScheduler and vice versa). If
>   the blocking pool is redirected to TaskScheduler, calling
>   FlushForTesting() on TaskScheduler guarantees that there are no
>   more blocking pool *and* TaskScheduler tasks.
>
> BUG=667892
>
> Review-Url: https://codereview.chromium.org/2769693002
> Cr-Commit-Position: refs/heads/master@{#475144}
> Committed: https://chromium.googlesource.com/chromium/src/+/e1aa28915a28da266d406202a07112d44d6cc018

TBR=gab@chromium.org,robliao@chromium.org,sky@chromium.org,fdoray@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=667892,727994

Review-Url: https://codereview.chromium.org/2909393003
Cr-Commit-Position: refs/heads/master@{#475816}

This patch makes TextUnderlinePosition an enum class for better type
safety.

BUG=684966
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2909423002
Cr-Commit-Position: refs/heads/master@{#475815}

This patch renames some StyleRareNonInheritedData members so that they
match the format expected by the generator.

BUG=628043

Review-Url: https://codereview.chromium.org/2911403002
Cr-Commit-Position: refs/heads/master@{#475814}

This is an initial step to merge MainThreadWorklet and ThreadedWorklet into
Worklet. No tests added, no behavior change.

In the current implementation, ThreadedWorklet implements the loader client for
classic script loading. That's blocking the merge effort. This CL moves the
client implementation from ThreadedWorklet to ThreadedWorkletMessagingProxy as
LoaderClient and reduces differences between MainThreadWorklet and
ThreadedWorklet.

DesignDoc: https://docs.google.com/document/d/1cgLcrua7H_7x_o5GlzYrAi2qt-TqTzgtOeixFAugR6g/edit?usp=sharing

Bug: 727194
Change-Id: I9b9adc04ff5a633a2d9afef3ded6a2f57b89e6ba
Reviewed-on: https://chromium-review.googlesource.com/517454
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475813}

https://skia.googlesource.com/skia.git/+log/b365cf590f87..b5e484254331

$ git log b365cf590..b5e484254 --date=short --no-merges --format='%ad %ae %s'
2017-05-30 mtklein clean up now that min_stride == 1
2017-05-30 mtklein call compile in convert_with_pipeline()
2017-05-30 egdaniel Allow GPU blur fast path for circles and rects when using ignore xform
2017-05-31 fmalita Revert "Delete SkGaussianEdgeShader"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I72c40a57d7eb0c2bfd81b069c6ea65565031049c
Reviewed-on: https://chromium-review.googlesource.com/518450Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475812}

My previous CL https://chromium-review.googlesource.com/c/514424/
change the warm-up connection erroneously to use
bindAsExternalService in place of bindToCallerCheck.
Fixing it and adding a test.

BUG=726901

Change-Id: I8b2dfc7ccc8dbf6db22af45714d7777c437e8f16
Reviewed-on: https://chromium-review.googlesource.com/518289Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475811}

The initial CL to support borders/paddings of the containing block of
inlines[1] added the block start of borders/paddings to every line.

This patch fixes to add it only once, to the content_size_, the same way
as NGBlockLayoutAlgorithm does.

[1] https://codereview.chromium.org/2886453005

BUG=636993, 725359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2914523002
Cr-Commit-Position: refs/heads/master@{#475810}

This patch introduces two mojom types: ServiceWorkerProviderHost and
ServiceWorkerProvider. They are currently used for managing the lifetime of
ServiceWorkerProviderHost from the renderer, but these interfaces will have
methods managing registrations, registration associated by the document and
controller.
These interfaces are now associated with SWDispatcherHost which is already bound
with the channel. After crrev.com/2779763004, interfaces for worker's context
will be associated with EWInstanceClient. This will solve the ordering issue
between messages of Stopped and ProviderDestroyed.

BUG=629701,676983,668633

Review-Url: https://codereview.chromium.org/2653493009
Cr-Commit-Position: refs/heads/master@{#475809}

MediaStreamTrack::applyConstraints() currently resolves with
PhotoCapabilities bc Caps+Settings are retrieved after applying
those constraints.

This CL changes this to resolve applyConstraints() with the
constraints that were applied. 

LayoutTests are updated and slightly cleaned up by factoring
out a service method into resources/imagecapture-helpers.js

Bug: 723251
Change-Id: I0db8671c75154fbeff1ef03f385ed277cf5ce17e
Reviewed-on: https://chromium-review.googlesource.com/517280
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475808}

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//device/geolocation starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018

Review-Url: https://codereview.chromium.org/2866003002
Cr-Commit-Position: refs/heads/master@{#475807}

This forwards accSelect to the AXPlatformNode. In order to do this, we
had to extension AccessibilityPerformAction a bit to be able to handle
AX_ACTION_FOCUS. Not that the node id is not passed as part of the AXActionData
and is not being used by the delegate at this point.

BUG=703369

Review-Url: https://codereview.chromium.org/2913553003
Cr-Commit-Position: refs/heads/master@{#475806}

This reverts commit 77c59a87.

Reason for revert: Broke build. See the comment on the original review.

Original change's description:
> Mojo EDK: Refactor layered message serialization
> 
> Consolidates and simplifies user message serialization within the EDK.
> Namely:
> 
>   * The ports layer no longer operates under the assumption that all
>   events exist exclusively in serialized form. This eliminates the
>   complexity of layered message allocation at the cost of a small amount
>   of extra copying in some cases.
> 
>   * ports::Message is now more aptly named ports::Event, and different
>   event types are subclasses.
> 
>   * Introduces a ports::UserMessage base class for ports embedder
>   message types. These can be attached to ports::UserMessageEvent
>   objects.
> 
>   * The MessageForTransit and PortsMessage types have been flattened
>   into a single UserMessageImpl type, a subclass of ports::UserMessage.
> 
>   * Nearly all user message serialization and deserialization logic has
>   been consolidated into UserMessageImpl. A few small pieces remain
>   isolated in node_controller.cc and will eventually move elsewhere
>   after additional refactoring.
> 
> All of this work is a precursor to supporting lazy serialization.
> 
> BUG=725321
> 
> Change-Id: Ib9e66cd0d5b88ac0e6dc898f248c958039078023
> Reviewed-on: https://chromium-review.googlesource.com/516402
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#475731}

TBR=jcivelli@chromium.org,rockot@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=725321

Change-Id: I84f950290e6c45dc830f2bc3177af09ae955f432
Reviewed-on: https://chromium-review.googlesource.com/518742Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475805}

BUG=720058

Review-Url: https://codereview.chromium.org/2917433002
Cr-Commit-Position: refs/heads/master@{#475804}

Non-secure HTTP cannot meet users’ security and privacy expectations
when browsing the web. This change introduces new flag states which will
control marking HTTP pages as non-secure in Incognito mode and after
editing HTML forms. Subsequent CLs will detect the new flag states and
adjust the Security Chip UI warnings accordingly.

BUG=721896

Review-Url: https://codereview.chromium.org/2907153006
Cr-Commit-Position: refs/heads/master@{#475803}

This test is no longer correct and doesn't have any real value anyway.
Bye, Felicia.

BUG=None
TBR=jcivelli@chromium.org

Change-Id: Ia13c63a5a8741db739c2c197f2164fea8180e719
Reviewed-on: https://chromium-review.googlesource.com/518485Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475802}

Due to conflicts with the GVR library, we had to stop using this for the VR
browser mode. I think this attribute is still useful for the future, but we
should use it to reduce priority of possibly-slow user GL code instead of using
"high" priority ourselves.

BUG=725684
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2914593003
Cr-Commit-Position: refs/heads/master@{#475801}

This patch generates getters/setters/mapping for TextEmphasisFill,
TextEmphasisPosition, TextEmphasisCustomMark.

BUG=628043

Review-Url: https://codereview.chromium.org/2904403002
Cr-Commit-Position: refs/heads/master@{#475800}

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

This patch also supports when inter-item is not breakable. Inline
margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

Includes a fix for LazyLineBreakIterator where offset 0 should not be
breakable.

This patch also adds tests when inter-items are not breakable.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2865903002
Cr-Commit-Position: refs/heads/master@{#475799}

This works behind flag. Currently only normal notification is supported.

BUG=723144

Review-Url: https://codereview.chromium.org/2892893002
Cr-Commit-Position: refs/heads/master@{#475798}

BUG=chromium:726811

Review-Url: https://codereview.chromium.org/2908383002
Cr-Commit-Position: refs/heads/master@{#475797}

This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters.
It rewrites base::Bind to base::BindOnce where the resulting Callback is converted to
OnceCallback immediately.
E.g.:
  base::PostTask(FROM_HERE, base::Bind(&Foo));
is rewritten to:
  base::PostTask(FROM_HERE, base::BindOnce(&Foo));

In terms of the behavior change after the rewrite, the OnceCallback
implementation moves out the bound argument to the target function, unlike
Callback.

Bug: 554299
Change-Id: Id0d8d60e6c0104d89093522a030fa05d7c50ae67
Reviewed-on: https://chromium-review.googlesource.com/517845Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475796}

Revert of Making answer card to behave like other results. (patchset #6 id:100001 of https://codereview.chromium.org/2905523004/ )

Reason for revert:
This broke a build
https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-generic%20Compile/builds/36279

Original issue's description:
> Making answer card to behave like other results.
>
> Now it lives in a search result container, which can be selected,
> highlighted, navigated with keyboard etc.
>
> Opening the result (i.e. what happens upon clicking on it) is not yet
> implemented.
>
> Unit test for the new result container isn't yet implemented since both
> result opening and accessibility behavior are not yet implemented.
>
> Bug=712331
>
> Review-Url: https://codereview.chromium.org/2905523004
> Cr-Commit-Position: refs/heads/master@{#475782}
> Committed: https://chromium.googlesource.com/chromium/src/+/2420a92712ee82be175bea6750774bec8006c5ce

TBR=xiyuan@chromium.org,jam@chromium.org,sky@chromium.org,vadimt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug=712331

Review-Url: https://codereview.chromium.org/2910173003
Cr-Commit-Position: refs/heads/master@{#475795}

BUG=n/a
TEST=n/a

Review-Url: https://codereview.chromium.org/2907333002
Cr-Commit-Position: refs/heads/master@{#475794}

This patch prunes two call sites of the deprecated function, which is
safe because layout is already updated at their caller,
Editor::HandleTextEvent().

BUG=698633

Review-Url: https://codereview.chromium.org/2912233002
Cr-Commit-Position: refs/heads/master@{#475793}

This is to fix a problem where the error message lists all the
directories owned by the teams that share a component instead of only
those that actually have the component specified.

BUG=707774
R=ymzhang,sshruthi,katesonia

Change-Id: Ibee24a40604d0e0e4e0475f937782887cf360ab7
Reviewed-on: https://chromium-review.googlesource.com/498055Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475792}

Per the analysis in https://crbug.com/725689, the equivalent functionality
of ShouldServiceRequest is present with PlzNavigate, which means this
comment is now obsolete.

BUG=725689

Review-Url: https://codereview.chromium.org/2910793002
Cr-Commit-Position: refs/heads/master@{#475791}

This patch fixes the PermissionRequestManager codepath to show Android
system permission prompts where appropriate, by implementing
PermissionRequestImpl::GetContentSettingsType() so we know what
permission to request.

BUG=606138

Review-Url: https://codereview.chromium.org/2909223003
Cr-Commit-Position: refs/heads/master@{#475790}

This CL implements the logic of display notification when selecting
"Open in new Chrome tab" from the Browser Actions context menu. Clicking
the notification will open Chrome. If the notification is for single
link, Chrome shows the current active tab, otherwise Chrome shows the
tab switcher. Opening Chrome will dismiss the notification.

BUG=719080

Review-Url: https://codereview.chromium.org/2876863002
Cr-Commit-Position: refs/heads/master@{#475789}

We currently use the default copy constructor for subgroups under
ComputedStyleBase like StyleSurroundData. We've been able to do so
because all fields had default copying behaviour. Now we want to
generate StyleRareNonInheritedData, which has std::unique_ptr fields
that cannot be copied by default. This means we have to explicitly
generate user-defined copy constructors for these subgroups.

This is in preparation for supporting custom copying behaviour for
fields.

Diff of generated files:
https://gist.github.com/darrnshn/1c51e498c11b2798fbc962390a009060/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2911373002
Cr-Commit-Position: refs/heads/master@{#475788}

https://skia.googlesource.com/skia.git/+log/114a3c0b2b26..b365cf590f87

$ git log 114a3c0b2..b365cf590 --date=short --no-merges --format='%ad %ae %s'
2017-05-30 fmalita Speculative fix for SkPerlinNoiseShaderImpl::asFragmentProcessor leak
2017-05-30 herb Add aarch64 tail code.
2017-05-30 fmalita [Reland] Relocate shaders to own dir
2017-05-30 fmalita Delete SkGaussianEdgeShader
2017-05-30 reed move perlinenoise2 into effects
2017-05-30 mtklein simplify sse41::srcover_srgb_srgb
2017-05-30 herb Add arm tail code.
2017-05-30 mtklein remove sse2::srcover_srgb_srgb
2017-05-30 fmalita Don't pull private headers in SkOverdrawColorFilter.h

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I27e6535e4fc5894b10a8ebdd63bd2e6f962a0db9
Reviewed-on: https://chromium-review.googlesource.com/518425Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475787}

This CL flips `use_once_callback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//services/device starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

Bug: 714018
Change-Id: Ida11b9eaa331cce7f72ed0f1554731fd26659f2f
Reviewed-on: https://chromium-review.googlesource.com/517586Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475786}

Add a "color spin" set of primaries to be used by layout tests. These
primaries are rotated RGB->GBR and have a ginormous gamut, so any
places where we fail to do color conversion should be very noticeable.

BUG=713891

Review-Url: https://codereview.chromium.org/2912903003
Cr-Commit-Position: refs/heads/master@{#475785}

Begin/FinishProcessingOrderNumber can release fence syncs and run their
callbacks. Those callbacks can call into the scheduler, in particular,
Enable/DisableSequence. So move the order processing to outside the lock
and make it safe to reenter the scheduler.

The included test deadlocks without this change. I haven't figured out
what happens after gpu process crash that causes problematic sync token
waits. I suspect it's sync tokens submitted by renderers that are left
over from the previous gpu process instance.

R=piman
BUG=514813
TEST=gpu_unittests SchedulerTest.ReentrantEnableSequenceShouldNotDeadlock

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0a1d4154bb5f7b83b32a197fa8cb47a0f0d8e188
Reviewed-on: https://chromium-review.googlesource.com/518583Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475784}

Single-line messages in the network detailed view are updated to follow
Material Design specs. Also, fixes the padding for single-line messages
in Bluetooth detailed view from 22dip to 18dip.

BUG=687778
TEST=none

Change-Id: I82c377ad401026c9bdac595f614006584bd74336
Reviewed-on: https://chromium-review.googlesource.com/517967Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475783}

Now it lives in a search result container, which can be selected,
highlighted, navigated with keyboard etc.

Opening the result (i.e. what happens upon clicking on it) is not yet
implemented.

Unit test for the new result container isn't yet implemented since both
result opening and accessibility behavior are not yet implemented.

Bug=712331

Review-Url: https://codereview.chromium.org/2905523004
Cr-Commit-Position: refs/heads/master@{#475782}

Currently, we only construct instances of TextMatchMarker (previously
RenderedDocumentMarker) inside TextMatchMarkerListImpl, by calling
TextMatchMarker::Create() on an instance of DocumentMarker. This CL changes this
so callers directly construct instances of TextMatchMarker. This sets us up to
eventually move the storage and accessor methods for whether or not the marker
is active out of DocumentMarker and into TextMatchMarker.

BUG=707867

Review-Url: https://codereview.chromium.org/2905753002
Cr-Original-Commit-Position: refs/heads/master@{#475724}
Committed: https://chromium.googlesource.com/chromium/src/+/6b0a494122ebe2fc48099a9549b0acbf0b28571d
Review-Url: https://codereview.chromium.org/2905753002
Cr-Commit-Position: refs/heads/master@{#475781}

Bug: 
Change-Id: Id45f9ef44b25aac984b1f444911a233457a630f5
Reviewed-on: https://chromium-review.googlesource.com/517550Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475780}

Active LayerImpl properties are never pushed. This patch enforces this
by making LayerImpl::SetNeedsPushProperties only work on the pending tree.

The existing VerifyLayerChangesAreTrackedProperly test has been modified
to work on the pending tree instead of the active tree. The existing
mask_to_bounds tests have been updated as they were intended for
another era when SetBounds did depend on mask_to_bounds.

An additional test has been added for active layer change tracking.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I711109df86e6c644333a8e14a5540a4b22675894
Reviewed-on: https://chromium-review.googlesource.com/516826
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475779}