- 22 Aug, 2018 40 commits
-
-
Tatsuhisa Yamaguchi authored
This will make notification latched at an in-between position by partially sliding it left or right, when the notification has either or both snooze/settings buttons. The position to latch the slider changes based on the number of those buttons. This change does not yet show buttons there. The feature is behind a flag. To test this, add --enable-features=NotificationSwipeControl flag. Bug: 840497 Change-Id: I5fce9216ebae79112d66eb289f6e669347c4aba7 Reviewed-on: https://chromium-review.googlesource.com/1177464Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585090}
-
Nico Weber authored
(The motivation here is to fix a compile error on the libc++ bot -- looks like std::size() is a C++17 thing, and libc++ only enables these functions with /std:c++17 while the MSVC STL allows it even in C++14 language mode. But using strlen() is simpler too.) Bug: 801780 Change-Id: Ic955935253e61d3a3947a314a2bdc3e0a9354016 Reviewed-on: https://chromium-review.googlesource.com/1182081Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#585089}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ea60b951d735..e6ab998bc2e6 git log ea60b951d735..e6ab998bc2e6 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 egdaniel@google.com Revert "added support for sk_Dimensions to SkSL" 2018-08-22 nigeltao@google.com Update SkCodec::rewindIfNeeded comment 2018-08-22 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 70aeda4942f5..44ae899ae9ce (3 commits) 2018-08-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-22 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 d710fee3861a..70aeda4942f5 (5 commits) 2018-08-21 mtklein@google.com let's like, chill out about all these rules, man 2018-08-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-21 herb@google.com Rename SkGlyphRunListDrawer to SkGlyphRunListPainter 2018-08-21 enne@chromium.org Add add_and_true_to_loop_condition workaround 2018-08-21 fmalita@chromium.org [skottie] Split-up Skottie.cpp 2018-08-21 herb@google.com Use SkGlyphRun directly in SkRemoteGlyphCache 2018-08-21 robertphillips@google.com Address fuzzer issue 2018-08-21 kjlubick@google.com Update Pixels to Android P 2018-08-21 egdaniel@google.com Disable FB Fetch in metal ios 2018-08-21 fmalita@chromium.org [skottie/cleanup] Refactor parser state handling 2018-08-21 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 7a4f6b8c7d5e..d710fee3861a (2 commits) 2018-08-21 herb@google.com Check for too small rect for path 2018-08-21 ethannicholas@google.com added support for sk_Dimensions to SkSL 2018-08-21 mtklein@google.com treat opaque dsts as src alpha type 2018-08-21 bsalomon@google.com Fix op chaining painter's order violation in GrRenderTargetOpList. 2018-08-21 herb@google.com Fix possible nullptr deref Created with: gclient setdep -r src/third_party/skia@e6ab998bc2e6 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 644669,chromium:829614,chromium:873020,chromium:873020 TBR=fmalita@chromium.org Change-Id: I4dc802075c67741f2c6db2225eb9e6d3772cd618 Reviewed-on: https://chromium-review.googlesource.com/1185061Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585088}
-
Scott Haseley authored
[scheduler] Move stop-in-background feature to blink::features and change availability to Android-only Changing the availability to Android-only since freezing on desktop is driven by the browser (TabManager), and this feature will conflict. Moving this feature to blink::features to be consistent with other scheduler features (kStopNonTimersInBackground), and since as a runtime enabled feature it will not make it past "test" since it is only available on Android. Bug: 876123 Change-Id: Ib83341504be4222da548bab2d6bb71375712bf52 Reviewed-on: https://chromium-review.googlesource.com/1182516Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#585087}
-
Amirhossein Simjour authored
Optional API calls are marked optional + I added a DCHECK to make sure that non-optional calls do exist. Change-Id: I13dfa5ab77f75a5b42eb1ca76ff0aa7e5eeeb840 Reviewed-on: https://chromium-review.googlesource.com/1177888Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#585086}
-
Dong-hee Na authored
Update FetchResponseData::Create() to set the response message to be an empty string unless the URLs protocol is about or data or blob. Bug: 832041 Change-Id: I9e8ec27dd8b4ba051bb97c6ca063f618191c95ce Reviewed-on: https://chromium-review.googlesource.com/1179513Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#585085}
-
Leonard Grey authored
Bug: 838119 Change-Id: Id2821c2e0fe8cdabc2cfa8d239656835be34c0ba Reviewed-on: https://chromium-review.googlesource.com/1181872Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#585084}
-
Dale Curtis authored
The test was using the .webm file instead of the .ogg file, switching it causes a few hash failures due to timestamp differences in how we trim the start time in AudioRendererImpl. To fix the hash differences, we now use std::round() when calculating how much to trim off the buffer. This allows us to maintain the same (voluminous) opus hashes for the ogg test and seems more correct. As luck has it, AudioTimeStampHelper::TimeToFrames handles this already, so use it. A couple MP3 hashes changed due to this, but that's okay. I've also added a DVLOG(1) message when trimming is applied to help future spelunkers. BUG=none TEST=tests pass Change-Id: I60eef31c2b62be879bba5151bdd26cbf5468dd16 Reviewed-on: https://chromium-review.googlesource.com/1184042Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#585083}
-
Kushagra Sinha authored
Enable Mirror on Chrome OS by default if Account Manager switch / flag is set. Bug: 820046 Change-Id: Id5fc4cdddcc15db4b2c3277704ca131345a01879 Reviewed-on: https://chromium-review.googlesource.com/1184914Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#585082}
-
Yuta Kitamura authored
DefaultThreadScheduler is an instance of ThreadScheduler that is used as the scheduler for the default thread, which is automatically assigned to a thread that does not have specific scheduling requirements. The default scheduler only implements a minimum amount of functionalities so most of Blink functions could run. SingleThreadedWebThread is now renamed to DefaultMainThread, because it can be actually used as a main thread for multi-threaded Blink Platform. This patch enables more miscellaneous embedders to run Blink on the default thread. They will be converted in follow-up patches. Bug: 826203 Change-Id: I91d38bd17e10b376f3463e3cf013a51bb7797321 Reviewed-on: https://chromium-review.googlesource.com/1181014 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
The CL adds media recording indicator to UserChooserView. Microphone and camera can be used by another user when multi user login is enabled. The indicator shows that they are in use by the background user. Screenshot: http://screen/drwebysXfDm TEST=manual BUG=845806 Change-Id: I02f8912d520315f1509e9f27ec818a0eeaccbe0e Reviewed-on: https://chromium-review.googlesource.com/1181001Reviewed-by:
-
Dale Curtis authored
This was needed where codec specific behavior was causing crashes with splicing, but now that we just use partial append window trimming, there's no reason not to support it on every audio codec. BUG=none TEST=unittests pass. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia52d058743f557bcddd24e31bcc5cf694e83ef8a Reviewed-on: https://chromium-review.googlesource.com/1182662 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
Rotation transform should be constructed so that when it is scaled, it should not lead to subpixel origin. Bug: 869090 Test: Covered by unittest. Also tested on a device Change-Id: I5bc0c0885350e0cbc10fe23f8300cbf9b4492449 Reviewed-on: https://chromium-review.googlesource.com/1184144Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima (OOO) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#585078}
-
Fredrik Söderquist authored
Rename SVGAnimatedPropertyBase::SetBaseValueAsString to AttributeChanged, to reflect how it interacts with the system in general (sets a new value based on an updated attribute string) - the counter- part to this notifier being BaseValueChanged. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I55b42d7662c744d4d4d39b8ea0545d0318bcbeab Reviewed-on: https://chromium-review.googlesource.com/1184844Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#585077}
-
Jüri Valdmann authored
This method checks for 3 bytes of available data, but reads only 2 bytes. Change-Id: I504e9ed6cda18907a3f74cd931ef97d910043df5 Reviewed-on: https://chromium-review.googlesource.com/1185019Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Rachel Blum <groby@chromium.org> Cr-Commit-Position: refs/heads/master@{#585076}
-
Helen Li authored
network::SocketDataPump uses Socket::ReadIfReady instead of Socket::Read, and expects ReadIfReady to be implemented. This CL adds the implementation to HttpProxyClientSocket, and fixes the incorrect test expectation, which can serve to catch future regressions. Bug: 875855 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic9b79cf8c1290de55d102052ea5c84fcac0f4fbd Reviewed-on: https://chromium-review.googlesource.com/1183984Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#585075}
-
Theresa authored
BUG=876483 Change-Id: I812e10922cee721cdd510c6a98190c8899cf3710 Reviewed-on: https://chromium-review.googlesource.com/1183809 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#585074}
-
bsheedy authored
Clears the two VR feedback shared preference values before a test starts if they aren't currently the default. This is to prevent flakiness in VrFeedbackInfoBarTest#* since shared preference settings are not automatically reset between tests (which is expected). Bug: 875977 Change-Id: Ic69cadd2ae43b1a3570ee9f349f2770fed812138 Reviewed-on: https://chromium-review.googlesource.com/1183816Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585073}
-
Xida Chen authored
Right now in TouchActionFilter, the member gesture_sequence_in_progress_ turns to true at GestureScrollBegin and false at GestureScrollEnd. When this is true, we do not reset the |scrolling_touch_action_| because being true means there are more incoming gesture events. However, when the renderer is busy, it could happen that we have GestureTapDown, and then we receive the OnHasTouchEventHandlers(true) message and reset the |scrolling_touch_action_|. In this case, processing the incoming gestures such as GSB can cause a crash because the |scrolling_touch_action_| has no value. Bug: 851644 Change-Id: Idd9de11fc59ef87d7fa8f2d9e3d951fb4db5c2c5 Reviewed-on: https://chromium-review.googlesource.com/1180560Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585072}
-
Ian Kilpatrick authored
Change-Id: Iffb3fd56ff4578f60e2c5c8d019fb75ebb61d9fb Reviewed-on: https://chromium-review.googlesource.com/1183492 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#585071}
-
Martin Kreichgauer authored
This changes FidoRequestHandler to translate any CtapDeviceResponseCode::kCtap2ErrOperationDenied (CTAP2_ERR_OPERATION_DENIED) responses from platform authenticators into FidoReturnCode::kUserConsentDenied. Upon receiving this error, all outstanding authenticator requests are cancelled, and the error is bubbled up into a NOT_ALLOWED_ERROR. More concretely, this is going to change UI behavior such that the request is cancelled if the user clicks cancel or fails verification in the native macOS Touch ID dialog. The WebAuthn spec in sections 5.1.3 and 5.1.4 states that "If any authenticator returns a status indicating that the user cancelled the operation", which indicate that the UA should cancel the entire operation and return NOT_ALLOWED_ERROR in this case". CTAP2_ERR_OPERATION_DENIED is used by the CTAP2 spec to signal - user declined to create a credential - user failed gesture verification - time out during user consent collection - user failing to select a credential on authenticators with account chooser UI (deny or timeout) Because of the reference to authenticator-defined timeouts, it is debatable whether this CTAP error sufficiently indicates that "the user cancelled the operation". For internal authenticators (Touch ID), however, this is definitely the case. I will track a follow-up discussion whether to extend this behavior to external authenticators also in crbug/875982. Also fix a bug in MockFidoDevice GetId generation and add a |ExpectCtapRequestAndReturnError| helper method. Bug: 875982, 678128 Change-Id: I616b319accb7d387c0d98de059c52b04bc80ce59 Reviewed-on: https://chromium-review.googlesource.com/1181863 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585070}
-
Jeremy Roman authored
This allows DeferredTaskHandler::RemoveMarkedSummingJunction to assume that the graph lock is held, rather than having to acquire it (recursively, if it's already held). Since Oilpan finalizers cannot safely touch other heap objects (as those object may be swept in the same GC cycle), the AudioNode and AudioParam objects now hold a direct reference to the DeferredTaskHandler associated with the audio context, which is needed to acquire the appropriate lock. Bug: 856641 Change-Id: Ied445a684d60b8beccb080b98867fcf80f967d21 Reviewed-on: https://chromium-review.googlesource.com/1182296 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585069}
-
Matthew Cary authored
This adds *SharedMemoryRegion create methods that parallel those in base::. These use mojo::SharedMemoryBuffer::Create, which will use a broker if appropriate to create shared memory in unprivileged processes. Also update comments to clarify migration. Bug: 872778 Change-Id: Ia32da8181fd37d88a49a26e3e7e158612147646b Reviewed-on: https://chromium-review.googlesource.com/1169602Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#585068}
-
Hans Wennborg authored
Previously we used a GCC/libstdc++ package from Ubuntu Precise to build a Clang that would work on Precise or later. These days, all bots and developers are on Trusty or later, so this should no longer be necessary. Bug: none Change-Id: I518ee55d07c04dc89163fe262c81d935e05fed78 Reviewed-on: https://chromium-review.googlesource.com/1183915Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585067}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4b9089142927..4cc579e9d288 git log 4b9089142927..4cc579e9d288 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 frankhu@google.com Add apex-access group to group baseline 2018-08-22 yueherngl@google.com octopus: add additional sign_type 2018-08-21 lannm@chromium.org Remove scripts/extract_gerrit_history 2018-08-21 lannm@chromium.org Move repository.CloneGitRepo to git.Clone 2018-08-21 manojgupta@google.com chromeos_config: Add amd64-generic-ubsan-fuzzer builder. 2018-08-21 xixuan@chromium.org cbuildbot: Remove swarming_cli_cmd. Created with: gclient setdep -r src/third_party/chromite@4cc579e9d288 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If74dc6d8d17d1bf03dc0f371ae82bdad0adeeece Reviewed-on: https://chromium-review.googlesource.com/1184761Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585066}
-
Mitsuru Oshima authored
* left_center()/top_center()/right_center()/bottom center() return the center of each edge. * Transpose() swap x/y axis Bug: None Test: covered by unittests Change-Id: Icd63578dfe236caf6376c043fc1a0ffe74dfe6cc Reviewed-on: https://chromium-review.googlesource.com/1176861Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Mitsuru Oshima (OOO) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#585065}
-
Anna Offenwanger authored
Moving as many of the WebXR LayoutTests as possible over to be WebPlatformTests. All the tests that have been moved test some aspect of the spec (https://immersive-web.github.io/webxr/) in a platform agnostic way. Bug: 863557, 844772 Change-Id: I203b4c59be0daa0ca624fb0281fc33035f1be8a1 Reviewed-on: https://chromium-review.googlesource.com/1171857Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#585064}
-
Reilly Grant authored
This class has been updated to use network::SimpleURLLoader and so no longer needs to run on the IO thread in order to access a URLRequestContextGetter. It is now incorrect to run on the IO thread because as long as the device service is hosted in the browser process it is using a SharedURLLoaderFactory that can only be accessed from the UI thread. Bug: 875283 Change-Id: I68181566aeb50dc460a32acc6afc58a9054f46a6 Reviewed-on: https://chromium-review.googlesource.com/1183969Reviewed-by:
-
Tien-Ren Chen authored
This CL adds a few layout tests for canvas with overflowing object-fit. Blink is expected to scale the contents properly and clip the overflow to to the content box. Composited version of the test doesn't work currently, but will be fixed by BGPT. There is a video counterpart in media/video-object-fit.html, which also will be fixed by BGPT. Also did minor code cleanup and updated comment that most code path don't use transform nodes for object-fit. No behavior change is expected. BUG=400829,866647 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iaa9bf18fc23b7b2309e5f46dea145eaa33a8e0f6 Reviewed-on: https://chromium-review.googlesource.com/1179278Reviewed-by:
-
Dave Tapuska authored
Since we want to indicate the user gesture to postMessage to a dedicated worker it is cleaner to adjust the worker APIs to take a BlinkTransferableMessage. This change is intended to have no behavioral change. BUG=861735 Change-Id: I825d886877ae0931ce979c6b28930f754349dd9f Reviewed-on: https://chromium-review.googlesource.com/1183288 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585061}
-
Dominik Röttsches authored
Preparation for issue 874059 in which the DevToolsProtocolTest harness is needed for verifying font selection, after discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1174540 Address banned and deprecated function warnings in the process: Using a OnceClosure for closing the specific RunLoop to replace QuitCurrent() and remove usage of RunMessageLoop(), mark NotificationMatcher as RepeatingCallback. Bug: 874059 Change-Id: Id63a73e4ca7d2cb3bef888eac91bb3cc7cf8fb1a Reviewed-on: https://chromium-review.googlesource.com/1183239Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#585060}
-
Vadym Doroshenko authored
In order to save gaia password hash, Password Manager should detect success of form submission. For achieving this PasswordFormManager has to be created for such forms. This CL implements 1.Creating PasswordFormManager for such forms 2.PasswordFormManager doesn't fetch credentials for these forms which prevents filling. Bug: 876283 Change-Id: Icbe539d1f99777ca343d5168e41b637b3e74aa8f Reviewed-on: https://chromium-review.googlesource.com/1184919Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#585059}
-
Ryan Sleevi authored
The set of additional trust anchors (read: Enterprise-configured trust) presently is passed as a parameter to the CertVerifier::Verify() call, except it is logically part of the system configuration. As it does not vary between calls, move it to the CertVerifier::Config and update the PolicyCertVerifier to pass this as part of the config. Bug: 848277, 862043 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ibeb084cf05411a1055f0fcfc5e6e987a96eb03e9 Reviewed-on: https://chromium-review.googlesource.com/1167472 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#585058}
-
Matt Menke authored
This CL moves all of the logic over to the UI thread, to keep things relatively simple and minimize thread hops, since that's where core network service objects live. It also fixes a pre-existing bug in the PPAPI UDP code, where read errors that occur when there's no pending read are converted into 0-byte read successes. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id6d23c26c1ac085211dfcfe23502a307fc29a284 Reviewed-on: https://chromium-review.googlesource.com/1171568 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#585057}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4d95f1eb9beb..efbcb31cb67e git log 4d95f1eb9beb..efbcb31cb67e --date=short --no-merges --format='%ad %ae %s' 2018-08-22 qingsi@webrtc.org Revert "Remove the flag PORTALLOCATOR_ENABLE_ANY_ADDRESS_PORTS." 2018-08-22 buildbot@webrtc.org Roll chromium_revision 3e0dea7b..ab3ab1ba (584728:584945) 2018-08-22 qingsi@google.com Revert "Use also the related address in redundancy detection for candidates from" 2018-08-22 qingsi@webrtc.org Revert "Update packetsLost and jitter stats any time a packet is received." 2018-08-21 koloskova@webrtc.org Adds utility function for PCC. 2018-08-21 koloskova@webrtc.org Adds monitor interval class for PCC. 2018-08-21 aluo@chromium.org Reland "Default runner to junit4" 2018-08-21 andersc@webrtc.org Add missing ifdefs to header files for SW video codecs. 2018-08-21 ilnik@webrtc.org Revert "Move FakeCodec to separate target and behave like real encoder." 2018-08-21 koloskova@webrtc.org Adds Rtt tracker for PCC. 2018-08-21 devicentepena@webrtc.org AEC3: adding a config option for applying a more conservative initial phase. Created with: gclient setdep -r src/third_party/webrtc@efbcb31cb67e The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:868610,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7fa8327a149cb62e4f71ab5e23bd64d8b6192d6b Reviewed-on: https://chromium-review.googlesource.com/1184764Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585056}
-
Maciej Pawlowski authored
When a tracked pref is cleared, it will no longer be present in the DictionaryValue that represents the pref store contents, but FilterUpdate() and FilterSerializeData() will still be called. Make the code handle nullptr Values safely. Bug: 867337 Change-Id: I1840c3f60bd815145a0f765adf5907a35bca1c87 Reviewed-on: https://chromium-review.googlesource.com/1150034Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#585055}
-
Lei Zhang authored
- Reduce number of parameters to DoComposite{Document,Page}ToPdf(). - Move ConvertContentInfoMap() into an anonymous namespace and remove unused parameter. - Change GenerateFrameGuid() so callers only pass a single parameter. Change-Id: I22d94f988ba64ba72a1fa9bea7190cf2b812b336 Reviewed-on: https://chromium-review.googlesource.com/1183022 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#585054}
-
Boris Sazonov authored
This CL changes ChromeUnifiedConsentClient to use kMetricsReportingEnabled pref to check whether UMA reporting is enabled, as IsMetricsAndCrashReportingEnabled always returns false on non-official builds, forcing unified consent to be off. Bug: 814728 Change-Id: Ie39ca8d23cdc1fbb757a5ec74c719092c758a1d6 Reviewed-on: https://chromium-review.googlesource.com/1183679Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#585053}
-
Clark DuVall authored
We need to notify download progress even if report_raw_headers is not set. Bug: 875298 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1074a50ca60cdbbb00cd265d83487abe55160732 Reviewed-on: https://chromium-review.googlesource.com/1184038Reviewed-by:
-
Joel Einbinder authored
This roll contains fixes for TypeScript syntax highlighting Change-Id: Ibe60b3378fca642c259e95686f3659b765d0edf9 Reviewed-on: https://chromium-review.googlesource.com/1182680Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#585051}
-
