- 15 Jan, 2021 40 commits
-
-
Tsuyoshi Horo authored
This CL introduces "scopes" attribute in <link> element for SubresourceWebBundles feature. https://github.com/WICG/webpackage/blob/master/explainers/subresource-loading.md#defining-the-scopes For example, if the following link tag exists in the page, <link rel="webbundle" href="https://example.com/dir/subresources.wbn" scopes="https://example.com/dir/js/ https://example.com/dir/img/ https://example.com/dir/css/"> subresources under "/dir/js/", "/dir/img/" and "/dir/css/" will be loaded from the web bundle "subresources.wbn". Bug: 1082020 Change-Id: I36ab832c301f33b0d0f1b6f4fea7e871f7ce2b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615732Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#843995}
-
danakj authored
Step 6 for bug 1125106. This is a subset of the mega-patch in https://chromium-review.googlesource.com/c/chromium/src/+/2462248. A same-document navigation should only be performed when the commit will happen in the currently loaded document. The renderer handled the browser doing the wrong thing in all kinds of ways, due to the browser making incorrect decisions when: - On an empty error page - Having an ongoing cross-document navigation which hasn't committed yet Now the browser does the right thing, so the renderer does not need to handle the fallback - except in one case which is a frameset. In that case the browser doesn't know the document is frameset, and the renderer currently enforces a policy that same-document navigations in a frameset document cause it to be reloaded. This is done for both renderer-initiated navigations (by sending the navigation to the browser process instead of performing the navigation immediately) and then by bouncing any same-document requests from the browser back as RestartCrossDocument. R=nasko@chromium.org Bug: 1125106 Change-Id: I74ca38a2213215a107c955127f1f664b96b58aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558926 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#843994}
-
Omar Morsi authored
Before this CL, platform keys API tests were disabled because they were flaky. The main reason behind that was mixing chrome.test.callbackPass() and chrome.test.succeed() in more than one test. This introduces unpredictable behavior as if the callback counter is incremented anywhere in a test function, the test infrastructure will automatically invoke chrome.test.succeed(). For more information about this problem, please refer to https://chromium.googlesource.com/chromium/src.git/+/master/extensions/docs/testing_api.md#don_t-mix-chrome_test_callbackpass_et-al_and-chrome_test_succeed This CL fixes mixing chrome.test.callbackPass() and chrome.test.succeed() by adapting only one of them in each test. This is a quick fix so as to include platform keys API tests again in trybots, but a refactor to totally avoid using callbackPass is being tracked in crbug.com/1154680. The flakiness is verified to be fixed by running the suite 20 consecutive successful times using the following command. browser_tests --gtest_filter=*EnterprisePlatform* --gtest_repeat=20 Bug: 1157137 Change-Id: If7a94d4cc37e5b0719d18fdd3a9cef425de17ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624473Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#843993}
-
Canon Mukai authored
Replace value.View() with value.Get() since View() is deprecated. Get() does the same thing as View(), so I just rewrote 'View' to 'Get'. Change-Id: I1e77b1eb8854722af6501841f825082b60c5b2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631870Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#843992}
-
Takuto Ikuta authored
This reverts commit 18f22206. Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159 Original change's description: > trigger_scripts: do not use use_swarming_go > > This is specified by default after https://crrev.com/c/2626865 > > Bug: 1127205 > Change-Id: I6d1b64ab6c68283196cc5614bfd26a2e03b025be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627651 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843977} TBR=kbr@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com Change-Id: If016b45324dfcf43c70a35ebcf8d203af8a192c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632546Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#843991}
-
Anatoliy Potapchuk authored
This reverts commit 669044bf. Reason for revert: ExternalConstantsOverriderTest.* tests were failing on many mac builders after adding them. example: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/33860 Original change's description: > Implement an ExternalConstants provider that reads from a base::Value. > > This is going to get populated with a JSONFileDeserializer. > > Bug: 1154901 > Change-Id: I5285b3b24a4d574c311addd44e34572b9e863c8b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598004 > Commit-Queue: Adam Norberg <norberg@google.com> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843868} TBR=sorin@chromium.org,waffles@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,milagreen@chromium.org,norberg@google.com Change-Id: Ieefffd98bc15542b8758a70c5590cdf90d3acc34 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1154901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632665Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#843990}
-
Christopher Cameron authored
This adds a zero-copy desktop capture mechanism to macOS. The frames are captured as NV12 IOSurfaces, packaged in IOSurfaces, and passed directly to the consumers (e.g, compositor, encoders, etc). This implementation is a trimmed-down version of the existing system, which can be found in the DesktopCaptureDevice class and the WebRTC class ScreenCapturerMac. The CGDisplayStream code is identical to the WebRTC code except for the following changes: - It requests NV12 as the capture format - It specifies the requested capture resolution (rather than capturing at retina resolution and downsampling in software) - It specifies kCGDisplayStreamMinimumFrameTime and kCGDisplayStreamColorSpace. Otherwise, all calls are identical. Bug: 1164736 Change-Id: I962911aa9b1863d730c333866f5644bbbd2b7164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616802 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#843989}
-
Keishi Hattori authored
Add use_backup_ref_ptr gn args flag which enables the ref count in PA and switches the CheckedPtr implementation to BackupRefPtr. Also turns off backup ref ptr support for NaCl as it is compiled as 32bit but address_pool_manager is not available, causing a link errors. https://source.chromium.org/chromium/chromium/src/+/master:base/BUILD.gn;l=1772 Bug: 1073933 Change-Id: I1e0ea1b1181623fa5783d39c6d9a379c1df2daf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626681Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843988}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610668478-7094d9e47d32a574227817d5f93a8aaa3dc9b368.profdata to chrome-mac-master-1610690109-720706a87994e4668591f57ede90f04b6ed715af.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic517e97e34cc6a69fb63ae812dba3a411359e7c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632169Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843987}
-
Anatoliy Potapchuk authored
This reverts commit b7af27f9. Reason for revert: seem to cause infra failures Original change's description: > Roll goldctl (mac) from Cb3ZdanPJ... to Asi8KSWBq... > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll > Please CC bsheedy@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: bsheedy@chromium.org > Change-Id: I5dd6f36473a83bc37b9f49e4c32558313fce09bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631472 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#843947} TBR=bsheedy@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: If840302f0f1ae3d7ccceca403277f47cba14ccf0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632605Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610668478-7263610d5b531e252a86c5f5dc54aba9a5ada050.profdata to chrome-win32-master-1610679078-fe2bb289a257049a216843cebd228815ff771bd5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib7250492bf0cae079f40cc185ce3f94b29799adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632166Reviewed-by:
-
Michael Bai authored
The experiment hasn't finished yet Bug: 1125778 Change-Id: I1e5e036cc8e41b77e8c3d79374e91301ac5c499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625531 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843984}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/50c82f42e33f..29eeb610bd49 2021-01-15 syoussefi@chromium.org Vulkan: Fix validation of MSRTT framebuffer attachment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1146753 Tbr: timvp@google.com Change-Id: I73585b490c63307dad6f5e06070ac651e4c23302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632167Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610668478-7d09cc584bcf96e72cb1514828da986e69ab213c.profdata to chrome-linux-master-1610690109-4d1151c59ad39afee419f9fccf0374e5470965d9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7700aa08f10f86d305895f54999737873589804f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631790Reviewed-by:
-
Alexey Baskakov authored
WebAppsChromeOs::GetMenuModel() appends the menu items using manifest resources already stored on disk (that part is already launched on all OSes) We override previously introduced WebAppsChromeOs::ExecuteContextMenuCommand() to launch the web app with url params appended. We implement ConvertSquareBitmapsToImageSkia helper function which converts manifest icons to hi-dpi in-memory representation needed by our AppService UI code. Bug: 1129721 Change-Id: Ic6aa0777f74db079c91d0f50f173f334d4be862e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462899 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843981}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610668478-796ed01e77791225afcd16f130ade4fe33aa8256.profdata to chrome-win64-master-1610679078-e6bf7486827a51823717a01d08f3ea1e32a813ef.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ieb438fbee42fbaacc0660857ebde6ae16ecc66c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632365Reviewed-by:
-
Devlin Cronin authored
Update the various features.json files (_[api|manifest|permission|behavior]_features.json) to use allowlist and blocklist terminology. Bug: 842387 Change-Id: I3e165efd2415b21275df06f5f67a944330474ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606784 Auto-Submit: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#843979}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - column_visibility_controller.js - dialog_action_controller.js - search_controller.js Bug: 1133186 Change-Id: I1aaecd54946f4c5fd8d33eba74951765f23cf000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632111 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#843978}
-
Takuto Ikuta authored
This is specified by default after https://crrev.com/c/2626865 Bug: 1127205 Change-Id: I6d1b64ab6c68283196cc5614bfd26a2e03b025be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627651 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#843977}
-
Glen Robertson authored
TestingProfile::IsNewProfile now defaults to false instead of defaulting to the impl's behaviour when not overridden. profile.cc's inclusion of first_run.h was its last dependency on //c/b/... except for constants that have separate GN targets, and profile_observer. Removing the dependency allows profile.{cc,h} and profile_observer.h to be moved from //c/b:browser to a separate GN target (will be done in subsequent CL). This will let us break dependency cycles and improve modularization of the codebase. Bug: 1149277 Change-Id: If4d4c30ca49df8da518f6b2c014f61d2e4d2c425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626814 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:Greg Thompson <grt@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#843976}
-
Daniel Cheng authored
This is a reland of bca5f7be The original CL passed the CQ, but https://crrev.com/843803 added a new usage in between the time the CQ run started and the CQ run seemingly succeeded. Original change's description: > Declare T as a base class of the BrowserAssociatedInterface<T> helper. > > When a class uses BrowserAssociatedInterface<T>, it should implement the > mojo interface T. Force that to be the case by making T a suclass of > BrowserAssociatedInterface<T>. > > Change-Id: Ide8ecd46c298ec86de57b229593ec7d6c4b6a3a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629670 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843845} Change-Id: I16fd909b587aa06402484d25184f2155974cc8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631985Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
Bug: 1155308 Change-Id: Ida2d8011c7a7d1ac14aff806d084e524e46d2bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628930Reviewed-by:
-
Matt Menard authored
Fixes missing trailing 's' from WebUI message. Ensures print server printers are always loaded after new print server is selected. Fixes opposite flag for print server selector. Bug: b:168650771 Change-Id: Ie2c7020d2f8752ab9bf00520a2b4ec3b6cddb776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622352Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Matt Menard <mattme@google.com> Cr-Commit-Position: refs/heads/master@{#843973}
-
Luciano Pacheco authored
Add JS modules for //ui/file_manager/file_manger/foreground/js/ : - element_importer.js - deferred_elements.m.js This replaces the elements_bundle.html. Bug: 1133186 Change-Id: I372fbb5afe8bdd22483d0fcccda3b2dd240f447a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631812 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#843972}
-
rajendrant authored
This reverts commit c08b4303. Reason for revert: Revert due to test failures Original change's description: > Fix flaky test > > Fix the path used in test server. > > Bug: 1166280 > Change-Id: I34fc06dc911c69d00f8dc4d193052d088f99816a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626022 > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843864} TBR=rajendrant@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ibfee8d1710479ea363bf41ea4cf02e8df400d964 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1166280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631913Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#843971}
-
wutao authored
Currently ambient mode will exit on key press. However, the key event is not consumed and will enter into the login pod. To be consistent with other platforms, the key press is consumed in ambient mode by making the ambient controller a pretarget event handler and stopping propagation of the key event. Bug: b/173642446 Test: new unittests Change-Id: Iad04b07a0e6124773326c1d52d4a48a919ab87fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626911 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843970}
-
Asami Doi authored
This CL adds external/wpt/html/cross-origin-embedder-policy/ tests to the PlzDedicatedWorker virtual test configuration and the "Tests" section in core/workers/README.md. Bug: 1060837 Change-Id: I2f2e654710ecba794e4c4e3c4e03138db23fd1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628271 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#843969}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610657917-c5f7c43f5defa75543fc37f687b27a8203dbe683.profdata to chrome-win32-master-1610668478-7263610d5b531e252a86c5f5dc54aba9a5ada050.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2c55b38e44305cc8f902596fef97e0ccc156594d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631471Reviewed-by:
-
Luciano Pacheco authored
Add JS module for //ui/file_manager/file_manager/foreground/js/ : Files app: Add JS module for quick_view_uma.js Files app: Add JS module for quick_view_controller.js Files app: Add JS module for scan_controller.js Bug: 1133186 Change-Id: I7a47a9fb7c5cb0a11ebeb123f86a12a312b23239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631654Reviewed-by:
-
Eugene Zemtsov authored
Currently VideoEncoder will readback frames as RGB even if they have mappable NV12 GPU buffers. There is no need to do it underlying encoders can map GPU buffers just fine. Test: https://wcwc.glitch.me/ Bug: 1166962 Change-Id: Ie72c65c4df114264a70b9da337af27a934a8b74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631407Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#843966}
-
Luciano Pacheco authored
Add JS module for //ui/file_manager/file_manager/foreground/js/ : - main_window_component.js - app_state_controller.js Bug: 1133186 Change-Id: Ifba0bd6bef3b4540bb76d316e3b0350315deeff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631869 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Greg Thompson authored
Chromium, Chrome Cleanup Tool, and Software Reporter Tool. R=nparker@chromium.org, oshima@chromium.org Bug: 764528,764538 Change-Id: I082ff80423baa2ab5e6d08c0dc80a8f2f21985f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611710Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#843964}
-
Etienne Bergeron authored
Based on the doc of the GetTimeZoneInformation(...) API https://docs.microsoft.com/en-us/windows/win32/api/timezoneapi/nf-timezoneapi-gettimezoneinformation Returned value needs to be compare to the value TIME_ZONE_ID_INVALID (-1). Follow up on a bug introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/2583012 R=gab@chromium.org Bug: 1074036 Change-Id: I7d227cd7a85b0b50eaea6be364012dee3d9357b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631925Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#843963}
-
Michael Thiessen authored
Implements LaunchCause.MAIN_LAUNCHER_ICON_SHORTCUT, for the shortcuts accessed by long-pressing the Main Launcher Icon (currently just to open new regular/incognito windows). Bug: 1163961 Change-Id: Id7f1c7e177fce5f0d2a9472f6e7d79b35b7e4474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626424 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#843962}
-
Justin Cohen authored
CrashKeyString wraps AddReportParameter/RemoveReportParameter when using breakpad. Bug: 1061431 Change-Id: Ia651045b8efe2ae79b769a099d49d5d85e00688b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574024Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#843961}
-
Sophie Chang authored
Bug: 1166906 Change-Id: I29b4ffd8e91923e0e86dc4b7fa6a0f54f0e4f63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631745Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843960}
-
Sophie Chang authored
These regexps will explicitly be not matched against an opt filter Bug: 1158883 Change-Id: I25b0659bcfbe5580598a08719bd673f8fed46f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631447Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Yuta Hijikata authored
This is a mechanical change replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and adding BUILDFLAG(IS_CHROMEOS_LACROS) to defined(OS_LINUX) to ensure switching lacros' target_os from linux to chromeos does not affect the lacros binary. It also renames chromeos_is_browser_only with is_chromeos_lacros which was a gn var introduced to be used in place of chromeos_is_browser_only. More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: I7e3e5685549c2b8c655a788a9fe827805988b11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628711 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#843958}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610657917-28dde97bcaff353b91ba180b51342313b1d23453.profdata to chrome-win64-master-1610668478-796ed01e77791225afcd16f130ade4fe33aa8256.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib80ff78c71af78d52a73cc6bf30cedc3e6ce4407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631218Reviewed-by:
-
Hirokazu Honda authored
This reverts commit 1980f0cb. Reason for revert: Kernel uprev for SKL is not complete in M89. Original change's description: > Revert "media/gpu/test/VFValidator: Workaround the buffer synchronization problem on intel 3.18" > > This reverts commit 276dd2ba. > > Reason for revert: The root cause of the synchronization is fixed. > Removes this workaround. > > Original change's description: > > media/gpu/test/VFValidator: Workaround the buffer synchronization problem on intel 3.18 > > > > There is a synchronization problem on the mapped buffer on intel > > skylake devices. This is due to some missing 9165 patches in kernel > > 3.18, and thus will be fixed if the kernel is upreved to 4.4 or > > newer. This bug causes a decoded content validation failure in > > video_decode_accelerator_tests. > > This is a workaround to this bug; usleep() is added after the > > buffer is mapped and before the frame validation if the kernel > > version is 3.18 and the processor is Skylake. > > > > Bug: b:149808895 > > Test: video_decode_accelerator_tests on sentry > > Change-Id: Ib77ebe0b83834e4d91bc994cbe6912348862e021 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371724 > > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > > Reviewed-by: Miguel Casas <mcasas@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801614} > > TBR=mcasas@chromium.org,hiroh@chromium.org,andrescj@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: b:149808895 > Change-Id: Id0f1bdcc486effef2c6d3fd64275d71051020028 > Test: None > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631645 > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843919} TBR=mcasas@chromium.org,hiroh@chromium.org,andrescj@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: b:149808895 Change-Id: I1f592a49c0276154101c59044c63c652c173e6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631808Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843956}
-
