GitLab

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org

Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
Review-Url: https://codereview.chromium.org/2058033002
Cr-Original-Commit-Position: refs/heads/master@{#406067}
Cr-Commit-Position: refs/heads/master@{#407106}

-webkit-appearance:menulist, which is the default appearance of menulist SELECT,
uses fixed font sizes, auto height, and the fixed font family.  Ignoring such
style was not good for platform-predictability.

After this CL, -webkit-appearance:menulist automatically fallbacks to
-webkit-appearnce:menulist-button by font-size, height, font-family CSS
properties.

This CL also changes the default rendering of <input type=color list> because it
uses -webkit-appearance:menulist with a fixed height. The new rendering is
better because its height is same as the default rendering of <input
type=color>.

BUG=104922

Review-Url: https://codereview.chromium.org/2171133003
Cr-Commit-Position: refs/heads/master@{#407105}

This DCHECK just rephrases the result of the previous line.

BUG=630141

Review-Url: https://codereview.chromium.org/2174693002
Cr-Commit-Position: refs/heads/master@{#407104}

.detail-checkmark creates a new containing block by position:absolute so that it is always clickable, but the thumbnail icons should not do that.

BUG=630236

Review-Url: https://codereview.chromium.org/2166353002
Cr-Commit-Position: refs/heads/master@{#407103}

Allow to specify dependencies that are only used by the create_bundle
target when using ios_app_bundle or ios_framework_bundle templates to
increase parallelism.

BUG=629867

Review-Url: https://codereview.chromium.org/2169973002
Cr-Commit-Position: refs/heads/master@{#407102}

When a Custom Tabs client dies, the Android framework sends a
notification to an IBinder.DeathRecipient. This is relayed by
CustomTabsSessionToken to CustomTabsConnection#cleanUpSession(). If this
method is called from a different thread than the UI thread, then this
triggers a native crash.
Avoid that crash by making sure that mClientManger#cleanupSession() (and
then CustomTabsConnection#cancelPrerender()) is called from the UI thread.

Also add a non-regression test.

BUG=623128

Review-Url: https://codereview.chromium.org/2158843003
Cr-Commit-Position: refs/heads/master@{#407101}

global functions.

Make Node::isContentEditable and Node::isRichEditable
global functions.
This CL also re-introduce HTMLElement::isContentEditable because
 it is a web-exposed IDL attribute.

This is a preparation to move these functions from core/dom to core/editing/

TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2121313003
Cr-Commit-Position: refs/heads/master@{#407100}

This patch converts "editing/deleting/delete-ws-fixup-00[1234].html" to use w3c
test harness and consolidates into "delete_ws_fixup.html" to simplify test
files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2174683002
Cr-Commit-Position: refs/heads/master@{#407099}

This patch converts "editing/deleting/delete-trailing-ws-00[12].html" to use w3c
test harness and consolidates into "delete_trailing_ws.html" to simplify test
files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2174673002
Cr-Commit-Position: refs/heads/master@{#407098}

This patch converts "editing/deleting/delete-to-select-table.html" to use w3c
test harness and consolidates into "delete_tab.html" to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2169323002
Cr-Commit-Position: refs/heads/master@{#407097}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5bc62d66..482fb9de

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2169353002
Cr-Commit-Position: refs/heads/master@{#407096}

Keep the name of the target generating the executable in ios_app_bundle
template the same whether the final binary is a fat or thin binary.

BUG=629867

Review-Url: https://codereview.chromium.org/2167933003
Cr-Commit-Position: refs/heads/master@{#407095}

BUG=629459

Review-Url: https://codereview.chromium.org/2166823004
Cr-Commit-Position: refs/heads/master@{#407094}

The XCTest support (used for EarlGrey tests) requires linking against
XCTest.framework whose location is relative to sdk-platform-path, so
propagate via ios_sdk_platform_path variable in gn.

BUG=629867

Review-Url: https://codereview.chromium.org/2168873003
Cr-Commit-Position: refs/heads/master@{#407093}

Clarify function call parameter.
BUG=none
R=esprehn@chromium.org

Review-Url: https://codereview.chromium.org/2145613002
Cr-Commit-Position: refs/heads/master@{#407092}

Here is a DOM state when we only add a blockquote.
<div contenteditable><blockquote>|<br></blockquote></div>

After indenting the blockquote, the change is as follows:
<div contenteditable>
  <blockquote>
    <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
      <blockquote>|<br></blockquote>
    </blockquote>
  </blockquote>
</div>

There is an unnecessary blockquote so the result should be as follows:

<div contenteditable>
  <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
    <blockquote>|<br></blockquote>
  </blockquote>
</div>

This CL removes the additional blockquote.

BUG=625802
TEST=editing/execCommand/indent-empty-quote.html

Review-Url: https://codereview.chromium.org/2175433002
Cr-Commit-Position: refs/heads/master@{#407091}

Cr-Commit-Position: refs/heads/master@{#407090}

Revert of Reland "Implement FullScreen using top layer." (patchset #13 id:260001 of https://codereview.chromium.org/2107233002/ )

Reason for revert:
Multiple regressions around the fullscreen transition becoming visibly
worse, as well as a suspected leak.

BUG=628554,628605,628662,630191

Original issue's description:
> Reland "Implement FullScreen using top layer."
>
> This reverts commit 2460a952.
>
> Notable changes on top of previous attempt:
>
> full-screen-iframe-ua-style.html is changed to use overflow property
> instead, as position is no longer changed on ancestors.
>
> :root:-webkit-full-screen-ancestor { overflow: hidden !important; } is
> retained, as the previous attempt regressed on Vimeo (crbug.com/543946)
> and it's not clear yet how to handle this in the spec:
> https://github.com/whatwg/fullscreen/issues/19
>
> Make ::backdrop work for replaced content (video, iframe, etc.) by
> changing StyleResolver::createPseudoElementIfNeeded to allow creating
> the ::backdrop pseudo-element even if the parent doesn't support
> children. With this change, full-screen-stacking-context.html was
> simplified and full-screen-video-has-backdrop.html was
> simplified+renamed.
>
> The will-change override is dropped, as full-screen-will-change.html
> passes without it.
>
> BUG=240576, 543946
>
> Committed: https://crrev.com/d666f503ae854fac360cc70da1f5971a6724546a
> Cr-Commit-Position: refs/heads/master@{#405478}

TBR=dsinclair@chromium.org,esprehn@chromium.org,eae@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=240576, 543946

Review-Url: https://codereview.chromium.org/2168373002
Cr-Commit-Position: refs/heads/master@{#407089}

The plot thickens:

This checkin introduces all the classes, and the links
between them. The links are important for object
lifetime management. Lifetime architecture is described
at
https://docs.google.com/document/d/1G4OmqqlFY3H3erQAUmteKES02-bIECikDjWBrDKH9PA/edit?usp=sharing

BUG=612962

ResizeObserver: conecting Objects
Review-Url: https://codereview.chromium.org/2161313002
Cr-Commit-Position: refs/heads/master@{#407088}

This patch converts "editing/deleting/delete-block-content-00[123].html" to use
w3c test harness to simplify test files by consolidating them into
"delete-block-content.html".

Note: "delete-block-content-003.html" is identical to
"delete-block-content-002.html" expect for 003.html has two DIV[id=root].

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2170273002
Cr-Commit-Position: refs/heads/master@{#407087}

This patch converts "editing/deleting/delete-contiguous-ws-001.html" to use w3c
test harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2169263003
Cr-Commit-Position: refs/heads/master@{#407086}

This patch converts "editing/deleting/delete-tab-[1234].html" to use w3c
test harness and consolidates into "delete_tab.html" to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2172943002
Cr-Commit-Position: refs/heads/master@{#407085}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/71da59b9..5bc62d66

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2176443003
Cr-Commit-Position: refs/heads/master@{#407084}

BUG=

Review-Url: https://codereview.chromium.org/2137863002
Cr-Commit-Position: refs/heads/master@{#407083}

Specification:
https://www.w3.org/TR/payment-request/#updatewith

BUG=629462

Review-Url: https://codereview.chromium.org/2170783002
Cr-Commit-Position: refs/heads/master@{#407082}

This patch converts "editing/deleting/delete-and-undo.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2164243002
Cr-Commit-Position: refs/heads/master@{#407081}

This patch converts "editing/deleting/delete-3928305-fix.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2170753003
Cr-Commit-Position: refs/heads/master@{#407080}

BUG=624038,497094

Review-Url: https://codereview.chromium.org/2169213002
Cr-Commit-Position: refs/heads/master@{#407079}

Before, only 4 were shown, even though there was space for more.
It could confuse users, that there are no other apps matching the
criteria.

This CL increases this limit to 8, which fill the available space.

TEST=Tested manually on Samus.
BUG=629411

Review-Url: https://codereview.chromium.org/2165483002
Cr-Commit-Position: refs/heads/master@{#407078}

Per the spec[1] we can treat an object as a callback interface
if an effective overload set contains the callback interface.

[1] http://heycam.github.io/webidl/#es-overloads

BUG=629068

Review-Url: https://codereview.chromium.org/2175463002
Cr-Commit-Position: refs/heads/master@{#407077}

The Cotnrol-Click functionality navigates users from Styles Sidebar Pane
into the Source code.

This patch moves this functionality into the
StylePropertiesSection from StylesSidebarPane, which
simplifies it a lot.

BUG=none
R=pfeldman

Review-Url: https://codereview.chromium.org/2153263002
Cr-Commit-Position: refs/heads/master@{#407076}

BUG=624590

Review-Url: https://codereview.chromium.org/2166093002
Cr-Commit-Position: refs/heads/master@{#407075}

Currently ThreadableLoader's destructor implicitly cancels loading.
This CL requires a user to cancel the loader explicitly before
destructing a ThreadableLoader, as a preparation for moving it to
Oilpan heap.

BUG=587663

Review-Url: https://codereview.chromium.org/2146403004
Cr-Commit-Position: refs/heads/master@{#407074}

|EditAction| is used to describe editing operations in
Blink internal only, however with the introduction of
|InputEvent| we got a new type |InputType| which does the
same thing and SPECed.

Since having both is redundant, this CL removes
|EditAction| and finalized the list of possible
|InputType|.

This CL shouldn't have too much web-exposed effect (except
some trivial command mapping).

BUG=627740
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ

Review-Url: https://codereview.chromium.org/2151353002
Cr-Commit-Position: refs/heads/master@{#407073}

The 32-bit metric is recorded as a sparse histogram. Each
sample contains information on transport RTT, HTTP RTT,
bandwidth, and time taken to download the resource. Each
metric occupies 7 bits with first 4 bits left unset.

BUG=624597

Review-Url: https://codereview.chromium.org/2107243003
Cr-Commit-Position: refs/heads/master@{#407072}

BUG=630056

Review-Url: https://codereview.chromium.org/2165023004
Cr-Commit-Position: refs/heads/master@{#407071}

Now the feature is moved to wayland, we can remove it.

BUG=b/29728385
TEST=Build and run ARC, with client side WindowManagerInstance removal.

Review-Url: https://codereview.chromium.org/2168533002
Cr-Commit-Position: refs/heads/master@{#407070}

We already have similar mechanism in cc. Blink-side DebugRedFill also
brings complexities about display item list and paint property tree.

Review-Url: https://codereview.chromium.org/2163113002
Cr-Commit-Position: refs/heads/master@{#407069}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cc88d565..71da59b9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2175573002
Cr-Commit-Position: refs/heads/master@{#407068}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ab911d94c16a..20358d6bf8c9

$ git log ab911d94c..20358d6bf --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2170183003
Cr-Commit-Position: refs/heads/master@{#407067}