- 17 Apr, 2018 40 commits
-
-
Lei Zhang authored
Also remove checks for |ServiceWorkerContextCore::observer_list_| being NULL. That cannot happen. BUG=558179 Change-Id: I33685dd6d113aab2e6d2fbe85c62365131fc07d3 Reviewed-on: https://chromium-review.googlesource.com/1014659Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#551243}
-
Erik Chen authored
This CL is a refactor with no intended behavior change outside of tests. Test behavior change: * TestDriver::CheckOrStartProfiling now waits for the allocator shim to be initialized even if profiling was enabled for the current process via command line flags. This is because initialization is asynchronous. * TestDriver::ValidateRendererAllocations no longer makes any checks if the renderer is not being profiled, since on Android WebView there may not even be a renderer process in this case. Refactor: * Moves the C++ side of the android test shim into components/heap_profiling, so that the logic can be shared with Android Webview. * Renames the test shim from TestAndroidShim to HeapProfilingTestShim. * Removes redundant checks in TestDriver::ValidateRendererAllocations. Change-Id: I4755f6169b0f9c556a86005916aa9150dec6853b BUG: 827545 Reviewed-on: https://chromium-review.googlesource.com/1012542Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551242}
-
Kent Tamura authored
Move check-webkit-style and lint-webkitpy from //third_party/WebKit/Tools/Scripts to //third_party/blink/tools. This CL also adds add_webkitpy.py to blinkpy/common. Bug: 829697 Change-Id: I592d0b2c5076bc89ee30fa6a7afbb15e8cb77319 Reviewed-on: https://chromium-review.googlesource.com/1013820 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#551241}
-
Xiaocheng Hu authored
The above mentioned function is symmetric when adjusting left and right edge of an inline box. This patch enforces the symmetry by unifying the algorithms with a template. It is also preparation for crrev.com/c/997134. Bug: 822575 Change-Id: Iacb6a77c3e43c598d2405d7f859e5f619e138a0b Reviewed-on: https://chromium-review.googlesource.com/1013059 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#551240}
-
Nico Weber authored
The clang tot bots moved off chromium.fyi to chromium.clang a while ago, and the testers were removed altogether since all the tests now run on swarming and can hence be triggered by the builder. Bug: none Change-Id: Ie6951241a375d397d98768811483a522ac589ad7 Reviewed-on: https://chromium-review.googlesource.com/1013611 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#551239}
-
Jinho Bang authored
Related spec change: https://github.com/w3c/payment-handler/pull/294 Bug: 833530 Change-Id: I65d0e01bb5b6bfdd44925b90ba98837161cc136b Reviewed-on: https://chromium-review.googlesource.com/1013664Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#551238}
-
Christian Biesinger authored
See the comments in the patch for why this is necessary. R=eae@chromium.org, ikilpatrick@chromium.org Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0a4042c0782c98fab1bfd27cb3bf6ca29c820542 Reviewed-on: https://chromium-review.googlesource.com/1013306Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#551237}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6d63741e. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15673 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/service-workers/cache-storage TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I47a23cc232874b9640034a4fce27ffbfc196b8bf Reviewed-on: https://chromium-review.googlesource.com/1014377 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551236}
-
Jamie Madill authored
This reverts commit 5f77b73e. Reason for revert: Roll has landed, reinstating tests. Original change's description: > Temporarily disable angle_vulkan_deqp_tests. > > Unblocks the Vulkan roll. > > Bug: angleproject:2482 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I9577f331977e9add28bb7875e70260d428ad0cd5 > Tbr: kbr@chromium.org > No-try: True > Reviewed-on: https://chromium-review.googlesource.com/1014322 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551102} TBR=jmadill@chromium.org,kbr@chromium.org Change-Id: Iab80706a6e74c442533d4df60c753e7dc270c380 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:2482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1014726Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#551235}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I043e19c9bfd8e620851878c96c962cf7c6124293 Reviewed-on: https://chromium-review.googlesource.com/1014725Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#551234}
-
Joel Hockey authored
Turn off FileManagerUITests from CQ until current audit of tests by noel@ is complete. Bug: 819478 Change-Id: I14dca567de4fb7919d94b1d89a0cb2dada5b8d67 Reviewed-on: https://chromium-review.googlesource.com/1013668Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#551233}
-
https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..08b9e046c1b6 $ git log aa8b3982a..08b9e046c --date=short --no-merges --format='%ad %ae %s' 2018-04-16 jmadill Vulkan: Disable warning in Mock ICD. 2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18 Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org No-Try: True Change-Id: I34309b2c8fc6f4d49ba465929378687aaaa181a1 Reviewed-on: https://chromium-review.googlesource.com/1014671 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551232}
-
Ken Rockot authored
Impending changes to Mojo IPC will require that handles serialized as shared memory handles are actually shared memory handles. DXGI resources are not, but are being transported using GpuMemoryBufferHandle's shared_memory field. This introduces a Windows-only GpuMemoryBufferHandle field for a generic HANDLE to be used for DXGI resources, as well as a corresponding mojom field for the same purpose. There should be no net effect on the behavior of the system wrt handle lifetime or usage. Bug: 826213 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5d510e0ebdb60d4872fc428a95ce681dd18369dc Reviewed-on: https://chromium-review.googlesource.com/1011600Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#551231}
-
Stephen Martinis authored
Forces layout tests to run in a debug mode. Bug: 818832 Change-Id: I860e41169ea759e32806ba4ab45ca4e0d72ba4cd Reviewed-on: https://chromium-review.googlesource.com/1014634Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#551230}
-
Christian Biesinger authored
To help with debugging R=xiaochengh@chromium.org,ikilpatrick@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie56254eef3aaa3d21e0f74d2323211197ecd127a Reviewed-on: https://chromium-review.googlesource.com/1013616Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#551229}
-
Noel Gordon authored
In a FileManagerBrowserTest...SetUpInProcessBrowserTestFixture happens after SetUpCommandLine and before SetUpOnMainThread. Move it there, so its code location in this file is in call-order. Bug: 831074 Change-Id: I999a057c3163ebe13146a54c44d8ba3deb7e0d8c Reviewed-on: https://chromium-review.googlesource.com/1013783Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551228}
-
Sergey Ulanov authored
headless_example fails to compile on fuchsia with https://chromium-review.googlesource.com/c/chromium/src/+/985648/15 . The problem is that headless_shell_lib implicitly depended on //base but that dependency wasn't in the gn file. Added //base to public_deps for headless_shell_lib to fix this problem. Bug: 831384 Change-Id: Ib4664a33a3c649063434911e0a4ee074233c3319 Reviewed-on: https://chromium-review.googlesource.com/1011631Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#551227}
-
Andrey Kosyakov authored
- let consumers create streams directly with DevTooolsStreamFoo::Create() rather than through different methods of DevToolsIOContext; - get rid of Close() methods, do all cleanup in destructors; - eliminate RWStream, let its consumer use DevToolsStreamFile directly; Bug: 831887 Change-Id: I1aa28f8dea4a4e00c0323cb4101dc8db274a9bd4 Reviewed-on: https://chromium-review.googlesource.com/1014303 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551226}
-
Igor Kobylin authored
R=dschuyler@chromium.org Bug: 677338 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I84fa57c20af482de22ff31dd09c223b4f4331770 Reviewed-on: https://chromium-review.googlesource.com/1007443Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#551225}
-
Jennifer Apacible authored
This consolidates some of the similar exit-Picture-in-Picture behavior from both WebMediaPlayerImpl and PictureInPictureWindowController sides. When exiting from WMPI, we need to run an additional callback to signal that the window should be closed. From user gesture, the window tear down has already been handled. BUG: 823172 Change-Id: I4ee6e03a519a7564f7eb8b195f2dc7ddeacf4a88 Reviewed-on: https://chromium-review.googlesource.com/1012521 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#551224}
-
Christopher Cameron authored
Historically, RWHVCocoa has owned RWHVMac, because the lifetime of RWHVCocoa is unpredictable, and we needed to keep the RWHVMac around to dereference it (the alternative would be to sprinkle "is the RWHVMac still around" statements throughout). RWHVCocoa no longer directly references RWHVMac -- all of its interactions now go through its RWHNSViewClient interface. Flip this ownership, so that now - RWHVMac owns a - RWHVNSViewBridge which owns a - RWHVCocoa To solve the issue of RWHVCocoa potentially out-living everything, when the RWHVMac is destroyed, change RWHVCocoa's RWHNSViewClient to be a dummy client which just ignores all of the calls made to it. Make RWHVMac delete itself when its Destroy method is called (just like Aura). Delete all of the checks that RWHVCocoa's client_ be non-null, and delete all of the checks that RWHVMac's browser_compositor_ and ns_view_bridge_ be non-null. These pointers will now be valid for the lifetime of the objects. TBR=avi Bug: 821651 Change-Id: I568be2a3e0ca7b7abd1a2a2a6f68e4ad37193b51 Reviewed-on: https://chromium-review.googlesource.com/1009482Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#551223}
-
Erik Luo authored
- Adds an empty 15px space directly below the Console prompt's editor. - Updates "isScrolledToBottom" logic in Console to account for the new space. Without this update, typing on the prompt's last line will not "jump + stick to bottom" as expected. With this CL, overlay scrollbars (e.g. on Mac), should never cover the prompt's editor. Bug: 725249 Change-Id: Ib0167f6919d5b9942e7f2dc4d8cf0c15fc9368df Reviewed-on: https://chromium-review.googlesource.com/965020 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#551222}
-
Varun Mohan authored
We do not want callers (TabManager) to have to implement any of the logic related to determining the thresholds, but simply consume them. These thresholds will be used to determine timeouts until discard for proactive tab discarding. Bug: 775644 Change-Id: I09b3f54cf3acb44ac3724ef4a08ae57d4ce42255 Reviewed-on: https://chromium-review.googlesource.com/1012797Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#551221}
-
Dave Schuyler authored
This Cl potentially fixes a regression in CharTypedToRepaintLatency UMA by restoring a shortcut for one line (non-wrapping) answers. Change-Id: I93d264610f73dfab9db10c81c4ba198adab14c90 Reviewed-on: https://chromium-review.googlesource.com/1014412 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#551220}
-
Matt Mueller authored
The old name did not make it obvious that the intermediates are not compared. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0b2a3f4e9e2baf5d72fe5ec62e4f7ac91684dbd6 Reviewed-on: https://chromium-review.googlesource.com/1009106Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#551219}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 74c38a06. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15672 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/service-workers/cache-storage TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I86175193483f50501563602bb03d902a53b82b05 Reviewed-on: https://chromium-review.googlesource.com/1014521 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/d5624a47bcaa..6b26e1ae6932 $ git log d5624a47b..6b26e1ae6 --date=short --no-merges --format='%ad %ae %s' 2018-04-16 hnakashima Remove non-const CPDF_PageObjectHolder::GetPageObjectList(). 2018-04-16 dsinclair Merge CFX_XMLElement and CFX_XMLAttributeNode 2018-04-16 tsepez Write out StringViewTemplate::Operator=(). 2018-04-16 tsepez Revert "Return pdfium::span<wchar_t> from WideString::GetBuffer()." 2018-04-16 dsinclair Split GetNumbericSymbol into individual methods 2018-04-16 hnakashima Add test for saving after adding or removing page objects. 2018-04-16 thestig Fix some checks for FX_Realloc() failures. 2018-04-16 npm Simplify CFX_DIBitmap::TransferBitmap 2018-04-16 thestig Consolidate Black/Whitepoint parsing code CPDF_ColorSpace. 2018-04-16 dsinclair Remove CXML 2018-04-16 tsepez Put prototypes of PDF_NameEncode/Decode in fpdf_parser_utility.h 2018-04-16 thestig Consolidate BlackPoint parsing code in CPDF_ColorSpace. 2018-04-16 thestig Add Black/WhitePoint array constant in CPDF_ColorSpace. 2018-04-16 thestig More CPDF_Colorspace cleanup. 2018-04-16 hnakashima Update AUTHORS. 2018-04-16 dsinclair Convert CXFA_XMLLocale to CFX_XML 2018-04-16 dsinclair Add CXFA_XMLLocale unittests 2018-04-16 npm Check that CFX_DIBitmap::Create calls succeeds in fpdf_view 2018-04-16 dsinclair Move CXML to be XFA only 2018-04-16 tsepez Revert "Return pdfium::span<char> from ByteString::GetBuffer()." 2018-04-16 thestig Fix some nits in CPDF_ColorSpace. 2018-04-16 thestig Fix a comment in CPDF_PatternCS. 2018-04-16 dsinclair Remove CPWL_Edit rich text support 2018-04-16 dsinclair Use CFX_XML instead of CXML in CPDF_Metadata Created with: roll-dep src/third_party/pdfium BUG=chromium:832557,chromium:832978,chromium:832992,chromium:833062,chromium:833097 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0362765b3919b2f1aa5ba1f50774f5176083a4fd Reviewed-on: https://chromium-review.googlesource.com/1014474Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551217}
-
Benjamin Pastene authored
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel-vm-tests https://chromium-review.googlesource.com/c/chromium/tools/build/+/1013289 needs to land before the tests actually do anything. Hopefully I'll be able to land that sometime soon. This at least gets the configs set up. Bug: 832374 Change-Id: I93665b1307c82e84e5a5d83d2092a792786573f6 Reviewed-on: https://chromium-review.googlesource.com/1014484 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
John Z Wu authored
Looks like the underlying ivar names changed. Change-Id: I78755e0d5a77c19c1b972ff933f0e81b14dbdbe4 Reviewed-on: https://chromium-review.googlesource.com/1013299Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#551215}
-
https://skia.googlesource.com/skia.git/+log/d234afdc2e56..b460320a96df $ git log d234afdc2..b460320a9 --date=short --no-merges --format='%ad %ae %s' 2018-04-17 mtklein Revert "low-hanging bilerp_clamp_8888 wins" 2018-04-16 mtklein low-hanging bilerp_clamp_8888 wins 2018-04-16 csmartdalton Don't support GrCubicEffect if float != fp32 2018-04-13 bungeman Add pixel geometry and dft selection to viewer app. 2018-04-16 csmartdalton Revert "ccpr: Implement conics" 2018-04-16 csmartdalton ccpr: Implement conics 2018-04-16 reed show cubic error-vectors anchored on pt(s) of max deviation 2018-04-16 herb Rename SkGlyphCacheGlobals to SkStrikeCache 2018-04-16 csmartdalton Add glFlush workaround for instanced draws on Skylake Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I395db6cc49729a477dabf03482080c657e814833 Reviewed-on: https://chromium-review.googlesource.com/1014665Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551214}
-
Carlos Knippschild authored
Fix a crash on PrefetchBackgroundTask when DeviceConditions was null what occurrs in some uncommon hardware. Bug: 830063 Change-Id: I7a16179a72c085020fc64ba7792b3edc537d04a5 Reviewed-on: https://chromium-review.googlesource.com/1014421 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#551213}
-
Antoine Labour authored
At this point it's only used in tests, to test itself. Also remove Resource::usage, which isn't used for anything anymore. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3b75bba09565d52a126c0f27c344d94ed50fc4c6 Reviewed-on: https://chromium-review.googlesource.com/1014274Reviewed-by:
-
Xiaohan Wang authored
In normal cases in the render process WebMediaPlayerImpl holds a reference to the CDM such that the CDM should never be destructed before the media pipeline. Howeven, when both the decoder and CDM are hosted remotely (e.g. in the GPU process on Android), the destruction order could be reversed due to IPC. In this case, we should just fail instead of crash. Note that this case is already handled in MojoAudioDecoderService, MojoVideoDecoderService and MojoRendererService. Bug: 833641 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7f07c07dea86033ebe57700e0ce8834ea94b06f3 Reviewed-on: https://chromium-review.googlesource.com/1013690Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#551211}
-
Hongchan Choi authored
Spec: https://webaudio.github.io/web-audio-api/#rendering-loop (Step 9.5) The AudioWorkletNode with zero output must be pulled by the renderer. The actual output will be ignored just like AnalyserNode. Bug: 831245 Test: LayoutTests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-automatic-pull.https.html Change-Id: If9bd27d6c4bfeecdcd2dd4c8445459afd8593e85 Reviewed-on: https://chromium-review.googlesource.com/1014388Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551210}
-
dpapad authored
Bug: 832173 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I982e24b7234617b111e7adfa3c0f83356722ec8d Reviewed-on: https://chromium-review.googlesource.com/1013280Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#551209}
-
Antonio Gomes authored
BUG=773295 TEST= 1. <out_chromeos>/chrome --user-data-dir=<profile> --new-wallpaper-picker 2. settings -> select wallpaper 3. selection is functional. Change-Id: Ib24dca7b428225772984860193c49f4d46225a0a Reviewed-on: https://chromium-review.googlesource.com/1014223Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#551208}
-
Lei Zhang authored
Revert "Add browser tests for autofilling the shipping address info and payment info on captured sites." This reverts commit 34a6f41d. Reason for revert: Broke the Mac and Windows build. https://ci.chromium.org/buildbot/chromium/Mac/40485 chrome/test/base/interactive_test_utils_aura.cc:24:9: error: member access into incomplete type 'NSWindow' window->Hide(); https://ci.chromium.org/buildbot/chromium/Win%20x64/21368 chrome/browser/autofill/autofill_captured_sites_interactive_uitest.cc(133,9): error: format specifies type 'char *' but the argument has type 'const wchar_t *' [-Werror,-Wformat] src_dir.AppendASCII("third_party/catapult/web_page_replay_go") Original change's description: > Add browser tests for autofilling the shipping address info and payment info on captured sites. > > These tests are the first step in building a test framework for testing chrome autofill on complex, real-world sites pages. Since interacting with live sites are flaky and vulnerable to updates to the sites' features, this framework interacts with captured sites. > > Sites are captured with the Web Page Replay (WPR) tool. Prior to running the test, the browser test will start WPR locally on the machine using a capture file. The test then navigates to the test site, interact with the site's checkout workflow, and verifies that autofill correctly completes the address and payment information. > > Tests for 5 sites are included in this code change: Amazon, Zappos, Apple, Ebay and Walmart. > > Change-Id: I4b28e645554a2912c632fcb462439cac7142cf9f > Reviewed-on: https://chromium-review.googlesource.com/963800 > Commit-Queue: Yiming Zhou <uwyiming@google.com> > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551190} TBR=anthonyvd@chromium.org,sebsg@chromium.org,mahmadi@chromium.org,uwyiming@google.com Change-Id: Ied983de9c011fb6e3099e68b03bc60641a31b056 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1014497Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#551207}
-
Koji Ishii authored
Following bot results are included. 4822 4825 Inlucdes 2 rebaselines after manual review of failures. 6 lines were removed and 7 lines were deflaked by consecutive results since 4761. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic196acdbab4a48ab44d3cd9c50750fc399a9fe57 Reviewed-on: https://chromium-review.googlesource.com/1013780 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#551206}
-
Maks Orlovich authored
This is exact same thing as https://chromium-review.googlesource.com/c/chromium/src/+/987919 but on explicit mass-erase rather than eviction. Thanks to nedwilliamson@ (on gmail) for the report and testcase. Bug: 831963 Change-Id: I96a46700c1f058f7feebe038bcf983dc40eb7102 Reviewed-on: https://chromium-review.googlesource.com/1014023 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551205}
-
Kent Tamura authored
* Sub-directories of PerformanceTests are renamed to snake_case * Need to skip PRESUBMIT because third_party/blink/perf_tests/speedometer/resources/todomvc/learn.json is not a valid JSON. NOPRESUBMIT=true Bug: 829695 Change-Id: I6c7fb94792aedbea19bbee194bb9ceaf6df5ddfb Reviewed-on: https://chromium-review.googlesource.com/1006740Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#551204}
-
