- 08 May, 2018 40 commits
 - 
- 
Luke Zielinski authored
Includes a component-accessible interface for interacting with the navigation observer manager. Bug: 817377 Change-Id: I6074e9cfa53cbc7332c1f78b310124be99932abc Reviewed-on: https://chromium-review.googlesource.com/1030776Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#556776}
 - 
Shakti Sahu authored
Bug: 830814 Change-Id: If1e12254aebabb06da1ba0b31de9500331444863 Reviewed-on: https://chromium-review.googlesource.com/1003043 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556775}
 - 
Chromium WPT Sync authored
Using wpt-import in Chromium 4cc719bf. With Chromium commits locally applied on WPT: 7712d138 "ReadableStreamBytesConsumer should check read results" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17157 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=danyao No-Export: true Change-Id: I73fe65df8f8d6254392d5c58365f9a09ef60ec40 Reviewed-on: https://chromium-review.googlesource.com/1049745 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556774}
 - 
Jinsuk Kim authored
Java class InterstitialPageDelegateAndroid and its native class are used by content/chrome test only. This CL moves the classes to content/test/android. For this, content shell test apk is configured to have a native library of target name content_native_test_support. Bug: 617324 Change-Id: I81b757fe636e96139f61dce781d14fe55da341dd Reviewed-on: https://chromium-review.googlesource.com/1039305 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#556773}
 - 
sebsg authored
Bug: 839859 Change-Id: I198b4cf906ed1eabb250c56282b34d96dbd53415 Reviewed-on: https://chromium-review.googlesource.com/1045174Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#556772}
 - 
Oleh Prypin authored
TBR: hinoka@chromium.org Bug: chromium:840277 Change-Id: I2a28107bab3be476b263c65bf829c1b79259c7cd Reviewed-on: https://chromium-review.googlesource.com/1049631Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556771}
 - 
David 'Digit' Turner authored
When compiling Java sources into .jar files, the javac.py script will also generate a .jar.info file, used to map fully-qualified Java class names to the path of the corresponding source or .srcjar file. These are stored along the generated .jar file, e.g.: $OUT/gen/base/base_java.javac.jar $OUT/gen/base/base_java.javac.jar.info In addition to this, each APK has a final .apk.jar.info file stored under $OUT_DIR/size-info/ that corresponds to the union of all the .jar.info files of its dependencies, e.g.: $OUT/size-info/ChromePublic.apk.jar.info Before this CL, the .apk.jar.info was generated by javac.py when compiling the APK's own source files (which include things like the auto-generated resource-related .srcjar files), by passing the --apk-jar-info option to the script. Unfortunately, this made the implementation of the android_apk(), java_library_impl() and compile_java() GN templates slightly more complex (tightly coupled) than needed, making future changes more difficult. This CL tries to untangle the coupling as follows: - Add a new script (merge_jar_info_files.py) to merge one or more .jar.info file into a final .apk.jar.info. - Remove --apk-jar-info option from javac.py. The latter is now only responsible for generating the .jar.info of its final .jar file, and doesn't need to know anything about that may or may not embed it later. Similarly, remove the 'apk_name' variable from compile_java() and java_library_impl(). - Ensure that the android_apk() generates the final .apk.jar.info file by calling merge_jar_info_files.py. + Move common functionality to build/android/gyp/util/jar_info_utils.py To test the result, I manually checked that all .apk.jar.info files are identical after sorting (since they are a dump of a Python dictionary, with no guaranteed ordering: BUG=830641 R=agrieve@chromium.org, yfriedman@chromium.org Change-Id: I2051bc35aba2931947d2a30db507a4d437998238 Reviewed-on: https://chromium-review.googlesource.com/1047269 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#556770}
 - 
nednguyen authored
NOTRY=true # test covered by PRESUBMIT Bug: 840365 Change-Id: Ic064341d126c656e2acbf4224807f63a0815b601 Reviewed-on: https://chromium-review.googlesource.com/1048984Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#556769}
 - 
Hans Wennborg authored
Bug: none Change-Id: I74c2f8d85642291604d82eddc8ab7c0588fb8463 Reviewed-on: https://chromium-review.googlesource.com/1049613Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#556768}
 - 
Guido Urdaneta authored
This reverts commit f1b4c43b. Reason for revert: Causes reliable failures on Win10 Tests x64 (dbg) bot Sample failed runs: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/413 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/414 Sample logs: [ RUN ] SnooperNodeTest.ContinuousAudioFlowAdaptsToSkew/1 [ RUN ] SnooperNodeTest.ContinuousAudioFlowAdaptsToSkew/1 [ RUN ] SnooperNodeTest.ContinuousAudioFlowAdaptsToSkew/1 [ RUN ] SnooperNodeTest.ContinuousAudioFlowAdaptsToSkew/1 Original change's description: > The SnooperNode: Audio loopback for a single stream. > > An audio::GroupMember::Snooper that records the audio from a GroupMember > on one thread, and re-renders it to the desired output format on another > thread. Since the data flow rates are known to be driven by different > clocks (audio hardware clock versus system clock), the SnooperNode also > uses its resampler to compensate for skew and re-synchronize the audio > going into and out of it. > > Bug: 824019 > Change-Id: I87d410724fd00f9372232bfffdfbb89ada0b3de8 > Reviewed-on: https://chromium-review.googlesource.com/1041657 > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Xiangjun Zhang <xjz@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556719} TBR=miu@chromium.org,chcunningham@chromium.org,olka@chromium.org,xjz@chromium.org Change-Id: I47750e3abb5e9387733b5fbf275d930a79a6d45e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824019 Reviewed-on: https://chromium-review.googlesource.com/1049905Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#556767}
 - 
Marc Treib authored
Supervised Users are deprecated, and creation has been disabled for a while. Time to get rid of the code. Bug: 828890 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib95d138a5bdfa8fa150c99c1f85b8d2688ee3a27 Reviewed-on: https://chromium-review.googlesource.com/1029952Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556766}
 - 
Christian Dullweber authored
Introduce a class that hold deletion related information to pass it to history observer. This will simplify future changes and the deprecation of the old OnUrlsDeleted method. Also migrate Media- and SiteEngagementService to the new method. Bug: 839798 Change-Id: I77ded53325eb098f0ce156d24e0cb48a9166d0f5 Reviewed-on: https://chromium-review.googlesource.com/1043751Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#556765}
 - 
Ian Vollick authored
This reverts commit 7bd37b66. Reason for revert: this did not appear to be the culprit. Original change's description: > Revert "Reland: Update build rules to support ARCore" > > This reverts commit 14c289be. > > Reason for revert: > Speculative revert for APK merger failure on official 64 bit builders: > https://bugs.chromium.org/p/chromium/issues/detail?id=840342 > > Original change's description: > > Reland: Update build rules to support ARCore > > > > In this change, I've moved the code in chrome_public_apk_tmpl from the > > monochrome to he chrome template and ensured that apk_merger will pass. > > > > > Define enable_arcore and add some build rules to use it. > > > > > > Bug: 833511 > > > Change-Id: I716123c2a282d7d123883df81ebbc00a0a883be8 > > > Reviewed-on: https://chromium-review.googlesource.com/1033580 > > > Commit-Queue: Ian Vollick <vollick@chromium.org> > > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > > > Reviewed-by: David Dorwin <ddorwin@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#555174} > > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr > > Change-Id: I155d420f3b6606642cdfea43db48840f2c21a0cb > > Reviewed-on: https://chromium-review.googlesource.com/1040905 > > Reviewed-by: Tao Bai <michaelbai@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Will Harris <wfh@chromium.org> > > Reviewed-by: Bill Orr <billorr@chromium.org> > > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > > Reviewed-by: Richard Coles <torne@chromium.org> > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > > Commit-Queue: Ian Vollick <vollick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#556200} > > TBR=vollick@chromium.org,sky@chromium.org,michaelbai@chromium.org,yfriedman@chromium.org,torne@chromium.org,wfh@chromium.org,estevenson@chromium.org,jbudorick@chromium.org,billorr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I99a778b62c27506b820d36dfc90aafac3c88f553 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr > Reviewed-on: https://chromium-review.googlesource.com/1047945 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556508} TBR=vollick@chromium.org,sky@chromium.org,michaelbai@chromium.org,yfriedman@chromium.org,torne@chromium.org,tedchoc@chromium.org,wfh@chromium.org,estevenson@chromium.org,jbudorick@chromium.org,billorr@chromium.org Change-Id: I8186226aa5be33b11f01fa7b751c41b3f94bb32f No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Reviewed-on: https://chromium-review.googlesource.com/1049845Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#556764}
 - 
Tatsuhisa Yamaguchi authored
unpacker.app.onSuspend was removed at f8781418 and no longer exists. https://chromium-review.googlesource.com/940742 Bug: 839158,789073,803752 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I973b7728095cddcceab2e58c06ca07986a6bd9e6 Reviewed-on: https://chromium-review.googlesource.com/1049417 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#556763}
 - 
Guido Urdaneta authored
TBR=bsheedy@chromium.org Bug: 840725 Change-Id: Id47604a849bcfcbb51e33ddf94ffa7a539ecb1df Reviewed-on: https://chromium-review.googlesource.com/1049668Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#556762}
 - 
Marina Ciocea authored
Turns out RepeatingCallback() doesn't create a bound callback, resulting in crash on Run(): https://chromium.googlesource.com/chromium/src/+/master/docs/callback.md#creating-a-callback-that-does-nothing Unittests could be prettier, I'll fix that next week. Bug: 834702 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6fa404cc195e709d581015c48aaf65580a47525a Reviewed-on: https://chromium-review.googlesource.com/1049625 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#556761}
 - 
Hwanseung Lee authored
We should switch from DOMString to CSSOMString as resolved in CSSWG resolved to use CSSOMStrings[1]. and there is idl issue when union type have set of typedef value. so this case did not change and will follow up (https://crbug.com/838890) [1]https://github.com/w3c/css-houdini-drafts/issues/687#issuecomment-379669504 Bug: 834164 Change-Id: Id4768a6edbcdc17bfa72cffd4a63c81d8124d256 Reviewed-on: https://chromium-review.googlesource.com/1034618 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#556760}
 - 
Marina Ciocea authored
Remove audio thread reset before ScopedAllowBlocking. Bug: 672469 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8e0ca007d87aa3dc1a7b520cdc8e6976e79e3448 Reviewed-on: https://chromium-review.googlesource.com/1049665Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#556759}
 - 
Alexander Hendrich authored
Added a policy to limit the user's choices for their main OS language. The user can only select one of the provided languages in this list. If the current user's language is not allowed, the user's preferred languages are checked for an allowed entry. Otherwise the language is set to the first valid entry in this policy or to 'en-US' as default. Bug: 695042 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5c17868a97339ec32b04483734b68843ec26d2a8 Reviewed-on: https://chromium-review.googlesource.com/1034056Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#556758}
 - 
Chromium WPT Sync authored
Using wpt-import in Chromium 9fdaf87d. With Chromium commits locally applied on WPT: 1f468ca9 "Reland "Adds a test for basic WebRTC video codec conformance."" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17156 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=danyao No-Export: true Change-Id: I8a0e76f6ac9bf829e45c9f94b163a3fb9ac407a1 Reviewed-on: https://chromium-review.googlesource.com/1049368 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556757}
 - 
Ramin Halavati authored
New binaries of traffic annotation auditor and extractor are rolled for Windows and Linux. TBR=msramek@chromium.org Bug: 690323 Change-Id: If51ad7baf059c3b727034ec73fb2c7100fc8b298 Reviewed-on: https://chromium-review.googlesource.com/1049653Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#556756}
 - 
Anita Woodruff authored
- This is the follow-up CL to add tests for https://crrev.com/1035267, which added code to run a one-time reset of all blocked site channels. - The new tests are similar to the existing tests for the one-time migration to site channels. - For testing the DSE exception conditions, it was necessary to set up a fake TemplateURLService - did this by copying the approach of CreateTemplateURLService in contextual_search_delegate_unittest.cc to initialize it with a particular default search engine. R=peter@chromium.org Bug: 835232 Change-Id: I2f61e8a48997a0685e0afaa38d33caaaadecb188 Reviewed-on: https://chromium-review.googlesource.com/1044194 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#556755}
 - 
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I7edee97c51e9758cb680ed9f0be8e829116597d9 Reviewed-on: https://chromium-review.googlesource.com/1049173 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556754}
 - 
Ilya Nikolaevskiy authored
This CL adds origin trial implementation and forwards it to RtcPeerConnectionHander. The flag should be forwarded further down to actual video codec selection in the later CL. Intention to experiment: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/vp8/blink-dev/vbYCDv5ve5w/pq-uV_QRAwAJ Bug: 794608 Change-Id: I5c50a2b402bea720b57e8ebb2a36a261fb512743 Reviewed-on: https://chromium-review.googlesource.com/1030173 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#556753}
 - 
Rohit Rao authored
Also moves the implementation of BookmarkTableCellTitleEditDelegate to BookmarkHomeViewController, as that was only referenced by one of the data source methods. Makes several BookmarkTableView methods public in order to ease migration. BUG=840381 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia4e1f41ed76c44a763771799b0ec35da90d8ef21 Reviewed-on: https://chromium-review.googlesource.com/1048073 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#556752}
 - 
Yutaka Hirano authored
ReadableStreamBytesConsumer expected that the results from ReadableStreamReaderDefaultRead should be Promise<Object> because that is provided from ReadableStream provided by blink, but it's possible to inject arbitrary values with the promise assimilation. This CL adds additional checks for such injection. Bug: 840320 Change-Id: I7b3c6a8bfcf563dd860b133ff0295dd7a5d5fea5 Reviewed-on: https://chromium-review.googlesource.com/1049413 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#556751}
 - 
Guido Urdaneta authored
TBR=catmullings@chromium.org Bug: 801316 Change-Id: I92df8309043b434d0465a1b098ddf63da0ef27a8 Reviewed-on: https://chromium-review.googlesource.com/1049646Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#556750}
 - 
Kent Tamura authored
- Avoid global variables Wrap the whole code with 'main()' function - Don't use obsolete 'string' module - Don't add parenthesis to assert. - Remove trailing whitespace - Remove unused variable 'saved_by_reusing' - Remove whitespace around a keyword argument =. This CL has no behavior changes. Bug: 838772 Change-Id: Ib79344a4c5a671c24a528ed918156e22b0d2c65d Reviewed-on: https://chromium-review.googlesource.com/1049407Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#556749}
 - 
Jan Wilken Doerrie authored
This change introduces BluetoothAdapterWinrt, which will contain an adapter implementation using Mirosoft UWP BLE APIs. This change merely provides a skeleton, where each member function is NOTIMPLEMENTED(). Further functionality will be provided in future CLs. Bug: 579202, 821766 Change-Id: I207e14de292f9d24b7d16710437e0dae839c82ec Reviewed-on: https://chromium-review.googlesource.com/1046589 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#556748}
 - 
Harald Alvestrand authored
TBR=ksakamoto@chromium.org Bug: chromium:840659 Change-Id: Id25d5f8678296cf0e797fc668cdf384e01354433 Reviewed-on: https://chromium-review.googlesource.com/1049645Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#556747}
 - 
Charlie Andrews authored
AFAICT, this class is completely unused. Change-Id: I7c6ddf03e6094515833c34a3550457fd8a6b6471 Reviewed-on: https://chromium-review.googlesource.com/1049027 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#556746}
 - 
Tommy Steimel authored
This CL changes the CSS to align the current time and duration with the newly-positioned media controls buttons. Bug: 840255 Change-Id: I1a55eeb032ba8f2b968b8bf04fda96396f573bab Reviewed-on: https://chromium-review.googlesource.com/1048029Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#556745}
 - 
Guido Urdaneta authored
TBR=finnur@chromium.org Bug: 792313 Change-Id: Ia48dbdf710a3898fe1393404402295884d8e9c98 Reviewed-on: https://chromium-review.googlesource.com/1049554Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#556744}
 - 
Fredrik Söderquist authored
From using AtomicString (for 'mask', 'marker-*', 'fill' and 'stroke') or the string representation of SVGResources ('filter' and 'clip-path'), convert to using SVGResources. Add an implementation of SVGResourceClient (SVGElementResourceClient) and register it with the existing resources. Invalidation code is moved here. This makes the invalidation code slightly more homogeneous between the various code-paths. The new SVGResourceClient implementation is stored in SVGElementRareData as needed. The various computed style representations are converted to use the new StyleSVGResource, which is a ref-counted wrapper around an SVGResource and its underlying string representation (which is needed for serialization.) Style building is changed to produce this new wrapper (rather than an AtomicString.) A helper for serialization is added to ComputedStyleUtils. The kHasPendingResources flag is removed since it no longer used, and the hook in Element is removed. All LayoutSVGResource* subclasses are changed to take SVGResourceClients instead of LayoutObjects, and the |clients_| set is removed in favor of the set in SVGResource. A bunch of helpers are added for updating (adding/removing) the client registrations. The various LayoutSVG subclasses are updated to call these helpers. TBR=junov@chromium.org Bug: 769774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I62418465251532240c4e895e5c4d253ed9e53b9a Reviewed-on: https://chromium-review.googlesource.com/977965 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#556743}
 - 
Joel Hockey authored
Run python tools/metrics/histograms/update_extension_histograms.py to fix enums.xml. I don't believe that these features would have had (much) use, so it should be safe to fix this. ACCESSIBILITY_PRIVATE_ONSELECTTOSPEAKSTATECHANGEREQUESTED was inadvertantly added in http://crosreview.com/1030901, problem compounded a little in http://crosreview.com/1043666 Change-Id: I9f6b2b52fe97ff4c7bb75f079158d9ae4455d319 Tbr: isherman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1049349Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#556742}
 - 
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 835626 Change-Id: Ie214d9ef7241ab084772010b2a854e50ef051b67 Reviewed-on: https://chromium-review.googlesource.com/1049347Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556741}
 - 
Christian Dullweber authored
When urls are removed from chrome://history, the site-engagement score is not removed if it reaches zero. This CL fixes the issue as it is not neccessary to keep a score of zero around. Bug: 838875 Change-Id: Ia580ee49f2c4df8cda46f33c36b6551580dafef7 Reviewed-on: https://chromium-review.googlesource.com/1046765Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#556740}
 - 
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3f3bcb2..9ef8a461 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1c65bbcf6ce40050b917cb288293b9226d1563ab Reviewed-on: https://chromium-review.googlesource.com/1049367Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556739}
 - 
Patrik Höglund authored
I followed the conventions in chromium.linux at ci.chromium.org. Bug: chromium:840277 Change-Id: I7dd757c00f6e4450d1070ebc503f0d8cdd6887e4 Reviewed-on: https://chromium-review.googlesource.com/1046565 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#556738}
 - 
Jinsuk Kim authored
WindowEventObserverManager is a new class that will take care of all window-related events. - WindowAndroid is now updated through WebContents, and then ContentObserverManager to trigger observer events. - More work have been moved to actual observers (GestureListenerManager, SelectionPopupController, SelectPopup, etc) Bug: 598880 Change-Id: Ie4b9b209fe3bf67373fd420799effea210e93e5d Reviewed-on: https://chromium-review.googlesource.com/1018640 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#556737}
 
 -