- 07 Oct, 2020 40 commits
-
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4265.0-1601892862-benchmark-87.0.4280.10-r1 to 87-4265.0-1601892862-benchmark-87.0.4280.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2984683d6e9c4afe9f605f11205f3e1a9dfbd5b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458826Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814834}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/935a915963e1..91ab730685a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I694f31b267db21bf8df27f52edad963fcefe301b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457846Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814833}
-
David Roger authored
This CL enables the following chrome.identity features that are going to be launched together: - ReturnScopesInGetAuthToken - SelectedUserIdInGetAuthToken - IdentityClearAllCachedAuthTokensEnabled The flags are kept in code as kill switches and should be removed in the next milestone. Bug: 1100535, 1125847 Change-Id: Iff75297b1bbb7c4932e1bd9aa311e3d6b6d6a4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418952Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#814832}
-
Brian Sheedy authored
We continue to have random flakes in numerous tests on ChromeOS Kevin devices seemingly due to a driver issue, so mark every test as RetryOnFailure. Bug: 1091562 Change-Id: I60995bb434159f1daa002f889a13462621d448c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457886 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#814831}
-
Mike Wasserman authored
Fixes test failures with small screen sizes (e.g. 640x480). Hopefully a viable and simpler alternative to crrev.com/c/2454549 Bug: None Test: On linux-chromeos: browser_tests --gtest_filter=All/PopupBrowserTest.* --ash-host-window-bounds=640x480 Change-Id: I5b7108ef295625624dbf69eaf782a3656fdebebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454425 Auto-Submit: Michael Wasserman <msw@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#814830}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsSearchPage*, OSSettingsGoogleAssistantPage* Change-Id: Iec88c92e6902bf844e4f46dec5316dc4308a9570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456848 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#814829}
-
Garrett Beaty authored
Using per-milestone buckets caused the scheduler jobs names to have the bucket name prefixed to them when the number of jobs for a builder with a given name was >1. To account for this, the bucketed_triggers property modified the behavior of the chromium recipe to prefix the builder name with the bucket name to trigger the appropriate builder. A generator ensured that builders in the ci bucket could be triggered with or without the bucket prefix so that when new branch builders were added, outstanding builds wouldn't infra fail attempting to trigger a scheduler job that no longer existed. With milestone-based buckets removed, neither of these things is necessary. Change-Id: I479d1bcb56908e677f59dfa5b4b8a2394c8ada6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458451 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#814828}
-
Xianzhu Wang authored
We should include layout overflow of the non-clipped axis. Bug: 1087667 Change-Id: Icd68f42a2d2db431b094367180a66ee4e0efaf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451391Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814827}
-
Wei Li authored
These subclasses of Buttons all used Button's default focus behavior. Now set those default values explicitly so they will continue to work after changing Button's default value. These classes are not focusable by default, but will be focusable for accessibility purpose. Bug: 1001103 Change-Id: I9a5e7eb1373f66d102bed2199657db5b479af242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429539 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#814826}
-
Anastasiia N authored
Add lacros_account_manager_util for lacros-specific implementation of util functions (e.g. IsAccountManagerAvailable()). Bug: 1111984 Change-Id: I400401ae7fb61dc7295d17687d40da004cdac3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332190Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#814825}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b1807129a628..c021360a88f9 2020-10-07 brianosman@google.com Only include one variable per declaration statement 2020-10-07 johnstiles@google.com Remove accidentally repeated bit-index expression. 2020-10-07 mtklein@google.com refactor HashAndEncode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I406821ee793ba6e61be03deeba0a54dd0191c83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457392Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814824}
-
Sean Topping authored
This change introduces some Mojo helper classes that make it easier to create and pass services between processes. The following classes have been added: BinderFactory: Encapsulates Mojo binding boilerplate, adding simple accessors to bind mojo::PendingReceivers or provide a Binder callback for an implementation. InterfaceBundle: An easy-to-use substitute for BinderRegistry and InterfaceProvider. This class allows interfaces to be bundled together and shipped across processes. RemoteInterfaces: Remote client interface for accessing interfaces provided by InterfaceBundle. Allows for late-binding and request queueing so services can immediately start using interfaces. Merge-With: eureka-internal/455677 Bug: internal b/169098077 Test: cast_mojo_unittests, Build/run cast_shell on display device + Chromecast Change-Id: I2dd748db1969b65042587fd29d1a83b86987126a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441952 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#814823}
-
Toby Huang authored
This CL modifies commit_checklist.md to add a reminder to run gclient sync -D after calling git rebase-update. Doing this removes third- party build errors when trying to re-build after a rebase. This CL also adds a tip about reverting CLs. Bug: None Change-Id: Id6a8072620a1162fbcdbe76b7f365b938287a785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450698 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#814822}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ibf6ce79dead82d3875e4a4d1d40cfa741c5dee1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457648Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#814821}
-
Adlai Holler authored
As far as Chromium is concerned, this is a direct rename with no functional changes. Change-Id: Ia48e6602c237f3504fac41cb0f951f8f878f125b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456511 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Auto-Submit: Adlai Holler <adlai@google.com> Cr-Commit-Position: refs/heads/master@{#814820}
-
Tim Volodine authored
Add UMA for logging the resource type that triggers the Safe Browsing blocking page for WebLayer and Android WebView. Currently this histogram is logged in chrome. It is useful in order to be able to compare usage numbers across platforms and to obtain overall Safe Browsing usage stats. BUG=1136072 Change-Id: I3b09f631b51d242e0fe6ab9b2421b377e25806df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456348 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#814819}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2b77059502c9..3ce148638bdc 2020-10-07 8729214+jonahryandavis@users.noreply.github.com Disable -Wno-conversion on MSVC compiler (#2410) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: Ied742e5d6f32285a2963d6297dc9c575d91652a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457391Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814818}
-
Peter Kotwicz authored
This CL makes //weblayer/shell/android:weblayer_shell_java ignore unavoidable known strict mode violations. The KnownViolations.java list is taken matches the list used for other Google apps. BUG=1134600 Change-Id: Ie3de4e820798659a5f0e5500329004c657a573fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445854 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814817}
-
Tibor Goldschwendt authored
Offers a toggle in the customize dialog that hides modules on the NTP. Screenshot (shown): https://screenshot.googleplex.com/BKvcrirTE6quvdi Screenshot (hidden): https://screenshot.googleplex.com/AxMQ6DZa3MrHopf Upon closing the customize dialog the visibility will be applied to the current NTP and saved to prefs. Bug: 1135393 Change-Id: I1dde6109ab3b8acccee5a4c57681a42302fbec76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454329 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#814816}
-
Jazz Xu authored
This CL makes CrOS GMC compatible with CrOS light/dark mode feature. Bug: 1135656 Change-Id: Idd4955fd8676d2171bd323c1282198dc57345981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451316 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#814815}
-
Brian Malcolm authored
This changes the subtitle that tells the user who is managing this device. For Dasher domains, it will continue to be a domain (foo.com). For FlexOrgs, this will be the email of the administrator of the organization (admin@foo.com). BUG=chromium:1081272 Change-Id: I41c6eb66115e2e4b9ad7e4427c12935bbcf4b223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454155Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#814814}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3a384ed186dd..ff30c3d43096 2020-10-07 tsepez@chromium.org Make XFA_MAPMODULEDATA::m_ValueMap map onto int, not void*. 2020-10-07 tsepez@chromium.org Make XFA_MAPMODULEDATA be keyed by uint32_t, not void*. 2020-10-06 tsepez@chromium.org Forward declare XFA_MAPDATABLOCKCALLBACKINFO in cjx_object.h 2020-10-06 nigi@chromium.org Roll third_party/freetype/src/ 16ee2a22a..20186d1be (9 commits) 2020-10-06 thestig@chromium.org Remove the last set_sources_assignment_filter(). 2020-10-06 thakis@chromium.org stretch engine: Hoist a options reads out of loops 2020-10-06 nigi@chromium.org Roll build/ 23dc5c578..50f81f245 (217 commits) 2020-10-06 tsepez@chromium.org Pass span to CXFA_Graphics::SetLineDash() 2020-10-06 thestig@chromium.org Split CGdiplusExt into its own file. 2020-10-06 thestig@chromium.org Split CGdiDisplayDriver into its own file. 2020-10-06 thestig@chromium.org Split CGdiPrinterDriver into its own file. 2020-10-06 thestig@chromium.org Split CPSPrinterDriver into its own file. 2020-10-06 thestig@chromium.org Split CTextOnlyPrinterDriver into its own file. 2020-10-06 thestig@chromium.org Make some CFX_AggDeviceDriver methods private. 2020-10-06 thestig@chromium.org Replace CAgg_PathData with BuildAggPath(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia8d75793f9e0eb424f76da007aef3472d151db95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814813}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a51c2a0b4243..34951b7955e2 2020-10-07 sdefresne@chromium.org build: Remove no-op calls to set_sources_assignment_filter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1018739 Tbr: timvp@google.com Change-Id: I98e51d9b8a5f379a83f5a73e906e7e2fbba0952d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457389Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814812}
-
Sebastien Lalancette authored
Adds an "additionalText" optional parameter to the ActivityServices scenarios, allowing to share a piece of text along with a page's URL and title. This additional text will be added as an extra activity item, and will be stored in the pasteboard when users select the Copy activity. Bug: 1136043 Change-Id: Ia8d86c4ecfb57bdbc2bac3f209ab37973d79fc59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451309 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#814811}
-
chrome://versiondpapad authored
Fixed: 1135807 Change-Id: Id627fb657bc1f507c25e845e602d3bcdb5dfbae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454982Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#814810}
-
Patrick Brosset authored
Links now appear in var() functions in the Styles panel of DevTools to allow users to jump to where custom properties are defined. This change adds a new state to the DevToolsAction enum so we can record when users click these links. Frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2451605/ Bug: 1124707 Change-Id: Ib38e57689973a94cf68837234d1bf66653e8d5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451925Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814809}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test no longer needs to be parameterized Bug: 1065748 Change-Id: I9827cee3d3393dc4bf2038057aa8ca197b2fe522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454611 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814808}
-
Brian Sheedy authored
Adds an ignore:1 to the JSON uploaded to Gold from the Android RenderTests if we are running on a trybot and it is not the final retry attempt. This is to counter flaky tests causing unrelated CLs to receive comments from Gold when the test causes their CL to produce a new image. With this change, CLs will only receive a comment if a test fails consistently. Bug: skia:10787 Change-Id: I827de961e49a357f1755d6931b89468e27bebac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446717Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#814807}
-
John Williams authored
Bug: 1129217 Change-Id: I683aeee86f06a157255eae0c9db3948509ebcbf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438749 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#814806}
-
George Burgess IV authored
Unless it's guaranteed that `std::forward` always turns into an rvalue ref, using `std::move(x)`, where `x`'s type is a universal reference, is generally unsafe. `std::forward` is preferred for these cases. Bug: 1134310 Change-Id: I09a45cc9ea6378102e1e6227894e4096706f023b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441382Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#814805}
-
Jesse Schettler authored
Add a TypeConverter to convert the Mojo ScanSettings struct to a lorgnette::ScanSettings proto. Bug: 1059779 Change-Id: I521c62bfb98b82214bce812719f05634b5355ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453792Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#814804}
-
Daniel Hosseinian authored
Instead of just clearing the canvas when going out of view, remove it. Recreate the canvas once needed again. Bug: 1134057 Change-Id: I11131d7bf584eb51c94f4fd24484ba9f6675e75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451387Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#814803}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I71bddb7d051200b4d816d16e4344c7033029e84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457866Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814802}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010070700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/uWbmcEtWADarsG0HhmvlhXO-JRde7y_pepUaXfu4TDAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/170162418 Tbr: help-app@grotations.appspotmail.com Change-Id: I02decd1ec740760753a917696c443c297ed89b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456014Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814801}
-
dpapad authored
Bug: None Change-Id: I53e732ac6f968583838b12a965c70cb3f56f5dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457326 Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#814800}
-
Vladimir Levin authored
This patch increases the viewport intersection margin for content-visibility: auto to 150% of the viewport. This prevents excessive 'checkerboarding' from lack of rendered content on quick flings. R=chrishtr@chromium.org TEST=Tested with scrollBy({ top: 10000, behavior: 'smooth' }) on FB. Change-Id: I70d3ef371d5aeb943dca26d6decae97184db446b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453029 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814799}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/91ab730685a6..3419b3b485ba 2020-10-07 primiano@google.com Merge "build: Remove no-op calls to set_sources_assignment_filter" 2020-10-07 ddrone@google.com Merge "Manually copy Chrome extensions to Perfetto" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I44914bbe29b3d8a0a6a74343dfba64a366507760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457390Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814798}
-
Scott Violet authored
BrowserControlsOffsetCallback landed in 88, not 87. I merged the restore code to 87: https://chromium-review.googlesource.com/c/chromium/src/+/2454639 so the version checks need to be updated. Lastly, I named a method wrong in Browser. This fixed that. BUG=none TEST=this only updates comments. Change-Id: I073dc8986588853c27aed906ed0f5ccee71f923c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454837Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814797}
-
Jose Dapena Paz authored
Fix build error: ../../components/omnibox/browser/on_device_head_model.h:68:15: error: ‘vector’ in namespace ‘std’ does not name a template type Bug: 957519 Change-Id: Idad1853af6afbf31faf288b6b5a73007497338a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453452Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#814796}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test no longer needs to be parameterized Bug: 1065748 Change-Id: I70940f9fe74c1865003ce42d421c36f34515f47c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454778 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814795}
-