- 17 Jan, 2020 40 commits
-
-
Vasilii Sukhanov authored
The metrics is collected. No follow-up is planned. Bug: 1037179,791541 Change-Id: I4db51f2595761fcff3a68abf7d912950112c42c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004993 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732823}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8dd28cd4db8d..1918d6d30029 Created with: gclient setdep -r src-internal@1918d6d30029 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If9033ade40986b98d6af0f8d81df6060aab2b16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007428Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732822}
-
Peter Boström authored
This more closely matches the button size for the close-x at the end of the downloads shelf. The focus ring and ink-drop highlight was significantly larger than intended, likely after r619533. This change also adds padding left of the drop-down button so that the "Discard" button doesn't get laid out edge-to-edge next to it with overlapping focus rings. Bug: chromium:1042633 Change-Id: I3aac0b77846020e0fe3eb612d35f67bf307dbd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006136 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#732821}
-
Jan Wilken Dörrie authored
This reverts commit 4184bbb0. Reason for revert: Likely culprit for a number of new flakes on Mac: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDE4NGJiYjBmM2ZlZjIzNzNlZGZjMTlkN2EzOGMxYTQ1NDBkZjBiOAw Original change's description: > Convert browser side's legacy IPCs of BlinkTest message to Mojo > > As a step to convert legacy IPCs to the Mojo, this CL > converts browser side's BlinkTest IPCs to Mojo. This > CL introduces WebTestClient interface to replace the > IPC messages to Mojo methods in web_test.mojom file. > The interface starts to support the original messages > as below, > > - InitiateLayoutDump() > - PrintMessageToStderr() > - SetPopupBlockingEnabled() > - NavigateSecondaryWindow() > - GoToOffset > - Reload() > - LoadURLForFrame() > - CloseRemainingWindows() > - ResetDone() > - SendBluetoothManualChooserEvent() > - GetBluetoothManualChooserEvents() > - SetBluetoothManualChooser() > > This CL should not change any behavior. > > Bug: 1039247 > Change-Id: Ic30f8cc0cb19ec8a306b577f3c10567d91bdccf1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002047 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#732388} TBR=dtapuska@chromium.org,mkwst@chromium.org,gyuyoung@igalia.com Change-Id: Iab211ed8d34d4fbc4781ec02e107f7deb3dbde72 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1039247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007389Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#732820}
-
Maksim Moskvitin authored
There is a scenario causing crash in old implementation: 1. Client receives NigoriSpecifics with non-decryptable |keystore_decryptor_token| in backward-compatible keystore mode. 2. User provides implicit passphrase. 3. Client decrypts |pending_keys| with implicit passphrase, but continues to ask for new keystore keys. 4. Client receives keystore keys and crashes when trying to dereference |pending_keys|. Current fix is to not do anything if there is no |pending_keys|. Bug: 1042203 Change-Id: I20d607cbe349bbb6eda5ed9b85f1e91d213fbc9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002615 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732819}
-
Mikel Astiz authored
This API is analogous to IsPassphraseRequired() and different from IsTrustedVaultKeyRequiredForPreferredDataTypes() in the sense that it's not influenced by the currently-selected sync datatypes. The rationale for introducing is that, when pending keys exist, certain operations such as setting up a custom passphrase should be disallowed by the UI, to prevent data loss. This is because having pending keys means the locally accessible keybag does not contain all keys, so e.g. setting up a custom passphrase would produce a new keybag where such keys may be missing. As a consequence, worst-case, this can effectively lead to user data loss, since there could be synced passwords encrypted with the keys that have just been lost. In this patch, setting pages on various platforms are updated to consume use the new function instead of IsTrustedVaultKeyRequiredForPreferredDataTypes(). Bug: 1019687 Change-Id: I6b5c69aac12b05ea34b4edc7dc149c84bd23d5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972140 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#732818}
-
David Roger authored
All these histograms but one (NonGaia) were no longer recorded. The NonGaia histograms only had one bucket recorded: PROFILE_DESKTOP_MENU_OPEN_USER_MANAGER This information can be found in Profile.Menu.ClickedActionableItem and is thus redundant. This CL also obsoletes the histogram Profile.AndroidAccountManagementMenu.GAIAIncognito which is never recorded in the code. Fixed: 1041533, 1041470 Change-Id: Ic5f6e05156d323f49ebe3a5b9daf7d64f319b7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002626 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732817}
-
Jan Wilken Dörrie authored
This reverts commit e03c42ac. Reason for revert: browser_tests failures on CrOS (https://crbug.com/1043074) Original change's description: > Add Quick Answers context menu observer. > > The feature is guarded by a feature flag that is currently disabled by default. > > This CL implements a temporarily UI for getting early feedback on product and > data quality while we are figuring out the final UI. > > More detail at: go/quick-answers-cros and go/quick-answers > > Bug: 1020004 > Test: Unit tests > Change-Id: I17dac669c230f5fbd2052cd5683344fa30c41b85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961210 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Li Lin <llin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732713} TBR=avi@chromium.org,xiyuan@chromium.org,thakis@chromium.org,estade@chromium.org,llin@chromium.org Change-Id: I5d0a1ca1a22301e1c79b8f6187df8c18ead14120 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007568Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fada3b97d140..d4405431bad0 git log fada3b97d140..d4405431bad0 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 phoglund@google.com Add support for diagnostics and unit conversion. Created with: gclient setdep -r src/third_party/catapult@d4405431bad0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: rmhasan@google.com Change-Id: If60017872120fa5803e22b3baac2d4bc8c3b9116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005803Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732815}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/47cbd1fb..07335b60 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If44db73d830df8f73ed9a67e8b1a388e6fe3e5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006171Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732814}
-
Swapnil authored
MANIFEST_FETCH_FAILED. This is to get a better idea for failure of Force installed extensions through UMA statistics by reporting error codes in case of MANIFEST_FETCH_FAILED. We report Network Error codes, Http error codes, and the number of fetch retries made in case of MANIFEST_FETCH_FAILED error. Following histograms are added: Extensions.ForceInstalledManifestFetchFailedNetworkErrorCode -> Reports the number of fetch retries made in case of MANIFEST_FETCH_FAILED. Extensions.ForceInstalledManifestFetchFailedHttpErrorCode -> Reports the Http Error Code in case of MANIFEST_FETCH_FAILED. Extensions.ForceInstalledManifestFetchFailedNetworkErrorCode -> Reports the Network error codes in case of MANIFEST_FETCH_FAILED. Error codes are received in the ExtensionDownloader. Bug: 981891 Change-Id: Icf5310d0f9422f77a4751c36ae8d6eaa5e772052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993976Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#732813}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 22387718. With Chromium commits locally applied on WPT: 62f8d5f0 "Enable Scroll To Text by default" 363313c0 "Sort the registrations returned by getRegistrations() by registration ID." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eroman@chromium.org, rsleevi@chromium.org: external/wpt/WebCryptoAPI foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie720a80bf763eccf9cac8688d155976f338b8eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006690Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732812}
-
Sebastian Jansson authored
Bug: webrtc:9883 Change-Id: I4c904949c43dccaf544463e3534ed4d7d29b51f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003168Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Sebastian Jansson <srte@chromium.org> Cr-Commit-Position: refs/heads/master@{#732811}
-
Olya Kalitova authored
Adds check whether Crostini container is already configured, so that default Crostini container configuration is triggered only when default Crostini container is not yet successfully configured using currently set CrostiniAnsiblePlaybook policy. Before this CL: container is reconfigured each time container is started if policy is specified & feature flag is set. TEST: unit_tests --gtest_filter="*Ansible*" Bug: 1024859 Change-Id: If1dc83a8130d35a9aa4eba5c8f5e8b39ea1e0dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000701 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#732810}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e4ddaa949540..fc8279d66c81 git log e4ddaa949540..fc8279d66c81 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 srte@webrtc.org Reland "Using simulated rtc::Thread for peer connection scenario tests." 2020-01-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f1e98807..862d9d7b (732621:732747) 2020-01-17 steveanton@webrtc.org Revert "Distinguish between send and receive codecs" Created with: gclient setdep -r src/third_party/webrtc@fc8279d66c81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029737 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I78aa8fe89b517ead7a2d8f1028270fb6cb47403c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005804Reviewed-by:
-
Julie Jeongeun Kim authored
This CL changes InputMsg_SetFocus so that it is implemented in the RemoteFrame interface since it is only got through RenderFrameProxy. It also introduces FakeRemoteFrame to use RemoteFrame on render_frame_host_manager_unittest.cc. Bug: 1039256 Change-Id: If7d1d2971fabf3c64777281b1bf5eedfa9fcf5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989714 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#732808}
-
Sylvain Defresne authored
This reverts commit 19619799. Reason for revert: Breaks official builder as the followup downstream CL cannot land. Reverting until the downstream situation can be fixed. Original change's description: > [iOS] Roll MDC to dc9529ad1077730cb7a57b05b77c9260d027b6d4 > > Bug: 1034144 > Change-Id: I8f69bae933c264839a60f4ce7c9cb6ac04249895 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003391 > Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732628} TBR=eugenebut@chromium.org,kkhorimoto@chromium.org Change-Id: I38a5bd99b76a22ff2a43a9d36ede6a7be2aedb54 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007448Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#732807}
-
Jan Wilken Dörrie authored
TBR=mythria Bug: 1043048 Change-Id: I84098257798335abaec43a54b59e5f746219eef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006353Reviewed-by:
-
Sebastian Jansson authored
PostAt and ReceiveSends are about to be removed from rtc::Thread, removing overrides to avoid compile error. Bug: webrtc:9883 Change-Id: I753fca76b07f5c82b1358f7fa3c4aadd661ecb5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000759Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sebastian Jansson <srte@chromium.org> Cr-Commit-Position: refs/heads/master@{#732805}
-
Monica Basta authored
As part of friendly settings, this CL implements changing |sync everything| from check box to radio button. The motivation behind this work is to clarify to users the difference between |Sync everything| checked and |Sync everything| unchecked but all single data types checked. Screenshot: http://screen/TuwQcMx3dmk Bug: 1035421 Change-Id: I4f9db188a6b324d18c5d17a5dfca6b9d70e0b1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995328 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#732804}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9819e9ed7b10..ce9f521465e1 git log 9819e9ed7b10..ce9f521465e1 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 3ed344dd784e..b0ada80356ca (1 commits) 2020-01-17 syoussefi@chromium.org Vulkan: Narrow KHR-GLES31 image failures Created with: gclient setdep -r src/third_party/angle@ce9f521465e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: Ied0fcb5efd1f75c22521edd58a8f8c64cabd05e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005798Reviewed-by:
-
Omer Katz authored
Marking in the mutator thread should start with mutator-thread-only worklists. If time runs out for incremental marking, concurrent marking can take care of the other worklists. Bug: 986235 Change-Id: Id566bd57b49df24aa63a1ce07bbfbe6259ead16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005992Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732802}
-
Eriko Kurimoto authored
Options for shared workers are kept as SharedWorkerInstance type in content/browser. We use script_type and credentials_mode for creating workers. These parameters are needed for implementing ES module for shared workers. This change doesn't affect the behavior. Bug: 824646 TBR: chrisha@chromium.org Change-Id: I63e54f25f3064a06ece72157342f2c92a60aef80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994854 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#732801}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibe331056d6621933513cc1ac7708b5c3b84f1e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005802Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=chenwilliam Bug: 1042688 Change-Id: I64c7d9366907ee3fc41d75ba18509f4fe57c871e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003176 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=adithyas Bug: 1042703 Change-Id: I5c8634b2b709940fd9b7348bd287e87337587ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006553Reviewed-by:
-
Jan Wilken Dörrie authored
This reverts commit be9ead6f. Reason for revert: Breaks content_browsertests on Linux CFI (https://crbug.com/1043059) Original change's description: > Roll src/third_party/perfetto 11c11a1a891c..cf0fcdbfc9a0 (16 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/11c11a1a891c..cf0fcdbfc9a0 > > git log 11c11a1a891c..cf0fcdbfc9a0 --date=short --first-parent --format='%ad %ae %s' > 2020-01-16 eseckler@google.com Merge "processor: Export pid/tid as signed integers into JSON" > 2020-01-16 lalitm@google.com Merge "trace_processor: fix compile and build on fuzzer" > 2020-01-16 joelaf@google.com Merge "Fix precision errors by explicit casting" > 2020-01-16 lalitm@google.com Merge "Revert "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead."" > 2020-01-16 chiur@google.com Merge "Add VulkanApiEvent.VkQueueSubmit message" > 2020-01-16 khokhlov@google.com Merge "trace_processor: Run metrics on Windows" > 2020-01-16 primiano@google.com Merge "gn: Fix issue with finding llvm when using python3" > 2020-01-16 hjd@google.com Merge changes Ic6800bd0,I29636316 > 2020-01-16 treehugger-gerrit@google.com Merge "processor: Fix handling of 0 timestamp in TrackEventTokenizer." > 2020-01-16 rsavitski@google.com Merge "heapprofd producer: use sigqueue(si_value: 0) instead of kill" > 2020-01-16 taylori@google.com Merge "perfetto-ui: Toggle sidebar on ctrl/cmd + b" > 2020-01-16 eseckler@google.com Merge "client lib: Support building in Chrome using a fake platform" > 2020-01-16 eseckler@google.com Merge "processor: Translate duplicate pids/tids during json export" > 2020-01-16 buss@google.com Merge changes I1bb0e215,I498ed990 > 2020-01-16 treehugger-gerrit@google.com Merge "processor: Support pid reuse in ProcessTracker without Start/EndThread" > 2020-01-16 primiano@google.com Merge "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead." > > Created with: > gclient setdep -r src/third_party/perfetto@cf0fcdbfc9a0 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: If9d0cfb1de77d821e94bc4598d682f39e70630ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005333 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#732631} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: If1b4bef65c19e3a43d04af679d3144b61ec4cd97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007208 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Alex Chau authored
- Renamed RecipientInfo to FCMChannelConfiguration to match sharing_message_specifics.proto - Introduced ServerChannelConfiguration Bug: 1042672 Change-Id: Idf72f0d0e7ee0df0101c04cd5efcf980acd66fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004990Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#732796}
-
Jan Wilken Dörrie authored
This reverts commit 870bcafd. Reason for revert: Previous roll broke content_browsertests on Linux CFI (https://crbug.com/1043059) Original change's description: > Roll src/third_party/perfetto cf0fcdbfc9a0..649f757cc08b (1 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/cf0fcdbfc9a0..649f757cc08b > > git log cf0fcdbfc9a0..649f757cc08b --date=short --first-parent --format='%ad %ae %s' > 2020-01-16 ilkos@google.com Merge "Remove symbols that are definitely not obfuscated" > > Created with: > gclient setdep -r src/third_party/perfetto@649f757cc08b > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: Idd6f625ab71b7b186970f43df6403bce66ac140a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006484 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#732698} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I1deea6a0457c8ded6f3ebf65a34f6fe0a800372d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007189Reviewed-by:
-
Javier Ernesto Flores Robles authored
Previously icons where being fetched in an precise URL manner. This led to many password rows not having Favicon. This attempts to reduce that by falling back to any host favicon. It also changes how the search is made for the favicon, previously if no favicon was at least the min amount of pixels no icon would be retrieved. Now the closest icon is resized to the desired pixels. This will improve favicons on iPads with big resolution, were the favicons in the history DB were never as big. Bug: 949076 Change-Id: Iac7619c76e8e3e6bd6b0de961dbaf40a5f3eeea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000697Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#732794}
-
Miyoung Shin authored
This CL replaces the SelfOwnedReceiver for TextSuggestionHost with an owned Receiver that matches the lifetime of TextSuggestionHostAndroid. TextSuggestionHostAndroid creates an instance of TextSuggestionHostMojoImplAndroid when BindTextSuggestionHost method is called, and owns it. Bug: 1034125 Change-Id: Ia07103806b7571008d27ba3e0cf21534121ee6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000447 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#732793}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6d6e911b50e1..fada3b97d140 git log 6d6e911b50e1..fada3b97d140 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 phoglund@google.com Add reserved_infos.h/cc. Created with: gclient setdep -r src/third_party/catapult@fada3b97d140 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: rmhasan@google.com Change-Id: Ibe159e6f6a0a6e505ef815faf3ea934ae1a16bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007150Reviewed-by:
-
Omer Katz authored
Bug: 986235 Change-Id: Idf6c50f07977804ae4a9d78a904043ab0bb7ba8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007049Reviewed-by:
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script Bug: chromium:878390 Change-Id: I6551ecfeff091e1f2614e143ae9e6bd8c9f393fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003323Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#732790}
-
Sean Harrison authored
Bug: 1007223 Change-Id: I9aa1f2db14ab501c2ed45900e28b40c99a9d8cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005168Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#732789}
-
Himanshu Jaju authored
Tracks time taken to respond to an incoming SharingMessage with the payload case as the suffix name. Bug: 1035433 Change-Id: I9fa15e5206e9a41c44fc64c0f5ef4a90b9fe7370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002910 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#732788}
-
Kunihiko Sakamoto authored
This histogram is as important as TimeToFirstMeaningfulPaint itself. This patch makes the expiry and the owners of the histogram aligned with the other FirstMeaningfulPaint related histograms. Bug: 1037180 Change-Id: I5e652996384a6444891582763e18d4c382d9dfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000449Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Maria Kazinova authored
PasswordForm is a result of parsing and is a part of the browser process. The renderer process doesn't need it, as all necessary renderer process information is contained in FormData. Bug: 949519 Change-Id: Ib5dd365f09e89820dc15b9f2966f88dc59b62519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992086Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#732786}
-
Sean Harrison authored
Move the settings enum and the call to uma to a separate browser proxy. Add UMA to all site settings subpage interactions and new toggles moved to the main settings card Bug: 1032584 Change-Id: Icadd71d4511fa1f604f2d3acbda92c0e84700173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967651 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
-
Kent Tamura authored
* FileInputType::SetValue() |input.value =""| triggered style recalc because style recalc triggered UpdateFromElement(). However, we don't need style recalc in this case and we need to do just paint invalidation. * UpdateFromElement() just does paint invalidation. The function is called from - HTMLFormControlElement::AttachLayoutTree() - HTMLFormControlElement::DidRecalcStyle() For both of them, paint invalidation by UpdateFromElement() is redundant. So we can remove UpdateFromElement(). This CL has no behavior changes. Bug: 1040828 Change-Id: I3e180de69cef7eef20d1944283938deec8de9685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006436Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#732784}
-
