GitLab

This patch removes a DumpWithoutCrashing call in DoCancel that wasn't particularly useful.

BUG=557430

Review URL: https://codereview.chromium.org/1645513003

Cr-Commit-Position: refs/heads/master@{#371887}

Chromecast executables depend on several shared libraries in $ORIGIN for
platform and OEM abstraction. The rpath for executables should be
updated so that these libraries can be found at runtime. This logic is
added here, instead of //build/config/gcc:executable_ldconfig, to keep
Chromecast-specific configs as concentrated as possible.

A note about security concerns: Chrome only enables this by default for
component and sanitizer builds, never shipped builds. This is to protect
users from arbitrary binaries being run in the shared lib directory.
Chromecast does not share these concerns, as it only runs trusted web
applications in practice.

BUG=516899

Review URL: https://codereview.chromium.org/1639343002

Cr-Commit-Position: refs/heads/master@{#371886}

aura_android.gni no longer needed as Android Aura project has been cancelled.

BUG=NONE

Review URL: https://codereview.chromium.org/1636143002

Cr-Commit-Position: refs/heads/master@{#371885}

TBR=nednguyen@google.com,zhenw@chromium.org

Review URL: https://codereview.chromium.org/1642493004

Cr-Commit-Position: refs/heads/master@{#371884}

Split Geolocation and DeviceOrientation off of OverridesSupport, used them in SensorsView.
Migrated some tests, DeviceSettingsTab and EmulatedDevices to DeviceModeModel.

BUG=540864

Review URL: https://codereview.chromium.org/1631223003

Cr-Commit-Position: refs/heads/master@{#371883}

R=eugenis@chromium.org
BUG=581762

Review URL: https://codereview.chromium.org/1640863002

Cr-Commit-Position: refs/heads/master@{#371882}

Just running the generator caused such changes.  It's better to land them independently.

BUG=
TEST=build
TBR=piman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1647663003

Cr-Commit-Position: refs/heads/master@{#371881}

Currently, the logcat monitor can hang if nothing is being output
by logcat after you try to join the recorder thread. Adding a
timeout to join to prevent this.

BUG=581352

Review URL: https://codereview.chromium.org/1648443002

Cr-Commit-Position: refs/heads/master@{#371880}

RenderPassDrawQuad::MaskUVRect() computes the UV rect by scaling
the quad->rect() by mask_uv_scale, then dividing by quad->rect size.
However, RenderSurfaceImpl::AppendQuads() computes the mask UV scale
as quad->rect() size / mask size. So let's just take the quad->rect() size
out of mask_uv_scale in the first place, so we don't have to divide
it back out in MaskUVRect().

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1647573002

Cr-Commit-Position: refs/heads/master@{#371879}

TBR=pfeldman

BUG=581468

Review URL: https://codereview.chromium.org/1640603003

Cr-Commit-Position: refs/heads/master@{#371878}

Two cases:
1. Device(s) discovered already. No user visible changes.
2. No device(s) discoverd. Show "No bluetooth devices found. Search again"
   text. https://folio.googleplex.com/chrome-ux/mocks/236-fizz/choosers/032515_ChooserPhone#%2F03_NoneAfterTimeOut.jpg

BUG=539607

Review URL: https://codereview.chromium.org/1625633004

Cr-Commit-Position: refs/heads/master@{#371877}

This is a precursor to deleting tools/telemetry so we don't break the gpu tests
presubmit when that lands.

BUG=478864

Review URL: https://codereview.chromium.org/1644723002

Cr-Commit-Position: refs/heads/master@{#371876}

Without this change when system_libdir is set (e.g.
to lib64) it would apply this to all toolchains
including the host toolchain.

Review URL: https://codereview.chromium.org/1583093002

Cr-Commit-Position: refs/heads/master@{#371875}

Record replacementRange from setMarkedText: event, then send along with
next ImeSetComposition message.

BUG=460999

Review URL: https://codereview.chromium.org/1635953002

Cr-Commit-Position: refs/heads/master@{#371874}

NativeWidgetMus sets up the context-factory for the WindowTreeHostMus,
and so WindowTreeHostMus doesn't need to know about the surface-type.

BUG=none

Review URL: https://codereview.chromium.org/1647483002

Cr-Commit-Position: refs/heads/master@{#371873}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fefcc888..778c5a60

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1639423002

Cr-Commit-Position: refs/heads/master@{#371872}

Direct copy-paste, no changes.

BUG=533681
TBR=erikchen

Review URL: https://codereview.chromium.org/1647523002

Cr-Commit-Position: refs/heads/master@{#371871}

Extracts the existing MediaSession usage from the browser media
player manager and moves it into the WebMediaPlayerDelegate where
it can be shared by both the desktop and android media players.

Notes:
- Removes RenderFrameObserver from all WebMediaPlayers since the
delegate observer interface handles all of their needs.
- The MediaStream WebMediaPlayer now has MediaSession support.
- Currently the WMPI has no concept of requesting permission to
play, the WMPA behavior has been preserved via a request to the
MediaWebContentsObserverAndroid from BrowserMediaPlayerManager.
- Fixes flakiness issues with the MediaSession tests which were
not completely waiting for playback to start before moving on
with test expectations.
- Extracts misplaced delegate messages from frame_messages.h and
puts them in their own media_player_delegate_messages.h file.
- During the message move, cleans up the player_cookie (a int64_t
pointer) in favor of a plain int. Renames messages for the better.
- Removes all delegate calls from the cast adapter since they are
always remote type which should be ignored anyways.
- |has_audio| is sticky in the MediaSessionController since WMPA
can't be relied upon to provide a true value and plumbing the
value from every MediaPlayerAndroid is non-trivial.
- Fixes MediaSession ContentShellTests which were passing on the
bots by happy circumstance -- the bots do not appear able to play
the .ogg files checked in -- instead instantly ending. Test were fixed
by adding .mp3 variants.

BUG=529887, 580626
TEST=new tests, existing MediaSession tests pass with and without
the unified media pipeline flag, manual verification of background
behavior.

Review URL: https://codereview.chromium.org/1570043002

Cr-Commit-Position: refs/heads/master@{#371870}

BUG=581758

Review URL: https://codereview.chromium.org/1640843002

Cr-Commit-Position: refs/heads/master@{#371869}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4c5aff546a57..fd3f2b38d1fb

$ git log 4c5aff546..fd3f2b38d --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1639403003

Cr-Commit-Position: refs/heads/master@{#371868}

When determining what field type to upload, if both PHONE_HOME_CITY_AND_NUMBER and PHONE_HOME_WHOLE_NUMBER are matched, it means there is no country code in the profile's phone number. In that case, only match PHONE_HOME_CITY_AND_NUMBER because it's more precise.

BUG=580629
TEST=AutofillManagerTest

Review URL: https://codereview.chromium.org/1623803002

Cr-Commit-Position: refs/heads/master@{#371867}

Fork Shelf View, Model, Button, TooltipManager, etc.
These provide a baseline of ash/shelf-like functionality.
(show open mash windows, support reordering, tooltips, etc.)

Restructure some ownership patterns (eg. shelf owns model).
Minimal code refactoring, removal and commenting.
(attempt to minimize diff, keep/stub some features)

TODO: Restore missing functionality/tests.

BUG=557406
TEST=mojo:mash_shell's shelf starts looking more like ash.
R=sky@chromium.org,bungeman@google.com

Review URL: https://codereview.chromium.org/1585363002

Cr-Commit-Position: refs/heads/master@{#371866}

This removes all the PLUGIN_PRINTF/MODULE_PRINTF calls from
components/nacl/renderer/plugin/.

There aren't very many of these logging calls left now.  They don't
look useful to have in release binaries, and it's against Chromium
style to keep this sort of logging in the code.  Anyone doing
debugging can manually add their own logging.

My main motivation here is to remove a non-standard logging mechanism
that depends on some native_client/ headers.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Review URL: https://codereview.chromium.org/1631413002

Cr-Commit-Position: refs/heads/master@{#371865}

BUG=493459

Review URL: https://codereview.chromium.org/1641783002

Cr-Commit-Position: refs/heads/master@{#371864}

Revert of mojo filesystem: Simplify full file reading/writing. (patchset #5 id:80001 of https://codereview.chromium.org/1634293002/ )

Reason for revert:
Broke the Windows build.

https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/10430/steps/compile/logs/stdio

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/filesystem/lib/directory_impl.obj.rsp /c ../../components/filesystem/directory_impl.cc /Foobj/components/filesystem/lib/directory_impl.obj /Fdobj/components/filesystem/lib_cc.pdb
e:\b\build\slave\win_x64_gn\build\src\components\filesystem\directory_impl.cc(274) : error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_x64_gn\build\src\components\filesystem\directory_impl.cc(274) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
ninja: build stopped: subcommand failed.

Original issue's description:
> mojo filesystem: Simplify full file reading/writing.
>
> One common pattern that's coming up multiple times is that we want to
> read or write the full contents of a file. The first attempt at an
> interface to that had was put on the File object.
>
> However, file seeking behaviour differs between platforms. Performing a
> seek on an empty file is safe on posix and errors on Windows. And when
> dealing with arbitrary File objects, we want to seek to the beginning
> just in case there was any previous usage on the File object.
>
> It was also cumbersome. The user was still responsible for opening the
> file and closing it once they were done with it. Putting these
> operations on Directory not only removes a bug, but also simplifies the
> interface.
>
> BUG=557405
>
> Committed: https://crrev.com/fd918ae590f61f145d75c800abb8eb050ca32b06
> Cr-Commit-Position: refs/heads/master@{#371845}

TBR=sky@chromium.org,erg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557405

Review URL: https://codereview.chromium.org/1643733002

Cr-Commit-Position: refs/heads/master@{#371863}

BUG=

Review URL: https://codereview.chromium.org/1634423002

Cr-Commit-Position: refs/heads/master@{#371862}

https://chromium.googlesource.com/skia.git/+log/ccfdaa5f2aee..2bbc343c1482

$ git log ccfdaa5f2..2bbc343c1 --date=short --no-merges --format='%ad %ae %s'
2016-01-27 ethannicholas switched to SkJSONCPP for JSON output GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639333002
2016-01-27 yujieqin Fix Windows build
2016-01-27 scroggo Stop testing SkImageDecoder in DM/nanobench
2016-01-27 yujieqin Enable RAW codec for Windows
2016-01-27 ebrauer It derives the dng_host and overrides PerformAreaTask() to split the task into several sub-tasks which get added to SkTaskGroup.
2016-01-27 yujieqin Fix complier issue [-Werror, -Wvla]

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1640353002

Cr-Commit-Position: refs/heads/master@{#371861}

In some cases this could save a copy of the outer object
(rareNonInheritedData in all cases.)
This also saves almost 3.5k of binary footprint.

BUG=581413

Review URL: https://codereview.chromium.org/1638213004

Cr-Commit-Position: refs/heads/master@{#371860}

- update ProgramPath to obtain program path on Windows

R=aizatsky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1635793002

Cr-Commit-Position: refs/heads/master@{#371859}

Daemon and desktop processes didn't have attachment brokers, and so the
desktop process was failing when trying to pass shared buffer to the
network process.

BUG=581174

Review URL: https://codereview.chromium.org/1634933007

Cr-Commit-Position: refs/heads/master@{#371858}

The previous theories haven't held up, so these crash keys will help
reveal how the proxy is being created.  They cover all the ways of
reaching the RenderFrameProxy constructor (i.e., RVI::Initialize,
RFI::OnSwapOut, and RTI::OnCreateNewFrameProxy).

BUG=575245
TEST=New crash keys present in crash reports.

Review URL: https://codereview.chromium.org/1643673002

Cr-Commit-Position: refs/heads/master@{#371857}

Revert of Introduce SelectionAdjuster to adjust selections between DOM tree version and composed tree version (patchset #2 id:20001 of https://codereview.chromium.org/1630903005/ )

Reason for revert:
This patch breaks text selection in DevTools console. Please see http://crbug.com/581800 for details

Original issue's description:
> Introduce SelectionAdjuster to adjust selections between DOM tree version and composed tree version
>
> This patch introduces |SelectionAdjuster| class to consolidate functions
> adjusting DOM tree version and composed tree version of selections in
> |VisibleSelection| class and |SelectionEditor| in one place to avoid having
> six parameters constructor, and rude name function |createWithoutValidation()|
> to simplify source code for improving readability.
>
> Note: For ease of reviewing to compare changes, this patch doesn't leave
> functions in original place. Following patch moves them to
> "SelectionAdjust.{cpp,h}".
>
> This patch is a preparation of introducing |m_hasTrailingWhitespace| into
> |VisibleSelection| class, which makes six parameters constructor to seven
> parameters constructor without this patch.
>
> BUG=n/a
> TEST=n/a; no behavior changes
>
> Committed: https://crrev.com/647b2143c21fade656c085f5a83426e96acbd38a
> Cr-Commit-Position: refs/heads/master@{#371697}

TBR=yoichio@chromium.org,hajimehoshi@chromium.org,tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=n/a

Review URL: https://codereview.chromium.org/1642723002

Cr-Commit-Position: refs/heads/master@{#371856}

static_cast should be used when casting within a class hierarchy.

BUG=None

Review URL: https://codereview.chromium.org/1639393002

Cr-Commit-Position: refs/heads/master@{#371855}

Revert of Move SelectionAdjust to its own file (patchset #2 id:20001 of https://codereview.chromium.org/1640623002/ )

Reason for revert:
This refactoring breaks text selection in DevTools console. Please see http://crbug.com/581800 for details

Original issue's description:
> Move SelectionAdjuster to its own file
>
> This patch moves implementations of |SelectionAdjuster| into its own file.
>
> This is a follow-up patch of http://crrev.com/1630903005, which introduces
> |SelectionAdjuster| into "SelectionEditor.cpp" and "VisibleSelection.cpp".
>
> BUG=n/a
> TEST=n/a; no behavior changes
>
> Committed: https://crrev.com/da8f47a0153b025331e2c8ed62c4f6510c63c703
> Cr-Commit-Position: refs/heads/master@{#371751}

TBR=tkent@chromium.org,yosin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=n/a

Review URL: https://codereview.chromium.org/1640913002

Cr-Commit-Position: refs/heads/master@{#371854}

This removes the cached activity copies from InterceptNavigationHandler
and ExternalNavigationHandler.

- Uses application context when it doesn't make any difference(For
  package manager related calls.)
- Tries to get the activity through the tab and if not fail gracefully
  either by early return or using application context for launching new
  activity.

BUG=546736

Review URL: https://codereview.chromium.org/1636573004

Cr-Commit-Position: refs/heads/master@{#371853}

BUG=

Review URL: https://codereview.chromium.org/1645653003

Cr-Commit-Position: refs/heads/master@{#371852}

That's a heavy function to call.  I removed the call.

The only thing it was being used for apparently was to get the port.
Frankly, I don't see much importance in checking the port of
search engines, but I added port_ and a cached internal variable
to maintain this support and entirely removed the heavy call.

For reference, the port line was part of a large change
https://chromium.googlesource.com/chromium/src/+/5b30787532fe44ff67e29fbbedfb1781663a4f06%5E%21/#F8
for which there was no motivating discussion about the need to check
ports.  I guess there's no harm in it though.

BUG=

Review URL: https://codereview.chromium.org/1595103007

Cr-Commit-Position: refs/heads/master@{#371851}

Instead of creating the Path object up front - when the StylePath is
created - create it on first access/use (usually on paint/layout.)

Review URL: https://codereview.chromium.org/1640313002

Cr-Commit-Position: refs/heads/master@{#371850}

Adds reporting of errors for the errors detected:

 * Missing starting moveto
 * Missing command verb
 * Unexpected input type (number, arc flag)

The parsing helper parseArcFlag() is adjusted to not consume any
character on error.

BUG=231612

Review URL: https://codereview.chromium.org/1642463004

Cr-Commit-Position: refs/heads/master@{#371849}

Use Noto Color Emoji instead of Noto Sans Emoji.

In an upcoming update, Noto Sans Emoji is also renamed Noto Emoji.

https://chromium-review.googlesource.com/320493 will be landed after this.

BUG=574585

Review URL: https://codereview.chromium.org/1562623002

Cr-Commit-Position: refs/heads/master@{#371848}