GitLab

I have been trying to see why the JavaBridgeChannelHost, which is reference counted, sticks around forever.

Here is what I found:

When talk back is enabled. Each JavaBridgeChannelHost typically have 5 references to it. 3 of them should be cleaned up by this patch. (see comments in the .cc file)

BUG=157699


Review URL: https://chromiumcodereview.appspot.com/11359143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170694 0039d316-1c4b-4281-b951-d872f2087c98

"drive_file_path" was unused...

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/11412295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170693 0039d316-1c4b-4281-b951-d872f2087c98

This is just a stub for now so I can iterate on it with follow up changes to
implement the real stuff.

views_examples_exe will be built directly on top of AURA API.

BUG=141187
TEST=out/Debug/views_examples_exe
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11421176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170692 0039d316-1c4b-4281-b951-d872f2087c98

This is a combination of https://codereview.chromium.org/11308302/ and https://codereview.chromium.org/11434064/, with some fixes to tests.

BUG=153137
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/11411308

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170689 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160903
Test=Manual

Review URL: https://chromiumcodereview.appspot.com/11417150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170688 0039d316-1c4b-4281-b951-d872f2087c98

Use SpdySessionDependencies in HttpNetworkTransaction and
HttpProxyClientSocketPool tests, instead of hand-rolled alternatives.BUG=


Review URL: https://chromiumcodereview.appspot.com/11348333

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170687 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133088
TBR=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11434074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170686 0039d316-1c4b-4281-b951-d872f2087c98

This should pass now.

TBR=rogerta@chromium.org
BUG=163630
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11414280

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170685 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170683 0039d316-1c4b-4281-b951-d872f2087c98

I left the unittest in ash still for the time being as it requires a bunch of stuff from ash too (mostly the activation logic which is still in progress for Corewm).

http://crbug.com/162100
R=rouslan@chromium.org
Review URL: https://codereview.chromium.org/11316287

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162923


Review URL: https://chromiumcodereview.appspot.com/11348284

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170678 0039d316-1c4b-4281-b951-d872f2087c98

This CL depends on https://codereview.chromium.org/11280159/

BUG=158265
TEST=Manually done on lumpy

Review URL: https://chromiumcodereview.appspot.com/11428049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170677 0039d316-1c4b-4281-b951-d872f2087c98

Currently if you reuse the same trace-dir, your previous traces will be
overwritten. This will number the outputs. Particularly useful if you use
the repeat flags (--page-repeat, --pageset-repeat). See if you like the idea.

Also contains a minor fix to the repeat flags, which didn't convert the input
value to int before trying to use it.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11434040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170676 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116954


Review URL: https://chromiumcodereview.appspot.com/11348275

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170675 0039d316-1c4b-4281-b951-d872f2087c98

- Layout test windows starting from (1,1) and move
  mouse to (0,0) so that they don't overlap unless
  test moves the cursor.
- Enabled disabled tests.
- RootWindowHostWin::SetBounds should move the window
  and call OnHostResized when the scale factor has changed.

This also seems to fix the desktop size limitation issue (148691)
probably because a popup window can be larger than the desktop size.

BUG=150986,157817,141577,148691
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170621

Review URL: https://chromiumcodereview.appspot.com/11428066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170673 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161992


Review URL: https://chromiumcodereview.appspot.com/11348299

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170672 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317,161776
TEST=manual, browser_tests not running on ARM

Review URL: https://chromiumcodereview.appspot.com/11412293

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170671 0039d316-1c4b-4281-b951-d872f2087c98

In the case of Japanese, IME shows word usage or its description. This
feature is already supported in Chrome OS native ibus IME engines.
With this patch, Chrome supports same feature for Extension IME.

This change does not affect existing extension implementation in terms of
backward compatibility.

BUG=158486
TEST=manually done one lumpy.


Review URL: https://chromiumcodereview.appspot.com/11412268

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170670 0039d316-1c4b-4281-b951-d872f2087c98

This continues the work of these two CLs:
https://chromiumcodereview.appspot.com/10983023
https://chromiumcodereview.appspot.com/11293235

SSLServerSocketNSS does not use NSS HTTP IO, so it doesn't need
to include nss_ocsp.h.

Use defined(OS_MACOSX) && !defined(OS_IOS) to detect Mac OS X
(excluding iOS).

R=blundell@chromium.org,droger@chromium.org,rsleevi@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/11434009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170669 0039d316-1c4b-4281-b951-d872f2087c98

instead of a single item at a time.

BUG=143124
TEST=Covered by content_unittests

Review URL: https://chromiumcodereview.appspot.com/11421103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170668 0039d316-1c4b-4281-b951-d872f2087c98

storage info provider in a way of polling the free space 
changes at a regular time interval.

BUG=141229
TEST=unit_test --gtest_filter=StorageInfoProviderTest.*

Review URL: https://chromiumcodereview.appspot.com/11415177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170667 0039d316-1c4b-4281-b951-d872f2087c98

R=shishir@chromium.org
Review URL: https://codereview.chromium.org/11412288

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170666 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130980

Review URL: https://chromiumcodereview.appspot.com/11348263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170665 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170662 0039d316-1c4b-4281-b951-d872f2087c98

Keep browser process alive while there are platform apps with background pages running. This does not happen on Android or ChromeOS builds: Android does not support browser process keep alive, and ChromeOS does not need or like it.

This change prevents platform apps getting killed unceremoniously while they have background pages active.

This also delays the process being shutdown after closing the last platform app window, as background pages are kept alive for 15 seconds after their last activity is completed.

This change re-lands r165772 which caused problems on Google branded ChromeOS. This version does not add keep alives for ChromeOS and was tested on the ChromeOS try bots.

TBR=davemoore@chromium.org for the ash launcher test change.

BUG=155457
TEST=Make sure platform apps can be used from the launcher without chrome windows open; make sure Chrome shuts down properly in all cases.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165772

Review URL: https://chromiumcodereview.appspot.com/11117011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170660 0039d316-1c4b-4281-b951-d872f2087c98

Revert 170658. r170654 had moved these tests to interactive_ui_tests, which is needed for notification tests on aura.

> Revert r170623 "Convert HTML5 notification pyauto tests to browser_tests."
> 
> TBR=chrisgao@chromium.org
> BUG=none
> TEST=none
> NOTRY=true
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11434073

TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/11316295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170659 0039d316-1c4b-4281-b951-d872f2087c98

TBR=chrisgao@chromium.org
BUG=none
TEST=none
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11434073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170658 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11415249

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170657 0039d316-1c4b-4281-b951-d872f2087c98

The EventDispatcher dispatches all events to EventHandler::OnEvent. The default
implementation routes various events to more appropriate handlers (e.g. OnKeyEvent
for KeyEvent etc.)

BUG=163606

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170641

Review URL: https://codereview.chromium.org/11299285

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170656 0039d316-1c4b-4281-b951-d872f2087c98

Makes it possible to specify the number of worker threads used to
rasterize content.
    
BUG=154637
TEST=manual
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11421171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170655 0039d316-1c4b-4281-b951-d872f2087c98

Move new desktop notification tests to interactive_ui_tests because they fail on win_aura. These were just added in r170623

Like the other notification tests that were moved to interactive_ui_tests, these tests require the user to be logged in which is the case for interactive_ui_tests. 

BUG=163196, 154081
TBR=scottmg
Review URL: https://codereview.chromium.org/11308309

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170654 0039d316-1c4b-4281-b951-d872f2087c98

It seems to be working now that the drivers have been updated.

BUG=163229


Review URL: https://chromiumcodereview.appspot.com/11412263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170652 0039d316-1c4b-4281-b951-d872f2087c98

Most of connection management stuff is moved to chromeos/dbus/ibus/ibus_config_client

This CL depends https://codereview.chromium.org/11413165/

BUG=158265
TEST=Manually done on lumpy

Review URL: https://chromiumcodereview.appspot.com/11419202

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170651 0039d316-1c4b-4281-b951-d872f2087c98

Following minor fixes are included:
- handling mouse up event outside of the area
- the display text is not selectable by -webkit-user-select
- hide 'Make primary' button rather than disabling it
- fix the position of white pointing arrow
- changes the space between "mirroring" and "make primary" button
- fix the position of display name text so that it won't change when the display gets the focus
- remove 'dirty' flag.  rather checks if the drop position is exactly same as the original position or not.
- changes the background mirroring display rectangle from dash to solid, also changes the margin between displays in mirroring to 2.

BUG=163546
TEST=make sure by operating in chrome://settings/display on an actual device.


Review URL: https://chromiumcodereview.appspot.com/11414276

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170650 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158341


Review URL: https://chromiumcodereview.appspot.com/11308274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170649 0039d316-1c4b-4281-b951-d872f2087c98

- Remove some unnecessary calls.
  Builder now only compiles and uploads.
  Tester now only runs standard tests.

TBR=yfriedman@chromium.org
BUG=160952
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11412292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170648 0039d316-1c4b-4281-b951-d872f2087c98

> events: Dispatch all events through EventHandler::OnEvent from the dispatcher.
> 
> The EventDispatcher dispatches all events to EventHandler::OnEvent. The default
> implementation routes various events to more appropriate handlers (e.g. OnKeyEvent
> for KeyEvent etc.)
> 
> BUG=163606
> 
> Review URL: https://codereview.chromium.org/11299285

TBR=sadrul@chromium.org
Review URL: https://codereview.chromium.org/11414283

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170647 0039d316-1c4b-4281-b951-d872f2087c98

This avoids races, and is no more overhead than the other many
long-lived browser threads that are kept about

BUG=158112
TEST=ran "chrome --single-process" on linux, open & close tabs.

Review URL: https://chromiumcodereview.appspot.com/11314014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170644 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/chromium-rel-win7-dual/dom_perf/report.html?history=550&rev=170452
-> rebaseline, noisy

http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=150&rev=170399
-> rebaseline, noisy

http://build.chromium.org/f/chromium/perf/linux-release-lowmem/dom_perf/report.html?history=250&rev=170467
-> rebaseline, noisy

BUG=None
TBR=cmp

Review URL: https://codereview.chromium.org/11418278

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162926

Review URL: https://chromiumcodereview.appspot.com/11413199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170642 0039d316-1c4b-4281-b951-d872f2087c98