- 01 Mar, 2018 40 commits
-
-
Ahmed Fakhry authored
We observed that users who need this feature get very confused and lost when the mouse cursor goes into the magnifier viewport. This CL makes it work as expected by confining the cursor outside the viewport. BUG=815208 TEST=Added test coverage Change-Id: If93ea59a2d0cca7f48f9da47dd28dc395c25bc85 Reviewed-on: https://chromium-review.googlesource.com/940261Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#539999}
-
Nate Chapin authored
Will reenable on trunk after the M66 branch point passes. M67 is the new target. Bug: 624061 Change-Id: Ied8563bbc21d3df3182a80aa5f5d1706ed0224d4 TBR=nasko@chromium.org,ojan@chromium.org,japhet@chromium.org Change-Id: Ied8563bbc21d3df3182a80aa5f5d1706ed0224d4 Reviewed-on: https://chromium-review.googlesource.com/941615 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#539998}
-
Cody Peterson authored
Properly update the root window bounds after updating the root transform. Previously, the call to window()->SetTransform() would update the transform, but it would not call UpdateRootWindowSizeInPixels(). The call to this function is what updates the root window bounds rect with the new transform after it is set. Using the translation + rotation transforms, if the base WindowTreeHost::UpdaterootWindowSizeInPixels() function is used, you end up with bounds represented by a rect with it's own origin not actually at (0,0). For example, with a rotation of 270 degrees applied to a 600x1024 display, you end up with bounds represented as a rect with its origin at (-1, 508) and its other corner at (1228, 1228) in the device-independent coordinates. By overriding this function in CastWindowTreeHost, after the new transform is applied to the root window bounds, these bounds are shifted back so that their origin is at (0,0). This allows located events to properly check whether or not they are contained within the root window. BUG=None TEST=Check touch events on displays with rotation applied. Change-Id: Ib5c5ec2ab9d82cd2f589bc6301e4b7b6dd712c5c Reviewed-on: https://chromium-review.googlesource.com/941728Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Cody Peterson <crpeterson@chromium.org> Cr-Commit-Position: refs/heads/master@{#539997}
-
Tsuyoshi Horo authored
Bug: 817668 TBR: vmpstr@chromium.org Change-Id: I3014686dd916acf90c4f970714d7e1206c1672b1 Reviewed-on: https://chromium-review.googlesource.com/942501Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#539996}
-
Carlos Knippschild authored
Introduce new code patterns to improve the likeliness that future changes to the elements of PrefetchItemState will be properly handled. A new |kOrderedPrefetchItemStates| complements the enum definition by providing the full listing of existing states. A new test also checks that changes to the enum are reflected in this listing. The implementation of GetAllStatesExcept was updated to use this official state list and accept a collection of states to filter from its result. New calls to this function were also added from tests where created a local listing of arbitrary states, what should guarantee that new or changed state values would have to be dealt with. Finally uses of `default` in switch blocks for PrefetchItemState were replaced with the full listing of all possible states so that build errors would guide the proper handling of all states. Bug: 701939 Change-Id: I2f303c6922795f509f8046000fdd286c5e0affa9 Reviewed-on: https://chromium-review.googlesource.com/937944 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#539995}
-
Konstantin Ganenko authored
Previously OnCaptureFailure could be called just after CaptureAsync call in case, when view actually was absent. That led to 2 calls of SendResponse. Extension functions are designed to receive 1 response on each call, so 2 calls is bad behavior. Now web capture clients behavior fixed. R=fsamuel@chromium.org, tbarzic@chromium.org Change-Id: I2ce195aaa3698d9c38ca2fa0e3735e6f9555f873 Reviewed-on: https://chromium-review.googlesource.com/930762 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539994}
-
Joshua Bell authored
Bug: 161072 Change-Id: I00c00e649c4248349e24f7a2d9cf2d4de25294ff Reviewed-on: https://chromium-review.googlesource.com/940334Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#539993}
-
Darren Shen authored
This patch implements shorthands for stylemap.set/delete. When we receive an UnsupportedShorthandProperty, we should get the CSSValues out of them and set them on the style map. We leave parsing of shorthand values for a future patch. Bug: 816722 Change-Id: Iebd0b33f89b1d8872bea5d3f80d1dde71d72bc45 Reviewed-on: https://chromium-review.googlesource.com/938684 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#539992}
-
Alexander Alekseev authored
This CL adds setTabletModeState sceen object method and event flow to update this status in runtime. Also illustration on the OOBE screen now depends on the device status. Bug: 792719 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I13a5dfb55630fe6b8debb022ca4a04529acdff52 Reviewed-on: https://chromium-review.googlesource.com/939049 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#539991}
-
Theresa authored
Remove BottomSheetNewTabController and related logic BUG=814528 Change-Id: If02ad59bebdd6daeb45821807bfa11716cf2b361 Reviewed-on: https://chromium-review.googlesource.com/910007Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#539990}
-
Tibor Goldschwendt authored
Also adds an opacity animation for showing and hiding the dialog. Bug: 815003 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I41648642627bba712e0d4106bcaba536d0480e45 Reviewed-on: https://chromium-review.googlesource.com/941547Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#539989}
-
Robert Ma authored
https://crrev.com/c/766652 moved some tests in paint/invalidation into subdirectories. The corresponding entries in SmokeTests weren't updated accordingly, causing these tests not running on Android. This CL fixes this issue. Change-Id: I24e7941b5ee26a9a9071cff5757ac3368907d6fc Reviewed-on: https://chromium-review.googlesource.com/941823Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539988}
-
Yuwei Huang authored
This CL passes feedback data created from ChromotingSession to the HelpAndFeedback instance, so that it can be later attached to the feedback report. This CL is coupled with an internal CL: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/578187 Bug: 814863 Change-Id: I83c41ec7850ab5bd6852e54438ab120aab65656c Reviewed-on: https://chromium-review.googlesource.com/940265 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#539987}
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/25322-[1-5].html" to utilize |selection_test()| and put them into "25322-1.html", since these tests use similar test input, for ease of maintenance. Following-patch will rename "25322-1.html" to "delete_after_block_image.html". Note: This patch is a preparation of the patch[1]. [1] http://crrev.com/c/938871 Make SelectionAdjuster to handle collapsed selection correctly Bug: 679977 Change-Id: I918ba66f7a7f899467eaf7a05255a1ca414fd658 Reviewed-on: https://chromium-review.googlesource.com/940726Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539986}
-
Katie D authored
Selection can be messy if it goes across multiple types of containers. This change is meant to make Select-to-Speak more robust to different types of selections, and adds a lot of tests to help keep STS from regressing in the future. There are still several odd selection cases known that are not solved, and any other strange selection tests would be appreciated. There are also some small logic changes in select_to_speak function to process selected nodes better. Bug: 803160 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I015a58bae245bc5cab0f1f79b3c758d7456e1b37 Reviewed-on: https://chromium-review.googlesource.com/879091 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#539985}
-
Michael Thiessen authored
Android task stacks are a confusing mess. For some reason starting the animation cancel activity in its own task stack is leading to a less- recent CTA instance being resumed instead of the CCT that invoked the animation cancel. We can fix this by not starting the animation cancel in a new task stack. Bug: 817476, 817503 Change-Id: I99fe4583c02c9c5c2333697166e6e4081ad4f818 Reviewed-on: https://chromium-review.googlesource.com/941912Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#539984}
-
bsheedy authored
Adds code to the VR Telemetry benchmarks to support the copying of the VR browsing assets that are normally downloaded via component updater onto the device before each story run. This allows the assets to be used without actually downloading anything. Bug: 808465 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I320c14e16eb411dd0bf29c57a330e3825fe4dcd6 Reviewed-on: https://chromium-review.googlesource.com/938398 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#539983}
-
arthursonzogni authored
Here "ResourceHandler" refers to the NavigationResourceHandler or the MojoAsyncResourceHandler depending on whether NavigationMojoResponse is enabled or not. It adds two histograms: * Navigation.ResourceHandler.ResponseStartedUntilProceedWithResponse * Navigation.ResourceHandder.ProceedWithResponseUntilStartLoadingResponseBody. It records the time delta between these 3 events. 1) OnResponseStarted(). 2) ProceedWithResponse(). 3) OnReadCompleted() is called for the first time. Bug: 705744 Change-Id: I10e26016df13b9f9a7c0687774986f8775ce59c3 Reviewed-on: https://chromium-review.googlesource.com/937516 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#539982}
-
Tsuyoshi Horo authored
This reverts commit 07c7facb. Reason for revert: Caused build error https://ci.chromium.org/buildbot/chromium.linux/Fuchsia%20ARM64%20Cast%20Audio/5780 ../../chromecast/media/cma/backend/stream_mixer_unittest.cc:423:13: error: unused function 'DeathRegex' [-Werror,-Wunused-function] std::string DeathRegex(const std::string& regex) { ^ 1 error generated. Original change's description: > Reland "[Chromecast] Update mixer unittests" > > This reverts commit d0ca87de. > > Added ifdef guard for death tests. > > Bug: internal b/71559266 > Change-Id: I204a00d7a1759a4a18407f5162843366e9229da5 > Reviewed-on: https://chromium-review.googlesource.com/941789 > Reviewed-by: Scott Graham <scottmg@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Commit-Queue: Kenneth MacKay <kmackay@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539976} TBR=halliwell@chromium.org,scottmg@chromium.org,kmackay@chromium.org Change-Id: I05ba642b66d4bb1e2f1eb8fe8e86c705b361a9a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: internal b/71559266 Reviewed-on: https://chromium-review.googlesource.com/942422Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#539981}
-
Charles Harrison authored
Currently, tab-unders require that the tab has opened a popup since the last user gesture in the tab. However, we check this condition on every navigation redirect, which is wrong. For example: 1. Navigate to a.com 2. Start a navigation without a user gesture to b.com 3. Open a popup 4. Navigation from (2) redirects and should not be blocked. This is fixed by checking the popup condition once at the start of the navigation. This CL also makes a couple of `bool` members const. Bug: 817514 Change-Id: I9ddcd383fa299d8d560889b2d0e393114b5afa96 Reviewed-on: https://chromium-review.googlesource.com/941923Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#539980}
-
gogerald authored
Bug: 812297 Change-Id: Ifb855b4e52ed3fde171569a017fa856cad5cc2dd Reviewed-on: https://chromium-review.googlesource.com/940324 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#539979}
-
Simeon Anfinrud authored
Added some features to reactive framework to make this smooth. This is one step to refactoring CastWebContentsActivity and adjacent classes to be testable. The ultimate goal is to express the logic of CastWebContentsActivity and other classes in terms of observable events, with the Activity, Service, and Fragment classes being thin adapters from Android API events to reactive Observables. That will let us cleanly separate concerns in the behavior classes and mount them in lightweight, potentially non- Robolectric test fixtures. Bug: Internal b/36777136 Test: cast_base_junit_tests, cast_shell_junit_tests Change-Id: Iacdeb0084e34d99193fc2733c2dbd42d9560b16a Reviewed-on: https://chromium-review.googlesource.com/929892 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#539978}
-
Theresa authored
We use a narrow snackbar on tablets, so a different background asset is needed to show shadows on all edges of the white snackbar. For now, don't use the modern snackbar on tablets. BUG=817518 Change-Id: I49bb4f6a14cf804e719d433db9f26192a52a9495 Reviewed-on: https://chromium-review.googlesource.com/941506Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#539977}
-
Ken MacKay authored
This reverts commit d0ca87de. Added ifdef guard for death tests. Bug: internal b/71559266 Change-Id: I204a00d7a1759a4a18407f5162843366e9229da5 Reviewed-on: https://chromium-review.googlesource.com/941789Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#539976}
-
Nate Fischer authored
No change to behavior, this only adds a comment. This adds a comment explaining why we're going to ignore the StaticFieldLeak lint warning. There is no real leak because the task doesn't run for a long time. Bug: 804422 Test: N/A Change-Id: I5a70a04a4eb5eed748f20a2396ea8dad3b86770c Reviewed-on: https://chromium-review.googlesource.com/942029Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539975}
-
Tibor Goldschwendt authored
Bug: 762588 Change-Id: I73723544788847a2209155eec756c7573dfe7b1d Reviewed-on: https://chromium-review.googlesource.com/788891Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#539974}
-
John Chen authored
Change-Id: I5ae7c91a864a9c760965d38296ae5dbf4cf3fbec Reviewed-on: https://chromium-review.googlesource.com/940166Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539973}
-
Mark Pearson authored
Bug: 726044 Change-Id: Id607c942778e89fc4c1e89b372196a5c711ce51b Reviewed-on: https://chromium-review.googlesource.com/940820Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#539972}
-
Peter Wen authored
This reverts commit 6d411ef0. Reason for revert: Failed perf builders with division by zero Original change's description: > Supersize: Fix pak spurious deltas > > Previously we recorded the exact pak compression ratios in .size files. > This results in minor changes to 1k+ unrelated symbols due to changes in > compression. Use a mostly accurate static constant instead to make .size > files comparable across runs. > > Bug: 814078 > Change-Id: I63c78379898ef02885ae86e0b95df95d51965918 > Reviewed-on: https://chromium-review.googlesource.com/938122 > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539252} TBR=wnwen@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 814078,817534 Change-Id: I5cd4a6375e1f318c3559801da95a850f5ffcf4fa Reviewed-on: https://chromium-review.googlesource.com/942061Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539971}
-
Reid Kleckner authored
It's unlikely that pruning the cache will resize the hash table, but this makes a copy of the scoped_refptr just in case. R=drott@chromium.org BUG=812600 Change-Id: I5a6256b9079e9c7f36249cadbb679189f0248afd Reviewed-on: https://chromium-review.googlesource.com/852531Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#539970}
-
Tsuyoshi Horo authored
This reverts commit 878a6bb6. Reason for revert: Caused build error https://ci.chromium.org/buildbot/chromium/Linux%20x64/59639 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F59639%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout In file included from ../../chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate_stub.cc:6: ../../chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate.h:12:10: fatal error: 'chrome/common/extensions/api/easy_unlock_private.h' file not found #include "chrome/common/extensions/api/easy_unlock_private.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Extension API: Move easyUnlockPrivate API to be CrOS-only. > > This is true in practice and is the next step in making SmartLock > CrOS-only. > > Bug: 817115 > Test: Existing tests > Change-Id: I38560b7d35859f65148a6a6cbbb9e4a66e7955a5 > Reviewed-on: https://chromium-review.googlesource.com/940538 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Toni Barzic <tbarzic@chromium.org> > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539965} TBR=tbarzic@chromium.org,jhawkins@chromium.org,lazyboy@chromium.org,benwells@chromium.org,karandeepb@chromium.org Change-Id: Ib5425ec7d3c9283a6fcb776a11c6a1a2f6b61efe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 817115 Reviewed-on: https://chromium-review.googlesource.com/942421Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#539969}
-
Nico Weber authored
Bug: 693709 Change-Id: I4e846d36fac5ca170c47c8e20906b0cf2715fbf5 Reviewed-on: https://chromium-review.googlesource.com/941904Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#539968}
-
file:///android_res/Torne (Richard Coles) authored
The removal of GetApplicationContext accidentally removed the parameter used to try shorter versions of the package name if the R class isn't found in the original package name, reintroducing crbug.com/599869 that this logic was written to fix. Put the package name parameter back so that stripping off elements of the package name actually has an effect. Bug: 599869 Change-Id: Iad5e0174052b1362c8fe7e86089655e3fd60b847 Reviewed-on: https://chromium-review.googlesource.com/941591Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539967}
-
Fan Yang authored
Turn on FLAGS_quic_reloadable_flag_quic_use_write_index. Increase acceptable time delta from 1 min to 2 mins. Merge internal change: 186930823 https://chromium-review.googlesource.com/c/chromium/src/+/937681 Deprecate FLAGS_quic_reloadable_flag_quic_fix_sequencer_buffer_block_count2. Merge internal change: 186669590 https://chromium-review.googlesource.com/c/chromium/src/+/937661 In QuicDispatcher: - Rename 'client_address' to 'peer_address' when it makes sense, i.e. if a variable named 'client_address' may not contain the actual client address, it is renamed to 'peer_address'. - For symmetry, rename 'server_address' to 'self_address'. Merge internal change: 186664180 https://chromium-review.googlesource.com/c/chromium/src/+/937587/1 Use QuicMakeUnique when initializing an unqiue_ptr. Merge internal change: 186475749 https://chromium-review.googlesource.com/c/chromium/src/+/937565/1 Replace FLAGS_quic_reloadable_flag_quic_enable_version_42 with FLAGS_quic_reloadable_flag_quic_enable_version_42_2. Merge internal change: 186384559 https://chromium-review.googlesource.com/c/chromium/src/+/937586/1 Remove unused Randomize() function from quic_http_frame_decoder_state_test_util. Merge internal change: 186374471 https://chromium-review.googlesource.com/c/chromium/src/+/937564/1 In QUIC, let session unblock stream in UpdateSendWindowOffset. So that in QuicStream::OnCanWrite, we can directly return after stream retransmits lost data. Protected by existing FLAGS_quic_reloadable_flag_quic_streams_unblocked_by_session2. Also add DCHECK after stream's OnCanWrite to make sure that if a stream has buffered data and it is not stream flow control blocked, it must be in the session's write blocked list. Merge internal change: 186305642 https://chromium-review.googlesource.com/c/chromium/src/+/937584/1 In QUIC, framer incrementally report ack ranges to the connection, also stop appending timestamps in ack frame. Protected by FLAGS_quic_reloadable_flags_quic_incremental_ack_frame. Merge internal change: 185827616 https://chromium-review.googlesource.com/c/chromium/src/+/937561/1 Change-Id: I0299a5c489eabd0ce47a21af9ba0093631c21b2c Reviewed-on: https://chromium-review.googlesource.com/941586Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#539966}
-
James Hawkins authored
This is true in practice and is the next step in making SmartLock CrOS-only. Bug: 817115 Test: Existing tests Change-Id: I38560b7d35859f65148a6a6cbbb9e4a66e7955a5 Reviewed-on: https://chromium-review.googlesource.com/940538Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#539965}
-
Thomas Tangl authored
Instead of using the full name in the settings sync promo, only the first name should be used. This CL fixes this. Bug: 810865 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib707abeebe65f8d5b02cfa94dca75c00596997e7 Reviewed-on: https://chromium-review.googlesource.com/941202 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539964}
-
Stephen Martinis authored
Adds the compile builder, and the tester. Bug: 790710, 790644 Change-Id: Ie7184a94b0ec7e518aa65a96432880529c1920c7 Reviewed-on: https://chromium-review.googlesource.com/940423Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#539963}
-
Mitsuru Oshima authored
* Start resizing upon resize request from client. * Client can start drag only if 1) mouse is pressed on the shell surface. 2) gesture is on progress. This CL includes a fix for potential issue when the drag to resize/move was requested when the mouse/touch drag wasn't in progress. BUG: b/72918846 TEST: covered by unit test Change-Id: Id32f9da7a2c718fdaef1cb0e4a4adb3b99cbd7f8 Reviewed-on: https://chromium-review.googlesource.com/938498 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#539962}
-
Weiliang Chen authored
Trying to access GL will crash vulkan build. Only create sync queries when it can be used. R=enne Bug: 644851 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibffe46608195541ab094aae9de4161871c1ab2b1 Reviewed-on: https://chromium-review.googlesource.com/941383Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#539961}
-
Katie D authored
Bug: 806169 Change-Id: Ibd56a9c4d281b2826901cceb07d5f84e7a6ab1c8 Reviewed-on: https://chromium-review.googlesource.com/941411Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#539960}
-