- 02 Dec, 2019 40 commits
-
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGRadialGradientElement> as new downcast helper 2. Use IsA<SVGRadialGradientElement>(element) in place of IsSVGRadialGradientElement(element) Bug: 891908 Change-Id: I2ae9b50ca2eb0617da5fd2838bf95a991fe00a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936617Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#720490}
-
Guido Urdaneta authored
Add Timeout to http/tests/devtools/compiler-script-mapping.js expectations since the test times out flakily. Bug: 1016772 Change-Id: I3b2b148d03df3c02b94e30f8943c11e30bfde343 TBR: rreverser@google.com No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946478Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#720489}
-
Geoff Lang authored
This test is flaky, most likely because initialization is not occuring. TBR=ynovikov@chromium.org NOTRY=true BUG=1017162 Change-Id: I252aed96b39a7dba2e71257090e48f10d7a1bce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944281Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#720488}
-
Jan Scheffler authored
This cl adds the tests for crrev.com/c/1944331. Fixed: 1029489 Change-Id: I35214f184a1ef53ea8f17b74923f48bd76200102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943142 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#720487}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 891670 Change-Id: Ib0e7dffcd366ce0a98793231e11386a83620828c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945169 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#720486}
-
Elly Fong-Jones authored
This change: 1) Filters a few components out of the Unconfirmed query. These are high-traffic components with their own triage processes for unconfirmed bugs. 2) Adds a new query for untriaged Mac-specific bugs without the Mac label, again excluding some components with their own triage processes. 3) Modifies the meeting process to also triage bugs in the query from (2) Bug: None Change-Id: I941102a180dd3c35a5be15ad4cefa2d4cac3b0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934590Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#720485}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::SystemInfo from ServiceLifetimeTestTemplate and AudioServiceLifetimeConnectorTest using Remote instead of SystemInfoPtr. Bug: 955171 Change-Id: I9401511be706730e5cae23c02017c3df963be94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942684 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#720484}
-
Mugdha Lakhani authored
Only allow Periodic Background Sync registration if the requesting origin has a main frame host present. Add browsertests to verify this behavior. Corresponding PR against the spec: https://github.com/WICG/BackgroundSync/pull/160 Bug: 1029712 Change-Id: I1142578edbde62f3f27ae95b9ca602855df3543b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942433 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#720483}
-
Anand K. Mistry authored
Fixed: 1007832 Change-Id: If378af56a88dea07b90ee12ebadd407e967ad46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943490 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#720482}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/adfb6ba3..684d2057 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia2bb5ff51bfe4d6b2ebc77c171097d374c34df39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944383Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720481}
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I135f13de7b9cad69525db3d2d91b991c0e477a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944858Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#720480}
-
Eric Seckler authored
Write TrackEvent's type and name_iid fields instead of LegacyEvent's where possible. Also avoid creating the LegacyEvent if we don't need to set any of its fields. This should save us some trace size in the (probably common) case where we don't need to set any special LegacyEvent flags, e.g. for END events of former COMPLETE events. Also removes a few remaining remnants of emitting complete events. Bug: 1029510, 1029465 Change-Id: If544f5e2dff97660ba7523605d20d09e29b26da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944393 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#720479}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/48c9ef678756..227ae8212a3d git log 48c9ef678756..227ae8212a3d --date=short --first-parent --format='%ad %ae %s' 2019-12-02 janscheffler@chromium.org Add warnings for manifest icons 2019-12-02 janscheffler@chromium.org Add a preview to svg image elements 2019-12-02 aerotwist@chromium.org Adds license checker Created with: gclient setdep -r src/third_party/devtools-frontend/src@227ae8212a3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie37d2d377ec8847df8c73e68f0dd8f0fe4277cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946143Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720478}
-
Yifan Luo authored
Rather than setting `Sec-Fetch-User` in NavigationRequest::AddAdditionalRequestHeaders, it should be set in SetFetchMetadataHeaders along with the others. Bug: 1027528 Change-Id: I42c16dadceb7b4e69165bab67734a09747eb35a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930742Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Yifan Luo <lyf@google.com> Cr-Commit-Position: refs/heads/master@{#720477}
-
Tomas Popela authored
The main reason for the flag is so called dialog hell, when you try to share the screen on Wayland through PipeWire. To address it we've created two changes, that are currently under review[0][1]. Once that's done the flag could be removed. [0] - https://webrtc-review.googlesource.com/c/src/+/160649 [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1942327 Bug: 682122 Change-Id: I2b194f0b1612ca7f9865d0cb4a45f5b5aa5e1c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942647 Auto-Submit: Tomáš Popela <tomas.popela@gmail.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#720476}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for js_to_cpp::blink::ForTesting using PendingAssociatedRemote. It also updates BitFlipResponse with pending_associated_remote from js_to_cpp.mojom. Bug: 955171 Change-Id: Ia17d27ce0776591346af404975e52615234a77c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942685 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for network::mojom::DhcpWpadUrlClient using PendingRemote instead of DhcpWpadUrlClientPtr. Bug: 955171 Change-Id: Ib212551349dfc1d1519ebc987305e41577c52434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943785 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/modules/plugins as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below factory functions, - DOMMimeTypeArray::Create - DOMMimeType::Create - DOMPlugin::Create - DOMPluginArray::Create Bug: 939691 Change-Id: Ie9d3f6ffbf5b12de66714c134bf192a518055c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945954Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up comments for ProxyConfigClientRequest and ProxyResolvingSocketPtr which are old Mojo types. NOTRY=true Bug: 955171 Change-Id: Ia5f22ae4a02b9418ef84f96037bad3612d960de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945952Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for network::mojom::URLLoaderFactory using Remote. Bug: 955171 Change-Id: I6dddbfd4358ac3b63ced2472a134bcd82dc6de2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946173 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
Mark the following as flaky on all platforms: external/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects.html virtual/not-site-per-process/external/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Bug: 1027434 Change-Id: Ifbaf02b9d45955347aeb1d808d4cdff8a603001d TBR: avi@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944678Reviewed-by:
-
Tanmoy Mollik authored
Create new feature flag ShowSyncErrorInfoBar for launching this infobar on android. Design-doc: http://go/clank-sync-infobar Bug: 1009954 Change-Id: I0496ae59930be6469bbc1e4a2690c92e2594fb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936252Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#720469}
-
Colin Blundell authored
This CL provides an initial implementation of intent handling in WebLayer. Specifically, it matches Android WebView's implementation. To do so, it brings in WebView's default behavior as implemented by aw_content_browser_client.cc::ShouldOverrideUrlLoading() and AwContentsClient.java:sendBrowsingIntent(), augmenting that default behavior with the Android WebView shell's internal handling of browser-specific URIs as implemented in WebViewBrowserActivity.java:startBrowsingIntent(). One exception to the above is that unlike WebView, this implementation starts the activity with the FLAG_ACTIVITY_NEW_TASK flag set. It is necessary to set this flag because the application context, which is used here to start the activity for the intent, isn't an Activity. Setting this flag also matches Chrome's behavior for launching external intents. We explored an alternative implementation wherein we would plumb the Activity that is available in BrowserFragmentImpl.java all the way to TabImpl.java via BrowserViewController.java, and then have TabImpl.java implement the handling of external intents. However, we preferred going with this implementation as it's simpler. To test, install the Alipay app, go to alipay.com in WebLayer Shell, tap "Open", and verify that the Alipay app is opened. I tried to add instrumentation tests but ran into blockers described at crbug.com/1029710. Change-Id: Ibc5ea1ce22875e85bc8f915856d754f52ed760e2 Bug: 1028745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942337 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#720468}
-
Rayan Kanso authored
Bug: 1024911 Change-Id: I37b5e4606f982f15a2e30c397de7183027940bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928772Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3af1ae4c5509..3d978726cc5a Created with: gclient setdep -r src-internal@3d978726cc5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I1a122d3dc0a53c2c7f87038a1ef0ed019d319ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946448Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720466}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1743241c4bad..1236f9cb9e83 git log 1743241c4bad..1236f9cb9e83 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 rslawik@google.com Merge "Add all matched packages to process metadata" 2019-12-02 hjd@google.com Merge "fuzzer: Remove bad CHECK on Send" Created with: gclient setdep -r src/third_party/perfetto@1236f9cb9e83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6b134ed6cd795dbd18a87e262861b575d7856f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945917Reviewed-by:
-
Alex Ilin authored
This CL adds a new LiveSignInTest::CancelSync to the suite of live signin tests. The test does the following: - Starts the signin flow from the settings page - Enters test account credentials on the login page - Cancels the sync confirmation dialog - Checks that Sync is disabled and there are no accounts in Chrome and on the web Bug: 1008888 Change-Id: I2480fc7eed0b927048b11894e75e859abb31c917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946371 Commit-Queue: Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#720464}
-
Guido Urdaneta authored
Bug: 1027481 Change-Id: I7fc1806eada39c58f3f6035736bf9d5c595fbb0b TBR: pwnall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946331Reviewed-by:
-
Jan Scheffler authored
This cl depends on crrev.com/c/1934213 Bug: chromium:1016772 Change-Id: I345d99b96dff194400c035d2885973feaca13ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936249 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
-
Tim van der Lippe authored
The view will be removed from the front_end [1]. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1946467 Change-Id: I015491b5070e9eabb9958a21eff488d8082d6f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946372 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#720461}
-
Guido Urdaneta authored
Disable on Windows because it is flaky. Bug: 1028371 Change-Id: I05e7c3988f8da24417b4f1da4091227f91638bdc TBR: svaldez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944673Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4092e36afe4..48c9ef678756 git log d4092e36afe4..48c9ef678756 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 janscheffler@chromium.org Fix background on rows with error network logview 2019-12-02 sigurds@chromium.org [memory] Offer 'Store as variable' in the heap profiler views 2019-12-02 aerotwist@chromium.org Updates manage_node_deps to install missing deps; adds yargs Created with: gclient setdep -r src/third_party/devtools-frontend/src@48c9ef678756 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029518,chromium:1027519 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I90f1cddca29c16f6e0336e1c0f770d5ce28204f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945916Reviewed-by:
-
Miyoung Shin authored
This CL converts OfflinePageAutoFetcher mojom interface clients in chrome to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Idd3f464cbb13641037a1406bc34199d4a59eb6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941727Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
TintedDrawables accepts all kinds of resources but renders empty images for VectorDrawables (which is how the linked bug occurred). This CL fixes the missing icon by using UiUtils.getTintedDrawable when loading the permission icons. I'd suggest to either fix TintedDrawable or at least assert that the given drawable is a bitmap to prevent the silent failure. (Adding this in a separate CL that is not a fix might be a good idea, though.) Tested on KitKat and Oreo. Works with dark mode. Screenshots in the linked bug. Bug: 1028925 Change-Id: I9ef6b67bcc8a7e0c02acd5a0b6b0221fafaa6765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942691Reviewed-by:
-
Jinfeng Ma authored
CompositedLayerMapping::NeedsRepaint always returned true if the target graphics layer is a scrollable area layer. This can be optimized because we can get paint invalidation flag from the overflow controls. Change-Id: Ie2612794403fabd8dcb8dad7aca41a60dfbb0c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943501Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720456}
-
Mia Glaese authored
Screenshots here: https://drive.google.com/open?id=1jqvHaKpi_7gKqnBO7tbOXlBcB_xTLjMQ Bug: 1028491 Change-Id: I854da2f726e0118dde7815f08457fc95e6cf8c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944530Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#720455}
-
Hans Wennborg authored
Ran `tools/clang/scripts/upload_revision.py c2443155a0fb245c8f17f2c1c72b6ea391e86e81`. Bug: 1028108, 1029385 Change-Id: I1222d343130a0c159c1283f20c41f60cb1b6db14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944343 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#720454}
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGFEDropShadowElement>(element) in place of IsSVGFEDropShadowElement(element) Bug: 891908 Change-Id: I01b8c852bb487493847267af2dd5ea7ffeede0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936575 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
-
Marc Treib authored
- Some obsolete TODOs are removed. - Valid TODOs are linked to a bug instead of a username. - Some valid TODOs are also made more specific etc. Bug: 1029479 Change-Id: Ic74475137ba543a8d1f73ab3a524596d722d7468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945171Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#720452}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/modules/webmidi as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below factory functions, - MIDIAccess::Create - MIDIInput::Create - MIDIMessageEvent::Create - MIDIOutput::Create Bug: 939691 Change-Id: Ic8342bd035c5b52c569bec574878db0e60b6f1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946172Reviewed-by:
-
