GitLab

2fd7b0b  Disable exceptions for the pdfium targets, now that pdfium:28 is done.
d4e406e  Remove try/catch block
d38a35e  Treat null Parent as no Parent for dictionary objects
9fa56b7  Fix missing or broken include guard macros in pdfium headers.
87708e1  For a CPDF_Color object, when set a new pattern to it, disconnect its link with the old pattern
fda0d42  When normalize coordinate, return instead of assert() when divide

BUG=382988,402260,402437,pdfium:28,82385
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/469603003

Cr-Commit-Position: refs/heads/master@{#289374}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289374 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402903
R=yoz@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/462103003

Cr-Commit-Position: refs/heads/master@{#289373}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289373 0039d316-1c4b-4281-b951-d872f2087c98

Implementation of the Battery Status API for the Linux platform.
Implementation uses DBus to talk to org.freedesktop.UPower service
to obtain battery information.

BUG=122593
TEST=http://jsbin.com/battery-status-test (manual)
TBR=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/436683002

Cr-Commit-Position: refs/heads/master@{#289372}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289372 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289371}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289371 0039d316-1c4b-4281-b951-d872f2087c98

This class stores criteria for selecting USB devices. A device can be
matched by its vendor and product IDs, and the interfaces that it
implements.

BUG=346953
TBR=satorux@chromium.org

Review URL: https://codereview.chromium.org/462753002

Cr-Commit-Position: refs/heads/master@{#289370}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289370 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403018
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/475533002

Cr-Commit-Position: refs/heads/master@{#289369}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289369 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=piman@chromium.org

Review URL: https://codereview.chromium.org/453163002

Cr-Commit-Position: refs/heads/master@{#289367}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289367 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a bug in displaying blink changelog if the range contains git hash and
displays better error message in case of ValueError from json.loads.

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/463243002

Cr-Commit-Position: refs/heads/master@{#289363}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289363 0039d316-1c4b-4281-b951-d872f2087c98

Also stop shadowing modules names like `file` as local variables and otherwise
adhere to the Python style guide:
https://google-styleguide.googlecode.com/svn/trunk/pyguide.html

R=tbreisacher@chromium.org
BUG=393873
TEST=pydoc checker.py processor.py

Review URL: https://codereview.chromium.org/475493002

Cr-Commit-Position: refs/heads/master@{#289361}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289361 0039d316-1c4b-4281-b951-d872f2087c98

This updates the includes in base but leaves a forwarding header for the rest of the project for now.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/468253002

Cr-Commit-Position: refs/heads/master@{#289360}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289360 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/458403002

Cr-Commit-Position: refs/heads/master@{#289358}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289358 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 288954 "[Sync] Don't synchronously stop datatypes that en..."
> 
> Reason for revert: see crbug.com/403098
> 
> > [Sync] Don't synchronously stop datatypes that encounter errors
> > 
> > The datatype logic may be operating unders assumptions that break when
> > the type is stopped from under it, possibly triggering crashes.
> > 
> > BUG=402595,403098
> > 
> > Review URL: https://codereview.chromium.org/462863002
> 
> TBR=zea@chromium.org
> 
> Review URL: https://codereview.chromium.org/467923002

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/471683002

Cr-Commit-Position: refs/heads/master@{#289357}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289357 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 288557 "[Sync] Use OnSingleDataTypeUnrecoverableError for..."
> 
> Reason for revert: see crbug.com/403098
> 
> > [Sync] Use OnSingleDataTypeUnrecoverableError for all errors
> > 
> > This removes the disable callback from all datatype controllers as well
> > as the DisableDataType method from the PSS, in favor of
> > OnSingleDataTypeUnrecoverable error (which now accepts a SyncError).
> > 
> > BUG=368834,403098
> > TBR=bauerb@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/436733002
> 
> TBR=zea@chromium.org
> 
> Review URL: https://codereview.chromium.org/465113002

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/469073002

Cr-Commit-Position: refs/heads/master@{#289356}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289356 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 288464 "[Sync] Cleanup datatype configuration error handl..."
> 
> Reason for revert: see crbug.com/403098
> 
> > [Sync] Cleanup datatype configuration error handling.
> > 
> > The FailedDataTypeHandler is now informed immediately of failures, including
> > datatype errors, and is therefore authoritative source for all errors. As such,
> > partial success is no longer tracked and the various ModelTypeSets for error
> > types in configure results are removed.
> > 
> > BUG=368834,403098
> > 
> > Review URL: https://codereview.chromium.org/420633002
> 
> TBR=zea@chromium.org
> 
> Review URL: https://codereview.chromium.org/468643002

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/469803004

Cr-Commit-Position: refs/heads/master@{#289354}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289354 0039d316-1c4b-4281-b951-d872f2087c98

Speculatively reverting because the CL may be causing the find_bugs
step on the Android builder to fail
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/63828/steps/findbugs/logs/stdio

TBR=jww
NOTRY=TRUE

Review URL: https://codereview.chromium.org/469003004

Cr-Commit-Position: refs/heads/master@{#289353}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289353 0039d316-1c4b-4281-b951-d872f2087c98

The old resources had too much bottom padding, and the radius of the
bottom corners was incorrect

There is a small related code change that fixes the size of
the button here: https://codereview.chromium.org/460233003/

Screenshots: https://drive.google.com/open?id=0B1B1Up4p2NRMd214MHJSbzlUcFk&authuser=1

BUG=395798
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/462043003

Cr-Commit-Position: refs/heads/master@{#289352}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289352 0039d316-1c4b-4281-b951-d872f2087c98

in r286141.

TBR=miket@chromium.org

Review URL: https://codereview.chromium.org/465273003

Cr-Commit-Position: refs/heads/master@{#289351}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289351 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/469053002

Cr-Commit-Position: refs/heads/master@{#289350}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289350 0039d316-1c4b-4281-b951-d872f2087c98

. Change the text color.
. Change the default background color.
. Make the fonts normal.
. Add a 1px border at the bottom.

BUG=401569
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/471503003

Cr-Commit-Position: refs/heads/master@{#289348}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289348 0039d316-1c4b-4281-b951-d872f2087c98

Favicons is known to have issues that trigger errors. Until those are resolved
the error uploading should be reduced. Disable for now.

BUG=384552
NOTRY=true

Review URL: https://codereview.chromium.org/470653003

Cr-Commit-Position: refs/heads/master@{#289346}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289346 0039d316-1c4b-4281-b951-d872f2087c98

- remove file mojo_view_manager_lib_unittests.gtest-drmemory.txt

R=oshima@chromium.org, bruening@chromium.org
BUG=403177
NOTRY=TRUE

Review URL: https://codereview.chromium.org/467333003

Cr-Commit-Position: refs/heads/master@{#289345}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289345 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/464113002

Cr-Commit-Position: refs/heads/master@{#289344}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289344 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=jar@chromium.org

Review URL: https://codereview.chromium.org/414563002

Cr-Commit-Position: refs/heads/master@{#289343}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289343 0039d316-1c4b-4281-b951-d872f2087c98

It makes more sense to try to open the entries first rather than create them, since they will usually only not exist the first time.

Review URL: https://codereview.chromium.org/465633003

Cr-Commit-Position: refs/heads/master@{#289342}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289342 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289340}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289340 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/b2721f7372652496e1b1ec722883904caa8134a8..fbd3576a18799da88988ef26fa9bce09e8ebba37

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=bsalomon@google.com
BUG=

Review URL: https://codereview.chromium.org/467293002

Cr-Commit-Position: refs/heads/master@{#289339}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289339 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/447673004

Cr-Commit-Position: refs/heads/master@{#289338}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289338 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/459903006

Cr-Commit-Position: refs/heads/master@{#289337}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289337 0039d316-1c4b-4281-b951-d872f2087c98

Previously, if you allowed an extension on all urls, the checkbox disappeared,
which was obviously very bad.  Fix it.

BUG=402958

Review URL: https://codereview.chromium.org/463983002

Cr-Commit-Position: refs/heads/master@{#289336}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289336 0039d316-1c4b-4281-b951-d872f2087c98

Two fingers: up is go to top, down is read from here, left is browser back, right is browser forward.
Three fingers: up and down map to page up/down.
Four fingers: up is home page, down is refresh.

Three/four finger left/right mappings to be added to the CL soon!

BUG=387304

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288857

Review URL: https://codereview.chromium.org/429633002

Cr-Commit-Position: refs/heads/master@{#289334}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289334 0039d316-1c4b-4281-b951-d872f2087c98

this reverts the revert of the revert of the revert

> Revert 289154 "Revert 289067 "Use RE string pattern matching for..."
> 
> > Revert 289067 "Use RE string pattern matching for blacklist stri..."
> > 
> > Reason for revert: uninitialize memory access
> > 
> > http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/29469/steps/memory%20test%3A%20content/logs/stdio
> > 
> > > Use RE string pattern matching for blacklist strings.
> > > 
> > > Including cpu_brand, gl_vendor, gl_renderer, gl_extension, driver_vendor,
> > > and machine_model_name.
> > > 
> > > BUG=396578
> > > TBR=piman@chromium.org
> > > TEST=gpu_unittests
> > > 
> > > Review URL: https://codereview.chromium.org/452293002
> > 
> > TBR=zmo@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/465163002
> 
> TBR=oshima@chromium.org
> 
> Review URL: https://codereview.chromium.org/468223002

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/475453002

Cr-Commit-Position: refs/heads/master@{#289328}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289328 0039d316-1c4b-4281-b951-d872f2087c98

This will be needed for request/response blobs in the ServiceWorkerCache.

BUG=392621

Review URL: https://codereview.chromium.org/459003002

Cr-Commit-Position: refs/heads/master@{#289326}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289326 0039d316-1c4b-4281-b951-d872f2087c98

TEST=InterceptorTest.BypassInterceptor*
R=abarth@chromium.org,raymes@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/467243002

Cr-Commit-Position: refs/heads/master@{#289325}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289325 0039d316-1c4b-4281-b951-d872f2087c98

BUG=352290

Review URL: https://codereview.chromium.org/456983003

Cr-Commit-Position: refs/heads/master@{#289324}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289324 0039d316-1c4b-4281-b951-d872f2087c98

Previously the <embed> element was created in client_session.js , while
it's owned by the ClientPlugin object. Moved plugin creation code where
it belongs, to client_plugin.js .

R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/469453003

Cr-Commit-Position: refs/heads/master@{#289323}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289323 0039d316-1c4b-4281-b951-d872f2087c98

R=aa@chromium.org, oshima@chromium.org
BUG=403177
NOTRY=TRUE

Review URL: https://codereview.chromium.org/471533003

Cr-Commit-Position: refs/heads/master@{#289322}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289322 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267117
TEST=LocalNTPTest (interactive_ui_tests)

Review URL: https://codereview.chromium.org/464483002

Cr-Commit-Position: refs/heads/master@{#289321}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289321 0039d316-1c4b-4281-b951-d872f2087c98

> Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace
> 
> Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is
> generally a NOP but will allow me to delete the other 4 variants in a followup
> (wanted to do that separately since that will require more review, since
> callsites will be changed in nontrivial ways).
> 
> In some cases, LowerCaseEqualsASCII is called with a WebString, which no
> longer is implicitly converted. I added base::string16(...) around such
> calls to force the right conversion. It happened in these files:
>   window_container_type.cc
>   savable_resources.cc
>   render_view_impl.cc
>   blink_ax_tree_source.cc
>   password_form_conversion_utils.cc
>   translate_helper.cc
>   chrome_render_view_observer.cc
>   dom_serializer_browsertest.cc
> 
> R=jamesr@chromium.org
> 
> Review URL: https://codereview.chromium.org/448143008

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/474483002

Cr-Commit-Position: refs/heads/master@{#289320}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289320 0039d316-1c4b-4281-b951-d872f2087c98

After cl https://codereview.chromium.org/324903002/, the X11 dependencies have been removed from IMF except for ImeKeyboard implementation for Ozone.
Without a valid ImeKeyboard implementation IME extensions can still work.

BUG=362698
TEST=Verified on Pixel device.

Review URL: https://codereview.chromium.org/444523003

Cr-Commit-Position: refs/heads/master@{#289319}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289319 0039d316-1c4b-4281-b951-d872f2087c98

There are too many load flags. This one is only used by loader code.

BUG=

Review URL: https://codereview.chromium.org/451623002

Cr-Commit-Position: refs/heads/master@{#289318}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289318 0039d316-1c4b-4281-b951-d872f2087c98