GitLab

Test is failing because FileManagerFileTasksComplexTest.FindFileHandlerTasks
doesn't initialize URL system request context. But URL fetch was started due
to misprint.

BUG=343589
TEST=unit_tests
NOTRY=true

Review URL: https://codereview.chromium.org/187603009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255218 0039d316-1c4b-4281-b951-d872f2087c98

What's removed:
 - The idea of unique_id's (these were for the now-gone webUI taskmanager).
 - The GetResourceExtension() method, which the tests no longer need.
 - The IsBackground getter, which is not used.

BUG=348836

Review URL: https://codereview.chromium.org/186153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255217 0039d316-1c4b-4281-b951-d872f2087c98

BUG=227247

Review URL: https://codereview.chromium.org/178883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255215 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345598

Review URL: https://codereview.chromium.org/187653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110119

Review URL: https://codereview.chromium.org/178473022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255210 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/187593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255209 0039d316-1c4b-4281-b951-d872f2087c98

BUG=260879

Review URL: https://codereview.chromium.org/28183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255208 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [AudioPlayer] Add test for opening another file from Files.app (https://codereview.chromium.org/177443006/)

Reason for revert:
This CL seems to be making OpenSpecialTypes/FileManagerBrowserTest.Test/5 timeout. See:

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%2BLSan%20Tests%20(2)

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%2BLSan%20Tests%20%282%29/builds/55/steps/browser_tests/logs/Test_5

Original issue's description:
> [AudioPlayer] Add test for opening another file from Files.app
> 
> BUG=none
> TEST=manually
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255003

TBR=hirono@chromium.org,yoshiki@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/188253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255205 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255203 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=168504:168526&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/187603006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255202 0039d316-1c4b-4281-b951-d872f2087c98

has a browser action which it starts reading from storage on startup, but then
it's updated to a new version with no browser action before the callback comes
back.

A better way to fix it would be to block the update until the extension is
"started", but we need better infrastructure to do that.

BUG=349371

Review URL: https://codereview.chromium.org/187323007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337526

Review URL: https://codereview.chromium.org/145923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255200 0039d316-1c4b-4281-b951-d872f2087c98

This argument is just used for an early out. Instead don't call the
method at all when it is true.

Depends on: https://codereview.chromium.org/183563003/

R=enne
BUG=344962

Review URL: https://codereview.chromium.org/187043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255199 0039d316-1c4b-4281-b951-d872f2087c98

crbug/349398: Disabled Widevine test license server on precise 32 bit.
crbug/349526: Disabled two failing tests on precise 64 bit.

BUG=349526,349398

Review URL: https://codereview.chromium.org/180733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255198 0039d316-1c4b-4281-b951-d872f2087c98

This makes "adding" an I/O thread easier (and usable when you already
have a test base class).

R=sky@chromium.org

Review URL: https://codereview.chromium.org/187383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255196 0039d316-1c4b-4281-b951-d872f2087c98

This is only used in !NDEBUG builds, and making the variable only available
there makes it harder to break -Wunused-const-variable builds with custom
traits. Follow-up to r255159.

BUG=349521,307668
R=fischman@chromium.org

Review URL: https://codereview.chromium.org/187903007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255194 0039d316-1c4b-4281-b951-d872f2087c98

These are unit tests so they should be in the unit_tests target. A
TODO says this did not work before, but they appear to pass as unit
tests now, so this is just a code move.

R=sky
BUG=270918

Review URL: https://codereview.chromium.org/186063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=manual
TRYBOT=None

Review URL: https://codereview.chromium.org/180723017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255191 0039d316-1c4b-4281-b951-d872f2087c98

Move the ContentGestureProvider to ui/, allowing the filtering and gesture
batching code to be used outside of content/.  Also eliminate
TouchDispositionGestureFilter's dependency on a custom ack result type,
instead simply using a bool to indicate whether or not the ack'ed touch was
consumed.

BUG=348588

Review URL: https://codereview.chromium.org/182383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255190 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/188133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255189 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255188 0039d316-1c4b-4281-b951-d872f2087c98

Manually patches in 77400c22b5bafd8aaaa75f90a1d997838204577a from upstream.

Description:
  Also on arm64, BOOL seems to be encoded as "bool" (the 'B' objcType, or
  _C_BOOL) rather than the historical 'c', but NSValue can still use 'c',
  so we need to have those compare as equal.

BUG=314720

Review URL: https://codereview.chromium.org/177373009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255187 0039d316-1c4b-4281-b951-d872f2087c98

TBR=isherman@chromium.org,qyearsley@chromium.org
NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/181233013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255186 0039d316-1c4b-4281-b951-d872f2087c98

The WindowTreeHost implementation for X11 currently receives an event from X11
when the keyboard mapping changes in the system. The implementation then calls
into WindowTreeHost::OnKeyboardMappingChanged(), which triggers the
corresponding method in all WindowTreeHostObservers. The EventRewriter is a
WindowTreeHostObserver, and so it can then reset the keycodes it maintains.

But the EventRewriter is also a MessagePumpObserver, which means it already
receives the X11 MappingNotify event, and so the plumbing of the event through
aura is unnecessary.  There is no other consumer of
WindowTreeHostObserver::OnKeyboardMappingChanged(), so remove it from the api.

BUG=343639
R=oshima@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/183893031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255185 0039d316-1c4b-4281-b951-d872f2087c98

> Cast: Using a min filter to compute time offset
> 
> Modifying the time offset filter to take to minimum of the first 10 values. 
> Once ten offset values were seen, the value will be constant for the entire session. 
> This may be justified by the fact we are seeking the offset between sender and
>  receiver without accounting the network jitter.
> 
> Review URL: https://codereview.chromium.org/186043003

TBR=mikhal@chromium.org

Review URL: https://codereview.chromium.org/183063011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255173 0039d316-1c4b-4281-b951-d872f2087c98

> Disable HostDriven_SyncTest.testDisableAndEnableSync
>
> BUG=348951
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/180273024

NOTRY=true
R=boliu@chromium.org, nyquist@chromium.org
TBR=nyquist@chromium.org

Review URL: https://codereview.chromium.org/186643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255168 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=mac 10.9 bots green
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/188013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255167 0039d316-1c4b-4281-b951-d872f2087c98

Modifying the time offset filter to take to minimum of the first 10 values. 
Once ten offset values were seen, the value will be constant for the entire session. 
This may be justified by the fact we are seeking the offset between sender and
 receiver without accounting the network jitter.

Review URL: https://codereview.chromium.org/186043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
R=creis@chromium.org

Review URL: https://codereview.chromium.org/185993008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255165 0039d316-1c4b-4281-b951-d872f2087c98

Also fixes a couple of the unittests and adds a debug log for when
this occurs.

BUG=176862
TEST=WebAudio reports the correct number of frames.

Review URL: https://codereview.chromium.org/187223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255162 0039d316-1c4b-4281-b951-d872f2087c98

Replace the custom ProxyConfigServiceDirect class with the equivalent
net::ProxyConfigServiceFixed class.

Original code review: https://codereview.chromium.org/180283003

TBR=eroman@chromium.org,stgao@chromium.org,rlarocque@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/185993009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255160 0039d316-1c4b-4281-b951-d872f2087c98

While building with clang=1, clang reports this error about the above variable being unused.

BUG=349521
NOTRY=true

Review URL: https://codereview.chromium.org/188003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255159 0039d316-1c4b-4281-b951-d872f2087c98

We need to reset the render_thread_checker and render_converter_ when the WebRtcAudioRenderer is going away.

NOTRY=true

BUG=264611
TEST=manual test webrtc with --enable-audio-track-processor

Review URL: https://codereview.chromium.org/178153007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255158 0039d316-1c4b-4281-b951-d872f2087c98

Since packets we don't understand are not actually that unexpected, turn
LOG(WARNING) messages in the mDNS code to DVLOG(1).

BUG=

Review URL: https://codereview.chromium.org/177373013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255157 0039d316-1c4b-4281-b951-d872f2087c98

The current behavior of FileDownloader::url() is strange since the value
changes after the initial GET request. I've found this a little awkward, and
decided to make url() always return the url passed to FileDownloader, and
full_url() return the extra url information from the GET request.

BUG=
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/181933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255156 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/168183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255155 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/183723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255153 0039d316-1c4b-4281-b951-d872f2087c98

BUG=181069
R=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/183893025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255152 0039d316-1c4b-4281-b951-d872f2087c98

1. Add functionality to ServiceResolverThunk to copy a thunk without patching.
2. Move chrome_elf thunk-handling code to a common location.
3. Use a thunk instead of a f'n ptr for redirects.

BUG=334379

Review URL: https://codereview.chromium.org/183833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255151 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary to ensure correct ordering of the CALayers
of the child NSViews of the window's content view. Most of
the time the NSViews appeared in the correct order, but
not all of the time (especially on 10.6). This fixes that issue.

Remove code to dynamically do this when entering and leaving
presentation mode.

Update the FastResizeView to host a white CALayer instead of
trying to call drawRect, and make the NSView opaque.

This caused a performance drop last time it was tried, but other
performance fixes, and the FastResizeView fix might make it so
that this does not have an appreciable performance impact.

BUG=348490
NOTRY=True

Review URL: https://codereview.chromium.org/184433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255150 0039d316-1c4b-4281-b951-d872f2087c98