GitLab

This CL adapts several test classes with changes due now that
the IPCS for beforeUnload ack and renderer navigation requests are not
one and the same anymore.

BUG=440266

Review URL: https://codereview.chromium.org/953503002

Cr-Commit-Position: refs/heads/master@{#319049}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/467060f..b317635

TBR=samli@chromium.org

Review URL: https://codereview.chromium.org/982503002

Cr-Commit-Position: refs/heads/master@{#319048}

Previously the thumbnail metadata is obtained as a part of old metadata.  The CL
adds thumbnailMetadataItem to GalleryItem, and remove old metadata models from
Gallery.

BUG=410766
TEST=None

Review URL: https://codereview.chromium.org/976713004

Cr-Commit-Position: refs/heads/master@{#319047}

Revert of Revert of Chromecast: Play audio streams not supported by CMA via default renderer (patchset #1 id:1 of https://codereview.chromium.org/981473003/)

Reason for revert:
Hmmm... My revert did not fix the test, so I'm undoing it. :/

Original issue's description:
> Revert of Chromecast: Play audio streams not supported by CMA via default renderer (patchset #5 id:70001 of https://codereview.chromium.org/973633002/)
>
> Reason for revert:
> Audio tests started failing consistently in the next build after this was checked in. See:
> https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/3762
>
> Not sure if this CL is the culprit, but seems the most likely one, so attempting a revert to see if it fixes the problem.
>
> Error:
> [ RUN      ] AudioRecorderTest.BasicRecordAndStop
> ../../components/audio_modem/audio_recorder_unittest.cc:203: Failure
> Value of: IsRecording()
> Actual: false
> Expected: true
> ../../components/audio_modem/audio_recorder_unittest.cc:208: Failure
> Value of: IsRecording()
> Actual: false
> Expected: true
> ../../components/audio_modem/audio_recorder_unittest.cc:213: Failure
> Value of: IsRecording()
> Actual: false
> Expected: true
> [  FAILED  ] AudioRecorderTest.BasicRecordAndStop (1292 ms)
>
> Original issue's description:
> > Chromecast: Play audio streams not supported by CMA via default renderer
> >
> > For Chromecast we want to choose which media renderer to use based on
> > the types of input content streams. We will use CMA media renderer for
> > media types that are supported by our hardware (H264, AAC, etc) and
> > will use the default media renderer for audio streams other than AAC
> > or Vorbis. This will allow us support software decoding of FLAC and
> > Opus via the default Chrome audio path.
> >
> > BUG=457959
> >
> > Committed: https://crrev.com/2e583073b996e66d62f709dd2ffde9e1ef58b276
> > Cr-Commit-Position: refs/heads/master@{#318941}
>
> TBR=gunsch@chromium.org,lcwu@chromium.org,dalecurtis@chromium.org,servolk@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=457959
>
> Committed: https://crrev.com/ee687fd9c6c2bc41642cd8b65de87fe548a3cf75
> Cr-Commit-Position: refs/heads/master@{#319033}

TBR=gunsch@chromium.org,lcwu@chromium.org,dalecurtis@chromium.org,servolk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=457959

Review URL: https://codereview.chromium.org/967933003

Cr-Commit-Position: refs/heads/master@{#319046}

These are flaky on various platforms for app windows; outerBounds is
preferred.

BUG=453707

Review URL: https://codereview.chromium.org/976563002

Cr-Commit-Position: refs/heads/master@{#319045}

1. Register client to quota manager after it is initialized.
As the ServiceWorker cache storage is not affected during DB
recovery we don't need to create a new ServiceWorkerCacheStorageManager.

2. Ongoing register jobs could be aborted by DB recovery.

BUG=none

Review URL: https://codereview.chromium.org/943333007

Cr-Commit-Position: refs/heads/master@{#319044}

Previously if MetadataProvider fails to fetch metaata, there is no way to check
if the entry does not have a property or it fails to obtain the metadata.

The CL adds error fields to MetadataItem, which are cached with corresponding
property.

BUG=410766
TEST=FileManagerJsTest.MetadataCacheItem

Review URL: https://codereview.chromium.org/977873002

Cr-Commit-Position: refs/heads/master@{#319043}

BUG=None.

Review URL: https://codereview.chromium.org/961673004

Cr-Commit-Position: refs/heads/master@{#319042}

IsAborted() and Remove() were removed, and semantics of Abort() simplified.

TEST=unit_tests: *FileSystemProvider*
BUG=463344

Review URL: https://codereview.chromium.org/971303003

Cr-Commit-Position: refs/heads/master@{#319041}

Whether the context menu appears on mouse up can depend on run-time
settings (in the case of Opera). This reads the setting to
WebPreferences, so that the browser has the possibility of
communicating the appropriate setting to the renderer. If not
explicitly set, it defaults, as before, to 'true' on Windows and
'false' on other platforms.

BUG=

Review URL: https://codereview.chromium.org/819293002

Cr-Commit-Position: refs/heads/master@{#319040}

BUG=410766
TEST=None

Review URL: https://codereview.chromium.org/971173002

Cr-Commit-Position: refs/heads/master@{#319039}

The HostTableEntry is currently shared between the local host section and
the host list.  However, they have slightly different creation behavior.
For one, the DOM is generated on the fly for the HostList whereas the local
host section has its DOM hard coded in the ui_me2me.html.

In addition, the existing HostTableEntry expects the host to be passed in
during construction time. This is slightly awkward for the LocalHostSection
as the host is null until the local host has started.

After the refactoring, the HostTableEntry generates the DOM in its
constructor. The host is passed in via the setHost() function that updates
the DOM using querySelector and innerText.  The refactor also combines
updateStatus() and setHostName() into once single function updateUI() that
refreshes the UI based on the underlying state (the host).

This CL also separates the local host section in the hostlist into its own class.

BUG=461539

Review URL: https://codereview.chromium.org/944183002

Cr-Commit-Position: refs/heads/master@{#319038}

Revert of Add new test: DownloadTest.TestMultipleDownloadsBubble (patchset #2 id:40001 of https://codereview.chromium.org/976823002/)

Reason for revert:
New test added is flaky. Sorry. :)
https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/21829

[ RUN      ] DownloadTest.TestMultipleDownloadsBubble
[3840:2828:0303/224822:WARNING:data_reduction_proxy_config.cc(240)] SPDY proxy OFF at startup
HTTP server started on http://127.0.0.1:54250...
sending server_data: {"host": "127.0.0.1", "port": 54250} (36 bytes)
c:\b\build\slave\win_x64_builder\build\src\chrome\browser\download\download_browsertest.cc(2974): error: Value of: mock_bubble_view->IsVisible()
Actual: false
Expected: true

Original issue's description:
> Add new test: DownloadTest.TestMultipleDownloadsBubble
>
> This ensures that both infobars and bubbles are tested by creating both
> DownloadTest.TestMultipleDownloadsInfobar and DownloadTest.
> TestMultipleDownloadsBubble. The correct UI (infobar or bubble) is
> forced with a switch.
>
> BUG=438758
>
> Committed: https://crrev.com/ff5eb76821e76cb6c90b940249caf3d748e6fbc0
> Cr-Commit-Position: refs/heads/master@{#318987}

TBR=asanka@chromium.org,felt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=438758

Review URL: https://codereview.chromium.org/977863002

Cr-Commit-Position: refs/heads/master@{#319037}

The CHECK-fail was introduced in r315272 (64121b7f), which switched the
app list to run with the "original profile" rather than the incognito
profile. Partially reverted that CL so that the app list runs with the
incognito profile, and fixed StartPageService to correctly use the
incognito profile (rather than being null when the app list profile is
incognito), which addresses the original issue
(http://crbug.com/440484).

Had to work around DCHECK on shutdown in StartPageService due to
crbug.com/463419.

Added a DCHECK to catch use of non-incognito profiles in guest mode
early (without having to select a search result to trigger the crash).
Added AppListControllerGuestModeBrowserTest to test opening the app list
in guest mode.

BUG=460437,440484

Review URL: https://codereview.chromium.org/976553003

Cr-Commit-Position: refs/heads/master@{#319036}

BUG=

Committed: https://crrev.com/b5020725ac56d11c064086295af7db628b4fe64b
Cr-Commit-Position: refs/heads/master@{#318859}

Review URL: https://codereview.chromium.org/965713002

Cr-Commit-Position: refs/heads/master@{#319035}

Revert of Fix BluetoothAdapterProfileChromeOS lifecycle management (patchset #7 id:120001 of https://codereview.chromium.org/935383003/)

Reason for revert:
Leaks detected.
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/7185

=================================================================
==22324==ERROR: LeakSanitizer: detected memory leaks

Indirect leak of 96 byte(s) in 1 object(s) allocated from:
#0 0x4d9b8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__1_/build/src/out/Release/device_unittests+0x4d9b8b)
#1 0x901bd6 in chromeos::BluetoothAdapterProfileChromeOS::Register(device::BluetoothUUID const&, chromeos::BluetoothProfileManagerClient::Options const&, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&, std::string const&)> const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:28:7
#2 0x8f6c47 in chromeos::BluetoothAdapterChromeOS::UseProfile(device::BluetoothUUID const&, dbus::ObjectPath const&, chromeos::BluetoothProfileManagerClient::Options const&, chromeos::BluetoothProfileServiceProvider::Delegate*, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&)> const&) device/bluetooth/bluetooth_adapter_chromeos.cc:982:5
#3 0x4ec8e2 in chromeos::BluetoothAdapterProfileChromeOSTest_SimultaneousRegisterFail_Test::TestBody() device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc:359:3
#4 0x85da05 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2420:12
#5 0x85da05 in testing::Test::Run() testing/gtest/src/gtest.cc:2436
#6 0x85f619 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5
#7 0x86040a in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5
#8 0x874063 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11
#9 0x8736b7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12
#10 0x8736b7 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220
#11 0x814bda in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10
#12 0x814bda in base::TestSuite::Run() base/test/test_suite.cc:230
#13 0x80ad38 in Run base/callback.h:396:12
#14 0x80ad38 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:181
#15 0x80a863 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:423:10
#16 0x7d25ac in main device/test/run_all_unittests.cc:14:10
#17 0x7f35c8c7276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

Indirect leak of 93 byte(s) in 1 object(s) allocated from:
#0 0x4d9b8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__1_/build/src/out/Release/device_unittests+0x4d9b8b)
#1 0x7f35c92df739 in __gnu_cxx::new_allocator<char>::allocate(unsigned long, void const*) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/ext/new_allocator.h:92
#2 0x7f35c92ded2c in std::string::_Rep::_S_create(unsigned long, unsigned long, std::allocator<char> const&) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:609
#3 0x7f35c92def04 in std::string::_Rep::_M_clone(std::allocator<char> const&, unsigned long) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:631
#4 0x7f35c92dbc48 in std::string::reserve(unsigned long) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:512
#5 0x9021d7 in operator+<char, std::char_traits<char>, std::allocator<char> > /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/basic_string.tcc:702:7
#6 0x9021d7 in chromeos::BluetoothAdapterProfileChromeOS::BluetoothAdapterProfileChromeOS(device::BluetoothUUID const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:47
#7 0x901be8 in chromeos::BluetoothAdapterProfileChromeOS::Register(device::BluetoothUUID const&, chromeos::BluetoothProfileManagerClient::Options const&, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&, std::string const&)> const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:28:11
#8 0x8f6c47 in chromeos::BluetoothAdapterChromeOS::UseProfile(device::BluetoothUUID const&, dbus::ObjectPath const&, chromeos::BluetoothProfileManagerClient::Options const&, chromeos::BluetoothProfileServiceProvider::Delegate*, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&)> const&) device/bluetooth/bluetooth_adapter_chromeos.cc:982:5
#9 0x4ec8e2 in chromeos::BluetoothAdapterProfileChromeOSTest_SimultaneousRegisterFail_Test::TestBody() device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc:359:3
#10 0x85da05 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2420:12
#11 0x85da05 in testing::Test::Run() testing/gtest/src/gtest.cc:2436
#12 0x85f619 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5
#13 0x86040a in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5
#14 0x874063 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11
#15 0x8736b7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12
#16 0x8736b7 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220
#17 0x814bda in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10
#18 0x814bda in base::TestSuite::Run() base/test/test_suite.cc:230
#19 0x80ad38 in Run base/callback.h:396:12
#20 0x80ad38 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:181
#21 0x80a863 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:423:10
#22 0x7d25ac in main device/test/run_all_unittests.cc:14:10
#23 0x7f35c8c7276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

Indirect leak of 24 byte(s) in 1 object(s) allocated from:
#0 0x4d9b8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__1_/build/src/out/Release/device_unittests+0x4d9b8b)
#1 0xd9c743 in chromeos::BluetoothProfileServiceProvider::Create(dbus::Bus*, dbus::ObjectPath const&, chromeos::BluetoothProfileServiceProvider::Delegate*) chromeos/dbus/bluetooth_profile_service_provider.cc:251:12
#2 0x90227f in chromeos::BluetoothAdapterProfileChromeOS::BluetoothAdapterProfileChromeOS(device::BluetoothUUID const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:51:7
#3 0x901be8 in chromeos::BluetoothAdapterProfileChromeOS::Register(device::BluetoothUUID const&, chromeos::BluetoothProfileManagerClient::Options const&, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&, std::string const&)> const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:28:11
#4 0x8f6c47 in chromeos::BluetoothAdapterChromeOS::UseProfile(device::BluetoothUUID const&, dbus::ObjectPath const&, chromeos::BluetoothProfileManagerClient::Options const&, chromeos::BluetoothProfileServiceProvider::Delegate*, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&)> const&) device/bluetooth/bluetooth_adapter_chromeos.cc:982:5
#5 0x4ec8e2 in chromeos::BluetoothAdapterProfileChromeOSTest_SimultaneousRegisterFail_Test::TestBody() device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc:359:3
#6 0x85da05 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2420:12
#7 0x85da05 in testing::Test::Run() testing/gtest/src/gtest.cc:2436
#8 0x85f619 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5
#9 0x86040a in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5
#10 0x874063 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11
#11 0x8736b7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12
#12 0x8736b7 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220
#13 0x814bda in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10
#14 0x814bda in base::TestSuite::Run() base/test/test_suite.cc:230
#15 0x80ad38 in Run base/callback.h:396:12
#16 0x80ad38 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:181
#17 0x80a863 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:423:10
#18 0x7d25ac in main device/test/run_all_unittests.cc:14:10
#19 0x7f35c8c7276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

Original issue's description:
> Fix BluetoothAdapterProfileChromeOS lifecycle management
>
> Have BluetoothAdapterProfileChromeOS remove itself from adapters when it
> is deleted via it's deconstructor, to avoid references being left behind
> after deletion.
>
> BUG=457978
>
> Committed: https://crrev.com/0cca591aaf6f6a0cbf46840faaead236dd8317a2
> Cr-Commit-Position: refs/heads/master@{#318925}

TBR=keybuk@chromium.org,isherman@chromium.org,armansito@chromium.org,stgao@chromium.org,jamuraa@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=457978

Review URL: https://codereview.chromium.org/975323002

Cr-Commit-Position: refs/heads/master@{#319034}

Revert of Chromecast: Play audio streams not supported by CMA via default renderer (patchset #5 id:70001 of https://codereview.chromium.org/973633002/)

Reason for revert:
Audio tests started failing consistently in the next build after this was checked in. See:
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/3762

Not sure if this CL is the culprit, but seems the most likely one, so attempting a revert to see if it fixes the problem.

Error:
[ RUN      ] AudioRecorderTest.BasicRecordAndStop
../../components/audio_modem/audio_recorder_unittest.cc:203: Failure
Value of: IsRecording()
Actual: false
Expected: true
../../components/audio_modem/audio_recorder_unittest.cc:208: Failure
Value of: IsRecording()
Actual: false
Expected: true
../../components/audio_modem/audio_recorder_unittest.cc:213: Failure
Value of: IsRecording()
Actual: false
Expected: true
[  FAILED  ] AudioRecorderTest.BasicRecordAndStop (1292 ms)

Original issue's description:
> Chromecast: Play audio streams not supported by CMA via default renderer
>
> For Chromecast we want to choose which media renderer to use based on
> the types of input content streams. We will use CMA media renderer for
> media types that are supported by our hardware (H264, AAC, etc) and
> will use the default media renderer for audio streams other than AAC
> or Vorbis. This will allow us support software decoding of FLAC and
> Opus via the default Chrome audio path.
>
> BUG=457959
>
> Committed: https://crrev.com/2e583073b996e66d62f709dd2ffde9e1ef58b276
> Cr-Commit-Position: refs/heads/master@{#318941}

TBR=gunsch@chromium.org,lcwu@chromium.org,dalecurtis@chromium.org,servolk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=457959

Review URL: https://codereview.chromium.org/981473003

Cr-Commit-Position: refs/heads/master@{#319033}

Reason for revert:
Causes test to consistently time out.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35869

[ RUN      ] ChromeWhispernetClientTest.EncodeAndDecode
[724:3320:0303/204246:WARNING:data_reduction_proxy_config.cc(240)] SPDY proxy OFF at startup
[3956:4296:0303/204248:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread!
[724:4156:0303/204249:INFO:CONSOLE(5)] "Not allowed to load local resource: chrome://resources/css/text_defaults.css", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/background.html (5)
[724:4156:0303/204249:INFO:CONSOLE(83)] "init: Starting Nacl bridge.", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (83)
[2012:2524:0303/204249:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread!
[2012:2832:0303/204249:ERROR:pnacl_translation_resource_host.cc(135)] Got invalid platformfilefortransit
[724:4156:0303/204253:INFO:CONSOLE(65)] "init: Nacl ready!", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (65)
[724:4156:0303/204254:INFO:CONSOLE(26)] "Configuring encoder and decoder for client E77A9C58-00C9-4A99-AC57-1353FB0B918D", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (26)
[223/223] ChromeWhispernetClientTest.EncodeAndDecode (TIMED OUT)

Original issue's description:
> 1. Token CRCs are not handled correctly. This adds the corrected Whispernet binary (from cl/87383487), and a test to confirm the correct behavior.
>
> 2. If we get tokens that require more than one padding character, the padding will not be completely removed when appropriate. This is a simple change in the js.
>
> BUG=463218
>
> Committed: https://crrev.com/6e37f17aa09f5244315d6eb84fa305154bc65062
> Cr-Commit-Position: refs/heads/master@{#319015}

TBR=rkc@chromium.org,ckehoe@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463218

Review URL: https://codereview.chromium.org/979723002

Cr-Commit-Position: refs/heads/master@{#319032}

I believe the param (active_version_id) was a remnant of the ancient spec/impl.

BUG=n/a

Review URL: https://codereview.chromium.org/966393002

Cr-Commit-Position: refs/heads/master@{#319031}

R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/971323002

Cr-Commit-Position: refs/heads/master@{#319030}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5c82b52..467060f

TBR=enne@chromium.org,samli@chromium.org

Review URL: https://codereview.chromium.org/964523004

Cr-Commit-Position: refs/heads/master@{#319029}

Cr-Commit-Position: refs/heads/master@{#319028}

Revert of Revert of Update V8 to version 4.3.16. (patchset #1 id:1 of https://codereview.chromium.org/978433002/)

Reason for revert:
The roll wasn't the cause for issue 463436. Therefore relanding.

Original issue's description:
> Revert of Update V8 to version 4.3.16. (patchset #1 id:1 of https://codereview.chromium.org/974813002/)
>
> Reason for revert:
> Speculative revert for issue 463436.
>
> Original issue's description:
> > Update V8 to version 4.3.16.
> >
> > Summary of changes available at:
> > https://chromium.googlesource.com/v8/v8/+log/155278d6..ea02c333
> >
> > Please follow these instructions for assigning/CC'ing issues:
> > https://code.google.com/p/v8-wiki/wiki/TriagingIssues
> >
> > TBR=machenbach@chromium.org
> > NOTRY=true
> >
> > Committed: https://crrev.com/5d61006f40e3f14bbf8f2c60f698b051f8f84fd9
> > Cr-Commit-Position: refs/heads/master@{#318874}
>
> TBR=v8-autoroll@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/cb33633cc8920c3dc61b217285e4887f03d75613
> Cr-Commit-Position: refs/heads/master@{#318879}

TBR=v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/976713005

Cr-Commit-Position: refs/heads/master@{#319027}

Review URL: https://codereview.chromium.org/977553003

Cr-Commit-Position: refs/heads/master@{#319026}

For onscreen, viewport should match window size initially. For offscreen,
viewport should match the default FBO size initially as-is.

Review URL: https://codereview.chromium.org/965223002

Cr-Commit-Position: refs/heads/master@{#319025}

After the inlined trace transition, the callee part of registerWeakMembers()
call can be of type CXXDependentScopeMemberExpr instead of UnresolvedMemberExpr.
The plugin should be aware of this case.

BUG=462511
R=kouhei@chromium.org
CC=zerny@chromium.org, oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/975683003

Cr-Commit-Position: refs/heads/master@{#319024}

Revert of Revert of Update V8 to version 4.3.15. (patchset #1 id:1 of https://codereview.chromium.org/975713002/)

Reason for revert:
The roll wasn't the cause for issue 463436. Therefore relanding.

Original issue's description:
> Revert of Update V8 to version 4.3.15. (patchset #1 id:1 of https://codereview.chromium.org/969053002/)
>
> Reason for revert:
> Speculative revert for issue 463436.
>
> Original issue's description:
> > Update V8 to version 4.3.15.
> >
> > Summary of changes available at:
> > https://chromium.googlesource.com/v8/v8/+log/c791d841..155278d6
> >
> > Please follow these instructions for assigning/CC'ing issues:
> > https://code.google.com/p/v8-wiki/wiki/TriagingIssues
> >
> > TBR=machenbach@chromium.org
> >
> > Committed: https://crrev.com/32e6c72188d6b0b948d668afdc1cb209d44c2e70
> > Cr-Commit-Position: refs/heads/master@{#318755}
>
> TBR=v8-autoroll@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/0607e55050323137b334f8569a7e522d6f1844da
> Cr-Commit-Position: refs/heads/master@{#318880}

TBR=v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/977583004

Cr-Commit-Position: refs/heads/master@{#319023}

BUG=461629
TEST=None

Review URL: https://codereview.chromium.org/975883003

Cr-Commit-Position: refs/heads/master@{#319022}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7d85a55..5c82b52

TBR=enne@chromium.org,samli@chromium.org

Review URL: https://codereview.chromium.org/978483003

Cr-Commit-Position: refs/heads/master@{#319021}

This skips a method call on devices where it would cause a crash.

BUG=463719

Review URL: https://codereview.chromium.org/969413003

Cr-Commit-Position: refs/heads/master@{#319020}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b2c2289..7d85a55

TBR=enne@chromium.org,samli@chromium.org

Review URL: https://codereview.chromium.org/981443002

Cr-Commit-Position: refs/heads/master@{#319019}

Setting cursor type to ui::kCursorNone is treated the same as setting
visibility to false.

However note that it is necessary to track the last requested cursor
visibility separately.

BUG=chrome-os-partner:30313
TEST=verify that large cursor disappears in Youtube full-screen mode

Review URL: https://codereview.chromium.org/980453002

Cr-Commit-Position: refs/heads/master@{#319018}

speculatively reverting this to solve browser CPM

BUG=463776

This reverts commit 5f1263bb.

Merge branch 'master' of https://chromium.googlesource.com/a/chromium/src

Revert "Handle unsucessful JsonPrefStore initialization in SupervisedUserSettingsService."

this may be casuing an increase in rendererexit code.

BUG=463646

This reverts commit 0197d5df.

Merge branch 'master' of https://chromium.googlesource.com/a/chromium/src

This is causing a huge amounts of renderer crashes because of RESULT_CODE_KILLED_BAD_MESSAGE.  Reverting this from master.

Revert "<webview>: Removed ResolveURL"

This reverts commit c2fc6144.

Cr-Commit-Position: refs/heads/master@{#319017}

BUG=463675
TEST=bots, WebGL2 demos
R=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/978593003

Cr-Commit-Position: refs/heads/master@{#319016}

1. Token CRCs are not handled correctly. This adds the corrected Whispernet binary (from cl/87383487), and a test to confirm the correct behavior.

2. If we get tokens that require more than one padding character, the padding will not be completely removed when appropriate. This is a simple change in the js.

BUG=463218

Review URL: https://codereview.chromium.org/969843002

Cr-Commit-Position: refs/heads/master@{#319015}

BUG=462507

Review URL: https://codereview.chromium.org/972893003

Cr-Commit-Position: refs/heads/master@{#319014}

This ensures that re-creating a window with the same id shows that
window if it already exists. This was broken in:
https://codereview.chromium.org/417433002

BUG=461081

Review URL: https://codereview.chromium.org/958923004

Cr-Commit-Position: refs/heads/master@{#319013}

BUG=
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/975973002

Cr-Commit-Position: refs/heads/master@{#319012}

The "on"/"off" text and the switch were both too close to the edge of
the screen on pre-L devices. The bug arose because the LinearLayout had
conflicting padding attributes: it defined "padding" inline, and used a
style which defined "paddingStart" and "paddingEnd". The latter values
were overriding the inline "padding" value.

Review URL: https://codereview.chromium.org/970603003

Cr-Commit-Position: refs/heads/master@{#319011}

This is to fix regression of https://codereview.chromium.org/913033002.

BUG=455996

Review URL: https://codereview.chromium.org/972293003

Cr-Commit-Position: refs/heads/master@{#319010}