- 16 Mar, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/717aa4d9..3c330b35 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9fcf9826563de6bd53e76d8c401172bf3deb36b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105733Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750615}
-
W. James MacLean authored
This test is also flakey on Linux, and to some extent Win. TBR=mkwst@chromium.org Bug: 1060175 Change-Id: I95c4c0cca2a42ae2883254d89f6c2fcd1f56f0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105756Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#750614}
-
Adam Langley authored
With this change, the caBLE authenticator will advertise with it's long-term keys and (always) exchange pairing information when doing QR handshakes. This removes the need to do a QR pairing for every operation. BUG=1002262 Change-Id: I1999e3de347f278a460f126c491d185d1cb18e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101288 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#750613}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f94815068d75..6c138716e9ad git log f94815068d75..6c138716e9ad --date=short --first-parent --format='%ad %ae %s' 2020-03-16 hcm@google.com fix up release notes file for milestone 83 2020-03-16 csmartdalton@google.com Remove GrMesh::setVertexData 2020-03-16 csmartdalton@google.com Rearrange Vulkan asserts for samplers 2020-03-16 mtklein@google.com begin refactoring SkTDynamicHash and SkTMultiMap 2020-03-16 mtklein@google.com Shrink SkTHashTables 2020-03-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 907b992f..6d7621ab (422 commits) 2020-03-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6963f58c7678..cb9a86a9d867 (13 commits) Created with: gclient setdep -r src/third_party/skia@6c138716e9ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: If9a160f7f413276aca518068af73eb309b292f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105580Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750612}
-
David Maunder authored
serialization method to protobufs. Currently in TabState fields are persisted by storing in a file one after another. This approach does not scale well - fields are not well organized and this approach makes it difficult to deprecate fields. PersistedTabData enables persisted fields to be better organized and protobufs offer better support for adding and deprecating fields. PersistedTabData also enables different storage methods - in an upcoming CL a PersistedTabData which uses a Level DB backend will be used for data for building new features but is not pertinent to the running of the app. Bug: 1046367 Change-Id: Id73074303641babb24e2f6109254c53d0d763e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025317 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#750611}
-
Friedrich Horschig authored
Users should not be able to retry the passwords check immediately if they don't have passwords to check. Saving at least one password will put it back into an idle state. Screenshots are in the linked bug. Bug: 1061935 Change-Id: I2eb101a32ca5a6a44e86a7cfbd458af1fd2efec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105220 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#750610}
-
Robert Ogden authored
Adds the following checks: * Prefetching cannot start if the tab is not visible. * When a tab becomes visible, prefetching is restarted. Note that a tab becoming hidden does not stop the current prefetch request. Instead, the current prefetch is allowed to finish in the hidden tab but no more will begin. This is partly done to avoid additional code complexity in storing the current prefetch url and partly because a user is likely to switch between a SRP tab and its results, so prefetching those links is beneficial in the end. Bug: 1023486 Change-Id: I03cff0f77721f450ac97b4aec39ad87290cbc886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105403Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#750609}
-
Justin Cohen authored
Changes in autocomplete logic broke some of the assertions in testTapPrerenderSuggestions. Since those assertions are just helping to set up the test, simply remove them. Bug: 1061373 Change-Id: Ie7da0302b3de5afe920aa2bd84bc5342cc80bbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103710 Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#750608}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/29de50e4d8ee..27657d9727a1 git log 29de50e4d8ee..27657d9727a1 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 ddrone@google.com Add brief instructions on IDE setup Created with: gclient setdep -r src/third_party/perfetto@27657d9727a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I541c08a07ca273ba17b0d9683a0efb915197434f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105579Reviewed-by:
-
Clark DuVall authored
It was a bit weird having embedders implement PermissionPrompt::Create() for desktop. This change implements it in //components/permissions by calling through to the embedder through PermissionsClient. Bug: 1025609 Change-Id: Icc1fd1e4a5f6efc2a8141a469cfb322579384e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101407 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#750606}
-
Jun Mukai authored
This has been disabled due to flakiness. The flakiness was observed on asan bot and win7 bot. Now this test is only built on non-sanitizer builds for chromeos (see r749747), so it's safe to re-enable it. As I tried running, it still fails sometimes on debug builds on waiting logic, so I modified it slightly. Bug: 1057864, 1057868 Test: interactive_ui_tests --gtest_repeat=20 Change-Id: I9e8112ffbd6f30f042ffd03f6b29bc7e1dbe18b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103521Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#750605}
-
kylechar authored
Bug: none Change-Id: I5be6711cbe726abfdc5bf7c21e7ec2e17e35b61d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105401Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#750604}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9b620aa0c12d..4b2483ee88ab git log 9b620aa0c12d..4b2483ee88ab --date=short --first-parent --format='%ad %ae %s' 2020-03-16 mbechard@users.noreply.github.com Fix #2005. Allow multiple compilation units to declare identical push_constant blocks (#2123) Created with: gclient setdep -r src/third_party/glslang/src@4b2483ee88ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: Ie9e2fed7147a8549b1cd977f09134c2884dab27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105577Reviewed-by:
-
Roman Sorokin authored
Sometimes network is not connected yet when online load is happening. So in case of a network error - try again while within timeout. Fixed: 1061202 Change-Id: Ic5a71eab806bfc48615d6f4c684f90abc1aeef3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102491Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750602}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1a56ce54e070..022952303c1a git log 1a56ce54e070..022952303c1a --date=short --first-parent --format='%ad %ae %s' 2020-03-16 thakis@chromium.org Suppress two -Wunreachable-code warnings. Created with: gclient setdep -r src/third_party/dawn@022952303c1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:346399 Tbr: cwallez@google.com Change-Id: Icdb88268a388dfcb4d1f11d2f7f0b44be3b89b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105581Reviewed-by:
-
ckitagawa authored
This CL is intended to integrate the hit tester into the player delegate. Note: it doesn't actually perform navigation or handle overlapping links yet (see crbugs). Bug: 1019883 Change-Id: I490e420ab31b2a828e8aa53779513ea4313c0935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101489Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#750600}
-
James Cook authored
Fix the tests in anticipation of enabling the feature by default. The tricky bit is that UserSelectableType::kApps isn't used on Chrome OS when the feature is enabled, but it is still part of UserSelectableTypeSet::All(). Update the tests to use the registered selectable types, which is closer to what the production code does. Test: components_unittests --enable-features=SplitSettingsSync Bug: 1060289 Change-Id: I16d4f119c1daa1cb51f2b9a35ea247beec75ece9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101722 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#750599}
-
Side Yilmaz authored
ExploreSitesBackgroundTask. Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates ExploreSitesBackgroundTask class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I8e6be991e2358fdb2130508c8baf0a46861a3e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095131Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750598}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d1d96d73bff7..a8631f682eb5 git log d1d96d73bff7..a8631f682eb5 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 jmadill@chromium.org Fix running trace tests in non-standard directories. Created with: gclient setdep -r src/third_party/angle@a8631f682eb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ynovikov@chromium.org Change-Id: Ia08c531ab4b9f62ab8a4ddd07f2d6f82749326df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105573Reviewed-by:
-
Hailey Wang authored
Add a policy in Performance Manager that will be responsible for background tab loading in replacement of TabLoader class. As of now, this policy consist of loading in a FIFO order with no additional restraint. Bug: 1059341 Change-Id: I1fbbfa096f44f75cad018c81b5ce2f921863503c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098743Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/master@{#750596}
-
Eugene But authored
I looked at existing Study and the number of entries is too low for statistically significant experiment. We should get more events by disabling the animations even if battery life is higher than 20%, so we can determine if animations affect PLT. This CL raises threshold to 50%, which is arbitrary chosen number. The experiment is only running on dev and canary, and not intended for beta or stable. Bug: 1006431 Change-Id: I8b6f0cb1ba876c7db11ec23169136e41c21b058e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096170Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#750595}
-
Robbie Gibson authored
Now, the tab helper holds whether the ui is active or not. Besides disabling the Text Zoom menu option when the UI is active, this also allows for better state logic to re-present the bar after a temporary hide. For instance, it is hidden when you begin a side swipe-to-navigate. Before, it wouldn't come back if you interrupted the swipe, but now it does. Fixed: 1056814, 1056821 Change-Id: I59d0b885bb4143c63563569837d1558af0b58024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080413Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#750594}
-
Joe DeBlasio authored
This CL fixes a mistaken NOTREACHED() that was reached when a user opened PageInfo on a page that triggered the (metrics-only) sensitive-keyword heuristic. It also adds a test for such. Fixed: 1061244 Change-Id: I11e6be8c4f75f308cc8f75f48523c4f64a275917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103398Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#750593}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/496706c9672e..98b339fb3c01 git log 496706c9672e..98b339fb3c01 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 wolfi@chromium.org New icons for breakpoints Created with: gclient setdep -r src/third_party/devtools-frontend/src@98b339fb3c01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4493d277b78505954032b4c6b8036707790a0957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105574Reviewed-by:
-
Xiaocheng Hu authored
Both call sites of Font::Update() in FontFaceSetDocument are redundant, so this patch removes them. The first call site is redundant as StyleResolver::ComputeFont() will set the underlying Document's FontSelector to the font. The second call site is redundant as it repeatedly sets the Document's FontSelector to the font. This is also preparation for eliminating Font::Update(). Bug: 1049295 Change-Id: I43196beb8c77e420083a125a6050d73d06e7b9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103146Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#750591}
-
sczs authored
When attempting to upload saved a card, there's a check where it assumes that the user providing a date expiration value is because the date was expired. This ends up calling LogSaveCardRequestExpirationDateReasonMetric which DCHECKS if the provided date is not expired. After enabling the editing support on the Save Card modal on iOS, users should not be able to send an expired date, but they will provide a date when attempting the upload (even if it is the original the date). Bug: 1029067 Change-Id: I874c8af5f24159e00a6cb3c50d46d988d3f391cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099481 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#750590}
-
Yue Zhang authored
Bug: 1057828 Change-Id: I5f2c3e6d24905471d268aec3119d86d1db26fdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095924Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#750589}
-
Mitsuru Oshima authored
Bug: b/148977363 Change-Id: I3568916986b9b5b8917e1ca3afa2cb0be126d150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104653Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#750588}
-
Chris Mumford authored
This change shifts from building the SQLite source in Chromium to building the SQLite source which now resides in its own repository. Motivation: now that SQLite has an official Git mirror we can switch from manually maintaining a set of patches to having a Chromium specific set of branches (master and releases). This simplifies the maintenance task and this repository. Bug: 945204 Change-Id: I83febc92d8968a75be69aeb18b352561b8817f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013741Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#750587}
-
Yue Zhang authored
http://crrev.com/c/2023250 assumes that we can get updated parent view height and width by swapping the value when orientation changes, which doesn't hold true for all devices. This CL fixes this issue by dynamically getting the parent view measures instead of using cached values. Also, this CL adds a regression test to make sure that TabGridDialog and selection editor that shows within TabGridDialog always show in the same position with same size. Bug: 1060472 Change-Id: I65dc93ebbbdababfc699671a2339a53a47d6a3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099239Reviewed-by:
-
Gauthier Ambard authored
The NewTab button is now enabled by default. This CL removes the code that is no longer useful. Bug: 974751, 998090 Change-Id: I8eb959753c35b522d58ca8c0626a1d0c7259b42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100851 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#750585}
-
Hongchan Choi authored
BaseAudioContext::decodeAudioData() caches the task runner reference so it can notify when a decoding task is finished. However, if this method gets called after the execution context is thrown away, attempting to access the task runner is invalid. This patch blocks such attempt and exit the function call. Test: Locally confirmed the repro case does not crash. Bug: 1058680 Change-Id: Id25a5bba0e4cf5a366dc1153ce4e6b353fad77ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091226Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750584}
-
Robbie Gibson authored
For unknown reasons, on iOS 13, whenever the user focuses a UITextField, the pasteboard's changeCount is incremented by 2, although the contents don't change. To fix this, if the changeCount is incremented by 2, we fallback and check MD5, because there's no way to know if the difference is because of this bug or because two actual changes occurred. It is possible to focus multiple text fields in between calls to this method (so properly, we should fallback to MD5 any time the change count difference is even), but that occurs much less frequently. The most common time this method is called is on tapping the omnibox, which will trigger the one-focus case. Bug: 1058487 Change-Id: I4d2b831840f98c071cc2dd76af10bd5d4731b0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096562Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#750583}
-
Patrick Noland authored
In https://crrev.com/c/2076402/ I removed a call to setTitleToPageTitle in onTabClosed, and inadvertently failed to replace it. Rather than replacing it directly, I think it's better to call onNavigatedToDifferentPage instead. This calls setTitleToPageTitle but also updates the status icon and re-checks the TITLE_ONLY state. For context, the check for getWebContents().isLoadingToDifferentDocument() was introduced to fix a hera (tabs in the Android launcher) bug in this internal cl: https://crrev.com/i/182069 I don't think this is really relevant any longer, since Hera is long gone, but I will happily re-purpose it. Bug: 1061356 Change-Id: I9b3e8ad675a022ba1da2e2409ee6dab96775e058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105396Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#750582}
-
Liquan (Max) Gu authored
Change: * Add success test * Add no-service test * Add unresponsive-service test * Remove smoke test Bug: 1057488 Change-Id: I9b3924b437b4f2eaf1fe016cee397bc75ffefc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102109 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750581}
-
David Tseng authored
Test: browser_tests --gtest_filter=ChromeVox*KeyboardHandler*.* Change-Id: Ide1ec47e01e44c8bb635335883e01d68cff50b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104263 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#750580}
-
Marc Treib authored
A bunch of passwords/encryption-related helpers existed in passwords_helper/encryption_helper but also had almost-identical copies in single_client_passwords_sync_test. This CL moves all the helpers into passwords/encryption_helper and de-dupes the almost-copies -> less duplication, and they can now be used in additional tests (like PasswordManagerSyncTest). Bug: 1058339 Change-Id: I5bae176053ca6c2a063d09fa3a80efb116df4003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101000 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#750579}
-
Peter Kotwicz authored
This CL changes WebApkActivityTestRule to disable WebAPK updates. BUG=1054718 Change-Id: I193827f09fed1a6d9f7f93d78fc2a37f845df748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098769Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750578}
-
Pâris Meuleman authored
This removes crash expectations that got fixed following the changes in https://crrev.com/c/2074482. Bug: 1040059 Change-Id: I91a9bfa3b49686ec204e5103e6bae369d351fb9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096587 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#750577}
-
W. James MacLean authored
NavigationPredictorPreconnectClientBrowserTest .PreconnectNotSearchBackgroundForeground is flakey on mac, see bug for details. TBR=ryansturm@chromium.org Bug: 1061932 Change-Id: I23de7d1b8aec2cfa34ae9b2c2d2f6c855a961171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105418Reviewed-by:
-
