- 16 Oct, 2018 40 commits
-
-
Peter E Conn authored
Since Origin logic was moved to Java, we can make the tests JUnit tests. Change-Id: Ied7b7d53bddb1847e81c62995f12d8ca82472852 Reviewed-on: https://chromium-review.googlesource.com/c/1280607 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#599924}
-
Christos Froussios authored
This reverts commit eb25f32f. Reason for revert: Suspect for build failures on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-device-xcode-clang Original change's description: > [ios] Move xcode-clang builders to Xcode 10. > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: Ie5bdc140b82f49151ca891b39f65112bf6210eac > Reviewed-on: https://chromium-review.googlesource.com/c/1278332 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599804} TBR=justincohen@chromium.org,jbudorick@chromium.org Bug: 895761 Change-Id: I9b1b83455bd9b27fdf9b6e7120467e3e87305007 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1282949Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#599923}
-
Mathias Bynens authored
The well-formed JSON.stringify() proposal changes JSON.stringify() to produce JavaScript/JSON-compatible escape sequences for any lone surrogates in its input. Because the test runner's `shouldBeEqualToString` uses `JSON.stringify` before comparing strings, these tests would otherwise break when shipping the `JSON.stringify()` change. Bug: v8:7782 Change-Id: If6ace9c023be8997ed10c8f1dbc2dcaed18c4687 Reviewed-on: https://chromium-review.googlesource.com/c/1281965 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#599922}
-
Luciano Pacheco authored
Rename error_util.js to error_counter.js to better describe its usage and avoid the generic term "util". Bug: 893430 Change-Id: I9cbb7f2f5ee09bf02d190dfb27d05e762bdde59f Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/c/1282682 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#599921}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6ea4d08b905d..bb3f58dbcb71 git log 6ea4d08b905d..bb3f58dbcb71 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 thestig@chromium.org Add pdfium_test --show-pageinfo to dump page bounding boxes. 2018-10-16 thestig@chromium.org Use more unique_ptrs in cfx_psrenderer.cpp for FaxCompressData(). 2018-10-16 thestig@chromium.org Make {A85,RunLength}Encode()'s buffer out parameter a unique_ptr. Created with: gclient setdep -r src/third_party/pdfium@bb3f58dbcb71 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I632d5f7ef143a9f431663bd146884e8f2cf95263 Reviewed-on: https://chromium-review.googlesource.com/c/1282351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599920}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f73b9a1f180..c98f7a176af9 Created with: gclient setdep -r src-internal@c98f7a176af9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id86a7a5d600f6a1160abb73aea29b6b0e7e92965 Reviewed-on: https://chromium-review.googlesource.com/c/1282328Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599919}
-
Morten Stenshorne authored
And it's marked as such in the main expectations file. TBR=kojii@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I1ffa182d2ca9ccbd2ef73e8f3171c0ed0355c595 Reviewed-on: https://chromium-review.googlesource.com/c/1282065 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599918}
-
Daniel Cheng authored
The two-argument version of UMA_HISTOGRAM_ENUMERATION can autodeduce the correct boundary value, so use that instead of defining a placeholder enumerator value that needs to be ignored in switch statements. Bug: 742517, 857134 Change-Id: I74ca2ace85fc6f3955f6f3a5e772e15bad8776e9 Reviewed-on: https://chromium-review.googlesource.com/c/1278060Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#599917}
-
Jordan Demeulenaere authored
When checking for presence of an element on a page, we now also compute the element BoxModel to make sure it is present on the page. This is necessary because some scripts have conditional actions (e.g. click on element X if X is on the page) which would fail if the element they act on has no box model but is still considered on the page. This makes the check for existence much slower, but for now correctness is more important than speed. Bug: 806868 Change-Id: Ibab82898c4ac3dc198b30ba8c10080d3bbebb474 Reviewed-on: https://chromium-review.googlesource.com/c/1280668 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#599916}
-
Morten Stenshorne authored
Block sizes are also not resolvable if the available block size is indefinite. There was no test coverage for this in the block directions, so added a couple of tests. They are not exportable to WPT, since we're using -webkit-fill-available. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I1020503de9e8d66ebf9d89a499937b0d58ef4c3a Reviewed-on: https://chromium-review.googlesource.com/c/1278993 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#599915}
-
Morten Stenshorne authored
Just update the render tree dump (it's closer to legacy now, than what it used to be). The screenshot matches anyway. TBR=kojii@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ibd3815ac650375ebf7a684eea44e00e4bf70e022 Reviewed-on: https://chromium-review.googlesource.com/c/1282408 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
[TreatNullAs] is applicable on DOMString, so the previous declaration [TreatNullAs] optional DOMString violates WebIDL grammer. This CL fixes it. Its spec also needs to be updated. Bug: 819112 Change-Id: Ifabca102c3969f3421817e41ad0d3f726643d047 Reviewed-on: https://chromium-review.googlesource.com/c/1281462Reviewed-by:
-
Steve Kobes authored
This will allow the page_load_metrics component to observe the jank. Also address nits in JankTracker::NotifyPrePaintFinished (empty viewport check, DCHECK for non-zero jank fraction). Bug: 581518 Change-Id: I22eab226dac31bd1b0ce284240bbca019ce49868 Reviewed-on: https://chromium-review.googlesource.com/c/1280616Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#599912}
-
Takashi Sakamoto authored
Bug: 888904 Change-Id: I7f6cda10647b4a14fb6b1de821603f99d1cc8008 Reviewed-on: https://chromium-review.googlesource.com/c/1282085Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#599911}
-
Kunihiko Sakamoto authored
This patch adds only one basic test (sxg-location.tentative.html); more tests will be converted from layout tests in following CLs. For now, Signed Exchange and certificate are checked-in as static files, assuming that UAs are configured to ignore signature expiration errors. The test is marked as tentative as this is an experimental feature. Bug: 895723 Change-Id: If762a0bf9c498ab3339b4aa09461d37d302e0210 Reviewed-on: https://chromium-review.googlesource.com/c/1282763Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599910}
-
Maya Lekova authored
This adds both finch and about:flags flag. Intent to ship discussions: https://groups.google.com/forum/#!topic/v8-users/ML7gOgK8Dsg https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/74QxqINq4g0 Bug: v8:8267, chromium:893469 Change-Id: Ib5a84519d48b9b82604875ff269f0e04977914d5 Reviewed-on: https://chromium-review.googlesource.com/c/1268200 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
-
Nicolas Pena authored
Currently, the element timing is provided to the frame that owns the <img> element. In particular, no origin checks are being made. This CL fixes this by doing the following: * Checking the image origin matches the hosting frame's origin before performing the computations in ImageElementTiming::NotifyImagePainted. * Plumbing the information to parent frames for as long as they exist and are same origin as the current frame. Bug: 879270 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If744dbc0448e3024ca5d16b59b2b1dc0f436ee58 Reviewed-on: https://chromium-review.googlesource.com/c/1277675Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Sergei Datsenko authored
Don't call javascript unsafely, delegate to a callback instead. Group related methods. BUG=chromium:883637 Change-Id: I0beefd27f5304947092f41929f6911a7b9b98a67 Reviewed-on: https://chromium-review.googlesource.com/c/1282485 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#599907}
-
Alexander Yashkin authored
Add optional upload_url param to OOPHeapProfiling feature. It could be convenient to upload heap profiling traces accumulated from feature turned on to different upload URL than those that are triggered by another reasons - chrome://tracing for example. Change-Id: I91fb0281398c9d2b86fd908e0d9c1b5dd1aaeeda Reviewed-on: https://chromium-review.googlesource.com/c/1278866Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#599906}
-
Egor Pasko authored
Currently we are investigating some noisy characteristics of the benchmark (http://crbug.com/891797), for that we enabled systrace. Unfortunately, on upstream bots running Android K the trace merging fails (reasons are unknown). After the investigation is done the systrace will be turned off anyways because it noticeably affects the metrics (in non-representative ways). Disabling the benchmark upstream. This. Is. Temporary. Yes. Bug: 894744 Change-Id: I9f607e4da1e10727cd2b31b30d0ad15d53ab37c8 Reviewed-on: https://chromium-review.googlesource.com/c/1278214 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#599905}
-
Nick Harper authored
Bug: 875053 Change-Id: I89a955d0eb9bb735e780d33e63fb7d428f93da67 Reviewed-on: https://chromium-review.googlesource.com/c/1279298Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#599904}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1929d6e1d44e..6ea4d08b905d git log 1929d6e1d44e..6ea4d08b905d --date=short --no-merges --format='%ad %ae %s' 2018-10-16 thestig@chromium.org Use unique_ptr and span in CPDF_Image::SetImage(). Created with: gclient setdep -r src/third_party/pdfium@6ea4d08b905d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1162cc3cb18f6f9cb2d0d05af5a5e2d70bbb7f87 Reviewed-on: https://chromium-review.googlesource.com/c/1282348Reviewed-by:
-
Asami Doi authored
storage. The goal is to import and evaluate as a module script at ServiceWorker. Users can use it by adding type 'module' when register a service worker script. This CL allows to fetch installed scripts from the service worker's script storage. I will add WPT tests and browser tests to make sure to fetch installed scripts from the service worker's script storage in the following CLs. Bug: 824647 Change-Id: I73bcac6ebb9298063fbc13f9dcc31011ae183cef Reviewed-on: https://chromium-review.googlesource.com/c/1270502 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#599902}
-
Fergal Daly authored
Change-Id: Ia8619be0f295445db3cfe8d3ca2466c2873db2d5 Reviewed-on: https://chromium-review.googlesource.com/c/1275486 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#599901}
-
Arthur Sonzogni authored
Remove FrameNavigationState::UpdateFrame. This function is not used. Bug: None. Change-Id: I59eb69494add5a3e0845a266bbff0af09475f9b4 Reviewed-on: https://chromium-review.googlesource.com/c/1280423Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#599900}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/feec80e97144..642641d03012 git log feec80e97144..642641d03012 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 tandrii@chromium.org git cl comments: remove Rietveld support. Created with: gclient setdep -r src/third_party/depot_tools@642641d03012 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:770408 TBR=agable@chromium.org Change-Id: I75683978717cf07b9ec40131dbec4a525168fdbb Reviewed-on: https://chromium-review.googlesource.com/c/1282349Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a97ee638d858..3f73b9a1f180 Created with: gclient setdep -r src-internal@3f73b9a1f180 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6449b84849a85ba55b9350ef0dfd2a6446cd15b6 Reviewed-on: https://chromium-review.googlesource.com/c/1282325Reviewed-by:
-
Tetsui Ohkubo authored
This reverts commit 987d8bc9. Reason for revert: Incomplete fix Original change's description: > Fix MessageListView crash on update during close. > > MessageListView crashes when a notification is updated during the > UnifiedSystemTray is closing. Like other views::Widget methods, > SynthesizeMouseMoveEvent() should not be called during the widget is > closing. > > See the bug for the asan trace. > > TEST=manual > BUG=894070 > > Change-Id: I9ffba0f73260542ebf21b2aef572af1f68e5c40b > Reviewed-on: https://chromium-review.googlesource.com/c/1276225 > Commit-Queue: James Cook <jamescook@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598768} TBR=jamescook@chromium.org,tetsui@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 894070 Change-Id: Ia953fbdc294027179dd85c92d70c8288afa13bbc Reviewed-on: https://chromium-review.googlesource.com/c/1282488Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#599897}
-
Lei Zhang authored
Change-Id: Ie14ad5fb36936e4dd940d22211e5cf77615ca886 Reviewed-on: https://chromium-review.googlesource.com/c/1282385Reviewed-by:
-
Lei Zhang authored
- When DCHECK is on, memset() gets called in partition_page.h. - Files that call (D)CHECK() should include base/logging.h. Change-Id: Iacb0fdea0fba809fcc3f1fd421ba9d0a2427bcbd Reviewed-on: https://chromium-review.googlesource.com/c/1282384Reviewed-by:
-
Marc Treib authored
Follow-up to https://crrev.com/c/1280268: Setting an implicit passphrase has not been supported for a long time. This CL removes a bunch of code to handle that case, and removes the accompanying tests. Bug: 865936 Change-Id: I3a7ff70b06ebebde8a684dfa5343b3dba563099b Reviewed-on: https://chromium-review.googlesource.com/c/1280724 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599894}
-
Maksim Sisov authored
This is first step to migrate minigbm to use GBM_BO_IMPORT_FD_MODIFIER instead of GBM_BO_IMPORT_FD_PLANAR. Ones ChromeOS will start using the newest chrome, we can finally add GBM_BO_IMPORT_FD_MODIFIER 0x5504 to minigbm and get rid of GBM_BO_IMPORT_FD_PLANAR. See comment from Tomasz in https://crrev.com/c/1273455 Bug: 869206, 578890, 820047 Change-Id: Ibac5c0c874c523e845675ff944561d3e2a3ec530 Reviewed-on: https://chromium-review.googlesource.com/c/1278400 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599893}
-
Patrik Höglund authored
LUCI is prod now for this master and the buildbot master is being turned down. Bug: chromium:877018 Change-Id: I7e71f0da927e1f2d8f79857814f2fbce831894b8 Reviewed-on: https://chromium-review.googlesource.com/c/1280267Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#599892}
-
Marc Treib authored
The passphrase type had two possible values, EXPLICIT and IMPLICIT. IMPLICIT is an ancient legacy concept that hasn't been used in many years, apart from tests: ProfileSyncServiceHarness did use it in some circumstances. It's a bad idea to have tests go through an otherwise-dead code path, so this CL removes those calls. Bug: 865936 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib91570265eccbe8831e4c831ad9d5dc3c7a6cc18 Reviewed-on: https://chromium-review.googlesource.com/c/1280268Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#599891}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Iacbffc166a5c02a6ef682a512dc07257f09dcb55 Reviewed-on: https://chromium-review.googlesource.com/c/1282663Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599890}
-
Findit authored
This reverts commit 980bc9b6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 599680 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTgwYmM5YjY1MzJiMDk4MDcyMWMxMjNmYTI5ZmE1NjFiYzUwM2Y5MQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/35414 Sample Failed Step: webkit_layout_tests on (none) GPU on Mac on Mac-10.10.5 Sample Flaky Test: external/wpt/css/css-layout-api/edges/scrollbar.https.html Original change's description: > [css-layout-api] Add LayoutEdges. > > This allows web developers to access pre-computed sizes for the border, > scrollbar, and padding "edges". > > This adds two types of tests: > 1) Uses the standard "green box" approach of testing the script values > match what is expected. > 2) Positions four children at each corner (using edges) are positioned > the same as using an abs-pos technique. > > Bug: 726125 > Change-Id: I3b53be9b44989d919cb657d4eabc6d3a1a79181b > Reviewed-on: https://chromium-review.googlesource.com/c/1252776 > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Aleks Totic <atotic@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599680} Change-Id: Ib4f9cb3e51daa57412d31cff71cbf0a3fe15cab9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726125, 895731 Reviewed-on: https://chromium-review.googlesource.com/c/1282724 Cr-Commit-Position: refs/heads/master@{#599889}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/339d23275d07..eea449a1e82a git log 339d23275d07..eea449a1e82a --date=short --no-merges --format='%ad %ae %s' 2018-10-15 dneto@google.com validator: FPRoundingMode can apply to vector conversions Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@eea449a1e82a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2baa0857a558deec0c7d9f65099bb3ed28691ce1 Reviewed-on: https://chromium-review.googlesource.com/c/1281864Reviewed-by:
-
Alexey Baskakov authored
Introduce DesktopPWAsWithoutExtensions command line switch. A WebApp represents single web app. WebApp objects are owned by WebAppRegistrar. WebAppRegistrar is a root entity which is able to add/remove new apps. Later WebAppRegistrar will be able: - to iterate over all the registered apps. - to iterate over various subsets of all registered apps (shortcut apps) - to survive the browser (and ChromeOS) relaunch (persistence) InstallManager is an abstract manager to plumb 3-dot menu user installation. We will evolve its WebAppInstallManager implementation into comprehensive install manager later. --enable-features=DesktopPWAsWithoutExtensions will enable off-extensions implementation for Desktop PWAs. Bug: 891172, 871116 Change-Id: Iebcbd93cf08eec0f11c7c22dce57ded81a2a2e94 Reviewed-on: https://chromium-review.googlesource.com/c/1275468Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f7fee39547d8..c9e6b969a452 git log f7fee39547d8..c9e6b969a452 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 ouj@fb.com Add necessary frameworks to sdk objc audio targets. 2018-10-15 mbonadei@webrtc.org Export symbols needed by the Chromium component build (part 2). 2018-10-15 benwright@webrtc.org Formatting and style guide improvements for opensslstreamadapter.cc 2018-10-15 mbonadei@webrtc.org Revert "Deprecates legacy transport feedback adapter." 2018-10-15 srte@webrtc.org Deprecates legacy transport feedback adapter. 2018-10-15 srte@webrtc.org Removes analyzer dependency on legacy congestion controller. 2018-10-15 niklas.enbom@webrtc.org Revert "Modernize rtc::SSLCertificate" 2018-10-15 eladalon@webrtc.org Fix force_fieldtrials documentation in video_loopback 2018-10-15 srte@webrtc.org Removing forward declarations in paced_sender.h. 2018-10-15 srte@webrtc.org Adds unit test for RTT based backoff. 2018-10-15 srte@webrtc.org Merges ControlHandler and PacerController. 2018-10-15 srte@webrtc.org Moves functionality to TransportFeedbackAdapter. 2018-10-15 ivoc@webrtc.org Stop simulations when a LOG_END event is reached. 2018-10-15 henrik.lundin@webrtc.org NetEq fuzzer: Restrict fuzzer input to 90000 bytes 2018-10-15 ivoc@webrtc.org Make ivoc owner of audio_coding. 2018-10-15 mbonadei@webrtc.org Revert "Reland: Use unique_ptr and ArrayView in SSLFingerprint" 2018-10-15 titovartem@webrtc.org Extract functionality of test_main into separate library. 2018-10-15 ivoc@webrtc.org Add command-line flag for setting the max number of packets in the buffer. 2018-10-15 sprang@webrtc.org Move MockVideoDecoder to api/test. 2018-10-15 gustaf@webrtc.org AEC3: Simplify render buffering 2018-10-15 srte@webrtc.org Moves rtc::SentPacket to separate target. 2018-10-15 crodbro@webrtc.org New method for precise packet reception time measurement. 2018-10-15 asapersson@webrtc.org Add field trial to disable unsignalled video. 2018-10-15 ilnik@webrtc.org Fix FakeEncoder to produce correct bitrate for several temporal layers 2018-10-15 ssilkin@webrtc.org Set frame duration per spatial layer. 2018-10-15 kron@webrtc.org Refactor of extmap-allow-mixed in SessionDescription 2018-10-15 phoglund@webrtc.org Delete force_mic_volume_max. 2018-10-15 jakobi@webrtc.org Add field trials for configuring Opus encoder packet loss rate. 2018-10-15 danilchap@webrtc.org in RtpPacketizers separate case 'frame fits into single packet'. 2018-10-15 asapersson@webrtc.org Add field trial for normalized simulcast size. 2018-10-15 mbonadei@webrtc.org Remove ios32_sim_ios9_dbg from CQ. 2018-10-15 oprypin@webrtc.org cq: explicitly mark presubmit tryjob as not re-usable in CQ. 2018-10-15 mbonadei@webrtc.org Remove rtc_base/Dummy.java. 2018-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 03013c95..0df2607f (599460:599562) 2018-10-14 oprypin@webrtc.org Revert "Propagate media transport to media channel." 2018-10-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3b54b6aa..03013c95 (599343:599460) 2018-10-12 sukhanov@google.com Propagate media transport to media channel. 2018-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c12ec9ee..3b54b6aa (599188:599343) 2018-10-12 steveanton@webrtc.org Modernize rtc::SSLCertificate 2018-10-12 steveanton@webrtc.org Reland: Use unique_ptr and ArrayView in SSLFingerprint 2018-10-12 benwright@webrtc.org Removes backwards compatability CryptoOptions support. 2018-10-12 terelius@webrtc.org Move expectations from eventlog unittests to helper functions. Created with: gclient setdep -r src/third_party/webrtc@c9e6b969a452 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:895082,chromium:None,chromium:895338,chromium:none,chromium:880074,chromium:none,chromium:893955,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I91bb7f65d2d749ab95ddcc51e5391973e6c6deca Reviewed-on: https://chromium-review.googlesource.com/c/1282323Reviewed-by:
-
Vikas Soni authored
Moving a DCHCEK to CHECK and adding a new CHECK macro to debug crash which are hard to reproduce on local devices. This CHECK will soon be moved back to DCHECK. Bug: 892354 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I44e237db73cec5259b90bb312e7940b41553d332 Reviewed-on: https://chromium-review.googlesource.com/c/1282104Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#599885}
-
